Jump to content

TileEntity not saving how it should (Was fine a few minutes ago)


Recommended Posts

Posted

Whats wrong with this?

package Abascus.UBlocks.common;

import java.awt.Toolkit;
import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlockWithMetadata;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.network.INetworkManager;
import net.minecraft.network.packet.Packet;
import net.minecraft.network.packet.Packet132TileEntityData;
import net.minecraft.src.ModLoader;
import net.minecraft.tileentity.TileEntity;

public class TileEntityUniversal extends TileEntity implements IInventory
{

public ItemStack[] inv;

// public BlockUniversalStair blockUS = (BlockUniversalStair)
// UniversalStairs.instance.universalStair;

public int getBlockId()
{
	if (inv[0] != null)
	{
		return getStackInSlot(0).itemID;
	}
	else
	{
		return Block.glass.blockID;
	}
}

private void sendUpdate() 
{
	worldObj.markBlockForUpdate(xCoord, yCoord, zCoord);
}

@Override
public Packet getDescriptionPacket() 
{
	Packet132TileEntityData packet = (Packet132TileEntityData) super.getDescriptionPacket();
	NBTTagCompound tag = packet != null ? packet.customParam1 : new NBTTagCompound();

	writeToNBT(tag);

	return new Packet132TileEntityData(xCoord, yCoord, zCoord, 1, tag);
}

@Override
public void onDataPacket(INetworkManager net, Packet132TileEntityData pkt)
{
	super.onDataPacket(net, pkt);
	NBTTagCompound tag = pkt.customParam1;
	readFromNBT(tag);
}

public int getMetaId()
{
	if (inv[0] != null)
	{
		return getStackInSlot(0).getItemDamage();
	}
	else
	{
		return 0;
	}
}

public TileEntityUniversal()
{
	inv = new ItemStack[1];
}

@Override
public int getSizeInventory()
{
	return inv.length;
}

@Override
public ItemStack getStackInSlot(int slot)
{
	return inv[slot];
}

@Override
public void setInventorySlotContents(int slot, ItemStack stack)
{
	inv[slot] = stack;
	if (stack != null && stack.stackSize > getInventoryStackLimit())
	{
		stack.stackSize = getInventoryStackLimit();
	}
}

@Override
public ItemStack decrStackSize(int slot, int amt)
{
	ItemStack stack = getStackInSlot(slot);
	if (stack != null)
	{
		if (stack.stackSize <= amt)
		{
			setInventorySlotContents(slot, null);
		}
		else
		{
			stack = stack.splitStack(amt);
			if (stack.stackSize == 0)
			{
				setInventorySlotContents(slot, null);
			}
		}
	}
	return stack;
}

@Override
public ItemStack getStackInSlotOnClosing(int slot)
{
	ItemStack stack = getStackInSlot(slot);
	if (stack != null)
	{
		setInventorySlotContents(slot, null);
	}
	return stack;
}

@Override
public int getInventoryStackLimit()
{
	return 64;
}

@Override
public boolean isUseableByPlayer(EntityPlayer player)
{
	return worldObj.getBlockTileEntity(xCoord, yCoord, zCoord) == this && player.getDistanceSq(xCoord + 0.5, yCoord + 0.5, zCoord + 0.5) < 64;
}

@Override
public void openChest()
{
}

@Override
public void closeChest()
{
}

@Override
public void readFromNBT(NBTTagCompound tagCompound)
{
	super.readFromNBT(tagCompound);

	NBTTagList tagList = tagCompound.getTagList("Inventory");
	for (int i = 0; i < tagList.tagCount(); i++)
	{
		NBTTagCompound tag = (NBTTagCompound) tagList.tagAt(i);
		byte slot = tag.getByte("Slot");
		if (slot >= 0 && slot < inv.length)
		{
			inv[slot] = ItemStack.loadItemStackFromNBT(tag);
		}
	}
}

@Override
public void writeToNBT(NBTTagCompound tagCompound)
{
	super.writeToNBT(tagCompound);

	NBTTagList itemList = new NBTTagList();
		ItemStack stack = inv[0];
		if (stack != null)
		{
			NBTTagCompound tag = new NBTTagCompound();
			tag.setByte("Slot", (byte) 0);
			stack.writeToNBT(tag);
			itemList.appendTag(tag);
		}
	tagCompound.setTag("Inventory", itemList);
}

@Override
public String getInvName()
{
	return "UniversalStair";
}

@Override
public boolean isInvNameLocalized()
{
	return false;
}

@Override
public boolean isStackValidForSlot(int i, ItemStack itemstack)
{
	return false;
}
}

 

The TileEntity isn't saving, but it's loading the data(ItemStack)

Posted

Whats wrong with this?

package Abascus.UBlocks.common;

import java.awt.Toolkit;
import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlockWithMetadata;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.network.INetworkManager;
import net.minecraft.network.packet.Packet;
import net.minecraft.network.packet.Packet132TileEntityData;
import net.minecraft.src.ModLoader;
import net.minecraft.tileentity.TileEntity;

public class TileEntityUniversal extends TileEntity implements IInventory
{

public ItemStack[] inv;

// public BlockUniversalStair blockUS = (BlockUniversalStair)
// UniversalStairs.instance.universalStair;

public int getBlockId()
{
	if (inv[0] != null)
	{
		return getStackInSlot(0).itemID;
	}
	else
	{
		return Block.glass.blockID;
	}
}

private void sendUpdate() 
{
	worldObj.markBlockForUpdate(xCoord, yCoord, zCoord);
}

@Override
public Packet getDescriptionPacket() 
{
	Packet132TileEntityData packet = (Packet132TileEntityData) super.getDescriptionPacket();
	NBTTagCompound tag = packet != null ? packet.customParam1 : new NBTTagCompound();

	writeToNBT(tag);

	return new Packet132TileEntityData(xCoord, yCoord, zCoord, 1, tag);
}

@Override
public void onDataPacket(INetworkManager net, Packet132TileEntityData pkt)
{
	super.onDataPacket(net, pkt);
	NBTTagCompound tag = pkt.customParam1;
	readFromNBT(tag);
}

public int getMetaId()
{
	if (inv[0] != null)
	{
		return getStackInSlot(0).getItemDamage();
	}
	else
	{
		return 0;
	}
}

public TileEntityUniversal()
{
	inv = new ItemStack[1];
}

@Override
public int getSizeInventory()
{
	return inv.length;
}

@Override
public ItemStack getStackInSlot(int slot)
{
	return inv[slot];
}

@Override
public void setInventorySlotContents(int slot, ItemStack stack)
{
	inv[slot] = stack;
	if (stack != null && stack.stackSize > getInventoryStackLimit())
	{
		stack.stackSize = getInventoryStackLimit();
	}
}

@Override
public ItemStack decrStackSize(int slot, int amt)
{
	ItemStack stack = getStackInSlot(slot);
	if (stack != null)
	{
		if (stack.stackSize <= amt)
		{
			setInventorySlotContents(slot, null);
		}
		else
		{
			stack = stack.splitStack(amt);
			if (stack.stackSize == 0)
			{
				setInventorySlotContents(slot, null);
			}
		}
	}
	return stack;
}

@Override
public ItemStack getStackInSlotOnClosing(int slot)
{
	ItemStack stack = getStackInSlot(slot);
	if (stack != null)
	{
		setInventorySlotContents(slot, null);
	}
	return stack;
}

@Override
public int getInventoryStackLimit()
{
	return 64;
}

@Override
public boolean isUseableByPlayer(EntityPlayer player)
{
	return worldObj.getBlockTileEntity(xCoord, yCoord, zCoord) == this && player.getDistanceSq(xCoord + 0.5, yCoord + 0.5, zCoord + 0.5) < 64;
}

@Override
public void openChest()
{
}

@Override
public void closeChest()
{
}

@Override
public void readFromNBT(NBTTagCompound tagCompound)
{
	super.readFromNBT(tagCompound);

	NBTTagList tagList = tagCompound.getTagList("Inventory");
	for (int i = 0; i < tagList.tagCount(); i++)
	{
		NBTTagCompound tag = (NBTTagCompound) tagList.tagAt(i);
		byte slot = tag.getByte("Slot");
		if (slot >= 0 && slot < inv.length)
		{
			inv[slot] = ItemStack.loadItemStackFromNBT(tag);
		}
	}
}

@Override
public void writeToNBT(NBTTagCompound tagCompound)
{
	super.writeToNBT(tagCompound);

	NBTTagList itemList = new NBTTagList();
		ItemStack stack = inv[0];
		if (stack != null)
		{
			NBTTagCompound tag = new NBTTagCompound();
			tag.setByte("Slot", (byte) 0);
			stack.writeToNBT(tag);
			itemList.appendTag(tag);
		}
	tagCompound.setTag("Inventory", itemList);
}

@Override
public String getInvName()
{
	return "UniversalStair";
}

@Override
public boolean isInvNameLocalized()
{
	return false;
}

@Override
public boolean isStackValidForSlot(int i, ItemStack itemstack)
{
	return false;
}
}

 

The TileEntity isn't saving, but it's loading the data(ItemStack)

Posted

Whats wrong with this?

package Abascus.UBlocks.common;

import java.awt.Toolkit;
import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlockWithMetadata;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.network.INetworkManager;
import net.minecraft.network.packet.Packet;
import net.minecraft.network.packet.Packet132TileEntityData;
import net.minecraft.src.ModLoader;
import net.minecraft.tileentity.TileEntity;

public class TileEntityUniversal extends TileEntity implements IInventory
{

public ItemStack[] inv;

// public BlockUniversalStair blockUS = (BlockUniversalStair)
// UniversalStairs.instance.universalStair;

public int getBlockId()
{
	if (inv[0] != null)
	{
		return getStackInSlot(0).itemID;
	}
	else
	{
		return Block.glass.blockID;
	}
}

private void sendUpdate() 
{
	worldObj.markBlockForUpdate(xCoord, yCoord, zCoord);
}

@Override
public Packet getDescriptionPacket() 
{
	Packet132TileEntityData packet = (Packet132TileEntityData) super.getDescriptionPacket();
	NBTTagCompound tag = packet != null ? packet.customParam1 : new NBTTagCompound();

	writeToNBT(tag);

	return new Packet132TileEntityData(xCoord, yCoord, zCoord, 1, tag);
}

@Override
public void onDataPacket(INetworkManager net, Packet132TileEntityData pkt)
{
	super.onDataPacket(net, pkt);
	NBTTagCompound tag = pkt.customParam1;
	readFromNBT(tag);
}

public int getMetaId()
{
	if (inv[0] != null)
	{
		return getStackInSlot(0).getItemDamage();
	}
	else
	{
		return 0;
	}
}

public TileEntityUniversal()
{
	inv = new ItemStack[1];
}

@Override
public int getSizeInventory()
{
	return inv.length;
}

@Override
public ItemStack getStackInSlot(int slot)
{
	return inv[slot];
}

@Override
public void setInventorySlotContents(int slot, ItemStack stack)
{
	inv[slot] = stack;
	if (stack != null && stack.stackSize > getInventoryStackLimit())
	{
		stack.stackSize = getInventoryStackLimit();
	}
}

@Override
public ItemStack decrStackSize(int slot, int amt)
{
	ItemStack stack = getStackInSlot(slot);
	if (stack != null)
	{
		if (stack.stackSize <= amt)
		{
			setInventorySlotContents(slot, null);
		}
		else
		{
			stack = stack.splitStack(amt);
			if (stack.stackSize == 0)
			{
				setInventorySlotContents(slot, null);
			}
		}
	}
	return stack;
}

@Override
public ItemStack getStackInSlotOnClosing(int slot)
{
	ItemStack stack = getStackInSlot(slot);
	if (stack != null)
	{
		setInventorySlotContents(slot, null);
	}
	return stack;
}

@Override
public int getInventoryStackLimit()
{
	return 64;
}

@Override
public boolean isUseableByPlayer(EntityPlayer player)
{
	return worldObj.getBlockTileEntity(xCoord, yCoord, zCoord) == this && player.getDistanceSq(xCoord + 0.5, yCoord + 0.5, zCoord + 0.5) < 64;
}

@Override
public void openChest()
{
}

@Override
public void closeChest()
{
}

@Override
public void readFromNBT(NBTTagCompound tagCompound)
{
	super.readFromNBT(tagCompound);

	NBTTagList tagList = tagCompound.getTagList("Inventory");
	for (int i = 0; i < tagList.tagCount(); i++)
	{
		NBTTagCompound tag = (NBTTagCompound) tagList.tagAt(i);
		byte slot = tag.getByte("Slot");
		if (slot >= 0 && slot < inv.length)
		{
			inv[slot] = ItemStack.loadItemStackFromNBT(tag);
		}
	}
}

@Override
public void writeToNBT(NBTTagCompound tagCompound)
{
	super.writeToNBT(tagCompound);

	NBTTagList itemList = new NBTTagList();
		ItemStack stack = inv[0];
		if (stack != null)
		{
			NBTTagCompound tag = new NBTTagCompound();
			tag.setByte("Slot", (byte) 0);
			stack.writeToNBT(tag);
			itemList.appendTag(tag);
		}
	tagCompound.setTag("Inventory", itemList);
}

@Override
public String getInvName()
{
	return "UniversalStair";
}

@Override
public boolean isInvNameLocalized()
{
	return false;
}

@Override
public boolean isStackValidForSlot(int i, ItemStack itemstack)
{
	return false;
}
}

 

The TileEntity isn't saving, but it's loading the data(ItemStack)

 

I don't understand... if it's loading, it's saving...

Please give us more details, what should happen, what is happening instead?

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Posted

Whats wrong with this?

package Abascus.UBlocks.common;

import java.awt.Toolkit;
import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlockWithMetadata;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.network.INetworkManager;
import net.minecraft.network.packet.Packet;
import net.minecraft.network.packet.Packet132TileEntityData;
import net.minecraft.src.ModLoader;
import net.minecraft.tileentity.TileEntity;

public class TileEntityUniversal extends TileEntity implements IInventory
{

public ItemStack[] inv;

// public BlockUniversalStair blockUS = (BlockUniversalStair)
// UniversalStairs.instance.universalStair;

public int getBlockId()
{
	if (inv[0] != null)
	{
		return getStackInSlot(0).itemID;
	}
	else
	{
		return Block.glass.blockID;
	}
}

private void sendUpdate() 
{
	worldObj.markBlockForUpdate(xCoord, yCoord, zCoord);
}

@Override
public Packet getDescriptionPacket() 
{
	Packet132TileEntityData packet = (Packet132TileEntityData) super.getDescriptionPacket();
	NBTTagCompound tag = packet != null ? packet.customParam1 : new NBTTagCompound();

	writeToNBT(tag);

	return new Packet132TileEntityData(xCoord, yCoord, zCoord, 1, tag);
}

@Override
public void onDataPacket(INetworkManager net, Packet132TileEntityData pkt)
{
	super.onDataPacket(net, pkt);
	NBTTagCompound tag = pkt.customParam1;
	readFromNBT(tag);
}

public int getMetaId()
{
	if (inv[0] != null)
	{
		return getStackInSlot(0).getItemDamage();
	}
	else
	{
		return 0;
	}
}

public TileEntityUniversal()
{
	inv = new ItemStack[1];
}

@Override
public int getSizeInventory()
{
	return inv.length;
}

@Override
public ItemStack getStackInSlot(int slot)
{
	return inv[slot];
}

@Override
public void setInventorySlotContents(int slot, ItemStack stack)
{
	inv[slot] = stack;
	if (stack != null && stack.stackSize > getInventoryStackLimit())
	{
		stack.stackSize = getInventoryStackLimit();
	}
}

@Override
public ItemStack decrStackSize(int slot, int amt)
{
	ItemStack stack = getStackInSlot(slot);
	if (stack != null)
	{
		if (stack.stackSize <= amt)
		{
			setInventorySlotContents(slot, null);
		}
		else
		{
			stack = stack.splitStack(amt);
			if (stack.stackSize == 0)
			{
				setInventorySlotContents(slot, null);
			}
		}
	}
	return stack;
}

@Override
public ItemStack getStackInSlotOnClosing(int slot)
{
	ItemStack stack = getStackInSlot(slot);
	if (stack != null)
	{
		setInventorySlotContents(slot, null);
	}
	return stack;
}

@Override
public int getInventoryStackLimit()
{
	return 64;
}

@Override
public boolean isUseableByPlayer(EntityPlayer player)
{
	return worldObj.getBlockTileEntity(xCoord, yCoord, zCoord) == this && player.getDistanceSq(xCoord + 0.5, yCoord + 0.5, zCoord + 0.5) < 64;
}

@Override
public void openChest()
{
}

@Override
public void closeChest()
{
}

@Override
public void readFromNBT(NBTTagCompound tagCompound)
{
	super.readFromNBT(tagCompound);

	NBTTagList tagList = tagCompound.getTagList("Inventory");
	for (int i = 0; i < tagList.tagCount(); i++)
	{
		NBTTagCompound tag = (NBTTagCompound) tagList.tagAt(i);
		byte slot = tag.getByte("Slot");
		if (slot >= 0 && slot < inv.length)
		{
			inv[slot] = ItemStack.loadItemStackFromNBT(tag);
		}
	}
}

@Override
public void writeToNBT(NBTTagCompound tagCompound)
{
	super.writeToNBT(tagCompound);

	NBTTagList itemList = new NBTTagList();
		ItemStack stack = inv[0];
		if (stack != null)
		{
			NBTTagCompound tag = new NBTTagCompound();
			tag.setByte("Slot", (byte) 0);
			stack.writeToNBT(tag);
			itemList.appendTag(tag);
		}
	tagCompound.setTag("Inventory", itemList);
}

@Override
public String getInvName()
{
	return "UniversalStair";
}

@Override
public boolean isInvNameLocalized()
{
	return false;
}

@Override
public boolean isStackValidForSlot(int i, ItemStack itemstack)
{
	return false;
}
}

 

The TileEntity isn't saving, but it's loading the data(ItemStack)

 

I don't understand... if it's loading, it's saving...

Please give us more details, what should happen, what is happening instead?

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Posted

it's loading the inv[] (ItemStack Array) perfectly, but it isn't saving it, but I don't know why, that means, lets say, there is a diamond in the Container, and I take it out and replaye it with dirt, save the game and load it again, the diamond is still in my Inventory, but in the mContainer, there is also one, cause the dirt wasn't saved, and the last save was the diamond

Posted

it's loading the inv[] (ItemStack Array) perfectly, but it isn't saving it, but I don't know why, that means, lets say, there is a diamond in the Container, and I take it out and replaye it with dirt, save the game and load it again, the diamond is still in my Inventory, but in the mContainer, there is also one, cause the dirt wasn't saved, and the last save was the diamond

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Yep I did upgrade just because it showed me a new version available.  I'll redownload the mod list and make sure anything works.  Thanks!
    • The latest log was taken down by pastebin for some reason. Did you try removing the mods you added? The mods you updated, was there a specific reason you updated, or just because? It's possible the updates introduced incompatibilitie, or even need a newer build of forge. If you didn't need the updates for a specific reason, you could also try downgrading those mods.
    • Please read the FAQ, and post logs as described there. https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/
    • I am using forge 1.20.1 (version 47.3.0). My pc has an RTX 4080 super and an i9 14900 KF, I am on the latest Nvidia graphics driver, latest windows 10 software, I have java 23, forge 1.12.2 works and so does all vanilla versions but for some reason no version of forge 1.20.1 works and instead the game just crashes with the error code "-1." I have no mods in my mods fodler, I have deleted my options.txt and forge.cfg files in case my settings were causing a crash and have tried removing my forge version from the installations folder and reinstalling but no matter what I still crash with the same code and my log doesn't tell me anything: 18:34:53.924 game 2025-02-06 18:34:53,914 main WARN Advanced terminal features are not available in this environment 18:34:54.023 game [18:34:54] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--username, mrmirchi, --version, 1.20.1-forge-47.3.0, --gameDir, C:\Users\aryam\AppData\Roaming\.minecraft, --assetsDir, C:\Users\aryam\AppData\Roaming\.minecraft\assets, --assetIndex, 5, --uuid, 2db00ea8d678420a8956109a85d90e9d, --accessToken, ????????, --clientId, ZWI3NThkNzMtNmNlZS00MGI5LTgyZTgtYmZkNzcwMTM5MGMx, --xuid, 2535436222989555, --userType, msa, --versionType, release, --quickPlayPath, C:\Users\aryam\AppData\Roaming\.minecraft\quickPlay\java\1738838092785.json, --launchTarget, forgeclient, --fml.forgeVersion, 47.3.0, --fml.mcVersion, 1.20.1, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20230612.114412] 18:34:54.027 game [18:34:54] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 10.0.9+10.0.9+main.dcd20f30 starting: java version 17.0.8 by Microsoft; OS Windows 10 arch amd64 version 10.0 18:34:54.132 game [18:34:54] [main/INFO] [ne.mi.fm.lo.ImmediateWindowHandler/]: Loading ImmediateWindowProvider fmlearlywindow 18:34:54.191 game [18:34:54] [main/INFO] [EARLYDISPLAY/]: Trying GL version 4.6 18:34:54.303 game [18:34:54] [main/INFO] [EARLYDISPLAY/]: Requested GL version 4.6 got version 4.6 18:34:54.367 monitor Process Monitor Process crashed with exit code -1     screenshot of log: https://drive.google.com/file/d/1WdkH88H865XErvmIqAKjlg7yrmj8EYy7/view?usp=sharing
    • I am currently working on a big mod, but I'm having trouble with my tabs, I want to find a way to add tabs inside tabs, like how in mrcrayfishes furniture mod, his furniture tab has multiple other sub tabs to them, so i know it is possible but i just don't know how it is possible, any help would be appreciated, thanks
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.