Hook request to make it possible for tipped arrows to work with Infinity

[NinjaNick95]

Hello,

 

I've been looking through the source code and forge documentation for most of the day trying to figure out how I can accomplish this. From what I can tell a coremod is the only way to do this currently.

 

This is because the code that removes a fired arrow from the player's inventory is in the onPlayerStoppedUsing method of ItemBow.class and not included in the ArrowNock or ArrowLoose events:

 

From ItemBow.class:

if (!flag1 && !entityplayer.capabilities.isCreativeMode)
{
	itemstack.shrink(1);

	if (itemstack.isEmpty())
	{
		entityplayer.inventory.deleteStack(itemstack);
	}
}

^Flag1 checks if ammo is of the ItemArrow class specifically (TippedArrow is its own class so it fails this check). This is probably the easiest place to modify to allow tipped arrows to work with Infinity.

 

Reflection is a completely new concept to me but from what I'm reading it doesn't look like it would work for this. Please correct me if I'm wrong.

[DaemonUmbra]

This can be done through registry replacement (i.e. creating custom Tipped Arrows and replacing the vanilla ones)

[NinjaNick95]

Looked up registry replacement and I'm not sure how it helps here. I could create a custom bow class, extending ItemBow, and override the onPlayerStoppedUsing method, but I'd prefer to not create custom items either way.

[DaemonUmbra]

I would assume you're looking at the instanceof check, and as ItemTippedArrow extends ItemArrow that will pass, what stops it is ItemArrow's implementation of the isInfinite method which does directly check for ItemArrow, so if you make a custom ItemTippedArrow that overrides isInfinite it will work.

[NinjaNick95]

Good catch, thank you. It took a few hours to figure out, but a custom class extending ItemTippedArrow worked like a charm. Appreciate the help! (Solved)