Hello,

 

I am taking my first steps with 1.14 modding, and have encountered a most curious error.

 

I want to make my own crafting table, so as a start I copied CraftingTableBlock and registered it. The item show up properly, can be retrieved from creative intentory and placed. But upon right clicking, the GUI opens up and then immediatelly closes. This does not happen for the standard workbench. I've tried making sense of what could be the reason, but turned up empty after some time.

 

Can someone guide me on which part could be wrong?

 

CraftingTableBlock.java

package com.gmail.zethariel.FoxTech.block;

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.inventory.container.INamedContainerProvider;
import net.minecraft.inventory.container.SimpleNamedContainerProvider;
import net.minecraft.inventory.container.WorkbenchContainer;
import net.minecraft.stats.Stats;
import net.minecraft.util.Hand;
import net.minecraft.util.IWorldPosCallable;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.BlockRayTraceResult;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.TranslationTextComponent;
import net.minecraft.world.World;

public class CraftingTableBlock extends Block {
	   private static final ITextComponent field_220271_a = new TranslationTextComponent("container.crafting");

	   public CraftingTableBlock(Block.Properties properties) {
	      super(properties);
	   }

	   @Override
	   public boolean onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit) {
	      player.openContainer(state.getContainer(worldIn, pos));
	      player.addStat(Stats.INTERACT_WITH_CRAFTING_TABLE);
	      return true;
	   }

	   
	   public INamedContainerProvider getContainer(BlockState state, World worldIn, BlockPos pos) {
	      return new SimpleNamedContainerProvider((p_220270_2_, p_220270_3_, p_220270_4_) -> {
	         return new WorkbenchContainer(p_220270_2_, p_220270_3_, IWorldPosCallable.of(worldIn, pos));
	      }, field_220271_a);
	   }
	}

 

ItemAndBlockRegister.java

package com.gmail.zethariel.FoxTech;

import com.gmail.zethariel.FoxTech.block.CraftingTableBlock;
import com.gmail.zethariel.FoxTech.item.FoxTechItemGroup;

import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.item.BlockItem;
import net.minecraft.item.Item;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.registries.ObjectHolder;


@Mod.EventBusSubscriber(modid = FoxTechMod.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD)
@ObjectHolder(FoxTechMod.MOD_ID)
public class ItemAndBlockRegister {

	 
	
	 public static final Item flour = null;
	 
	 public static final Block mixing_bowl = null;
	 
    /**
     * The actual event handler that registers the custom items.
     *
     * @param event The event this event handler handles
     */
    @SubscribeEvent
    public static void registerItems(RegistryEvent.Register<Item> event) {
    	//create group
    	
    	
        //In here you pass in all item instances you want to register.
        //Make sure you always set the registry name.
        event.getRegistry().registerAll(

            new Item(new Item.Properties().group(FoxTechItemGroup.foxTechItemGroup)).setRegistryName(FoxTechMod.MOD_ID, "flour"),
            new BlockItem(mixing_bowl, new Item.Properties().group(FoxTechItemGroup.foxTechItemGroup)).setRegistryName(mixing_bowl.getRegistryName())
        );
    }
    
    

    /**
     * The actual event handler that registers the custom blocks.
     *
     * @param event The event this event handler handles
     */
    @SubscribeEvent
    public static void registerBlocks(RegistryEvent.Register<Block> event) {
        //In here you pass in all block instances you want to register.
        //Make sure you always set the registry name.
        event.getRegistry().registerAll(

            new CraftingTableBlock(Block.Properties.create(Material.GLASS).hardnessAndResistance(0.3F).sound(SoundType.GLASS)).setRegistryName(FoxTechMod.MOD_ID, "mixing_bowl")

        );
    }
}

 

 

Thanks in advance!

Don’t simply copy the vanilla code. In most cases the code is based on 10 years of patches and forge almost always provides a better modder-friendly replacement for the vanilla method of doing things.

 

I believe that your code is not working because the crafting table container does an instanceof check to make sure that there is a crafting table at the location the container is being opened (your crafting table is not/does not extend the vanilla crafting table and therefore this check fails)