Jump to content

Recommended Posts

Posted (edited)

I'm a new modder and just trying to make a simple mod ,but when I put my block ,the game crash with "Registry Object not present".

I've tried to fix it ,but still can't find where wrong.

 

Thanks for helping.

 

crash report :

image.thumb.png.0118a355cd25dea3d545a713fc715097.png

 

 

conveyor_belt_block.java 

	@Nullable
	@Override
	public TileEntity createTileEntity(final BlockState state, final IBlockReader world) {
		return ModTileEntityTypes.CONVEYOR_BELT.get().create();  // line38
	}

 

 

ModTileEntityTypes.java :

public final class ModTileEntityTypes {
	
	public static final DeferredRegister<TileEntityType<?>> TILE_ENTITY_TYPES = new DeferredRegister<>(ForgeRegistries.TILE_ENTITIES, Conveyor.modid);
	
	public static final RegistryObject<TileEntityType<conveyor_belt_tile_entity>> CONVEYOR_BELT = TILE_ENTITY_TYPES.register("conveyor_belt", () ->
	TileEntityType.Builder.create(conveyor_belt_tile_entity::new, ModBlocks.CONVEYOR_BELT.get().setRegistryName("conveyor_belt"))
		.build(null)
	);
}

 

 

ModBlocks.java :

public final class ModBlocks {
	public static final DeferredRegister<Block> BLOCKS = new DeferredRegister<>(ForgeRegistries.BLOCKS, Conveyor.modid);
	
	public static final RegistryObject<Block> CONVEYOR_BELT = BLOCKS.register("conveyor_belt", () -> new conveyor_belt_block());

}

 

 

conveyor_belt_tile_entity.java :

public class conveyor_belt_tile_entity extends TileEntity implements ITickableTileEntity{
	
	public conveyor_belt_tile_entity() {
		super(ModTileEntityTypes.CONVEYOR_BELT.get());
	}
	
	@Override
      public void tick() {
      	System.out.println("test tick");
    }
}

 

 

Edited by haruto1017
Posted
1 hour ago, diesieben07 said:

Where do you register your DeferredRegister instances to the event bus?

 

Also please follow Java class naming conventions.

 

Sorry, I have already renamed them.

 

Do you mean this?

	@SubscribeEvent
	public static void registerTileEntities (final RegistryEvent.Register<TileEntityType<?>> event) {
			
		ModTileEntityTypes.TILE_ENTITY_TYPES.register(FMLJavaModLoadingContext.get().getModEventBus());
		
		LOGGER.info("TileEntities registered");
	}

 

Posted

It doesn't work,the game still crash.

I don't know,registerItems and registerBlocks can work normally.

Is it the correct method to register them?

package haruto.conveyor;

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import haruto.conveyor.block.ConveyorBeltBlock;
import haruto.conveyor.init.ModTileEntityTypes;
import haruto.conveyor.lists.BlockList;
import haruto.conveyor.lists.ItemList;
import net.minecraft.block.Block;
import net.minecraft.item.BlockItem;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraft.tileentity.TileEntityType;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent;
import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;

@Mod("conveyor")
public class Conveyor
{
	
	public static Conveyor instance;
	public static final String modid = "conveyor";
	private static final Logger LOGGER = LogManager.getLogger(modid);
	
	public static final ItemGroup conveyorG = new ConveyorItemGroup();
	
	public Conveyor()
	{
		
		instance = this;
		
		FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup);
		FMLJavaModLoadingContext.get().getModEventBus().addListener(this::clientRegistries);
		
		MinecraftForge.EVENT_BUS.register(this);
		
		/**
		 * It doesn't work,the game still crash.
		 */
		// BlockList.conveyor_belt = new ConveyorBeltBlock().setRegistryName(location("conveyor_belt"))
		
	}
	
	private void setup(final FMLCommonSetupEvent event)
	{
		LOGGER.info("setup");
	}
	
	private void clientRegistries(final FMLClientSetupEvent event)
	{
		LOGGER.info("clientRegistries");
	}
	
	
	@Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD)
	public static class RegistryEvents
	{
		
		@SubscribeEvent
		public static void registerItems(final RegistryEvent.Register<Item> event)
		{
			event.getRegistry().registerAll
			(
					ItemList.gear = new Item(new Item.Properties().group(conveyorG)).setRegistryName(location("gear")),
					ItemList.conveyor_belt = new BlockItem(BlockList.conveyor_belt, new Item.Properties().group(conveyorG)).setRegistryName(BlockList.conveyor_belt.getRegistryName())
			);
			
			LOGGER.info("Items registered");
		}
		
		@SubscribeEvent
		public static void registerBlocks(final RegistryEvent.Register<Block> event)
		{
			event.getRegistry().registerAll
			(
				BlockList.conveyor_belt = new ConveyorBeltBlock().setRegistryName(location("conveyor_belt"))
			);
			
			
			LOGGER.info("Blocks registered");
		}
		
		@SubscribeEvent
		public static void registerTileEntities (final RegistryEvent.Register<TileEntityType<?>> event) {
			
			ModTileEntityTypes.TILE_ENTITY_TYPES.register(FMLJavaModLoadingContext.get().getModEventBus());
			
			LOGGER.info("TileEntities registered");
		}
		
		private static ResourceLocation location(String name)
		{
			return new ResourceLocation(modid,name);
		}
			
	}
}

 

This is my log.

image.thumb.png.74a1902cceb716d3cbd3514009ea209d.png

 

Thanks for your help.

Posted
19 minutes ago, diesieben07 said:

This makes no sense.

The registration to the event bus must happen in your mod class constructor.

When using DeferredRegister you do not subscribe to the events yourself, DeferredRegister handles it all for you.

OK,I'll try it.
Thanks.

Posted

It's working !

public Conveyor()
{
	LOGGER.debug("Conveyor mod testing");
		
	final IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();

	ModBlocks.BLOCKS.register(modEventBus);
	ConveyorItems.ITEMS.register(modEventBus);
	ModTileEntityTypes.TILE_ENTITY_TYPES.register(modEventBus);
		
}

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Add the crash-report or latest.log (logs-folder) with sites like https://mclo.gs/ and paste the link to it here  
    • So i have a forge modded aternos server that worked just fine for a month untill today it suddenly crashes most of the time giving errors and idk which mod is causing the error or its smth else here is the crash log link https://mclo.gs/gGkzGKT
    • Struggling to decipher a crash report I'm getting in a custom modpack I'm tinkering with. The crash happens on startup, but weirdly, only some of the time. It seems to be related to Steves Carts, but weirdly it only started happening recently, and I can't identify if another mod is conflicting, or why it is only happening some of the time:   java.lang.NullPointerException: Cannot invoke "net.minecraft.world.entity.player.Player.m_20202_()" because "player" is null at vswe.stevescarts.events.OverlayEventHandler.onRenderTick(OverlayEventHandler.java:24) ~[stevescarts-1.20.1-1.1.14.jar%23527!/:1.20.1-1.1.14] {re:classloading} at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:260) ~[eventbus-6.0.5.jar%23127!/:?] {} at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:252) ~[eventbus-6.0.5.jar%23127!/:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.5.jar%23127!/:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.5.jar%23127!/:?] {} at net.minecraftforge.event.ForgeEventFactory.onRenderTickEnd(ForgeEventFactory.java:919) ~[forge-1.20.1-47.1.106-universal.jar%23581!/:?] {re:mixin,re:classloading,pl:mixin:APP:modernfix-forge.mixins.json:perf.potential_spawns_alloc.ForgeEventFactoryMixin,pl:mixin:A} at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1148) ~[client-1.20.1-20230612.114412-srg.jar%23576!/:?] {re:mixin,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick_render_call,xf:fml:xaerominimap:xaero_minecraftclient,xf:fml:xaeroworldmap:xaero_wm_minecraftclient,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick_render_call,xf:fml:xaerominimap:xaero_minecraftclient,xf:fml:xaeroworldmap:xaero_wm_minecraftclient,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:718) ~[client-1.20.1-20230612.114412-srg.jar%23576!/:?] {re:mixin,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick_render_call,xf:fml:xaerominimap:xaero_minecraftclient,xf:fml:xaeroworldmap:xaero_wm_minecraftclient,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick_render_call,xf:fml:xaerominimap:xaero_minecraftclient,xf:fml:xaeroworldmap:xaero_wm_minecraftclient,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.main(Main.java:218) ~[minecraft-1.20.1-client.jar:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:APP:flywheel.mixins.json:ClientMainMixin,pl:mixin:A,pl:runtimedistcleaner:A}     Including some extra info in case any of it is relevant^. Appreciate any ideas/advice!    
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.