Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

Hello together

On testing my own World Ore Gen Geatures i've fond an Error and i don't understand how this Error can Happens.

 

When World is be createted the function place in Any Feature will bee called. When i Configured my Feature with a  placement with bottom-offset top-offset an maxHeigt.

Wenn Place is called it is possible to get an y-value with is lower then bottomOffset. On serching i've fond the Class placement witch is called befor Feture starts.
                

package net.minecraft.world.gen.placement;

import com.mojang.datafixers.Dynamic;
import java.util.Random;
import java.util.function.Function;
import java.util.stream.IntStream;
import java.util.stream.Stream;
import net.minecraft.util.math.BlockPos;

public class HeightBiasedRange extends SimplePlacement<CountRangeConfig> {
   public HeightBiasedRange(Function<Dynamic<?>, ? extends CountRangeConfig> p_i51388_1_) {
      super(p_i51388_1_);
   }

   public Stream<BlockPos> getPositions(Random random, CountRangeConfig p_212852_2_, BlockPos pos) {
      return IntStream.range(0, p_212852_2_.count).mapToObj((p_227436_3_) -> {
         int i = random.nextInt(16) + pos.getX();
         int j = random.nextInt(16) + pos.getZ();
         int k = random.nextInt(random.nextInt(p_212852_2_.maximum - p_212852_2_.topOffset) + p_212852_2_.bottomOffset);
         return new BlockPos(i, k, j);
      });
   }

}

in Line int k = random.. there are two errors:

   a) when calling the inner random.nextInt(..) with Value ..Maximum = 64 and bottomOffset = 30) the parameter in nextInt will not be 34. In some test i fond ther will be allways an value of 31 by differnet values of Maximum and topOffset it might be the Differenz in Adress range not in Value)

 

   b) when k is the y value for placement. I think there is an random.nextInt(...) to much. the correct line must be:

int k = random.nextInt(p_212852_2_.maximum - p_212852_2_.topOffset) + p_212852_2_.bottomOffset;

 

How To test it:

 

only set an Breakpoint on line 19 (int k  = ...) in net.minecraft.world.gen.placement.HeightBiasedRange

and look wat will be happend.

 

For Info: I Worrk with Eclipse, Version 2019-19

 

 

Edited by wilpito
Wrong Placement Config used

  • Author

Sorry, I've used the wrong placement.

With Placement.COUNT_RANGE it will work correctly.

 

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.