Jump to content

[1.15.2] How do I make a food item have the enchated glow like an enchanted golden apple?


Recommended Posts

Posted

I am learning how to make mods. For my Hello World project I chose to make a platinum mod? How would I add the enchant effect to an Enchanted Platinum Apple. Thank you in advance. Here is my code:

package com.melon9191.platinummod.init;

import com.melon9191.platinummod.PlatinumMod;
import com.melon9191.platinummod.PlatinumMod.PlatinumItemGroup;

import net.minecraft.item.Food;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraft.potion.EffectInstance;
import net.minecraft.potion.Effects;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;
import net.minecraftforge.registries.ObjectHolder;

@Mod.EventBusSubscriber(modid = PlatinumMod.MOD_ID, bus = Bus.MOD)
@ObjectHolder(PlatinumMod.MOD_ID)
public class ItemInit 
{
	public static final Item platinum_ingot = null;
	public static final Item platinum_apple = null;
	public static final Item platinum_enchantedapple = null;
	
	@SubscribeEvent
	public static void registerItems(final RegistryEvent.Register<Item> event) 
	{
		event.getRegistry().register(new Item(new Item.Properties().group(ItemGroup.MISC)).setRegistryName("platinum_ingot"));	
		event.getRegistry().register(new Item(new Item.Properties().group(PlatinumItemGroup.instance).food(new Food.Builder().hunger(5).saturation(1.3f).setAlwaysEdible().effect(new EffectInstance(Effects.STRENGTH, 3000, 1), 1f).effect(new EffectInstance(Effects.ABSORPTION, 3000, 1), 1f).effect(new EffectInstance(Effects.REGENERATION, 3000, 2), 1f).effect(new EffectInstance(Effects.RESISTANCE, 3000, 0), 1f).build())).setRegistryName("platinum_apple"));
		event.getRegistry().register(new Item(new Item.Properties().group(PlatinumItemGroup.instance).food(new Food.Builder().hunger(6).saturation(1.4f).setAlwaysEdible().effect(new EffectInstance(Effects.STRENGTH, 3600, 2), 1f).effect(new EffectInstance(Effects.ABSORPTION, 3600, 3), 1f).effect(new EffectInstance(Effects.REGENERATION, 3600, 3), 1f).effect(new EffectInstance(Effects.RESISTANCE, 3600, 2), 1f).effect(new EffectInstance(Effects.FIRE_RESISTANCE, 3600, 0), 1f).effect(new EffectInstance(Effects.GLOWING, 3600, 0), 1f).build())).setRegistryName("platinum_enchantedapple"));
	}
}

 

Posted

The enchanted glow is added to an item whenever Item::hasEffect returns true. So you'll probably have to override that to get it to return true, somehow. I'm a little confused by your syntax for creating items, so you'd have to look into that yourself.

  • Thanks 1
Posted
36 minutes ago, Melon9191 said:

I am learning how to make mods. For my Hello World project I chose to make a platinum mod? How would I add the enchant effect to an Enchanted Platinum Apple. Thank you in advance. Here is my code:


package com.melon9191.platinummod.init;

import com.melon9191.platinummod.PlatinumMod;
import com.melon9191.platinummod.PlatinumMod.PlatinumItemGroup;

import net.minecraft.item.Food;
import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraft.potion.EffectInstance;
import net.minecraft.potion.Effects;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;
import net.minecraftforge.registries.ObjectHolder;

@Mod.EventBusSubscriber(modid = PlatinumMod.MOD_ID, bus = Bus.MOD)
@ObjectHolder(PlatinumMod.MOD_ID)
public class ItemInit 
{
	public static final Item platinum_ingot = null;
	public static final Item platinum_apple = null;
	public static final Item platinum_enchantedapple = null;
	
	@SubscribeEvent
	public static void registerItems(final RegistryEvent.Register<Item> event) 
	{
		event.getRegistry().register(new Item(new Item.Properties().group(ItemGroup.MISC)).setRegistryName("platinum_ingot"));	
		event.getRegistry().register(new Item(new Item.Properties().group(PlatinumItemGroup.instance).food(new Food.Builder().hunger(5).saturation(1.3f).setAlwaysEdible().effect(new EffectInstance(Effects.STRENGTH, 3000, 1), 1f).effect(new EffectInstance(Effects.ABSORPTION, 3000, 1), 1f).effect(new EffectInstance(Effects.REGENERATION, 3000, 2), 1f).effect(new EffectInstance(Effects.RESISTANCE, 3000, 0), 1f).build())).setRegistryName("platinum_apple"));
		event.getRegistry().register(new Item(new Item.Properties().group(PlatinumItemGroup.instance).food(new Food.Builder().hunger(6).saturation(1.4f).setAlwaysEdible().effect(new EffectInstance(Effects.STRENGTH, 3600, 2), 1f).effect(new EffectInstance(Effects.ABSORPTION, 3600, 3), 1f).effect(new EffectInstance(Effects.REGENERATION, 3600, 3), 1f).effect(new EffectInstance(Effects.RESISTANCE, 3600, 2), 1f).effect(new EffectInstance(Effects.FIRE_RESISTANCE, 3600, 0), 1f).effect(new EffectInstance(Effects.GLOWING, 3600, 0), 1f).build())).setRegistryName("platinum_enchantedapple"));
	}
}

 

 

7 minutes ago, M3rein said:

The enchanted glow is added to an item whenever Item::hasEffect returns true. So you'll probably have to override that to get it to return true, somehow. I'm a little confused by your syntax for creating items, so you'd have to look into that yourself.

If that what @M3rein has say was true, then you need to create a new class that extend Item and override the Item.hasEffect.

New in Modding? == Still learning!

Posted

This is what I got from that, but it isn't working. I made a new class in init and wrote this up. Sorry I'm just learning and getting a grasp on everything!

package com.melon9191.platinummod.init;

import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;

public class ItemEffect extends Item {
	
	public ItemEffect(Properties hasEffect) {
		super(hasEffect);
	}

	@Override
	   public boolean hasEffect(ItemStack platinum_enchantedapple) {
	      return platinum_enchantedapple.isEnchanted();
	   }

}

 

Posted

Instead of checking if the stack is enchanted, simply return true. Since the stack likely isn't enchanted, it will return false otherwise.

Also, there's actually a SimpleFoiledItem class in vanilla that you can use like you were doing before, without having to make your own class just for that.

I'm eager to learn and am prone to mistakes. Don't hesitate to tell me how I can improve.

Posted

Like I said before I am new so alot of this is just lack of experience but once I paste the code into a new class what do I do?

package com.melon9191.platinummod.init;

import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;

public class ItemEffect extends Item {
	   public ItemEffect(Item.Properties builder) {
		      super(builder);
		   }

		   public boolean hasEffect(ItemStack stack) {
		      return true;
		   }
		}

 

Posted
4 minutes ago, Melon9191 said:

Like I said before I am new so alot of this is just lack of experience but once I paste the code into a new class what do I do?

Instantiate it during registration just like you do with the normal Item class. Basically call new ItemEffect() instead of new Item() when registering your items.

Side note: I would encourage you to learn Java outside of Minecraft modding, as learning Java in this sort of environment can be difficult. :)

I'm eager to learn and am prone to mistakes. Don't hesitate to tell me how I can improve.

Posted
5 minutes ago, imacatlolol said:

Instantiate it during registration just like you do with the normal Item class. Basically call new ItemEffect() instead of new Item() when registering your items.

Side note: I would encourage you to learn Java outside of Minecraft modding, as learning Java in this sort of environment can be difficult. :)

Thank you this method worked. Where do you recommend me to learn Java?

Posted
3 minutes ago, Melon9191 said:

Where do you recommend me to learn Java?

I'm not a Java expert myself so I'm sure someone else could give a better answer, but there's a few resources I know of.

  • W3Schools' tutorials are pretty good, and they have good examples. Their section on Classes and Object Oriented Programming in general may be particularly useful.
  • Oracle's official documentations have a pretty bare-bones tutorial, if that works for you.
  • If you're a visual learner, there are also many YouTube tutorials that may help explain some confusing aspects of java using examples, too many to list here.
  • And of course, when in doubt, Google can be your best friend when something is confusing. It's no secret that even veteran programmers regularly use Google to make sure they're doing something correctly.

I personally learned Java by just looking up random resources to find what worked for me, then I just trial-and-errored my way here. I've gotten pretty good, but it's very easy to fall into bad habits. It's always a good idea to look at other people's code to see how to improve.

I'm eager to learn and am prone to mistakes. Don't hesitate to tell me how I can improve.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.