Jump to content

Recommended Posts

Posted (edited)

Hi, I´m having a little problem with custom trees code in eclipse.

Everything it´s fine, no errors or bugs in the code

Minecraft loads with no errors

But when the custom sapling grows (naturally or bonemealed) spawn a vanilla oak tree

Any ideas of what´s wrong?

 

here is the code that should generate a custom tree (i think), instead of the oak one-

 

package food.mod.world.gen.generators;

 

import java.util.Random;

import food.mod.init.ModBlocks;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Blocks;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.gen.feature.WorldGenAbstractTree;
import net.minecraftforge.common.IPlantable;

 

public class WorldGenBananaTrees extends WorldGenAbstractTree 
{
    public static final IBlockState LOG = ModBlocks.BANANA_LOG.getDefaultState();
    public static final IBlockState LEAF = ModBlocks.BANANA_LEAVES_BLOCK.getDefaultState();
    
    private final int minHeight;
    
    public WorldGenBananaTrees() 
    {
        super(false);
        this.minHeight = 5;
    }

    @Override
    public boolean generate(World world, Random rand, BlockPos pos) 
    {
        int height = this.minHeight + rand.nextInt(3);
        boolean flag = true;
        
        int x = pos.getX();
        int y = pos.getY();
        int z = pos.getZ();
        
        for(int yPos = y; yPos <= y + 1 + height; yPos++)
        {
            int b0 = 2;
            if(yPos == y) b0 = 1;
            if(yPos >= y + 1 + height - 2) b0 = 2;
            
            BlockPos.MutableBlockPos mutable = new BlockPos.MutableBlockPos();
            
            for(int xPos = x - b0; xPos <= x + b0 && flag; xPos++)
            {
                for(int zPos = z - b0; zPos <- z + b0 && flag; zPos++)
                {
                    if(yPos >= 0 && yPos < world.getHeight())
                    {
                        if(!this.isReplaceable(world, new BlockPos(xPos, yPos, zPos)))
                        {
                            flag = false;
                        }
                    }
                    else
                    {
                        flag = false;
                    }
                }
            }
        }
        
        if(!flag)
        {
            return false;
        }
        else
        {
            BlockPos down = pos.down();
            IBlockState state = world.getBlockState(down);
            boolean isSoil = state.getBlock().canSustainPlant(state, world, down, EnumFacing.UP, (IPlantable) Blocks.SAPLING);
            
            if(isSoil && y < world.getHeight() - height - 1)
            {
                state.getBlock().onPlantGrow(state, world, down, pos);
                
                for(int yPos = y - 3 + height; yPos <= y + height; yPos++)
                {
                    int b1 = yPos - (y + height);
                    int b2 = 1 - b1 / 2;
                    
                    for(int xPos = x - b2; xPos <= x + b2; xPos++)
                    {
                        int b3 = xPos - x;
                        for(int zPos = z - b2; zPos <= z + b2; zPos++)
                        {
                            int b4 = zPos - z;
                            if(Math.abs(b3) != b2 || Math.abs(b4) != b2 || rand.nextInt(2) != 0 && b1 != 0)
                            {
                                BlockPos treePos = new BlockPos(xPos, yPos, zPos);
                                IBlockState treeState = world.getBlockState(treePos);
                                if(treeState.getBlock().isAir(treeState, world, treePos) || treeState.getBlock().isAir(treeState, world, treePos))
                                {
                                    this.setBlockAndNotifyAdequately(world, treePos, LEAF);
                                    this.setBlockAndNotifyAdequately(world, treePos.add(0, -0.25 * height, 0), LEAF);
                                    this.setBlockAndNotifyAdequately(world, treePos.add(0, -0.5 * height, 0), LEAF);
                                }
                            }
                        }
                    }
                }
                
                for(int logHeight = 0; logHeight < height; logHeight++)
                {
                    BlockPos up = pos.up(logHeight);
                    IBlockState logState = world.getBlockState(up);
                    
                    if(logState.getBlock().isAir(logState, world, up) || logState.getBlock().isLeaves(logState, world, up))
                    {
                        this.setBlockAndNotifyAdequately(world, pos.up(logHeight), LOG);
                    }
                }
                
                return true;
            }
        }
        
        return true;
    }    
    
    @Override
    protected boolean canGrowInto(Block blockType)
    {
        Material material = blockType.getDefaultState().getMaterial();
        return material == Material.AIR || material == Material.LEAVES || material == Material.GROUND || blockType == Blocks.GRASS || blockType == Blocks.DIRT || blockType == Blocks.LOG || blockType == Blocks.LOG2 || blockType == Blocks.SAPLING || blockType == Blocks.VINE;
  
    }
}

Edited by Creepy27
grammatical errors, didn´t put the code, to ask for help

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • When I first heard about Bitcoin back in 2018, I was skeptical. The idea of a decentralized, digital currency seemed too good to be true. But I was intrigued as I learned more about the technology behind it and its potential. I started small, investing just a few hundred dollars, dipping my toes into the cryptocurrency waters. At first, it was exhilarating to watch the value of my investment grow exponentially. I felt like I was part of the future, an early adopter of this revolutionary new asset. But that euphoria was short-lived. One day, I logged into my digital wallet only to find it empty - my Bitcoin had vanished without a trace. It turned out that the online exchange I had trusted had been hacked, and my funds were stolen. I was devastated, both financially and emotionally. All the potential I had seen in Bitcoin was tainted by the harsh reality that with decentralization came a lack of regulation and oversight. My hard-earned money was gone, lost to the ether of the digital world. This experience taught me a painful lesson about the price of trust in the uncharted territory of cryptocurrency. While the technology holds incredible promise, the risks can be catastrophic if you don't approach it with extreme caution. My Bitcoin investment gamble had failed, and I was left to pick up the pieces, wiser but poorer for having placed my faith in the wrong hands. My sincere appreciation goes to MUYERN TRUST HACKER. You are my hero in recovering my lost funds. Send a direct m a i l ( muyerntrusted ( @ ) mail-me ( . )c o m ) or message on whats app : + 1 ( 4-4-0 ) ( 3 -3 -5 ) ( 0-2-0-5 )
    • You could try posting a log (if there is no log at all, it may be the launcher you are using, the FAQ may have info on how to enable the log) as described in the FAQ, however this will probably need to be reported to/remedied by the mod author.
    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.