Jump to content

[SOLVED] How to make a player able to fly on consuming a potion


BlockyPenguin

Recommended Posts

Hey! I'd like to potion (which I already have, as well as the long variant, and the respective effect), where, when a player gets the effect, they can fly as if in creative. Here is my code as it stands:
 

package com.blockypenguin.labkit.effects;

import com.blockypenguin.labkit.util.list.ModEffects;

import net.minecraft.entity.Entity;
import net.minecraft.entity.LivingEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.potion.Effect;
import net.minecraft.potion.EffectInstance;
import net.minecraft.potion.EffectType;
import net.minecraft.potion.Effects;
import net.minecraft.util.text.ITextComponent;

public class FlyingEffect extends Effect {
	
	public FlyingEffect() {
		super(EffectType.BENEFICIAL, 0x87cefa);
		setRegistryName("flying");
	}
	
	@Override
	public void affectEntity(Entity source, Entity indirectSource, LivingEntity entity, int amplifier,
			double health) {
		
		if (entity instanceof PlayerEntity) {
			PlayerEntity player = (PlayerEntity) entity;
			player.abilities.allowFlying = true;
			player.abilities.isFlying = true;
			
			if(player.getActivePotionEffect(ModEffects.FLYING).getDuration() == 100) {
				player.sendStatusMessage(ITextComponent.Serializer.fromJson("You will stop flying in 5 seconds!"), true);
			}
			
			if(player.getActivePotionEffect(ModEffects.FLYING).getDuration() <= 1) {
				player.abilities.isFlying = false;
				player.abilities.allowFlying = false;
			}
		}else {
			entity.addPotionEffect(new EffectInstance(Effects.LEVITATION, 200, 3));
		}
		
		super.affectEntity(source, indirectSource, entity, amplifier, health);
	}
	
}

 

But it doesn't do anything, as if the code never gets run. What have I done wrong? All help appreciated. Thanks!

Edited by BlockyPenguin

Today (22/10/20) I reached 100 posts!

I'm probably more excited than I should be for something so realistically minor...

Link to comment
Share on other sites

6 hours ago, diesieben07 said:

affectEntity is for instant ("splash") potions.

For long running effects you need to use Effect#performEffect, which will be called every tick, as long as Effect#isReady returned true that tick.


There are also the two methods Effect#applyAttributesModifiersToEntity and Effect#removeAttributesModifiersFromEntity. They are badly named and should be called onStart and onEnd. They are called at when an entity starts (and stops respectively) to be affected by your effect.

Ah okay! I was wondering about the Effect#applyAttributesModifiersToEntity and Effect#removeAttributesModifiersFromEntity methods, but I didn't think they were relevant. Thank you so much. :)

Okay, I've tried that now, and the code gets called, and my NBT data gets updated (I did /data get @s, and I saw mayFly: 1b.), but... I still can't fly. What's gone wrong?

 

package com.blockypenguin.labkit.effects;

import com.blockypenguin.labkit.LabKit;
import com.blockypenguin.labkit.util.list.ModEffects;

import net.minecraft.entity.LivingEntity;
import net.minecraft.entity.ai.attributes.AbstractAttributeMap;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.potion.Effect;
import net.minecraft.potion.EffectInstance;
import net.minecraft.potion.EffectType;
import net.minecraft.potion.Effects;
import net.minecraft.util.text.ITextComponent;

public class FlyingEffect extends Effect {
	
	public FlyingEffect() {
		super(EffectType.BENEFICIAL, 0x87cefa);
		setRegistryName("flying");
	}
	
	@Override
	public void removeAttributesModifiersFromEntity(LivingEntity entity, AbstractAttributeMap attributeMap, int amplifier) {
		if (entity instanceof PlayerEntity) {
			PlayerEntity player = (PlayerEntity) entity;
			player.abilities.isFlying = false;
			player.abilities.allowFlying = false;
		}else {
			entity.removeActivePotionEffect(Effects.LEVITATION);
		}
		
	}
	
	@Override
	public void applyAttributesModifiersToEntity(LivingEntity entity, AbstractAttributeMap attributeMap, int amplifier) {
		if (entity instanceof PlayerEntity) {
			PlayerEntity player = (PlayerEntity) entity;
			player.abilities.allowFlying = true;
			
			if(player.getActivePotionEffect(ModEffects.FLYING).getDuration() == 100) {
				player.sendStatusMessage(ITextComponent.Serializer.fromJson("You will stop flying in 5 seconds!"), true);
			}
			
		}else {
			entity.addPotionEffect(new EffectInstance(Effects.LEVITATION, 200, 3));
		}
		
	}
	
}

 

Today (22/10/20) I reached 100 posts!

I'm probably more excited than I should be for something so realistically minor...

Link to comment
Share on other sites

It works! thank you so much! Just a sidenote, other than using affectEntity, are there any special methods/classes that I'd need to use for an instant potion?

 

EDIT: Also, how would I disable splash and lingering potion types for a potion, whilst keeping the standard drinkable potion?

Edited by BlockyPenguin

Today (22/10/20) I reached 100 posts!

I'm probably more excited than I should be for something so realistically minor...

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Your drivers are in a broken state, follow the guide in the FAQ: https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/#:~:text=How do I update my drivers%3F
    • A fatal error has been detected by the Java Runtime Environment: # # EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x00007ffc3fe22b60, pid=15228, tid=5140 # # JRE version: OpenJDK Runtime Environment Microsoft-8035246 (17.0.8+7) (build 17.0.8+7-LTS) # Java VM: OpenJDK 64-Bit Server VM Microsoft-8035246 (17.0.8+7-LTS, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, windows-amd64) # Problematic frame: # C [atio6axx.dll+0x192b60] # # No core dump will be written. Minidumps are not enabled by default on client versions of Windows # # If you would like to submit a bug report, please visit: # https://aka.ms/minecraftjavacrashes # The crash happened outside the Java Virtual Machine in native code. # See problematic frame for where to report the bug i have no idea why please help
    • Quick-Books is great with regards to coordinating your monetary data. You can decide to live talk with a specialist at Quick-Books to get the answer for your questions. You will actually want to get to the talk going to the landing page and call us +1855-210-1428.
    • Update: I managed to make the item not disappear after crafting, but it doesn't remove any durability. import net.minecraft.enchantment.EnchantmentHelper; import net.minecraft.enchantment.Enchantments; import net.minecraft.enchantment.UnbreakingEnchantment; import net.minecraft.item.Item; import net.minecraft.item.ItemStack; public class NuggetHammer extends Item { private boolean damage; public NuggetHammer(Properties p_i48487_1_) { super(p_i48487_1_); } @Override public int getMaxDamage(ItemStack stack) { return 54 - 1; } public boolean isBarVisible(ItemStack stack) { return false; } @Override public ItemStack getContainerItem(ItemStack stack) { ItemStack copy = stack.copy(); copy.setCount(1); if (!this.damage) return copy; int unbreaking = EnchantmentHelper.getItemEnchantmentLevel(Enchantments.UNBREAKING, stack); for (int i = 0; i < unbreaking; i++) { if (UnbreakingEnchantment.shouldIgnoreDurabilityDrop(stack, unbreaking, random)) return copy; } copy.setDamageValue(stack.getDamageValue() + 1); if (copy.getDamageValue() > stack.getMaxDamage()) return ItemStack.EMPTY; return copy; } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.