BlockyPenguin

Ah, ok, I understand thank you!

Oh ok... how exactly does it defeat the point of DeferredRegister though? I thought the point was it stops you from doing things at the wrong time.

So, I'm switching my mod to use deferred registries. I've got this method: public static RegistryObject<Block> registerBlock(Block block) { return BLOCKS.register(block.getRegistryName().getPath(), () -> block); } (BLOCKS is my deferred registry for blocks) This allows me to do this in another class: public static final RegistryObject<Block> CAUTION_BLOCK = ModRegistry.registerBlock(new CautionBlock()); Which I personally think is a nice, clean way to do it. However, when it comes to things with "type"s, e.g. entities or tile entities, I have this: public static RegistryObject<TileEntityType<?>> registerTile(TileEntity te, ResourceLocation regName, Block... validBlocks) { TileEntityType<?> tetype = TileEntityType.Builder.create(() -> te.getTileEntity(), validBlocks).build(null).setRegistryName(regName); return TILE_TYPES.register(tetype.getRegistryName().getPath(), () -> tetype); } And that works! However for entities I have this: public static RegistryObject<EntityType<?>> registerEntity(Entity entity, ResourceLocation regName, EntityClassification classification, float width, float height) { EntityType<?> entityType = EntityType.Builder.create((a, b) -> entity, classification).size(width, height).build(regName.toString()).setRegistryName(regName); return ENTITY_TYPES.register(entityType.getRegistryName().getPath(), () -> entityType); } And I call it like this: public static final RegistryObject<EntityType<?>> ROBOT = ModRegistry.registerEntity(new RobotEntity(null, null), new ResourceLocation(LabKit.MODID, "robot"), EntityClassification.CREATURE, 0.6f, 0.9f); But that produces an odd error in the console: java.lang.IllegalStateException: Attempted to set registry name with existing registry name! New: labkit:robot Old: labkit:robot What am I doing wrong?

Yes

Ah, thanks! Yeah, sorry, my bad. Typed the wrong thing. Ok, cool! Will do! Thanks!

So I have an array of blocks in my registry class: private static Block[] modBlocks = { ModBlocks.CAUTION_BLOCK, ModBlocks.WHITE_FLOOR_TILES, ModBlocks.GREY_FLOOR_TILES, ModBlocks.DARK_GREY_FLOOR_TILES, ... }; I then loop through it to register them all: @SubscribeEvent public static void blockRegistry(final RegistryEvent.Register<Block> e) { for(Block block : modBlocks) { e.getRegistry().register(block); } } I was wondering if there's a way to do this for tile entities, as they're a little more awkward. I'm using the @ObjectHolder to register things. Thanks!

Ah cool, thank you!

I was trying to avoid lag, but okay

Oh ok, yeah, I didn't think about that, but it makes sense. I was hoping to keep the power stored in a blockstate to avoid using a tile entity. Do you know if it's still possible do that?

Thanks, I'll do that!

So I created a new block, adapting it from RedstoneWireBlock in the vanilla code. Here's my code: public class EnergyConduit extends Block { public static final BooleanProperty NORTH = BlockStateProperties.NORTH; public static final BooleanProperty EAST = BlockStateProperties.EAST; public static final BooleanProperty SOUTH = BlockStateProperties.SOUTH; public static final BooleanProperty WEST = BlockStateProperties.WEST; public static final BooleanProperty UP = BlockStateProperties.UP; public static final BooleanProperty DOWN = BlockStateProperties.DOWN; public static final IntegerProperty ENERGY = ModBlockStateProperties.CONDUIT_POWER_1000; public static final Map<Direction, BooleanProperty> CONNECTED_PROPERTY_MAP = Maps.newEnumMap(ImmutableMap.of( Direction.NORTH, NORTH, Direction.EAST, EAST, Direction.SOUTH, SOUTH, Direction.WEST, WEST )); private final Set<BlockPos> blocksNeedingUpdate = Sets.newHashSet(); public EnergyConduit() { super(Block.Properties.create(Material.IRON, MaterialColor.RED_TERRACOTTA) .hardnessAndResistance(3.0f) .sound(SoundType.LANTERN) ); this.setDefaultState(this.stateContainer.getBaseState().with(NORTH, Boolean.valueOf(false)).with(EAST, Boolean.valueOf(false)).with(SOUTH, Boolean.valueOf(false)).with(WEST, Boolean.valueOf(false)).with(ENERGY, Integer.valueOf(0))); this.setRegistryName(new ResourceLocation(LabKit.MODID, "energy_conduit")); } public BlockState getStateForPlacement(BlockItemUseContext context) { return getConnectedState(context.getWorld(), context.getPos()); } public BlockState updatePostPlacement(BlockState state, Direction facing, BlockState facingState, IWorld world, BlockPos currentPos, BlockPos facingPos) { return getConnectedState(world.getWorld(), currentPos); } private BlockState updateSurroundingConduits(World worldIn, BlockPos pos, BlockState state) { List<BlockPos> list = Lists.newArrayList(this.blocksNeedingUpdate); this.blocksNeedingUpdate.clear(); for(BlockPos blockpos : list) { worldIn.notifyNeighborsOfStateChange(blockpos, this); } return state; } private void notifyConduitNeighborsOfStateChange(World worldIn, BlockPos pos) { if (worldIn.getBlockState(pos).getBlock() == this) { worldIn.notifyNeighborsOfStateChange(pos, this); for(Direction direction : Direction.values()) { worldIn.notifyNeighborsOfStateChange(pos.offset(direction), this); } } } public void onBlockAdded(BlockState state, World worldIn, BlockPos pos, BlockState oldState, boolean isMoving) { if (oldState.getBlock() != state.getBlock() && !worldIn.isRemote) { this.updateSurroundingConduits(worldIn, pos, state); for(Direction direction : Direction.Plane.VERTICAL) { worldIn.notifyNeighborsOfStateChange(pos.offset(direction), this); } for(Direction direction1 : Direction.Plane.HORIZONTAL) { this.notifyConduitNeighborsOfStateChange(worldIn, pos.offset(direction1)); } for(Direction direction2 : Direction.Plane.HORIZONTAL) { BlockPos blockpos = pos.offset(direction2); if (worldIn.getBlockState(blockpos).isNormalCube(worldIn, blockpos)) { this.notifyConduitNeighborsOfStateChange(worldIn, blockpos.up()); } else { this.notifyConduitNeighborsOfStateChange(worldIn, blockpos.down()); } } } } @SuppressWarnings("deprecation") public void onReplaced(BlockState state, World worldIn, BlockPos pos, BlockState newState, boolean isMoving) { if (!isMoving && state.getBlock() != newState.getBlock()) { super.onReplaced(state, worldIn, pos, newState, isMoving); if (!worldIn.isRemote) { for(Direction direction : Direction.values()) { worldIn.notifyNeighborsOfStateChange(pos.offset(direction), this); } this.updateSurroundingConduits(worldIn, pos, state); for(Direction direction1 : Direction.Plane.HORIZONTAL) { this.notifyConduitNeighborsOfStateChange(worldIn, pos.offset(direction1)); } for(Direction direction2 : Direction.Plane.HORIZONTAL) { BlockPos blockpos = pos.offset(direction2); if (worldIn.getBlockState(blockpos).isNormalCube(worldIn, blockpos)) { this.notifyConduitNeighborsOfStateChange(worldIn, blockpos.up()); } else { this.notifyConduitNeighborsOfStateChange(worldIn, blockpos.down()); } } } } } public void neighborChanged(BlockState state, World worldIn, BlockPos pos, Block blockIn, BlockPos fromPos, boolean isMoving) { if (!worldIn.isRemote) { if (state.isValidPosition(worldIn, pos)) { this.updateSurroundingConduits(worldIn, pos, state); } else { spawnDrops(state, worldIn, pos); worldIn.removeBlock(pos, false); } } } @SuppressWarnings("deprecation") protected static boolean canConnectTo(BlockState blockState, IBlockReader world, BlockPos pos, @Nullable Direction side) { Block block = blockState.getBlock(); if (block == ModBlocks.ENERGY_CONDUIT) { return true; } else if (block.hasTileEntity() && world.getTileEntity(pos).getCapability(CapabilityEnergy.ENERGY).isPresent()) { return true; } else { return blockState.canConnectRedstone(world, pos, side) && side != null; } } public BlockRenderLayer getRenderLayer() { return BlockRenderLayer.CUTOUT; } protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) { builder.add(NORTH, EAST, SOUTH, WEST, ENERGY); } private BlockState getConnectedState(World world, BlockPos pos) { BlockState returnState = this.getDefaultState(); if(world.getBlockState(pos.north()).getBlock() == ModBlocks.ENERGY_CONDUIT) { returnState = returnState.with(NORTH, Boolean.valueOf(true)); } if(world.getBlockState(pos.east()).getBlock() == ModBlocks.ENERGY_CONDUIT) { returnState = returnState.with(EAST, Boolean.valueOf(true)); } if(world.getBlockState(pos.south()).getBlock() == ModBlocks.ENERGY_CONDUIT) { returnState = returnState.with(SOUTH, Boolean.valueOf(true)); } if(world.getBlockState(pos.west()).getBlock() == ModBlocks.ENERGY_CONDUIT) { returnState = returnState.with(WEST, Boolean.valueOf(true)); } if(world.getBlockState(pos.up()).getBlock() == ModBlocks.ENERGY_CONDUIT) { returnState = returnState.with(UP, Boolean.valueOf(true)); } if(world.getBlockState(pos.down()).getBlock() == ModBlocks.ENERGY_CONDUIT) { returnState = returnState.with(DOWN, Boolean.valueOf(true)); } return returnState; } } But when I launch Minecraft, forge just hangs after printing this to the console: [modloading-worker-1/DEBUG] [ne.mi.fm.ja.FMLModContainer/LOADING]: Completed Automatic event subscribers for forge What have I done wrong? I've added some breakpoints and it seems that it never actually registers the block.

So I'd like to create a new crafting block. What do I mean by that? I need a block like a crafting table, so I put in some items, and it gives me another in return. I'd also like it to be reversible. Similar to the Machine Workbench from OmegaCraft. I've been searching through the internet and vanilla code, and all I end up with is a headache. Could someone please give some advice? Thanks, BP.

Ah, that's perfect, thank you! ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ Thanks for the advice, but directions are handled by StairsBlock, which my class extends.

So I've now changed it to this, and the game loads, but if I place down a stair block, it crashes... public class CautionBlockStairs extends StairsBlock { public CautionBlockStairs() { super(new CautionBlock().getDefaultState(), Block.Properties.from(new CautionBlock())); this.setDefaultState(new CautionBlock().getDefaultState()); this.setRegistryName("caution_block_stairs"); } protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) { builder.add(CautionBlock.BORDER); builder.add(CautionBlock.SHADING); super.fillStateContainer(builder); } } Here's the crash report: What I understand from this is that because I'm passing in the CautionBlock's default state, I need to add the direction/shape properties to it. How would I do that?

Ok, I've now added that in: protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) { builder.add(CautionBlock.BORDER); builder.add(CautionBlock.SHADING); super.fillStateContainer(builder); } But I'm still getting the same error. It's pointing to line 13: super(null, Block.Properties.from(new CautionBlock())); in the constructor. I realise that adding super in the fillStateContainer probably prevents another error from occurring further down the line, so thanks for that!