Posted April 8, 20205 yr EDIT: Created a pull request https://github.com/MinecraftForge/MinecraftForge/pull/6609 -------------------------------------------------------------------- Not sure if I found a forge bug. Ill just elaborate: - The Vanilla Effect class implements the Forge IForgeEffect interface - IForgeEffect interface has a method "getCurativeItems" which returns a list of item stacks which cure the effect - This has a default implementation containing only the milk bucket - The MilkBucketItem class then appropriately calls the method which checks if it cures each effect and then removes it only if applicable - So far so good - Now here is the problem: In the same method it also calls a method which removes all potion effects regardless, kinda negating everything from above. Latest 1.15.2 version of forge The code mentioned: Inside MilkBucketItem::onItemUseFinish Correct first call: LivingEntity::curePotionEffects Unnecessary (I guess) call: LivingEntity::clearActivePotions Edited April 9, 20205 yr by CAS_ual_TY https://github.com/CAS-ual-TY/Visibilis [1.14] How to Villagers, Trades, Professions, Fix Trades https://minecraft.curseforge.com/projects/gun-customization-infinity / https://github.com/CAS-ual-TY/GunCus https://minecraft.curseforge.com/projects/ygo-dueling-mod https://minecraft.curseforge.com/projects/mundus-magicus https://minecraft.curseforge.com/projects/deuf-duplicate-entity-uuid-fix
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.