Jump to content

[1.15.2] Trouble adding Entities to the game


Triphion

Recommended Posts

I've managed to add entities to the mod, but not with spawn eggs and natural spawns. To start off with, I don't know when to add the entity spawns. Secondly, I don't know if my current spawn code actually works since I haven't tried it, but if you see some problem with it, please point that out. And lastly, the spawn eggs. I know how to add a spawn egg, unfortunately, since i'm using deferred registries for the entities etc. the normal "Entitytype.MYENTITY" does not work, and neither does "Entitytype.MYENTITY.get()" nor "RegistryObject.of(Entitytype.MYENTITY.getId(), ForgeRegistries.ENTITIES)". So to fix this, i decided to pretty much copy the original spawnEggItem class, and change it so it can work with deferred registries. But, some problem has arisen there as well. Specifically, the coloring of the egg; it's always white and grey. 

 

 

 

	public static void registerSpawns() 
	{
		spawnEntities(RegistryObject.of(EtauricEntities.CHUPNUT.getId(), ForgeRegistries.ENTITIES), 25, 1, 3, Biome.Category.FOREST);
		spawnEntities(RegistryObject.of(EntityType.IRON_GOLEM.getRegistryName(), ForgeRegistries.ENTITIES), 25, 1, 3, Biome.Category.FOREST);
	}
	
	private static void spawnEntities(RegistryObject<? extends EntityType<? extends LivingEntity>> entityType, int weightIn, int minGroupCountIn, int maxGroupCountIn, Biome.Category...biomes) 
	{
		Utils.getLogger().info("EntityType: " + entityType);
		
		for (int i = 0; i < biomes.length; i++)
		{
			for (Biome biome : ForgeRegistries.BIOMES)
			{
				if (biome.getCategory() == biomes[i])
				{
					biome.getSpawns(EntityClassification.MONSTER).add(new Biome.SpawnListEntry(entityType.get(), weightIn, minGroupCountIn, maxGroupCountIn));
				}
			}
		}
	}

This is my entity spawn method. 

 

public class EtauricSpawnEggItem extends Item
{
	private static final Map<RegistryObject<? extends EntityType<?>>, EtauricSpawnEggItem> EGGS = Maps.newIdentityHashMap();
	private final int primaryColor;
	private final int secondaryColor;
	private final RegistryObject<? extends EntityType<?>> typeIn;
	
	public EtauricSpawnEggItem(RegistryObject<? extends EntityType<?>> typeIn, int primaryColorIn, int secondaryColorIn, Properties builder) 
	{
		super(builder);
		this.typeIn = typeIn;
		this.primaryColor = primaryColorIn;
		this.secondaryColor = secondaryColorIn;
		EGGS.put(typeIn, this);
	}
	
	public ActionResultType onItemUse(ItemUseContext context) 
	{
		World world = context.getWorld();
		if (world.isRemote) 
		{
			return ActionResultType.SUCCESS;
		} 
		else 
		{
			ItemStack itemstack = context.getItem();
			BlockPos blockpos = context.getPos();
			Direction direction = context.getFace();
			BlockState blockstate = world.getBlockState(blockpos);
			Block block = blockstate.getBlock();
			if (block == Blocks.SPAWNER) 
			{
				TileEntity tileentity = world.getTileEntity(blockpos);
				if (tileentity instanceof MobSpawnerTileEntity) 
				{
					AbstractSpawner abstractspawner = ((MobSpawnerTileEntity)tileentity).getSpawnerBaseLogic();
					RegistryObject<? extends EntityType<?>> entitytype1 = this.getType(itemstack.getTag());
					abstractspawner.setEntityType(entitytype1.get());
					tileentity.markDirty();
					world.notifyBlockUpdate(blockpos, blockstate, blockstate, 3);
					itemstack.shrink(1);
					return ActionResultType.SUCCESS;
				}
			}

			BlockPos blockpos1;
			if (blockstate.getCollisionShape(world, blockpos).isEmpty()) 
			{
				blockpos1 = blockpos;
			} 
			else 
			{
				blockpos1 = blockpos.offset(direction);
		    }
			RegistryObject<? extends EntityType<?>> entitytype = this.getType(itemstack.getTag());
			if (entitytype.get().spawn(world, itemstack, context.getPlayer(), blockpos1, SpawnReason.SPAWN_EGG, true, !Objects.equals(blockpos, blockpos1) && direction == Direction.UP) != null) 
			{
				itemstack.shrink(1);
		    }

			return ActionResultType.SUCCESS;
		}
	}

		   /**
		    * Called to trigger the item's "innate" right click behavior. To handle when this item is used on a Block, see
		    * {@link #onItemUse}.
		    */
	public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn) 
	{
		ItemStack itemstack = playerIn.getHeldItem(handIn);
		RayTraceResult raytraceresult = rayTrace(worldIn, playerIn, RayTraceContext.FluidMode.SOURCE_ONLY);
		if (raytraceresult.getType() != RayTraceResult.Type.BLOCK) 
		{
			return ActionResult.resultPass(itemstack);
		} 
		else if (worldIn.isRemote) 
		{
			return ActionResult.resultSuccess(itemstack);
		} 
		else 
		{
			BlockRayTraceResult blockraytraceresult = (BlockRayTraceResult)raytraceresult;
			BlockPos blockpos = blockraytraceresult.getPos();
			if (!(worldIn.getBlockState(blockpos).getBlock() instanceof FlowingFluidBlock)) 
			{
				return ActionResult.resultPass(itemstack);
			} 
			else if (worldIn.isBlockModifiable(playerIn, blockpos) && playerIn.canPlayerEdit(blockpos, blockraytraceresult.getFace(), itemstack)) 
			{
				RegistryObject<? extends EntityType<?>> entitytype = this.getType(itemstack.getTag());
				if (entitytype.get().spawn(worldIn, itemstack, playerIn, blockpos, SpawnReason.SPAWN_EGG, false, false) == null) 
				{
					return ActionResult.resultPass(itemstack);
				} 
				else 
				{
					if (!playerIn.abilities.isCreativeMode) 
					{
						itemstack.shrink(1);
					}
					playerIn.addStat(Stats.ITEM_USED.get(this));
					return ActionResult.resultSuccess(itemstack);
				}
			} 
			else 
			{
				return ActionResult.resultFail(itemstack);
			}
		}
	}

	public boolean hasType(@Nullable CompoundNBT p_208077_1_, RegistryObject<? extends EntityType<?>> type) 
	{
		return Objects.equals(this.getType(p_208077_1_), type);
	}

	@OnlyIn(Dist.CLIENT)
	public int getColor(int tintIndex) 
	{
		return tintIndex == 0 ? this.primaryColor : this.secondaryColor;
	}

	@Nullable
	@OnlyIn(Dist.CLIENT)
	public static EtauricSpawnEggItem getEgg(@Nullable RegistryObject<? extends EntityType<?>> type) 
	{
		return EGGS.get(type);
	}

	public static Iterable<EtauricSpawnEggItem> getEggs() 
	{
		return Iterables.unmodifiableIterable(EGGS.values());
	}

	public RegistryObject<? extends EntityType<?>> getType(@Nullable CompoundNBT p_208076_1_) 
	{
		if (p_208076_1_ != null && p_208076_1_.contains("EntityTag", 10)) 
		{
			CompoundNBT compoundnbt = p_208076_1_.getCompound("EntityTag");
			if (compoundnbt.contains("id", 8)) 
			{
				return RegistryObject.of(new ResourceLocation(compoundnbt.getString("id")), ForgeRegistries.ENTITIES);
			}
		}
		return this.typeIn;
	}
}

This is my spawn egg class. 

 

	public static final RegistryObject<Item> CHUPNUT_SPAWN_EGG = ITEMS.register("chupnut_spawn_egg", () -> new EtauricSpawnEggItem(RegistryObject.of(EtauricEntities.CHUPNUT.getId(), ForgeRegistries.ENTITIES), 4993583, 12692382, (new Item.Properties().group(ItemGroup.MISC))));

And this is how I register it in my Items register. 

 

Any sort of help is very much appreciated. 

Edited by Triphion
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello. I'm using IntelliJ IDEA and making a mod for Forge 1.20.1 and I'm trying to make a GUI. I found that the Minecraft-related codes are all obfuscated and when setting up the workspace, Gradle did not execute Deobfuscation tasks like createMcpToSrg. Is this normal or a bug? Can anyone help me with this?
    • Hello! I'm trying to get a list of all entries registered in the infusion upgrade registry. Code can be found in github: https://github.com/ChamoisEST/MiningMadness/tree/1.20.1 Registry in common/registries/MMRegistries.java Event that calls the registry is in MiningMadness.java List of registered entries should be called in common/capabilities/infusion/InfusionCapabilityImplementation.java:getActiveInfusions() in the for loop. Is there any way to accomplish that? Thanks in advance!  
    • So, I am trying to create and add tags to my custom damage type, but looks like I made something wrong, since it crashing with error that "cannot register" damage type. Im trying to register it, and in datagen add tags, but it everytime crashing due to not register "grimtales:entropy". Full code there - https://github.com/undertakerJ/Grim-Tales-Forge ModDamageTypes class public class ModDamageTypes { public static final DeferredRegister<DamageType> DAMAGE_TYPES = DeferredRegister.create(Registries.DAMAGE_TYPE, GrimTales.MOD_ID); public static final ResourceKey<DamageType> ENTROPY_KEY = ResourceKey.create(Registries.DAMAGE_TYPE, new ResourceLocation(GrimTales.MOD_ID, "entropy")); public static final RegistryObject<DamageType> ENTROPY = DAMAGE_TYPES.register( "entropy", () -> new DamageType("entropy_effect", DamageScaling.ALWAYS, 1f, DamageEffects.HURT)); // // public static final DamageSource ENTROPY_SOURCE = new DamageSource(Holder.direct(ENTROPY.get())); public static void register(IEventBus eventBus) { DAMAGE_TYPES.register(eventBus); } } Datagen for damageTags public class ModDamageTagsProvider extends DamageTypeTagsProvider { public ModDamageTagsProvider( PackOutput p_270719_, CompletableFuture<HolderLookup.Provider> p_270256_, @Nullable ExistingFileHelper existingFileHelper) { super(p_270719_, p_270256_, GrimTales.MOD_ID, existingFileHelper); } @Override protected void addTags(HolderLookup.Provider pProvider) { this.tag(DamageTypeTags.BYPASSES_INVULNERABILITY).add(ModDamageTypes.ENTROPY_KEY); } } Datagen class it self   @Mod.EventBusSubscriber(modid = GrimTales.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD) public class DataGenerators { @SubscribeEvent public static void gatherData(GatherDataEvent event){ DataGenerator generator = event.getGenerator(); PackOutput packOutput = generator.getPackOutput(); ExistingFileHelper helper = event.getExistingFileHelper(); CompletableFuture<HolderLookup.Provider> lookupProvider = event.getLookupProvider(); generator.addProvider(event.includeServer(), new ModDamageTagsProvider(packOutput, lookupProvider, helper)); } } And register class in main class public GrimTales() { IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus(); ModDamageTypes.register(modEventBus); modEventBus.addListener(this::commonSetup); MinecraftForge.EVENT_BUS.register(this); modEventBus.addListener(this::addCreative); }  
    • Looking for a semi-vanilla Minecraft server? Maybe one with keep inventory and land claims? I have one for you! Let me introduce you to Safe Survival! Come on and join us at mc.safesurvival.net. It is bedrock supported too!
    • Hi. I'm trying to play RLCraft with Optifine but my game keeps crashing on startup with Exit Code 1. The modpack was working fine yesterday, not sure what changed to make it not wanna work anymore. I was hoping someone here could help me figure out what's going wrong. If I remove Optifine, nothing changes, I still get the same errors. Thanks in advance. Crash Report (I only included the errors+fatal, I’m not sure if more is needed, please let me know): https://pastebin.ai/66ivknz0f4  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.