Jump to content

Recommended Posts

Posted (edited)

I am currently working on a world render event that draws blocks in the world. In order to do this in 1.15.2, it appears I need a buffer that implements IRenderTypeBuffer. Could someone please explain how I could get an instance of this kind of buffer from within a RenderWorldLastEvent function?

Edited by nanorover59
Posted

Hi

Looking at where RenderWorldLastEvent is called in the vanilla code, it appears to be called after all the vanilla render buffers have already been finished, so there's nothing for you to write to.  (See WorldRenderer::updateCameraAndRender and ::renderWorld

 

Based on this link you can create your own buffer-

https://gist.github.com/williewillus/30d7e3f775fe93c503bddf054ef3f93e

 

But it may be difficult to achieve the effects you want if you're drawing out of the correct sequence; especially translucent blocks can be very sensitive to the order that you draw them in.  You might be better off drawing the blocks a different way (for example: tileentity).

 

-TGG

 

 

Posted

For my purposes (mobile "sub-worlds" or "meta-worlds"), rendering with a client event seems preferable and was used successfully in 1.12.2.

 

My first idea for initializing a buffer has no compiler errors and is written as follows.

IRenderTypeBuffer buffer = IRenderTypeBuffer.getImpl(Tessellator.getInstance().getBuffer());

 

Does this look correct so far?

Posted

Howdy

 

I've never done that yet but based on Vanilla, yes it looks about right

IRenderTypeBuffer buffer = IRenderTypeBuffer.getImpl(Tessellator.getInstance().getBuffer());
// set up your render settings
// do your render
buffer.finish();

perhaps wrapped in

RenderSystem.pushMatrix(); 
RenderSystem.popMatrix();

-TGG

Posted (edited)

Thanks for the help so far!

I was able to render an obsidian block in the world. However, it moves around strangely whenever I stand on a block next to it and sneak or more noticeably if I view it from third person.

 

The code for the RenderWorldLastEvent that renders the block:

Spoiler

@Mod.EventBusSubscriber(Dist.CLIENT)
public class ClientEvents
{
	@SuppressWarnings("deprecation")
	@SubscribeEvent
	public static void renderWorldLastEvent(RenderWorldLastEvent event)
	{
		if(event.getPhase() != EventPriority.NORMAL)
			return;
		
		Entity entity = Minecraft.getInstance().getRenderViewEntity();
		
		if(entity == null)
			return;
		
		double x = entity.lastTickPosX + (entity.getPosX() - entity.lastTickPosX) * (double) event.getPartialTicks();
		double y = entity.lastTickPosY + (entity.getPosY() - entity.lastTickPosY) * (double) event.getPartialTicks();
		double z = entity.lastTickPosZ + (entity.getPosZ() - entity.lastTickPosZ) * (double) event.getPartialTicks();
		
		MinecraftServer server = Minecraft.getInstance().getIntegratedServer();
		World world = DimensionManager.getWorld(server, DimensionType.OVERWORLD, false, true);
		MatrixStack matrixStack = event.getMatrixStack();
		BlockRendererDispatcher blockRendererDispatcher = Minecraft.getInstance().getBlockRendererDispatcher();
		
		BlockState blockState = Blocks.OBSIDIAN.getDefaultState();
				
		Impl renderTypeBuffer = IRenderTypeBuffer.getImpl(Tessellator.getInstance().getBuffer());
		
		matrixStack.push();
		matrixStack.translate(-x, -y + 128.0, -z);
		
		RenderType renderType = RenderTypeLookup.getRenderType(blockState);
		blockRendererDispatcher.renderModel(blockState, new BlockPos(0, 128, 0), world, matrixStack, renderTypeBuffer.getBuffer(renderType), false, world.getRandom());

		matrixStack.pop();
		
		renderTypeBuffer.finish();
    }
}

 

 

Two screenshots of the rendered block from first and third person perspectives (with a normal diamond block for reference):

Spoiler

mDyrEc1.png

s4WkVN8.png

 

 

Edited by nanorover59
Posted

Sorry, I have no clue about that, it sounds to me like MatrixStack is changing its transformation based on what the player is doing, unlike the various other world rendering (blocks, entities, etc) where it's tied to the world x,y,z.

 

You could try tracing through the vanilla render code and/or inspecting the MatrixStack (using a breakpoint) to see what is going on, it may be hard work...

 

Williewillus may know- see here https://gist.github.com/williewillus/353c872bcf1a6ace9921189f6100d09a

... since this looks promising...

Quote

Your world renderers (RenderWorldLastEvent) look weird? give this a read: https://discordapp.com/channels/313125603924639766/454376090362970122/588257071812837376

Unfortunately the link appears to be busted.

 

If you comment on that gist (s)he may reply, has been pretty responsive in the past

 

-TGG

 

Posted (edited)

 

 

 

9 hours ago, nanorover59 said:

Thanks for the help so far!

I was able to render an obsidian block in the world. However, it moves around strangely whenever I stand on a block next to it and sneak or more noticeably if I view it from third person.

 

The code for the RenderWorldLastEvent that renders the block:

  Hide contents


@Mod.EventBusSubscriber(Dist.CLIENT)
public class ClientEvents
{
	@SuppressWarnings("deprecation")
	@SubscribeEvent
	public static void renderWorldLastEvent(RenderWorldLastEvent event)
	{
		if(event.getPhase() != EventPriority.NORMAL)
			return;
		
		Entity entity = Minecraft.getInstance().getRenderViewEntity();
		
		if(entity == null)
			return;
		
		double x = entity.lastTickPosX + (entity.getPosX() - entity.lastTickPosX) * (double) event.getPartialTicks();
		double y = entity.lastTickPosY + (entity.getPosY() - entity.lastTickPosY) * (double) event.getPartialTicks();
		double z = entity.lastTickPosZ + (entity.getPosZ() - entity.lastTickPosZ) * (double) event.getPartialTicks();
		
		MinecraftServer server = Minecraft.getInstance().getIntegratedServer();
		World world = DimensionManager.getWorld(server, DimensionType.OVERWORLD, false, true);
		MatrixStack matrixStack = event.getMatrixStack();
		BlockRendererDispatcher blockRendererDispatcher = Minecraft.getInstance().getBlockRendererDispatcher();
		
		BlockState blockState = Blocks.OBSIDIAN.getDefaultState();
				
		Impl renderTypeBuffer = IRenderTypeBuffer.getImpl(Tessellator.getInstance().getBuffer());
		
		matrixStack.push();
		matrixStack.translate(-x, -y + 128.0, -z);
		
		RenderType renderType = RenderTypeLookup.getRenderType(blockState);
		blockRendererDispatcher.renderModel(blockState, new BlockPos(0, 128, 0), world, matrixStack, renderTypeBuffer.getBuffer(renderType), false, world.getRandom());

		matrixStack.pop();
		
		renderTypeBuffer.finish();
    }
}

 

 

Two screenshots of the rendered block from first and third person perspectives (with a normal diamond block for reference):

  Hide contents

mDyrEc1.png

s4WkVN8.png

 

 

I had a very similar problem. What fixes it is replacing


		double x = entity.lastTickPosX + (entity.getPosX() - entity.lastTickPosX) * (double) event.getPartialTicks();
		double y = entity.lastTickPosY + (entity.getPosY() - entity.lastTickPosY) * (double) event.getPartialTicks();
		double z = entity.lastTickPosZ + (entity.getPosZ() - entity.lastTickPosZ) * (double) event.getPartialTicks();
		
		

with

Vec3d projectedView = Minecraft.getInstance().gameRenderer.getActiveRenderInfo().getProjectedView();
        matrixStack.translate(-projectedView.x, -projectedView.y+128, -projectedView.z);

(replacing the old matrixStack.translate call in the proper place obviously)

 

When I had it using .getPartialTicks(), my rendering disappeared while I was moving. Not sure the technical reason behind this, but switching to projectedView works.

 

works.png

Edited by Contomman
Posted (edited)

I tried the other way of getting view point coordinates and it works now!

 

One issue still remains, which is that the east, west, and bottom sides of the block appear slightly darker than the other sides. This lighting behavior is not visible on normal obsidian blocks.

Edited by nanorover59
Posted (edited)
58 minutes ago, nanorover59 said:

I tried the other way of getting view point coordinates and it works now!

 

One issue still remains, which is that the east, west, and bottom sides of the block appear slightly darker than the other sides. This lighting behavior is not visible on normal obsidian blocks.

Im not quite sure how do do that either, im working on a different bit of my mod right now, but I know if you look at the code for defining the RenderType you can give it variables for lighting (there is one called lightmap), but I havent tried changing it yet. That part of the code doesnt seem to be fully mapped out yet, even on the latest mappings, so there is still alot of obfuscated variables. Let me know If you get it working. Ill message you if I ever get that far.

Edited by Contomman
Posted

I was able to fix that final issue with lighting by iterating through all of the block render types.

The "block" now looks exactly like a normal obsidian block in the world!

From past experience, tile entities should be somewhat simpler to render because of their dedicated rendering functions that can be invoked.

 

For anyone curious about rendering blocks this way, here is the final client event handler code:

@Mod.EventBusSubscriber(Dist.CLIENT)
public class ClientEvents
{
	@SuppressWarnings({ "resource" })
	@SubscribeEvent
	public static void renderWorldLastEvent(RenderWorldLastEvent event)
	{
		if(event.getPhase() != EventPriority.NORMAL)
			return;
		
		// Get instances of the classes required for a block render.
		MinecraftServer server = Minecraft.getInstance().getIntegratedServer();
		World world = DimensionManager.getWorld(server, DimensionType.OVERWORLD, false, true);
		MatrixStack matrixStack = event.getMatrixStack();
		
		// Get the projected view coordinates.
		Vec3d projectedView = Minecraft.getInstance().gameRenderer.getActiveRenderInfo().getProjectedView();
		
		// Choose obsidian as the arbitrary block.
		BlockState blockState = Blocks.OBSIDIAN.getDefaultState();

		// Begin rendering the block.	
		Impl renderTypeBuffer = IRenderTypeBuffer.getImpl(Tessellator.getInstance().getBuffer());
		
		renderBlock(matrixStack, renderTypeBuffer, world, blockState, new BlockPos(0, 128, 0), projectedView, new Vec3d(0.0, 128.0, 0.0));
		
		renderTypeBuffer.finish();
    }
	
	@SuppressWarnings("deprecation")
	public static void renderBlock(MatrixStack matrixStack, Impl renderTypeBuffer, World world, BlockState blockState, BlockPos logicPos, Vec3d projectedView, Vec3d renderCoordinates)
	{
		BlockRendererDispatcher blockRendererDispatcher = Minecraft.getInstance().getBlockRendererDispatcher();
		int i = OverlayTexture.NO_OVERLAY;
		
		matrixStack.push();
		matrixStack.translate(-projectedView.x + renderCoordinates.x, -projectedView.y + renderCoordinates.y, -projectedView.z + renderCoordinates.z);
		
		for(RenderType renderType : RenderType.getBlockRenderTypes())
		{
            if(RenderTypeLookup.canRenderInLayer(blockState, renderType))
            	blockRendererDispatcher.getBlockModelRenderer().renderModel(world, blockRendererDispatcher.getModelForState(blockState), blockState, logicPos, matrixStack, renderTypeBuffer.getBuffer(renderType), true, new Random(), blockState.getPositionRandom(logicPos), i);
		}
		
		matrixStack.pop();
	}
}

 

Thanks for all of the support on this somewhat complex topic!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm sure this entire community knows exactly who you are, what mixin you're talking about, and how deer function in minecraft.  But being new here, and I am ignorant about all of those things. That said, I'd love to review your mixin.  I'm also having mixin issues, and I feel that if I can help you, perhaps both of our problems might get solved. Can you provide some links and context for people who aren't aware of your renown?  I'm asking humbly because I know you probably have better things to do, and you just want somebody to fix things for you.
    • I am working in the latest MDK.  Minecraft 1.21.4, Forge 54.1.0. I am trying to create a mixin.  The implementation doesn't matter.  Assume it is doing nothing more than logging to the console: @Mixin(LevelRenderer.class) public abstract class LevelRendererMixin { private static final Logger LOGGER = LogManager.getLogger("LevelRendererMixin"); @Inject(method = "renderLevel", at = @At("TAIL")) private void onRenderLevel( com.mojang.blaze3d.resource.GraphicsResourceAllocator allocator, net.minecraft.client.DeltaTracker deltaTracker, boolean someFlag, Camera camera, GameRenderer gameRenderer, Matrix4f matrix1, Matrix4f matrix2, CallbackInfo ci ) { Assuming my whole implementation is just to write something to console, it works perfectly fine in when I debug (runClient) in IntelliJ.  Whenever the Minecraft `renderLevel` runs every frame, my logging is overlaid at "TAIL". Yes, this spams the sht out of the console. But when I `build` and use the jar as a mod, it does not.  The mixin annotation processor shows to be loading, and my other parts of my mod work, but the nothing gets logged by my mixin. I am apparently generating a proper `refmap` and it's in the jar root.  Other files are also in the jar appropriately, including mods.toml.  And all the naming and reference paths are correct. I had to add this to my build.gradle to get my refmap into the jar ([name] obviously replaced): tasks.register("copyRefmap", Copy) { dependsOn tasks.named("compileJava") from("${project.buildDir}/tmp/compileJava") { include "mixins.[name].refmap.json" } into("${project.buildDir}/resources/main") } tasks.named("processResources", ProcessResources).configure { dependsOn(tasks.named("copyRefmap")) } tasks.named("jar", Jar).configure { // Include the generated refmap from build/resources/main into the jar. from("${project.buildDir}/resources/main") { include "mixins.[name].refmap.json" } }   Just for fun, here is my refmap in case something looks wrong to anybody:   { "mappings": { "com/[name]/mixin/LevelRendererMixin": { "renderLevel": "Lnet/minecraft/client/renderer/LevelRenderer;m_109599_(Lcom/mojang/blaze3d/resource/GraphicsResourceAllocator;Lnet/minecraft/client/DeltaTracker;ZLnet/minecraft/client/Camera;Lnet/minecraft/client/renderer/GameRenderer;Lorg/joml/Matrix4f;Lorg/joml/Matrix4f;)V" } }, "data": { "searge": { "com/[name]/mixin/LevelRendererMixin": { "renderLevel": "Lnet/minecraft/client/renderer/LevelRenderer;m_109599_(Lcom/mojang/blaze3d/resource/GraphicsResourceAllocator;Lnet/minecraft/client/DeltaTracker;ZLnet/minecraft/client/Camera;Lnet/minecraft/client/renderer/GameRenderer;Lorg/joml/Matrix4f;Lorg/joml/Matrix4f;)V" } } } } TLDR; My mixin works in dev, but not when built and run in an official Forge/Minecraft environment.  Like it's not overlaying/replacing the minecraft function. What are some typical other things to check when a mixin works in dev, but not after build?
    • Thank you, Ugdhar.  But that only confirms the problem.  Both in the github and in my IDE, if I search for objects extended from net.minecraftforge.client.event, it isn't there.  Though the javadocs (at least at nekoyue) say it should be. Maybe since it definitely isn't there, is there some other way anybody knows to highlight some blocks (without mixins and drawing artificial faces on the camera).
    • Please read the FAQ for how to properly post logs.   Also, this is a fabric log, not a forge log, you would probably get better results posting where fabric support is given.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.