Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[SOLVED] [1.15.2] Why my custom item entity not renderer?

grossik

By grossik
in Modder Support

 Share

Recommended Posts

grossik Stone Miner

grossik

Posted
Posted

Hello. I make custom item entity, but if I press Q my item not render. I dont know why

Entity: 

package cz.grossik.farmcraft.entity;

import cz.grossik.farmcraft.init.ItemInit;
import net.minecraft.block.material.Material;
import net.minecraft.entity.EntityType;
import net.minecraft.entity.item.ItemEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class FarmCraftItemEntity extends ItemEntity {
		
	public FarmCraftItemEntity(EntityType<? extends ItemEntity> p_i50217_1_, World p_i50217_2_) {
		super(p_i50217_1_, p_i50217_2_);
	}
	
	public FarmCraftItemEntity(World worldIn, double x, double y, double z) {
		super(worldIn, x, y, z);
	}

	public FarmCraftItemEntity(World worldIn, double x, double y, double z, ItemStack stack) {
		this(worldIn, x, y, z);
	}
	
	@Override
	public void tick() {
		System.err.println("tick");
		if(this.isInWater()) {
			System.err.println("water");
			ItemStack newItemStack = new ItemStack(ItemInit.soaked_barley.get());
			ItemEntity newItem = new ItemEntity(this.world, this.getPosition().getX(), this.getPosition().getY(), this.getPosition().getZ(), newItemStack);
			this.world.addEntity(newItem);
			this.remove();
		}
		super.tick();
	}
}

Render: 

package cz.grossik.farmcraft.renderer;

import com.mojang.blaze3d.matrix.MatrixStack;

import cz.grossik.farmcraft.entity.FarmCraftItemEntity;

import java.util.Random;

import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.IRenderTypeBuffer;
import net.minecraft.client.renderer.Vector3f;
import net.minecraft.client.renderer.entity.EntityRenderer;
import net.minecraft.client.renderer.entity.EntityRendererManager;
import net.minecraft.client.renderer.model.IBakedModel;
import net.minecraft.client.renderer.model.ItemCameraTransforms;
import net.minecraft.client.renderer.texture.AtlasTexture;
import net.minecraft.client.renderer.texture.OverlayTexture;
import net.minecraft.entity.LivingEntity;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.math.MathHelper;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;

@OnlyIn(Dist.CLIENT)
public class FarmCraftItemEntityRenderer extends EntityRenderer<FarmCraftItemEntity> {
   private final net.minecraft.client.renderer.ItemRenderer itemRenderer;
   private final Random random = new Random();

   public FarmCraftItemEntityRenderer(EntityRendererManager renderManagerIn) {
      super(renderManagerIn);
      this.itemRenderer = Minecraft.getInstance().getItemRenderer();
      this.shadowSize = 0.15F;
      this.shadowOpaque = 0.75F;
   }

   protected int getModelCount(ItemStack stack) {
	      int i = 1;
	      if (stack.getCount() > 48) {
	         i = 5;
	      } else if (stack.getCount() > 32) {
	         i = 4;
	      } else if (stack.getCount() > 16) {
	         i = 3;
	      } else if (stack.getCount() > 1) {
	         i = 2;
	      }

	      return i;
	   }

	   public void render(FarmCraftItemEntity entityIn, float entityYaw, float partialTicks, MatrixStack matrixStackIn, IRenderTypeBuffer bufferIn, int packedLightIn) {
	      matrixStackIn.push();
	      ItemStack itemstack = entityIn.getItem();
	      int i = itemstack.isEmpty() ? 187 : Item.getIdFromItem(itemstack.getItem()) + itemstack.getDamage();
	      this.random.setSeed((long)i);
	      IBakedModel ibakedmodel = this.itemRenderer.getItemModelWithOverrides(itemstack, entityIn.world, (LivingEntity)null);
	      boolean flag = ibakedmodel.isGui3d();
	      int j = this.getModelCount(itemstack);
	      float f = 0.25F;
	      float f1 = shouldBob() ? MathHelper.sin(((float)entityIn.getAge() + partialTicks) / 10.0F + entityIn.hoverStart) * 0.1F + 0.1F : 0;
	      float f2 = ibakedmodel.getItemCameraTransforms().getTransform(ItemCameraTransforms.TransformType.GROUND).scale.getY();
	      matrixStackIn.translate(0.0D, (double)(f1 + 0.25F * f2), 0.0D);
	      float f3 = ((float)entityIn.getAge() + partialTicks) / 20.0F + entityIn.hoverStart;
	      matrixStackIn.rotate(Vector3f.YP.rotation(f3));
	      if (!flag) {
	         float f7 = -0.0F * (float)(j - 1) * 0.5F;
	         float f8 = -0.0F * (float)(j - 1) * 0.5F;
	         float f9 = -0.09375F * (float)(j - 1) * 0.5F;
	         matrixStackIn.translate((double)f7, (double)f8, (double)f9);
	      }

	      for(int k = 0; k < j; ++k) {
	         matrixStackIn.push();
	         if (k > 0) {
	            if (flag) {
	               float f11 = (this.random.nextFloat() * 2.0F - 1.0F) * 0.15F;
	               float f13 = (this.random.nextFloat() * 2.0F - 1.0F) * 0.15F;
	               float f10 = (this.random.nextFloat() * 2.0F - 1.0F) * 0.15F;
	               matrixStackIn.translate(shouldSpreadItems() ? f11 : 0, shouldSpreadItems() ? f13 : 0, shouldSpreadItems() ? f10 : 0);
	            } else {
	               float f12 = (this.random.nextFloat() * 2.0F - 1.0F) * 0.15F * 0.5F;
	               float f14 = (this.random.nextFloat() * 2.0F - 1.0F) * 0.15F * 0.5F;
	               matrixStackIn.translate(shouldSpreadItems() ? f12 : 0, shouldSpreadItems() ? f14 : 0, 0.0D);
	            }
	         }

	         this.itemRenderer.renderItem(itemstack, ItemCameraTransforms.TransformType.GROUND, false, matrixStackIn, bufferIn, packedLightIn, OverlayTexture.NO_OVERLAY, ibakedmodel);
	         matrixStackIn.pop();
	         if (!flag) {
	            matrixStackIn.translate(0.0, 0.0, 0.09375F);
	         }
	      }

	      matrixStackIn.pop();
	      super.render(entityIn, entityYaw, partialTicks, matrixStackIn, bufferIn, packedLightIn);
	   }

	   /**
	    * Returns the location of an entity's texture.
	    */
	   public ResourceLocation getEntityTexture(FarmCraftItemEntity entity) {
	      return AtlasTexture.LOCATION_BLOCKS_TEXTURE;
	   }
	   
	   /*==================================== FORGE START ===========================================*/

	   /**
	    * @return If items should spread out when rendered in 3D
	    */
	   public boolean shouldSpreadItems() {
	      return true;
	   }

	   /**
	    * @return If items should have a bob effect
	    */
	   public boolean shouldBob() {
	      return true;
	   }
	   /*==================================== FORGE END =============================================*/
	}

Registry in FMLClientSetupEvent: 

RenderingRegistry.registerEntityRenderingHandler(EntityInit.ITEM_ENTITY.get(), FarmCraftItemEntityRenderer::new);

Entity init: 

	public static RegistryObject<EntityType<FarmCraftItemEntity>> ITEM_ENTITY = ENTITIES
			.register("item_farmcraft", () -> EntityType.Builder.<FarmCraftItemEntity>create(FarmCraftItemEntity::new, EntityClassification.MISC)
					.size(0.25F, 0.25F)
					.build(new ResourceLocation("minecraft:item").toString()));

 

grossik Stone Miner

grossik

Posted
  • Author
Posted (edited)
  On 5/3/2020 at 11:01 AM, diesieben07 said:

You cannot do this.

All your constructors must call a super constructor that accepts your entity type. Otherwise your entity will not be saved to disk correctly and also not sent to the client correctly.

 

All custom entities must also override createSpawnPacket and use NetworkHooks.getEntitySpawningPacket.

 

Also please use @Override when overriding methods and do not use @OnlyIn.

Expand  

Ok. Thank you. But it didn't solve my problem. Renderer is initialized but render method not called

Edited by grossik
grossik Stone Miner

grossik

Posted
  • Author
Posted
  On 5/3/2020 at 12:55 PM, diesieben07 said:

Post updated code.

Expand  

Render: 

package cz.grossik.farmcraft.renderer;

import com.mojang.blaze3d.matrix.MatrixStack;

import cz.grossik.farmcraft.entity.FarmCraftItemEntity;

import java.util.Random;

import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.IRenderTypeBuffer;
import net.minecraft.client.renderer.Vector3f;
import net.minecraft.client.renderer.entity.EntityRenderer;
import net.minecraft.client.renderer.entity.EntityRendererManager;
import net.minecraft.client.renderer.model.IBakedModel;
import net.minecraft.client.renderer.model.ItemCameraTransforms;
import net.minecraft.client.renderer.texture.AtlasTexture;
import net.minecraft.client.renderer.texture.OverlayTexture;
import net.minecraft.entity.LivingEntity;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.math.MathHelper;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;

@SuppressWarnings("deprecation")
public class FarmCraftItemEntityRenderer extends EntityRenderer<FarmCraftItemEntity> {
   private final net.minecraft.client.renderer.ItemRenderer itemRenderer;
   private final Random random = new Random();

   public FarmCraftItemEntityRenderer(EntityRendererManager renderManagerIn) {
      super(renderManagerIn);
      this.itemRenderer = Minecraft.getInstance().getItemRenderer();
      this.shadowSize = 0.15F;
      this.shadowOpaque = 0.75F;
   }

   protected int getModelCount(ItemStack stack) {
	      int i = 1;
	      if (stack.getCount() > 48) {
	         i = 5;
	      } else if (stack.getCount() > 32) {
	         i = 4;
	      } else if (stack.getCount() > 16) {
	         i = 3;
	      } else if (stack.getCount() > 1) {
	         i = 2;
	      }

	      return i;
	   }

	   public void render(FarmCraftItemEntity entityIn, float entityYaw, float partialTicks, MatrixStack matrixStackIn, IRenderTypeBuffer bufferIn, int packedLightIn) {
		   matrixStackIn.push();
	      ItemStack itemstack = entityIn.getItem();
	      int i = itemstack.isEmpty() ? 187 : Item.getIdFromItem(itemstack.getItem()) + itemstack.getDamage();
	      this.random.setSeed((long)i);
	      IBakedModel ibakedmodel = this.itemRenderer.getItemModelWithOverrides(itemstack, entityIn.world, (LivingEntity)null);
	      boolean flag = ibakedmodel.isGui3d();
	      int j = this.getModelCount(itemstack);
	      float f = 0.25F;
	      float f1 = shouldBob() ? MathHelper.sin(((float)entityIn.getAge() + partialTicks) / 10.0F + entityIn.hoverStart) * 0.1F + 0.1F : 0;
	      float f2 = ibakedmodel.getItemCameraTransforms().getTransform(ItemCameraTransforms.TransformType.GROUND).scale.getY();
	      matrixStackIn.translate(0.0D, (double)(f1 + 0.25F * f2), 0.0D);
	      float f3 = ((float)entityIn.getAge() + partialTicks) / 20.0F + entityIn.hoverStart;
	      matrixStackIn.rotate(Vector3f.YP.rotation(f3));
	      if (!flag) {
	         float f7 = -0.0F * (float)(j - 1) * 0.5F;
	         float f8 = -0.0F * (float)(j - 1) * 0.5F;
	         float f9 = -0.09375F * (float)(j - 1) * 0.5F;
	         matrixStackIn.translate((double)f7, (double)f8, (double)f9);
	      }

	      for(int k = 0; k < j; ++k) {
	         matrixStackIn.push();
	         if (k > 0) {
	            if (flag) {
	               float f11 = (this.random.nextFloat() * 2.0F - 1.0F) * 0.15F;
	               float f13 = (this.random.nextFloat() * 2.0F - 1.0F) * 0.15F;
	               float f10 = (this.random.nextFloat() * 2.0F - 1.0F) * 0.15F;
	               matrixStackIn.translate(shouldSpreadItems() ? f11 : 0, shouldSpreadItems() ? f13 : 0, shouldSpreadItems() ? f10 : 0);
	            } else {
	               float f12 = (this.random.nextFloat() * 2.0F - 1.0F) * 0.15F * 0.5F;
	               float f14 = (this.random.nextFloat() * 2.0F - 1.0F) * 0.15F * 0.5F;
	               matrixStackIn.translate(shouldSpreadItems() ? f12 : 0, shouldSpreadItems() ? f14 : 0, 0.0D);
	            }
	         }

	         this.itemRenderer.renderItem(itemstack, ItemCameraTransforms.TransformType.GROUND, false, matrixStackIn, bufferIn, packedLightIn, OverlayTexture.NO_OVERLAY, ibakedmodel);
	         matrixStackIn.pop();
	         if (!flag) {
	            matrixStackIn.translate(0.0, 0.0, 0.09375F);
	         }
	      }

	      matrixStackIn.pop();
	      super.render(entityIn, entityYaw, partialTicks, matrixStackIn, bufferIn, packedLightIn);
	   }

	   /**
	    * Returns the location of an entity's texture.
	    */
	   public ResourceLocation getEntityTexture(FarmCraftItemEntity entity) {
	      return AtlasTexture.LOCATION_BLOCKS_TEXTURE;
	   }
	   
	   /*==================================== FORGE START ===========================================*/

	   /**
	    * @return If items should spread out when rendered in 3D
	    */
	   public boolean shouldSpreadItems() {
	      return true;
	   }

	   /**
	    * @return If items should have a bob effect
	    */
	   public boolean shouldBob() {
	      return true;
	   }
	   /*==================================== FORGE END =============================================*/
	}

 

Entity: 

package cz.grossik.farmcraft.entity;

import java.util.Objects;
import java.util.UUID;

import javax.annotation.Nullable;

import cz.grossik.farmcraft.init.ItemInit;
import net.minecraft.block.material.Material;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityType;
import net.minecraft.entity.MoverType;
import net.minecraft.entity.item.ItemEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Items;
import net.minecraft.nbt.CompoundNBT;
import net.minecraft.nbt.NBTUtil;
import net.minecraft.network.IPacket;
import net.minecraft.network.datasync.DataParameter;
import net.minecraft.network.datasync.DataSerializers;
import net.minecraft.network.datasync.EntityDataManager;
import net.minecraft.network.play.server.SSpawnObjectPacket;
import net.minecraft.stats.Stats;
import net.minecraft.tags.FluidTags;
import net.minecraft.util.DamageSource;
import net.minecraft.util.SoundEvents;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.MathHelper;
import net.minecraft.util.math.Vec3d;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.TranslationTextComponent;
import net.minecraft.world.World;
import net.minecraft.world.dimension.DimensionType;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;

public class FarmCraftItemEntity extends ItemEntity {
	 private static final DataParameter<ItemStack> ITEM = EntityDataManager.createKey(FarmCraftItemEntity.class, DataSerializers.ITEMSTACK);
	   private int age;
	   private int pickupDelay;
	   private int health = 5;
	   private UUID thrower;
	   private UUID owner;

	   public int lifespan = 6000;
	   public final float hoverStart = (float)(Math.random() * Math.PI * 2.0D);

	   public FarmCraftItemEntity(EntityType<? extends ItemEntity> p_i50217_1_, World p_i50217_2_) {
	      super(p_i50217_1_, p_i50217_2_);
	   }
	   
	   @Override
	   protected boolean canTriggerWalking() {
	      return false;
	   }

	   @Override
	   protected void registerData() {
	      this.getDataManager().register(ITEM, ItemStack.EMPTY);
	   }

	   @Override
	   public void tick() {
	      if (getItem().onEntityItemUpdate(this)) return;
	      if (this.getItem().isEmpty()) {
	         this.remove();
	      } else {
	         super.tick();
	         if (this.pickupDelay > 0 && this.pickupDelay != 32767) {
	            --this.pickupDelay;
	         }

	         this.prevPosX = this.getPosX();
	         this.prevPosY = this.getPosY();
	         this.prevPosZ = this.getPosZ();
	         Vec3d vec3d = this.getMotion();
	         if (this.areEyesInFluid(FluidTags.WATER)) {
	            this.applyFloatMotion();
	         } else if (!this.hasNoGravity()) {
	            this.setMotion(this.getMotion().add(0.0D, -0.04D, 0.0D));
	         }

	         if (this.world.isRemote) {
	            this.noClip = false;
	         } else {
	            this.noClip = !this.world.func_226669_j_(this);
	            if (this.noClip) {
	               this.pushOutOfBlocks(this.getPosX(), (this.getBoundingBox().minY + this.getBoundingBox().maxY) / 2.0D, this.getPosZ());
	            }
	         }

	         if (!this.onGround || horizontalMag(this.getMotion()) > (double)1.0E-5F || (this.ticksExisted + this.getEntityId()) % 4 == 0) {
	            this.move(MoverType.SELF, this.getMotion());
	            float f = 0.98F;
	            if (this.onGround) {
	               BlockPos pos = new BlockPos(this.getPosX(), this.getPosY() - 1.0D, this.getPosZ());
	               f = this.world.getBlockState(pos).getSlipperiness(this.world, pos, this) * 0.98F;
	            }

	            this.setMotion(this.getMotion().mul((double)f, 0.98D, (double)f));
	            if (this.onGround) {
	               this.setMotion(this.getMotion().mul(1.0D, -0.5D, 1.0D));
	            }
	         }

	         boolean flag = MathHelper.floor(this.prevPosX) != MathHelper.floor(this.getPosX()) || MathHelper.floor(this.prevPosY) != MathHelper.floor(this.getPosY()) || MathHelper.floor(this.prevPosZ) != MathHelper.floor(this.getPosZ());
	         int i = flag ? 2 : 40;
	         if (this.ticksExisted % i == 0) {
	            if (this.world.getFluidState(new BlockPos(this)).isTagged(FluidTags.LAVA)) {
	               this.setMotion((double)((this.rand.nextFloat() - this.rand.nextFloat()) * 0.2F), (double)0.2F, (double)((this.rand.nextFloat() - this.rand.nextFloat()) * 0.2F));
	               this.playSound(SoundEvents.ENTITY_GENERIC_BURN, 0.4F, 2.0F + this.rand.nextFloat() * 0.4F);
	            }

	            if (!this.world.isRemote && this.func_213857_z()) {
	               this.searchForOtherItemsNearby();
	            }
	         }

	         if (this.age != -32768) {
	            ++this.age;
	         }

	         this.isAirBorne |= this.handleWaterMovement();
	         if (!this.world.isRemote) {
	            double d0 = this.getMotion().subtract(vec3d).lengthSquared();
	            if (d0 > 0.01D) {
	               this.isAirBorne = true;
	            }
	         }

	         ItemStack item = this.getItem();
	         if (!this.world.isRemote && this.age >= lifespan) {
	             int hook = net.minecraftforge.event.ForgeEventFactory.onItemExpire(this, item);
	             if (hook < 0) this.remove();
	             else          this.lifespan += hook;
	         }

	         if (item.isEmpty()) {
	            this.remove();
	         }

	      }
	   }

	   private void applyFloatMotion() {
	      Vec3d vec3d = this.getMotion();
	      this.setMotion(vec3d.x * (double)0.99F, vec3d.y + (double)(vec3d.y < (double)0.06F ? 5.0E-4F : 0.0F), vec3d.z * (double)0.99F);
	   }

	   private void searchForOtherItemsNearby() {
	      if (this.func_213857_z()) {
	         for(FarmCraftItemEntity itementity : this.world.getEntitiesWithinAABB(FarmCraftItemEntity.class, this.getBoundingBox().grow(0.5D, 0.0D, 0.5D), (p_213859_1_) -> {
	            return p_213859_1_ != this && p_213859_1_.func_213857_z();
	         })) {
	            if (itementity.func_213857_z()) {
	               this.func_226530_a_(itementity);
	               if (this.removed) {
	                  break;
	               }
	            }
	         }

	      }
	   }

	   private boolean func_213857_z() {
	      ItemStack itemstack = this.getItem();
	      return this.isAlive() && this.pickupDelay != 32767 && this.age != -32768 && this.age < 6000 && itemstack.getCount() < itemstack.getMaxStackSize();
	   }

	   private void func_226530_a_(FarmCraftItemEntity p_226530_1_) {
	      ItemStack itemstack = this.getItem();
	      ItemStack itemstack1 = p_226530_1_.getItem();
	      if (Objects.equals(this.getOwnerId(), p_226530_1_.getOwnerId()) && func_226532_a_(itemstack, itemstack1)) {
	         if (itemstack1.getCount() < itemstack.getCount()) {
	            func_213858_a(this, itemstack, p_226530_1_, itemstack1);
	         } else {
	            func_213858_a(p_226530_1_, itemstack1, this, itemstack);
	         }

	      }
	   }

	   public static boolean func_226532_a_(ItemStack p_226532_0_, ItemStack p_226532_1_) {
	      if (p_226532_1_.getItem() != p_226532_0_.getItem()) {
	         return false;
	      } else if (p_226532_1_.getCount() + p_226532_0_.getCount() > p_226532_1_.getMaxStackSize()) {
	         return false;
	      } else if (p_226532_1_.hasTag() ^ p_226532_0_.hasTag()) {
	         return false;
	      }else if (!p_226532_0_.areCapsCompatible(p_226532_1_)) {
	         return false;
	      } else {
	         return !p_226532_1_.hasTag() || p_226532_1_.getTag().equals(p_226532_0_.getTag());
	      }
	   }

	   public static ItemStack func_226533_a_(ItemStack p_226533_0_, ItemStack p_226533_1_, int p_226533_2_) {
	      int i = Math.min(Math.min(p_226533_0_.getMaxStackSize(), p_226533_2_) - p_226533_0_.getCount(), p_226533_1_.getCount());
	      ItemStack itemstack = p_226533_0_.copy();
	      itemstack.grow(i);
	      p_226533_1_.shrink(i);
	      return itemstack;
	   }

	   private static void func_226531_a_(FarmCraftItemEntity p_226531_0_, ItemStack p_226531_1_, ItemStack p_226531_2_) {
	      ItemStack itemstack = func_226533_a_(p_226531_1_, p_226531_2_, 64);
	      p_226531_0_.setItem(itemstack);
	   }

	   private static void func_213858_a(FarmCraftItemEntity p_213858_0_, ItemStack p_213858_1_, FarmCraftItemEntity p_213858_2_, ItemStack p_213858_3_) {
	      func_226531_a_(p_213858_0_, p_213858_1_, p_213858_3_);
	      p_213858_0_.pickupDelay = Math.max(p_213858_0_.pickupDelay, p_213858_2_.pickupDelay);
	      p_213858_0_.age = Math.min(p_213858_0_.age, p_213858_2_.age);
	      if (p_213858_3_.isEmpty()) {
	         p_213858_2_.remove();
	      }

	   }

	   @Override
	   protected void dealFireDamage(int amount) {
	      this.attackEntityFrom(DamageSource.IN_FIRE, (float)amount);
	   }

	   @Override
	   public boolean attackEntityFrom(DamageSource source, float amount) {
	      if (this.world.isRemote || this.removed) return false; //Forge: Fixes MC-53850
	      if (this.isInvulnerableTo(source)) {
	         return false;
	      } else if (!this.getItem().isEmpty() && this.getItem().getItem() == Items.NETHER_STAR && source.isExplosion()) {
	         return false;
	      } else {
	         this.markVelocityChanged();
	         this.health = (int)((float)this.health - amount);
	         if (this.health <= 0) {
	            this.remove();
	         }

	         return false;
	      }
	   }

	   @Override
	   public void writeAdditional(CompoundNBT compound) {
	      compound.putShort("Health", (short)this.health);
	      compound.putShort("Age", (short)this.age);
	      compound.putShort("PickupDelay", (short)this.pickupDelay);
	      compound.putInt("Lifespan", lifespan);
	      if (this.getThrowerId() != null) {
	         compound.put("Thrower", NBTUtil.writeUniqueId(this.getThrowerId()));
	      }

	      if (this.getOwnerId() != null) {
	         compound.put("Owner", NBTUtil.writeUniqueId(this.getOwnerId()));
	      }

	      if (!this.getItem().isEmpty()) {
	         compound.put("Item", this.getItem().write(new CompoundNBT()));
	      }

	   }

	   @Override
	   public void readAdditional(CompoundNBT compound) {
	      this.health = compound.getShort("Health");
	      this.age = compound.getShort("Age");
	      if (compound.contains("PickupDelay")) {
	         this.pickupDelay = compound.getShort("PickupDelay");
	      }
	      if (compound.contains("Lifespan")) lifespan = compound.getInt("Lifespan");

	      if (compound.contains("Owner", 10)) {
	         this.owner = NBTUtil.readUniqueId(compound.getCompound("Owner"));
	      }

	      if (compound.contains("Thrower", 10)) {
	         this.thrower = NBTUtil.readUniqueId(compound.getCompound("Thrower"));
	      }

	      CompoundNBT compoundnbt = compound.getCompound("Item");
	      this.setItem(ItemStack.read(compoundnbt));
	      if (this.getItem().isEmpty()) {
	         this.remove();
	      }

	   }

	   @Override
	   public void onCollideWithPlayer(PlayerEntity entityIn) {
	      if (!this.world.isRemote) {
	         if (this.pickupDelay > 0) return;
	         ItemStack itemstack = this.getItem();
	         Item item = itemstack.getItem();
	         int i = itemstack.getCount();

	         int hook = net.minecraftforge.event.ForgeEventFactory.onItemPickup(this, entityIn);
	         if (hook < 0) return;

	         ItemStack copy = itemstack.copy();
	         if (this.pickupDelay == 0 && (this.owner == null || lifespan - this.age <= 200 || this.owner.equals(entityIn.getUniqueID())) && (hook == 1 || i <= 0 || entityIn.inventory.addItemStackToInventory(itemstack))) {
	            copy.setCount(copy.getCount() - getItem().getCount());
	            net.minecraftforge.fml.hooks.BasicEventHooks.firePlayerItemPickupEvent(entityIn, this, copy);
	            entityIn.onItemPickup(this, i);
	            if (itemstack.isEmpty()) {
	               entityIn.onItemPickup(this, i);
	               this.remove();
	               itemstack.setCount(i);
	            }

	            entityIn.addStat(Stats.ITEM_PICKED_UP.get(item), i);
	         }

	      }
	   }

	   @Override
	   public ITextComponent getName() {
	      ITextComponent itextcomponent = this.getCustomName();
	      return (ITextComponent)(itextcomponent != null ? itextcomponent : new TranslationTextComponent(this.getItem().getTranslationKey()));
	   }

	   @Override
	   public boolean canBeAttackedWithItem() {
	      return false;
	   }

	   @Nullable
	   @Override
	   public Entity changeDimension(DimensionType destination, net.minecraftforge.common.util.ITeleporter teleporter) {
	      Entity entity = super.changeDimension(destination, teleporter);
	      if (!this.world.isRemote && entity instanceof FarmCraftItemEntity) {
	         ((FarmCraftItemEntity)entity).searchForOtherItemsNearby();
	      }

	      return entity;
	   }

	   @Override
	   public ItemStack getItem() {
	      return this.getDataManager().get(ITEM);
	   }

	   @Override
	   public void setItem(ItemStack stack) {
	      this.getDataManager().set(ITEM, stack);
	   }

	   @Nullable
	   @Override
	   public UUID getOwnerId() {
	      return this.owner;
	   }

	   @Override
	   public void setOwnerId(@Nullable UUID p_200217_1_) {
	      this.owner = p_200217_1_;
	   }

	   @Nullable
	   @Override
	   public UUID getThrowerId() {
	      return this.thrower;
	   }

	   @Override
	   public void setThrowerId(@Nullable UUID p_200216_1_) {
	      this.thrower = p_200216_1_;
	   }

	   @Override
	   public int getAge() {
	      return this.age;
	   }

	   @Override
	   public void setDefaultPickupDelay() {
	      this.pickupDelay = 10;
	   }

	   @Override
	   public void setNoPickupDelay() {
	      this.pickupDelay = 0;
	   }

	   @Override
	   public void setInfinitePickupDelay() {
	      this.pickupDelay = 32767;
	   }

	   @Override
	   public void setPickupDelay(int ticks) {
	      this.pickupDelay = ticks;
	   }

	   @Override
	   public boolean cannotPickup() {
	      return this.pickupDelay > 0;
	   }

	   @Override
	   public void setNoDespawn() {
	      this.age = -6000;
	   }
	   
	   @Override
	   public void makeFakeItem() {
	      this.setInfinitePickupDelay();
	      this.age = getItem().getEntityLifespan(world) - 1;
	   }

	   @Override
	   public IPacket<?> createSpawnPacket() {
	      return new SSpawnObjectPacket(this);
	   }
	}

 

I copy all code of ItemEntity

grossik Stone Miner

grossik

Posted
  • Author
Posted
  On 5/3/2020 at 12:58 PM, diesieben07 said:

Why did you do that?! That makes no sense. Either copy-paste the code, and don't extend the class (ugly) or extend the class. Doing both makes zero sense.

Expand  

Because I test this -_- Ok this: 

package cz.grossik.farmcraft.entity;

import cz.grossik.farmcraft.init.ItemInit;
import net.minecraft.block.material.Material;
import net.minecraft.entity.EntityType;
import net.minecraft.entity.item.ItemEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.network.IPacket;
import net.minecraft.network.datasync.DataParameter;
import net.minecraft.network.datasync.DataSerializers;
import net.minecraft.network.datasync.EntityDataManager;
import net.minecraft.network.play.server.SSpawnObjectPacket;
import net.minecraft.world.World;

public class FarmCraftItemEntity extends ItemEntity {
		
	private static final DataParameter<ItemStack> ITEM = EntityDataManager.createKey(FarmCraftItemEntity.class, DataSerializers.ITEMSTACK);

	public FarmCraftItemEntity(EntityType<? extends ItemEntity> p_i50217_1_, World p_i50217_2_) {
		super(p_i50217_1_, p_i50217_2_);
	}
	
	@Override
	protected void registerData() {
		this.getDataManager().register(ITEM, ItemStack.EMPTY);
	}
	   
	@Override
	public IPacket<?> createSpawnPacket() {
		return new SSpawnObjectPacket(this);
	}
	   
	@Override
	public void tick() {
		System.err.println("tick");
		if(this.isInWater()) {
			System.err.println("water");
			ItemStack newItemStack = new ItemStack(ItemInit.soaked_barley.get());
			ItemEntity newItem = new ItemEntity(this.world, this.getPosition().getX(), this.getPosition().getY(), this.getPosition().getZ(), newItemStack);
			this.world.addEntity(newItem);
			this.remove();
		}
		super.tick();
	}
}

 

grossik Stone Miner

grossik

Posted
  • Author
Posted 
package cz.grossik.farmcraft.entity;

import cz.grossik.farmcraft.init.ItemInit;
import net.minecraft.entity.EntityType;
import net.minecraft.entity.item.ItemEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.network.IPacket;
import net.minecraft.world.World;
import net.minecraftforge.fml.network.NetworkHooks;

public class FarmCraftItemEntity extends ItemEntity {
		
	public FarmCraftItemEntity(EntityType<? extends ItemEntity> p_i50217_1_, World p_i50217_2_) {
		super(p_i50217_1_, p_i50217_2_);
	}
	   
	@Override
	public IPacket<?> createSpawnPacket() {
		return NetworkHooks.getEntitySpawningPacket(this);
	}
	   
	@Override
	public void tick() {
		System.err.println("tick");
		if(this.isInWater()) {
			System.err.println("water");
			ItemStack newItemStack = new ItemStack(ItemInit.soaked_barley.get());
			ItemEntity newItem = new ItemEntity(this.world, this.getPosition().getX(), this.getPosition().getY(), this.getPosition().getZ(), newItemStack);
			this.world.addEntity(newItem);
			this.remove();
		}
		super.tick();
	}
}

 

grossik Stone Miner

grossik

Posted
  • Author
Posted
  On 5/3/2020 at 1:21 PM, diesieben07 said:

Post where you spawn the entity.

Expand  

This item: 

package cz.grossik.farmcraft.item;

import cz.grossik.farmcraft.entity.FarmCraftItemEntity;
import cz.grossik.farmcraft.init.EntityInit;
import net.minecraft.entity.Entity;
import net.minecraft.entity.item.ItemEntity;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class ItemBarley extends Item {

	public ItemBarley(Properties properties) {
		super(properties);
	}

	@Override
	public boolean hasCustomEntity(ItemStack itemstack) {
		return true;
	}
	
	@Override
	public Entity createEntity(World world, Entity location, ItemStack itemstack) {
		return new FarmCraftItemEntity(EntityInit.ITEM_ENTITY.get(), world);
	}
}

 

grossik Stone Miner

grossik

Posted
  • Author
Posted
  On 5/3/2020 at 1:24 PM, diesieben07 said:

This is your issue. You need to use your own registry name.

Expand  

Yes I know. I forgot send new registration. Sorry 

	public static RegistryObject<EntityType<FarmCraftItemEntity>> ITEM_ENTITY = ENTITIES
			.register("item_farmcraft", () -> EntityType.Builder.<FarmCraftItemEntity>create(FarmCraftItemEntity::new, EntityClassification.MISC)
					.size(0.25F, 0.25F)
					.build(new ResourceLocation(Main.MOD_ID, "item_farmcraft").toString()));

 

grossik Stone Miner

grossik

Posted
  • Author
Posted
  On 5/3/2020 at 1:28 PM, diesieben07 said:

At this point I can't see the issue from just staring at the code.

Please post a Git repository showing the issue so I can test this locally.

Expand  

https://github.com/grossik/FarmCraft/blob/master/src/main/java/cz/grossik/farmcraft/entity/FarmCraftItemEntity.java

Item for this entity

https://github.com/grossik/FarmCraft/blob/master/src/main/java/cz/grossik/farmcraft/item/ItemBarley.java

grossik Stone Miner

grossik

Posted
  • Author
Posted
  On 5/3/2020 at 1:52 PM, diesieben07 said:

You are creating your custom entity without setting its location. The location defaults to 0, 0, 0, which is in the void and the item immediately dies.

Expand  

I update constructor with position. And I update github ass well. But render still not work

grossik Stone Miner

grossik

Posted
  • Author
Posted

Thank you. I have new problem... The position where item entity spawn is bad I need player position and if I drop item I'll take it back to inventory. (therefore onCollideWithPlayer is empty), and item entity not move like default item entity

grossik Stone Miner

grossik

Posted
  • Author
Posted
  On 5/3/2020 at 4:57 PM, diesieben07 said:

First you are copying the position wrong (do not use getPosition, it returns a BlockPos). Use getPosX, getPosY and getPosZ.

Then you also need to copy the other properties of the entity. Most importantly motion (Entity#getMotion) and for ItemEntity properties like pickupDelay, age, etc.

Expand   
float f8 = MathHelper.sin(location.rotationPitch * ((float)Math.PI / 180F));
float f2 = MathHelper.cos(location.rotationPitch * ((float)Math.PI / 180F));
float f3 = MathHelper.sin(location.rotationYaw * ((float)Math.PI / 180F));
float f4 = MathHelper.cos(location.rotationYaw * ((float)Math.PI / 180F));
float f5 = ((float)Math.PI * 2F);
float f6 = 0.02F;
itementity.setMotion((double)(-f3 * f2 * 0.3F) + Math.cos((double)f5) * (double)f6, (double)(-f8 * 0.3F + 0.1F * 0.1F), (double)(f4 * f2 * 0.3F) + Math.sin((double)f5) * (double)f6);

This code drop item around player no in front of the player. Its from PlayerEntity drop

  • grossik changed the title to [SOLVED] [1.15.2] Why my custom item entity not renderer?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Grinhecker
      [1.20.1] Severe server freeze when exiting Nether portal or entering End (no mods, Forge 1.20.1, Arch Linux)

      By Grinhecker · Posted

      UPDATE: this seems to be an Arch-specific issue. Switching to Ubuntu server fixed EVERYTHING.
    • Haijimaaa65
      What is Attapoll Referral Code [{AOVCQ]} Get $20

      By Haijimaaa65 · Posted

      Yes, Attapoll offers a $20 Sign-up bonus for new users using a code (AOVCQ). Enter the Attapoll Referral Code “AOVCQ” and submit. Yes, Attapoll offers $20 Referral Code {AOVCQ} For New Customers. If you are who wish to join Attapoll, then you should use this exclusive Attapoll referral code $20 Signup Bonus Use this Code (AOVCQ) and get $20 Welcome Bonus. You can get a $20 Signup bonus use this referral code {AOVCQ}. You can get a $20 Attpoll Referral Code {AOVCQ}. This Attapoll $20 Referral code is specifically for existing customers and can be redeemed to receive a $20. Enter $20 Attapoll Referral Code {AOVCQ} at checkout. Enjoy $20Welcome Bonus. Use the best Attapoll referral code $20 (AOVCQ) to get up to $20 first time survey as a new user. Complete the survey and get $20 credited on your Attapoll account. Plus, refer your friend to earn 10% commission on their earning If you're on the hunt for a little extra cash or some cool rewards without too much hassle, you've landed in the right place. Today, we're diving into the world of Attapoll referral codes, a nifty way to boost your earnings while taking surveys. Use this Attapoll Referral Link or code {{AOVCQ}} to get a $20 sign up bonus.
    • Haijimaaa65
      Attpoll Referral Code [{AOVCQ]} Get $20 signup bonus

      By Haijimaaa65 · Posted

      Yes, Attapoll offers a $20 Sign-up bonus for new users using a code (AOVCQ). Enter the Attapoll Referral Code “AOVCQ” and submit. Yes, Attapoll offers $20 Referral Code {AOVCQ} For New Customers. If you are who wish to join Attapoll, then you should use this exclusive Attapoll referral code $20 Signup Bonus Use this Code (AOVCQ) and get $20 Welcome Bonus. You can get a $20 Signup bonus use this referral code {AOVCQ}. You can get a $20 Attpoll Referral Code {AOVCQ}. This Attapoll $20 Referral code is specifically for existing customers and can be redeemed to receive a $20. Enter $20 Attapoll Referral Code {AOVCQ} at checkout. Enjoy $20Welcome Bonus. Use the best Attapoll referral code $20 (AOVCQ) to get up to $20 first time survey as a new user. Complete the survey and get $20 credited on your Attapoll account. Plus, refer your friend to earn 10% commission on their earning If you're on the hunt for a little extra cash or some cool rewards without too much hassle, you've landed in the right place. Today, we're diving into the world of Attapoll referral codes, a nifty way to boost your earnings while taking surveys. Use this Attapoll Referral Link or code {{AOVCQ}} to get a $20 sign up bonus.
    • Haijimaaa65
      Attpoll Referral Code [{AOVCQ]} Get $20 Signup Bonus + $20 Referral Bonus

      By Haijimaaa65 · Posted

      Yes, Attapoll offers a $20 Sign-up bonus for new users using a code (AOVCQ). Enter the Attapoll Referral Code “AOVCQ” and submit. Yes, Attapoll offers $20 Referral Code {AOVCQ} For New Customers. If you are who wish to join Attapoll, then you should use this exclusive Attapoll referral code $20 Signup Bonus Use this Code (AOVCQ) and get $20 Welcome Bonus. You can get a $20 Signup bonus use this referral code {AOVCQ}. You can get a $20 Attpoll Referral Code {AOVCQ}. This Attapoll $20 Referral code is specifically for existing customers and can be redeemed to receive a $20. Enter $20 Attapoll Referral Code {AOVCQ} at checkout. Enjoy $20Welcome Bonus. Use the best Attapoll referral code $20 (AOVCQ) to get up to $20 first time survey as a new user. Complete the survey and get $20 credited on your Attapoll account. Plus, refer your friend to earn 10% commission on their earning If you're on the hunt for a little extra cash or some cool rewards without too much hassle, you've landed in the right place. Today, we're diving into the world of Attapoll referral codes, a nifty way to boost your earnings while taking surveys. Use this Attapoll Referral Link or code {{AOVCQ}} to get a $20 sign up bonus.
    • Haijimaaa65
      [{UniQue?]} Attapoll Referral Code [{AOVCQ]} Get $20 Signup Bonus

      By Haijimaaa65 · Posted

      Yes, Attapoll offers a $20 Sign-up bonus for new users using a code (AOVCQ). Enter the Attapoll Referral Code “AOVCQ” and submit. Yes, Attapoll offers $20 Referral Code {AOVCQ} For New Customers. If you are who wish to join Attapoll, then you should use this exclusive Attapoll referral code $20 Signup Bonus Use this Code (AOVCQ) and get $20 Welcome Bonus. You can get a $20 Signup bonus use this referral code {AOVCQ}. You can get a $20 Attpoll Referral Code {AOVCQ}. This Attapoll $20 Referral code is specifically for existing customers and can be redeemed to receive a $20. Enter $20 Attapoll Referral Code {AOVCQ} at checkout. Enjoy $20Welcome Bonus. Use the best Attapoll referral code $20 (AOVCQ) to get up to $20 first time survey as a new user. Complete the survey and get $20 credited on your Attapoll account. Plus, refer your friend to earn 10% commission on their earning If you're on the hunt for a little extra cash or some cool rewards without too much hassle, you've landed in the right place. Today, we're diving into the world of Attapoll referral codes, a nifty way to boost your earnings while taking surveys. Use this Attapoll Referral Link or code {{AOVCQ}} to get a $20 sign up bonus.

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept