Jump to content

Power network structure [1.12.2]


Gaffa

Recommended Posts

Hello all forge modders,

 

How would one create an efficient power network system with cables? I have had multiple thoughts, but don't know the usual/best implementation. The goal is a simple power system similar to IC2, but without different voltages and power falloff over distance. Any cables connected shares power 1:1, meaning a generator (adding power to a neighboring cable) could power an electric furnace (consuming power from neighboring cable), however many blocks away. 

 

My suggestions:

  • Cables being TileEntities distributing power to its neighbors directly. Every cable has a IEnergyStorage. Would require power splitting on multiple neighbors. This would probably be very inefficient (based on other posts in this forum).

 

  • Creating a WorldSavedData class, containing a List<List<BlockPos>> (note; this structure might be inefficient as well. Suggestions here are also welcome :) ). Every time a cable block is placed, add it to the WorldSavedData. The First list represents one isolated network, the second all blocks in that network. By adding blocks to the network (and merging/splitting networks when needed), only one IEnergyStorage would be needed for one isolated network. This system would barely use tileEntities. Every cable TileEntity would have to store the corresponding network id (or a search in the List<List<BlockPos>> every time a power generator/consumer is placed). Therefore, this system may be redundant compared to next suggestion.

 

  • Similar to the last one, but instead every Cable TileEntity keeping track of its own networkId. Merging of two networks would become more complex (TileEntities would need to update their neighbors, resulting in a chain reaction). This makes saves smaller. The previous system has an advantage, I believe copying all BlockPos from one net to another is performance-cheaper than executing this chain reaction. Not tested.

 

 

 

To those curious, this is my implementation of WorldSavedData (nbt saving not yet done):

package olle.techal.world;

import java.util.ArrayList;
import java.util.List;

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapStorage;
import net.minecraft.world.storage.WorldSavedData;
import olle.techal.Reference;
import olle.techal.Techal;

public class CableNetworkData extends WorldSavedData {

	private static final String dataIdentifier = Reference.MODID + "_cableNetwork";
	
	private List<List<BlockPos>> cableNetworks = new ArrayList<List<BlockPos>>();
	private int testData = 0;
	
	public CableNetworkData() {
		super(dataIdentifier);
	}
	public CableNetworkData(String name) {
		super(name);
	}

	@Override
	public void readFromNBT(NBTTagCompound compound) {
		testData = compound.getInteger("testData");
	}

	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound compound) {
		compound.setInteger("testData", testData);
		return compound;
	}

	
	public static CableNetworkData get(World world) {
		MapStorage storage = world.getPerWorldStorage();
		CableNetworkData instance = (CableNetworkData) storage.getOrLoadData(
				CableNetworkData.class, dataIdentifier);
		
		// If data doesn't exist, create it
		if (instance == null) {
			instance = new CableNetworkData();
			storage.setData(dataIdentifier, instance);
		}
		
		return instance;
	}
	
	public int addCable(BlockPos pos) {
		// Loop through all cableNetworks
		// If one entry in the cableNetwork is neighbor
		//		Add to that cableNetwork
		// If none, create new cableNetwork and add to that
		
		List<Integer> foundNetIds = new ArrayList<Integer>();
		
		for(int i = 0; i < cableNetworks.size(); i++) {
			for(BlockPos block : cableNetworks.get(i)) {
				if(isNeighbor(pos, block)) {
					foundNetIds.add(i);
					
					// Stop searching this network
					// One block means connected
					break;
				}
			}
		}
		
		// If foundNetIds contains more than one netId, 
		if(foundNetIds.size() > 1) {
			Techal.info("Found multiple (" + Integer.toString(foundNetIds.size()) + ") neighboring networks. merging down!");
			Techal.info(foundNetIds);
			
			
			// Merge all networks[foundNetIds]
			// Merge top down, deleting causes indexOutOfRange
			int rootId = foundNetIds.get(0);
			for(int i = foundNetIds.size() -1; i > 0; i--) {
				int branchId = foundNetIds.get(i);
				Techal.info("Merging net " + Integer.toString(branchId) + 
						" to root (net " + Integer.toString(rootId) + ")");
				
				Techal.info("to merge (net " + Integer.toString(branchId) + "): " + cableNetworks.get(branchId).toString());
				
				Techal.info("before (net " + Integer.toString(rootId) + "): " + cableNetworks.get(rootId).toString());
				
				cableNetworks.get(rootId).addAll(
						cableNetworks.get(branchId)
				);
				
				Techal.info("after (net " + Integer.toString(rootId) + "): " + cableNetworks.get(rootId).toString());
				
				// add remove old branch
				cableNetworks.remove(branchId);
			}
			cableNetworks.get(rootId).add(pos);
			return rootId;
					
		} else if(foundNetIds.size() == 1){
			Techal.info("Found a neighboring network.");
			// Get id
			int networkId = foundNetIds.get(0);
			
			// Add BlockPos to network networkId
			cableNetworks.get(networkId).add(pos);
			return networkId;
		}
		
		// If no neighboring network found
		Techal.info("Found no neighboring network. Creating new!");
		List<BlockPos> newNetwork = new ArrayList<BlockPos>();
		newNetwork.add(pos);
		cableNetworks.add(newNetwork);

		return cableNetworks.size()-1;
	}
	
	public void removeCable(BlockPos pos) {
		
	}
	
	public List<List<BlockPos>> getNetworks() {
		return cableNetworks;
	}
	
	
	
	// Returns true if a and b are neighbors (directly connected)
	private boolean isNeighbor(BlockPos a, BlockPos b) {
		// Test X
		if( a.getX() == b.getX()-1 && a.getY() == b.getY() && a.getZ() == b.getZ() ) return true;
		if( a.getX() == b.getX()+1 && a.getY() == b.getY() && a.getZ() == b.getZ() ) return true;
		
		// Test Y
		if( a.getX() == b.getX() && a.getY() == b.getY()-1 && a.getZ() == b.getZ() ) return true;
		if( a.getX() == b.getX() && a.getY() == b.getY()+1 && a.getZ() == b.getZ() ) return true;
		
		// Test Z
		if( a.getX() == b.getX() && a.getY() == b.getY() && a.getZ() == b.getZ()-1 ) return true;
		if( a.getX() == b.getX() && a.getY() == b.getY() && a.getZ() == b.getZ()+1 ) return true;
		
		return false;
	}
}

 

 

 

 

Do you have any other suggestions? Which of the above would be best scalable for performance (and world save size, but not as big of a priority). 

 

Any help would be appreciated!

 

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Honestly i gave up on hiring a online hacker due to the bad experienced i always encounter with them but this time i was really in urgent need for a legit one cos i needed to be sure what my partners plan is as he is avoiding me and always hiding hen making calls couple with his late night movement. i was so scared so i got a helping hand from a friend Hyung who introduced me with this expert hacker, i was scared and lost trust in him at first but after giving him a try in couple of hours i got access to my partner phone and saw his call recordings, hidden text messages, social accounts , hidden photos and more. Thank you [ Hacker11tech @ gm ail . c om ] for been legit.
    • Hello I'm looking for help launching minecraft through curseforge. I've scoured the Internet and can't seem to find anyone with a solution to my specific situation/fix that I haven't tried. I'll post the Curseforge debug Logs below. But basically I'm on a Laptop (Lenovo Legion Slim 7 2021) And the people I've seen with the most similar scenario and found a fix they always had an AMD graphics card and were missing the correct drivers, Well i have the Nvidia geforce RTX 3060 Laptop version with all the most updated drivers, I've reinstalled the drivers so that doesn't seem to me the problem. Also, minecraft will launch in vanilla and through another modloader called modrinth. So it doesn't feel like a Java error either but I don't no how to read this debug page so I'm looking for advice. Please help?!  
    • Hello. Basically I made a custom standalone util library (https://github.com/lolhol/Pathfinder3D) and want to use it with my mod. Although I have done the normal jit pack stuff (basically the tutorial on their website) the Minecraft crashes the second it starts saying that it cannot find the name of a class inside of my library. (When I remove the implement(<my library link thingy>) mc launches normally and does not crash (if I comment out the code that uses the custom lib)). Now then, is there a quick fix for this because all of the other questions that I found on this topic were trying to load another mod (again, not what I’m trying to do). Am I doing something wrong? 
    • Fast Leaf Decay (by olafskiii) Rubidium (by Asek3) Artifacts (by ochotonida) Framework (by MrCrayfish) Max Health Fix (by DarkhaxDev) Embeddium/Rubidium Extras (by Txni) Essential Mod (by SparkUniverse_) Immersive Aircraft [Fabric/Forge] (by Conczin) Cherished Worlds (Fabric/Forge/NeoForge/Quilt) (by TheIllusiveC4) ExpandAbility (by florensie) Sophisticated Core (by P3pp3rF1y) Tinkers' Levelling Addon (by Pyre540) Better Advancements (by way2muchnoise) Immersive Melodies [Fabric/Forge] (by Conczin) Citadel (by sbom_xela) Vampirism - Become a vampire! (by maxanier) FerriteCore ((Neo)Forge) (by malte0811) CoroUtil (by Corosus) Create Big Cannons (by rbasamoyai) Controlling (by Jaredlll08) Cloth Config API (Fabric/Forge/NeoForge) (by shedaniel) Mekanism (by bradyaidanc) BetterF3 (by cominixo) Supplementaries (by MehVahdJukaar) Chest Cavity - Forge Port (by booneldanforever) ConnectedTexturesMod (by tterrag1098) NetherPortalFix (by BlayTheNinth) Spartan Weaponry (by ObliviousSpartan) Charm of Undying (Fabric/Forge/Quilt) (by TheIllusiveC4) Plushie Mod (by Link4real) JourneyMap (by techbrew) Farmer's Delight (by vectorwing) Connectivity[Forge/Fabric] (by someaddon) Create : Misc & Things (by To0pa) Create: Steam 'n' Rails (by IThundxr) Shutup Experimental Settings! (by Corgi_Taco) Alex's Mobs (by sbom_xela) Quark (by Vazkii) Tool Belt (by gigaherz) Just Enough Items (JEI) (by mezz) Bookshelf (by DarkhaxDev) FastWorkbench (by Shadows_of_Fire) Tinkers Construct (by mDiyo) Collective (by Serilum) Inventory HUD+ (by dmitrylovin) Explorer's Compass (by Chaosyr) playerAnimator (by KosmX) Size Devices (by DaFlame_rl) Jade 🔍 (by Snownee) Create Slice & Dice (by possible_triangle) Create Jetpack (by possible_triangle) Carry On (by Tschipp) Moonlight Lib (by MehVahdJukaar) Kotlin for Forge (by thedarkcolour) CraftTweaker (by Jaredlll08) Just Enough Resources (JER) (by way2muchnoise) AI Improvements (by QueenOfMissiles) Patchouli (by Vazkii) Catalogue (by MrCrayfish) Tool Stats (by DarkhaxDev) It Takes a Pillage (by izofar) JEITweaker (by Jaredlll08) Waystones (by BlayTheNinth) Vampires Need Umbrellas (by focamacho) Oculus (by Asek3) Mantle (by mDiyo) Mob Grinding Utils (by vadis365) Chiseled (by freepeopleworking) AutoRegLib (by Vazkii) Mystical Agriculture (by BlakeBr0) Embeddium/Rubidium Dynamic Lights (by Txni) Flywheel (Legacy) (by jozufozu) Builder's Delight (Forge) (by Tynoxs) Apotheosis (by Shadows_of_Fire) What Are They Up To (Watut) (by Corosus) Create: Interiors (by sudolev) FastFurnace (by Shadows_of_Fire) Balm (Forge Edition) (by BlayTheNinth) Clumps (by Jaredlll08) Iris & Oculus Flywheel Compat (by leon_mout) Configured (by MrCrayfish) Tinkers' Expansion (by Insane96) Crafting on a stick (by OfekN_) MrCrayfish's Gun Mod (by MrCrayfish) Create: Crystal Clear (by singularity_cyvack) FTB Library (Forge) (by FTB) AppleSkin (by squeek502) Curios API (Forge/NeoForge) (by TheIllusiveC4) Better Third Person (by Socolio) Caelus API (Forge/NeoForge) (by TheIllusiveC4) Sons Of Sins (by Furti_Two) SwingThroughGrass (by exidex) AttributeFix (by DarkhaxDev) Quests Additions (Forge) (by NaturaSpell) Building Gadgets (by Direwolf20) Enchantment Descriptions (by DarkhaxDev) Skin Layers 3D (Fabric/Forge) (by tr7zw) Bad Wither No Cookie - Reloaded (by Kreezxil) Placebo (by Shadows_of_Fire) FTB Teams (Forge) (by FTB) Mod Name Tooltip (by mezz) Enigmatic Graves (by Quarris) Sophisticated Backpacks (by P3pp3rF1y) GeckoLib (by Gecko) Builders Crafts & Additions (by MRHminer) Immersive Portals (for Forge) (by qouteall) Architectury API (Fabric/Forge/NeoForge) (by shedaniel) Lazy DataFixerUpper(LazyDFU) [FORGE] (by Corgi_Taco) Create Ore Excavation (by tom54541) Tinkers' Rapier (by sz0999312) Mowzie's Mobs (by bobmowzie) Better Combat [Fabric & Forge] (by daedelus_dev) Create Stuff & Additions (by Furti_Two) Cucumber Library (by BlakeBr0) FPS Reducer (by bre2el) Item Filters (by LatvianModder) FTB Quests (Forge) (by FTB) L_Ender 's Cataclysm (by mcl_ender) Starter Kit (by Serilum) Feature NBT Deadlock Be Gone (by telepathicgrunt) Materialis (by RCXcrafter) KleeSlabs (by BlayTheNinth) Pehkui (by Virtuoel) Grappling Hook Mod (by yyonne) Security Craft (by Geforce132) Ars Nouveau (by baileyholl2) Mouse Tweaks (by YaLTeR) Werewolves - Become a Beast! (by Cheaterpaul) Elytra Slot (Fabric/Forge/Quilt) (by TheIllusiveC4) Create (by simibubi) Budschie's Morph Mod (by budschie_) Ore Excavation (by Funwayguy) Create Confectionery (by Furti_Two)
    • Hello, im kind of a newbie on creating mods, and i been trying to make simples mods so far, Right now, i'm creating a mod which detect an specific type of mob and kill it if reach a certain number, by far the mod is detecting the mob and counting them but at the time it reach the limit number, it don't do anything. The Game don't tweak, don't crash, just i't don't run the method i call, which is kill().   public InteractionResultHolder<ItemStack> use(Level pLevel, Player pPlayer, InteractionHand pUsedHand) { final var TotalCows = pLevel.getNearbyEntities(Cow.class, TargetingConditions.forNonCombat(), pPlayer, pPlayer.getBoundingBox().inflate(5)); if(pLevel.isClientSide){ if(pPlayer.getItemInHand(InteractionHand.MAIN_HAND).getItem() == this.asItem()){ if(!TotalCows.isEmpty()){ if(TotalCows.get(0).isAlive()){ TotalCows.get(0).kill(); } }else{ pPlayer.sendSystemMessage(Component.literal("No hay vacas")); } } } The sendSystemMessage is get triggered, and when i change the method .kill() by any other like send a message it got called, can i get some tips, and a clue of what i'm missing
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.