How can i make a custom model for the existing wooden signs?

[Drachenbauer]

Hello

i want to modify the model of the sign to display the wooden texture in the same size of common blocks:

16 pixels width, 8 pixels high (in the center of the texture) and 1 pixel thick, exact touching the wall of a solid block.

Standing signs should be attached to a 2x2 pixels thick, 16 pixels high post (12 pixels below it´s top).

 

how can i do this in a resource-pack?

Or is this only possible in a mod?

[ChampionAsh5357]

Signs are rendered through TileEntityRenderer. You cannot change the model. The most you can do is change the texture. If you really want to change the model, create a new block.

[Drachenbauer]

Now i try to override the signs in a mod.

 

I created a modifyed SignTileEntityRenderer (it includes the model as a subclass).

Spoiler

package drachenbauer32.recreatedsignsmod.tileentities.renderers;

import java.util.List;

import com.mojang.blaze3d.matrix.MatrixStack;
import com.mojang.blaze3d.vertex.IVertexBuilder;

import net.minecraft.block.AbstractSignBlock;
import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.StandingSignBlock;
import net.minecraft.block.WallSignBlock;
import net.minecraft.block.WoodType;
import net.minecraft.client.gui.FontRenderer;
import net.minecraft.client.gui.RenderComponentsUtil;
import net.minecraft.client.renderer.Atlases;
import net.minecraft.client.renderer.IRenderTypeBuffer;
import net.minecraft.client.renderer.RenderType;
import net.minecraft.client.renderer.Vector3f;
import net.minecraft.client.renderer.model.Material;
import net.minecraft.client.renderer.model.Model;
import net.minecraft.client.renderer.model.ModelRenderer;
import net.minecraft.client.renderer.texture.NativeImage;
import net.minecraft.client.renderer.tileentity.TileEntityRenderer;
import net.minecraft.client.renderer.tileentity.TileEntityRendererDispatcher;
import net.minecraft.tileentity.SignTileEntity;
import net.minecraft.util.text.ITextComponent;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;

public class SignTileEntityRenderer extends TileEntityRenderer<SignTileEntity> {
    /** The ModelSign instance for use in this renderer */
    private final SignTileEntityRenderer.SignModel model = new SignTileEntityRenderer.SignModel();
    
    public SignTileEntityRenderer(TileEntityRendererDispatcher rendererDispatcherIn)
    {
        super(rendererDispatcherIn);
    }
    
    public void render(SignTileEntity tileEntityIn, float partialTicks, MatrixStack matrixStackIn, IRenderTypeBuffer bufferIn, int combinedLightIn, int combinedOverlayIn)
    {
        BlockState blockstate = tileEntityIn.getBlockState();
        matrixStackIn.push();
        
        if (blockstate.getBlock() instanceof StandingSignBlock)
        {
            matrixStackIn.translate(0.5D, 0.5D, 0.5D);
            float f1 = -((float)(blockstate.get(StandingSignBlock.ROTATION) * 360) / 16.0F);
            matrixStackIn.rotate(Vector3f.YP.rotationDegrees(f1));
            this.model.signStick.showModel = true;
        }
        else
        {
            matrixStackIn.translate(0.5D, 0.5D, 0.5D);
            float f2 = -blockstate.get(WallSignBlock.FACING).getHorizontalAngle();
            matrixStackIn.rotate(Vector3f.YP.rotationDegrees(f2));
            matrixStackIn.translate(0.0D, -0.5D, -0.5D);
            this.model.signStick.showModel = false;
        }
        
        matrixStackIn.push();
        Material material = getMaterial(blockstate.getBlock());
        IVertexBuilder ivertexbuilder = material.getBuffer(bufferIn, this.model::getRenderType);
        this.model.signBoard.render(matrixStackIn, ivertexbuilder, combinedLightIn, combinedOverlayIn);
        this.model.signStick.render(matrixStackIn, ivertexbuilder, combinedLightIn, combinedOverlayIn);
        matrixStackIn.pop();
        FontRenderer fontrenderer = this.renderDispatcher.getFontRenderer();
        matrixStackIn.translate(0.0D, (double)0.33333334F, (double)0.046666667F);
        matrixStackIn.scale(0.010416667F, -0.010416667F, 0.010416667F);
        int i = tileEntityIn.getTextColor().getTextColor();
        int j = (int)((double)NativeImage.getRed(i) * 0.4D);
        int k = (int)((double)NativeImage.getGreen(i) * 0.4D);
        int l = (int)((double)NativeImage.getBlue(i) * 0.4D);
        int i1 = NativeImage.getCombined(0, l, k, j);
        
        for(int j1 = 0; j1 < 4; ++j1)
        {
            String s = tileEntityIn.getRenderText(j1, (p_212491_1_) ->
            {
                List<ITextComponent> list = RenderComponentsUtil.splitText(p_212491_1_, 90, fontrenderer, false, true);
                return list.isEmpty() ? "" : list.get(0).getFormattedText();
            }
            );
            
            if (s != null)
            {
                float f3 = (float)(-fontrenderer.getStringWidth(s) / 2);
                fontrenderer.renderString(s, f3, (float)(j1 * 10 - tileEntityIn.signText.length * 5), i1, false, matrixStackIn.getLast().getMatrix(), bufferIn, false, 0, combinedLightIn);
            }
        }
        
        matrixStackIn.pop();
    }
    
    public static Material getMaterial(Block blockIn) {
        WoodType woodtype;
        if (blockIn instanceof AbstractSignBlock) {
            woodtype = ((AbstractSignBlock)blockIn).getWoodType();
        }
        else
        {
            woodtype = WoodType.OAK;
        }
        
        return Atlases.getSignMaterial(woodtype);
    }
    
    @OnlyIn(Dist.CLIENT)
    public static final class SignModel extends Model
    {
        public final ModelRenderer signBoard = new ModelRenderer(this);
        public final ModelRenderer signStick = new ModelRenderer(this);
        
        public SignModel()
        {
            super(RenderType::getEntityCutoutNoCull);
            
            textureWidth = 64;
            textureHeight = 32;
            
            this.signBoard.setRotationPoint(0.0F, 16.0F, 0.0F);
            this.signBoard.addBox("board",     -8.0F, -20.0F, -1.0F, 1,  8, 1, 0.0F, 0,  0);
            
            this.signStick.setRotationPoint(0.0F, 16.0F, 0.0F);
            this.signStick.addBox("stick",     -1.0F, -20.0F, -1.0F, 2, 20, 2, 0.0F, 0, 10);
            this.signStick.addBox("stick_top", -1.0F, -22.0F, -1.0F, 2,  2, 2, 0.0F, 8, 28);
        }
        
        public void render(MatrixStack matrixStackIn, IVertexBuilder bufferIn, int packedLightIn, int packedOverlayIn, float red, float green, float blue, float alpha)
        {
            this.signBoard.render(matrixStackIn, bufferIn, packedLightIn, packedOverlayIn, red, green, blue, alpha);
            this.signStick.render(matrixStackIn, bufferIn, packedLightIn, packedOverlayIn, red, green, blue, alpha);
        }
    }
}

 

And i registered it like this:

private void clientRegistries(final FMLClientSetupEvent event)
    {
        ClientRegistry.bindTileEntityRenderer(TileEntityType.Builder.create(SignTileEntity::new,
                                             RecreatedSignsBlocks.ACACIA_SIGN.get(),
                                             RecreatedSignsBlocks.BIRCH_SIGN.get(),
                                             RecreatedSignsBlocks.DARK_OAK_SIGN.get(),
                                             RecreatedSignsBlocks.JUNGLE_SIGN.get(),
                                             RecreatedSignsBlocks.OAK_SIGN.get(),
                                             RecreatedSignsBlocks.SPRUCE_SIGN.get(),
                                             RecreatedSignsBlocks.ACACIA_WALL_SIGN.get(),
                                             RecreatedSignsBlocks.BIRCH_WALL_SIGN.get(),
                                             RecreatedSignsBlocks.DARK_OAK_WALL_SIGN.get(),
                                             RecreatedSignsBlocks.JUNGLE_WALL_SIGN.get(),
                                             RecreatedSignsBlocks.OAK_WALL_SIGN.get(),
                                             RecreatedSignsBlocks.SPRUCE_WALL_SIGN.get()
                                             ).build(null), SignTileEntityRenderer::new);
    }

As theese where the original block-instances, i saw the old models in the game.

So i overrided the blocks and items with deferred register.

But now i see no sign models in the game and if i place a sign, no editor opens.

i saw no references to the TileEntityRenderer in the Block- Item and Tileentity-classes for the sign.

So i did not create copies of them jet.

Edited May 5, 2020 by Drachenbauer

[Drachenbauer]

bump

 

I found out, that the SignEditorScreen also uses the SignTileEntityRenderer.

So i made my own modifyed variant of this, too:

Spoiler

package drachenbauer32.recreatedsignsmod.screens;

import com.mojang.blaze3d.matrix.MatrixStack;
import com.mojang.blaze3d.platform.GlStateManager;
import com.mojang.blaze3d.systems.RenderSystem;
import com.mojang.blaze3d.vertex.IVertexBuilder;

import drachenbauer32.recreatedsignsmod.tileentities.renderers.SignTileEntityRenderer;

import java.util.List;
import net.minecraft.block.BlockState;
import net.minecraft.block.StandingSignBlock;
import net.minecraft.client.gui.RenderComponentsUtil;
import net.minecraft.client.gui.fonts.TextInputUtil;
import net.minecraft.client.gui.screen.Screen;
import net.minecraft.client.gui.widget.button.Button;
import net.minecraft.client.network.play.ClientPlayNetHandler;
import net.minecraft.client.renderer.BufferBuilder;
import net.minecraft.client.renderer.IRenderTypeBuffer;
import net.minecraft.client.renderer.Matrix4f;
import net.minecraft.client.renderer.RenderHelper;
import net.minecraft.client.renderer.Tessellator;
import net.minecraft.client.renderer.WorldVertexBufferUploader;
import net.minecraft.client.renderer.model.Material;
import net.minecraft.client.renderer.texture.OverlayTexture;
import net.minecraft.client.renderer.vertex.DefaultVertexFormats;
import net.minecraft.client.resources.I18n;
import net.minecraft.network.play.client.CUpdateSignPacket;
import net.minecraft.tileentity.SignTileEntity;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.StringTextComponent;
import net.minecraft.util.text.TranslationTextComponent;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;

@OnlyIn(Dist.CLIENT)
public class EditSignScreen extends Screen
{
    private final SignTileEntityRenderer.SignModel field_228191_a_ = new SignTileEntityRenderer.SignModel();
    /** Reference to the sign object. */
    private final SignTileEntity tileSign;
    /** Counts the number of screen updates. */
    private int updateCounter;
    /** The index of the line that is being edited. */
    private int editLine;
    private TextInputUtil textInputUtil;
    
    public EditSignScreen(SignTileEntity teSign)
    {
        super(new TranslationTextComponent("sign.edit"));
        this.tileSign = teSign;
    }
    
    protected void init()
    {
        this.minecraft.keyboardListener.enableRepeatEvents(true);
        
        this.addButton(new Button(this.width / 2 - 100, this.height / 4 + 120, 200, 20, I18n.format("gui.done"), (p_214266_1_) ->
        {
            this.close();
        }
        ));
        
        this.tileSign.setEditable(false);
       
        this.textInputUtil = new TextInputUtil(this.minecraft, () ->
        {
            return this.tileSign.getText(this.editLine).getString();
        }
        , (p_214265_1_) ->
        {
            this.tileSign.setText(this.editLine, new StringTextComponent(p_214265_1_));
        }
        , 90);
    }
    
    public void removed()
    {
        this.minecraft.keyboardListener.enableRepeatEvents(false);
        ClientPlayNetHandler clientplaynethandler = this.minecraft.getConnection();
        
        if (clientplaynethandler != null)
        {
            clientplaynethandler.sendPacket(new CUpdateSignPacket(this.tileSign.getPos(), this.tileSign.getText(0), this.tileSign.getText(1), this.tileSign.getText(2), this.tileSign.getText(3)));
        }
        
        this.tileSign.setEditable(true);
    }
    
    public void tick()
    {
        ++this.updateCounter;
        
        if (!this.tileSign.getType().isValidBlock(this.tileSign.getBlockState().getBlock()))
        {
            this.close();
        }
    }
    
    private void close()
    {
        this.tileSign.markDirty();
        this.minecraft.displayGuiScreen((Screen)null);
    }
    
    public boolean charTyped(char p_charTyped_1_, int p_charTyped_2_)
    {
        this.textInputUtil.func_216894_a(p_charTyped_1_);
        return true;
    }
    
    public void onClose()
    {
        this.close();
    }
    
    public boolean keyPressed(int p_keyPressed_1_, int p_keyPressed_2_, int p_keyPressed_3_)
    {
        if (p_keyPressed_1_ == 265)
        {
            this.editLine = this.editLine - 1 & 3;
            this.textInputUtil.func_216899_b();
            return true;
        }
        else if (p_keyPressed_1_ != 264 && p_keyPressed_1_ != 257 && p_keyPressed_1_ != 335)
        {
            return this.textInputUtil.func_216897_a(p_keyPressed_1_) ? true : super.keyPressed(p_keyPressed_1_, p_keyPressed_2_, p_keyPressed_3_);
        }
        else
        {
            this.editLine = this.editLine + 1 & 3;
            this.textInputUtil.func_216899_b();
            return true;
        }
    }
    
    public void render(int p_render_1_, int p_render_2_, float p_render_3_)
    {
        RenderHelper.setupGuiFlatDiffuseLighting();
        this.renderBackground();
        this.drawCenteredString(this.font, this.title.getFormattedText(), this.width / 2, 40, 16777215);
        MatrixStack matrixstack = new MatrixStack();
        matrixstack.push();
        matrixstack.translate((double)(this.width / 2), 0.0D, 50.0D);
        matrixstack.scale(93.75F, -93.75F, 93.75F);
        matrixstack.translate(0.0D, -1.5D, 0.0D);
        BlockState blockstate = this.tileSign.getBlockState();
        boolean flag = blockstate.getBlock() instanceof StandingSignBlock;
        
        if (!flag)
        {
            matrixstack.translate(0.0D, -0.5D, 0.0D);
        }
        
        boolean flag1 = this.updateCounter / 6 % 2 == 0;
        matrixstack.push();
        IRenderTypeBuffer.Impl irendertypebuffer$impl = this.minecraft.getRenderTypeBuffers().getBufferSource();
        Material material = SignTileEntityRenderer.getMaterial(blockstate.getBlock());
        IVertexBuilder ivertexbuilder = material.getBuffer(irendertypebuffer$impl, this.field_228191_a_::getRenderType);
        this.field_228191_a_.signBoard.render(matrixstack, ivertexbuilder, 15728880, OverlayTexture.NO_OVERLAY);
        
        if (flag)
        {
            this.field_228191_a_.signStick.render(matrixstack, ivertexbuilder, 15728880, OverlayTexture.NO_OVERLAY);
        }
        
        matrixstack.pop();
        matrixstack.translate(0.0D, (double)0.33333334F, (double)0.046666667F);
        matrixstack.scale(0.010416667F, -0.010416667F, 0.010416667F);
        int i = this.tileSign.getTextColor().getTextColor();
        String[] astring = new String[4];
        
        for(int j = 0; j < astring.length; ++j)
        {
            astring[j] = this.tileSign.getRenderText(j, (p_228192_1_) ->
            {
                List<ITextComponent> list = RenderComponentsUtil.splitText(p_228192_1_, 90, this.minecraft.fontRenderer, false, true);
                return list.isEmpty() ? "" : list.get(0).getFormattedText();
            }
            );
        }
        
        Matrix4f matrix4f = matrixstack.getLast().getMatrix();
        int k = this.textInputUtil.func_216896_c();
        int l = this.textInputUtil.func_216898_d();
        int i1 = this.minecraft.fontRenderer.getBidiFlag() ? -1 : 1;
        int j1 = this.editLine * 10 - this.tileSign.signText.length * 5;
        
        for(int k1 = 0; k1 < astring.length; ++k1)
        {
            String s = astring[k1];
            
            if (s != null)
            {
                float f3 = (float)(-this.minecraft.fontRenderer.getStringWidth(s) / 2);
                this.minecraft.fontRenderer.renderString(s, f3, (float)(k1 * 10 - this.tileSign.signText.length * 5), i, false, matrix4f, irendertypebuffer$impl, false, 0, 15728880);
                
                if (k1 == this.editLine && k >= 0 && flag1)
                {
                    int l1 = this.minecraft.fontRenderer.getStringWidth(s.substring(0, Math.max(Math.min(k, s.length()), 0)));
                    int i2 = (l1 - this.minecraft.fontRenderer.getStringWidth(s) / 2) * i1;
                    
                    if (k >= s.length())
                    {
                        this.minecraft.fontRenderer.renderString("_", (float)i2, (float)j1, i, false, matrix4f, irendertypebuffer$impl, false, 0, 15728880);
                    }
                }
            }
        }
        
        irendertypebuffer$impl.finish();
        
        for(int k3 = 0; k3 < astring.length; ++k3) {
            String s1 = astring[k3];
            
            if (s1 != null && k3 == this.editLine && k >= 0)
            {
                int l3 = this.minecraft.fontRenderer.getStringWidth(s1.substring(0, Math.max(Math.min(k, s1.length()), 0)));
                int i4 = (l3 - this.minecraft.fontRenderer.getStringWidth(s1) / 2) * i1;
                if (flag1 && k < s1.length())
                {
                    fill(matrix4f, i4, j1 - 1, i4 + 1, j1 + 9, -16777216 | i);
                }
                
                if (l != k)
                {
                    int j4 = Math.min(k, l);
                    int j2 = Math.max(k, l);
                    int k2 = (this.minecraft.fontRenderer.getStringWidth(s1.substring(0, j4)) - this.minecraft.fontRenderer.getStringWidth(s1) / 2) * i1;
                    int l2 = (this.minecraft.fontRenderer.getStringWidth(s1.substring(0, j2)) - this.minecraft.fontRenderer.getStringWidth(s1) / 2) * i1;
                    int i3 = Math.min(k2, l2);
                    int j3 = Math.max(k2, l2);
                    Tessellator tessellator = Tessellator.getInstance();
                    BufferBuilder bufferbuilder = tessellator.getBuffer();
                    RenderSystem.disableTexture();
                    RenderSystem.enableColorLogicOp();
                    RenderSystem.logicOp(GlStateManager.LogicOp.OR_REVERSE);
                    bufferbuilder.begin(7, DefaultVertexFormats.POSITION_COLOR);
                    bufferbuilder.pos(matrix4f, (float)i3, (float)(j1 + 9), 0.0F).color(0, 0, 255, 255).endVertex();
                    bufferbuilder.pos(matrix4f, (float)j3, (float)(j1 + 9), 0.0F).color(0, 0, 255, 255).endVertex();
                    bufferbuilder.pos(matrix4f, (float)j3, (float)j1, 0.0F).color(0, 0, 255, 255).endVertex();
                    bufferbuilder.pos(matrix4f, (float)i3, (float)j1, 0.0F).color(0, 0, 255, 255).endVertex();
                    bufferbuilder.finishDrawing();
                    WorldVertexBufferUploader.draw(bufferbuilder);
                    RenderSystem.disableColorLogicOp();
                    RenderSystem.enableTexture();
                }
            }
        }
        
        matrixstack.pop();
        RenderHelper.setupGui3DDiffuseLighting();
        super.render(p_render_1_, p_render_2_, p_render_3_);
    }
}

 

How do i override theese two original classes with my own modifyed ones, wich i created?

 

The SignTileEntityRenderer is registered in the TileEntityRendererDispatcher.

How do i override this registry-entry?

 

The SignEditorScreen is referenced in the ClientPlayerEntity.

How do i override this reference?