[1.15.2] Custom Regen Effect

[kykaro]

Hi, so I am trying to make a custom regen effect that is enabled when the player wears a certain piece of armor. I thought making a custom potion effect would be the best way to go about that, but perhaps not (if you have a better idea I am all for it, I am new to modding minecraft). I have been able to register a new effect with forge and I figured the best time to check if they have the armor on is during the LivingEquipmentChangeEvent, that way its only firing on a trigger and not all the time. I am able to get the effect to show up, as in when they wear the item, they have the effect with artwork, proper name, proper swirl color, all that fun stuff, but the effect doesnt tick at all. I know I am doing something simple wrong, but I just cant quite figure it out. 

So
 

//Where I add the effect

@Mod.EventBusSubscriber(modid = FantasyOres.MOD_ID, bus = Mod.EventBusSubscriber.Bus.FORGE, value = Dist.CLIENT)
public class ArmorEffect {

  @SubscribeEvent
      public static void onEquip(LivingEquipmentChangeEvent event) {
          LivingEntity actor = event.getEntityLiving();
          if (actor instanceof PlayerEntity) {
            Iterable<ItemStack> equipment = actor.getEquipmentAndArmor();
            //Increment through all equipped items
            for (ItemStack i : equipment) {
                //check against tag. since any ruby item should grant the effect
                //TODO there has to be a better way to do this
                if (i.getItem().getTags().toString().contains("fantasyores:ruby") {
                  actor.addPotionEffect(new EffectInstance(EffectInit.RUBY_REGEN_EFFECT.get(),100,1));
                }
            }
      }
}

//Where I register effect
public class EffectInit {

    public static final DeferredRegister<Effect> EFFECTS = new DeferredRegister<>(ForgeRegistries.POTIONS, FantasyOres.MOD_ID);
    public static final DeferredRegister<Potion> POTIONS = new DeferredRegister<>(ForgeRegistries.POTION_TYPES, FantasyOres.MOD_ID);

    public static final RegistryObject<Effect> RUBY_REGEN_EFFECT = EFFECTS.register("ruby_regen",() -> new RegenEffect(EffectType.BENEFICIAL, 15151675));
    public static final RegistryObject<Potion> RUBY_REGEN_POTION = POTIONS.register("ruby_regen", () -> new Potion(new EffectInstance(RUBY_REGEN_EFFECT.get())));
}

//Regen Effect with debug
public class RegenEffect extends Effect {


    public RegenEffect(EffectType typeIn, int liquidColorIn) {
        super(typeIn, liquidColorIn);
        FantasyOres.LOGGER.info("Constructor called");
    }

    @Override
    public void performEffect(LivingEntity entityLivingBaseIn, int amplifier) {
        FantasyOres.LOGGER.info("Tick");
        if (entityLivingBaseIn.getHealth() < entityLivingBaseIn.getMaxHealth()) {
            entityLivingBaseIn.heal(1.0F);
        } else {
            entityLivingBaseIn.heal((float)Math.max(4 << amplifier, 0));
        }
    }

    @Override
    public void affectEntity(@Nullable Entity source, @Nullable Entity indirectSource, LivingEntity entityLivingBaseIn, int amplifier, double health) {
        FantasyOres.LOGGER.info("entity affected by ruby regen");
        this.performEffect(entityLivingBaseIn, amplifier);
    }
}

//Main class
@Mod(FantasyOres.MOD_ID)
@Mod.EventBusSubscriber(modid = FantasyOres.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class FantasyOres {

    public static final Logger LOGGER = LogManager.getLogger();
    public static final String MOD_ID = "fantasyores";

    public FantasyOres() {
        final IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();
        modEventBus.addListener(this::setup);
        modEventBus.addListener(this::doClientStuff);

        EffectInit.EFFECTS.register(modEventBus);
        EffectInit.POTIONS.register(modEventBus);
        ItemInit.ITEMS.register(modEventBus);

        BlockInit.BLOCKS.register(modEventBus);

        BiomeInit.BIOMES.register(modEventBus);
        //DimensionInit.MOD_DIMENSIONS.register(modEventBus);

        MinecraftForge.EVENT_BUS.register(this);
    }

    @SubscribeEvent
    public static void onRegisterItems(final RegistryEvent.Register<Item> event) {
        final IForgeRegistry<Item> registry = event.getRegistry();

        BlockInit.BLOCKS.getEntries().stream().map(RegistryObject::get).forEach(block -> {
            final Item.Properties properties = new Item.Properties().group(FantasyOres.TAB);
            final BlockItem blockItem = new BlockItem(block, properties);
            blockItem.setRegistryName(block.getRegistryName());
            registry.register(blockItem);
        });
    }

    @SubscribeEvent
    public static void onRegisterBiomes(final RegistryEvent.Register<Biome> event) {
        BiomeInit.registerBiomes();
    }

    private void setup(final FMLCommonSetupEvent event) {

    }

    private void doClientStuff(final FMLClientSetupEvent event) {

    }

    @SubscribeEvent
    public void onServerStarting(FMLServerStartingEvent event) {

    }

    @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
    public static class RegistryEvents {

    }

    @SubscribeEvent
    public static void LoadCompleteEvent(FMLLoadCompleteEvent event) {
        ModOreGen.GenerateOre();
    }


    public static final ItemGroup TAB = new ItemGroup("fantasyores_tab") {
        @Override
        public ItemStack createIcon() { return new ItemStack(ItemInit.RUBY.get()); }
    };
}

Any help is appreciated, sorry if the code is a bit messy, new to this all.

[[NoOneButNo]]

Use IForgeItem#onArmorTick method. Do the necessary checking.