Jump to content

Recommended Posts

Posted

Currently, if player deals no damage, LivingAttackEvent is not called. Therefore, LivingHurtEvent is also not called. This causes some issues such as enchantment x unable to apply its bonus damage (subscribed at LivingHurtEvent or LivingDamageEvent) but is not called. An example scenario would be a player having -8 damage but has enchantment x that gives +`12 damage. Now, since the game checks first if the player has actually positive damage, the +12 will never be applied since the +12 is only present in the LivingHurtEvent which is never called.

 

Now, I suggest that LivingHurtEvent should modify the damage first before checking if the damage is actually positive to ensure that the damage calculation is done right.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.