Ok, I will preface this by saying I know ASM and coremods should only be used when absolutely necessary. I've been trying to remove air resistance from arrows on my server, and this pesky bit of code is always eluding me:

float f2 = 0.99F;
if (this.isInWater()) {
    for(int j = 0; j < 4; ++j) {
        float f4 = 0.25F;
        this.world.addParticle(ParticleTypes.BUBBLE, d5 - d3 * 0.25D, d1 - d4 * 0.25D, d2 - d0 * 0.25D, d3, d4, d0);
    }

    f2 = this.getWaterDrag();
}

this.setMotion(vec3d.scale((double)f2));

float f2 is basically how drag is implemented in arrows. If I could simply delete the line f2 = this.getWaterDrag() and set float f2 = 1.0F, I'd have removed air resistance

 

The problem is that the f2 variable isn't defined in the class, it's defined in the method block. Instantly that completely makes reflection useless. I can't replace AbstractArrowEntity.java with my own Arrow Entity either, because it's a base class diverging out to many different Arrow subclasses. If I did that the server would crash every time a tipped arrow was shot. And I've also tried reverting the drag using LivingUpdateEvent at both end and start phases, and even both phases at once, but all that did was make arrows unusable because they'd fly around randomly after being shot. It seems ASM is my only way forward unfortunately, but Forge has switched the Coremod system and I'm not too sure how to use it

11 minutes ago, _vertig0 said:

I know ASM and coremods should only be used when absolutely necessary

This doesn't seem like a good use case for ASM.

 

11 minutes ago, _vertig0 said:

LivingUpdateEvent

Thing about this for a second, are arrows living? Of course they aren't, arrows extend Entity and implement IProjectile.

In my opinion you should cancel one of the many events (maybe ArrowLooseEvent?) that references arrows and implement your own physics there.

Edited June 9, 20205 yr by Novârch

3 minutes ago, Novârch said:

This doesn't seem like a good use case for ASM.

 

Thing about this for a second, are arrows living? Of course they aren't, arrows extend Entity and implement IProjectile.

In my opinion you should cancel one of the many events (maybe ArrowLooseEvent?) that references arrows and implement your own physics there.

I'll try that and see if it works, but I suspect it's just going to clash with the base physics in AbstractArrowEntity anyway and go all wonky

 

 

Ah well, who else to blame but Mojang haha

3 minutes ago, _vertig0 said:

clash with the base physics in AbstractArrowEntity anyway and go all wonky

Maybe you could replace all of the arrow entities entirely? Canceling either the usage of the bow or the spawning of the arrows.