Jump to content

Dark Theme adjustment


Curle

Recommended Posts

 

The dark theme is a bit... off-kilter.

 

This is just an infodump in a reliable location while i try to figure my way around the Web repo and actually effect these changes myself.

 

If you go to somebody's profile and switch to dark theme:

unknown.png

 

The text becomes unbearably low contrast.

The dark text is color #555 and the background is #3C3F41, meaning a contrast of 1.4:1.

The Web Content Accessibility Guidelines (WCAG 2.0) level AA requires a 4.5:1 color contrast between text and background for normal text, and you can certainly see why.

 

A 4.5:1 color rating means the text must be at least #999999, but #BBBBBB is far better on my eyes, and maintains a decent color contrast from the headers and infos ("8 minutes ago").

 

 

It's 5:21am as i write this, and i need sleep, but i didn't want to forget this and i didn't trust Notepad to keep it safe >.>

Will update as i meander the https://github.com/MinecraftForge/Web/tree/master/sass repo

Link to comment
Share on other sites

  • 6 months later...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I recently updated my mods and now my game is crashing on startup i tried adding them one at a time and couldn't find anything wrong and no crash log is being made the only thing I have is the debug log. If it helps I'm also using the curseforge launcher to launch the game. Minecraft version- 1.20.1 Forge Version-47.2.0 https://gist.github.com/keepinitreal247/d3105af6bb70e30f183505715113c61a
    • i managed to use another launcher but it still says logging in
    • i tried to open the modpack with multimc by importing it from Ftb and it gave me an error https://paste.ee/p/YDqWN
    • Hi, I'm trying to render a single quad in the world. I'm mixing into the ChestRenderer class. If I understand correctly, BufferSource#getBuffer opens a buffer according to the supplied RenderType (Quads with POSITION_COLOR in my case). Then, I can supply my vertices (a simple 1-block plane along the Z Axis) and close the buffer using BufferSource#endBatch for rendering. This is the code I'm using: @Inject(at = @At("TAIL"), method = "render(...)V") public void render(T blockEntity, float partialTick, PoseStack poseStack, MultiBufferSource multiBufferSource, int packedLight, int packedOverlay, CallbackInfo ci) { BlockPos pos = blockEntity.getBlockPos(); AABB box = new AABB(pos, pos.offset(1, 1, 1)); BufferSource buffer = Minecraft.getInstance().renderBuffers().bufferSource(); VertexConsumer consumer = buffer.getBuffer(RenderType.guiOverlay()); poseStack.pushPose(); poseStack.translate(-pos.getX(), -pos.getY(), -pos.getZ()); consumer.vertex(box.minX, box.maxY, box.minZ).color(1, 1, 1, 1).endVertex(); consumer.vertex(box.minX, box.maxY, box.maxZ).color(1, 1, 1, 1).endVertex(); consumer.vertex(box.minX, box.minY, box.maxZ).color(1, 1, 1, 1).endVertex(); consumer.vertex(box.minX, box.minY, box.minZ).color(1, 1, 1, 1).endVertex(); buffer.endBatch(RenderType.guiOverlay()); poseStack.popPose(); } However, the plane does not get rendered. However, if I replace those 4 vertices with a call to LevelRenderer#renderLineBox and set the RenderType to LINES, it works. Do I need something else to render planes other than the 4 edges of the quad? I used QUADS back in 1.8 where it was still the raw OpenGL type and it worked then. Or am I missing something else entirely? Thanks!
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.