Jump to content

Client-Server mismatch


TuxCraft

Recommended Posts

Help, I have no idea on how to use packets. I know there's a tutorial on the forge wiki about it but it makes no sense to me. There are two glitches in my mod that I've whittled down to the client and server not matching up. One is where the client gives me a ghost item and another is an entity that only shows up client side when thrown. I've been saving the fixing of these two bugs for last because again, I have no idea how to use packets. If someone could explain to me how they work and give me the general gist of it I'm sure I can go from there.

Link to comment
Share on other sites

for the ghost entity you should be able to get away with an if(!world.isRemote) before spawning it.

 

as for the other bug, can we see your code rather than doing this blind?

 

Thanks for responding but I don't think the ghost entity will be solved that way because the way I have it set up it is incased in a if(world.isRemote). Here let me show you.

 

@Override
public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World,
        EntityPlayer par3EntityPlayer)
{

	if (par2World.isRemote)
	{
		if (TuxWeaponsCore.harpoonEntity != null)
		{
			int i = TuxWeaponsCore.harpoonEntity.recall();
			par1ItemStack.damageItem(i, par3EntityPlayer);
			par3EntityPlayer.swingItem();
		}

		else
		{
			par2World.playSoundAtEntity(par3EntityPlayer, "random.bow",
			        0.5F, 0.4F / (itemRand.nextFloat() * 0.4F + 0.8F));
			par2World.spawnEntityInWorld(new EntityHarpoon(par2World,
			        par3EntityPlayer, 0.7F, 5));
			par3EntityPlayer.swingItem();
		}
	}

	return par1ItemStack;
}

 

 

I'm making a Harpoon which works similar to a fishing rod. What happens is you throw the harpoon and it will bounce off of entities it comes into contact with but it will not do any damage.

 

As for the ghost item here's the code. It's a spear so before you through it it gets the itemstack and on the entity side it adds it to the inventory.

 

Here's the copy code

 

@Override
public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World,
        EntityPlayer par3EntityPlayer)
{

	itemstack = par3EntityPlayer.inventory.getCurrentItem().copyItemStack(par1ItemStack);

	if (par3EntityPlayer.capabilities.isCreativeMode
	        || par3EntityPlayer.inventory.hasItem(this.itemID))
	{
		par3EntityPlayer.setItemInUse(par1ItemStack,
		        this.getMaxItemUseDuration(par1ItemStack));
	}

	return par1ItemStack;
}

 

 

And the entity pickup code

 

@Override
public void onCollideWithPlayer(EntityPlayer par1EntityPlayer)
{

	boolean flag = this.canBePickedUp == 1 || this.canBePickedUp == 2
	        && par1EntityPlayer.capabilities.isCreativeMode;

	if (this.inGround && this.arrowShake <= 0)
	{

		if (!this.worldObj.isRemote)
		{

			if (this.canBePickedUp == 1
			        && !par1EntityPlayer.inventory
			                .addItemStackToInventory(stack))
			{
				flag = false;
			}
		}

		if (flag)
		{
			this.playSound(
			        "random.pop",
			        0.2F,
			        ((this.rand.nextFloat() - this.rand.nextFloat()) * 0.7F + 1.0F) * 2.0F);
			par1EntityPlayer.onItemPickup(this, 1);
			this.setDead();
		}
	}

}

 

 

Now I have partially solved the ghost item problem, by putting the if (!this.worldObj.isRemote) around the add item to inventory code and not the kill code it will put the correct itemstack in the inventory and it is not a ghost, but after it hits an entity you can not pick it up just like the arrow which I used to base this code on, so I'll look and see if there's a fix for that, I assume it has something to do with this.canBePickedUp. If I don't have the if (!this.worldObj.isRemote) it will let me pick up the item every time as a ghost and if I have it around the set dead code it will kill the entity but the client will still show it.

Link to comment
Share on other sites

for the first bit of code, try this:

@Override
public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World,
        EntityPlayer par3EntityPlayer)
{
		if (TuxWeaponsCore.harpoonEntity != null)
		{
			int i = TuxWeaponsCore.harpoonEntity.recall();
			par1ItemStack.damageItem(i, par3EntityPlayer);
			par3EntityPlayer.swingItem();
		}

		else
		{
			par2World.playSoundAtEntity(par3EntityPlayer, "random.bow",
			        0.5F, 0.4F / (itemRand.nextFloat() * 0.4F + 0.8F));

                                if(par2World.isRemote)
			        par2World.spawnEntityInWorld(new EntityHarpoon(par2World,
			                par3EntityPlayer, 0.7F, 5));

			par3EntityPlayer.swingItem();
		}

	return par1ItemStack;
}

 

that may fix it, not too sure if that will work but give it a shot (don't have anything like this anymore for reference)

if not, play around with it just remember you only want to spawn the entity when world.isRemote = false (i.e. you're on the server), as this will send the relevant stuff to the client, also damage is only done on the server hence it wasn't doing damage as you only had it on the client.

 

not too sure about the other problem though...

Link to comment
Share on other sites

Ok I made HUGE changes to the harpoon code and I'm not sure what exactly you changed, it looks like you took out the 'if(par2World.isRemote)' at the top and moved it to only be above the spawn entity in world bit. When I tried those two changes the projectile briefly flashed in the corner of my screen and then disappeared. I believe you meant to have the exclamation mark before par2World because when I did that it did damage to enemies I aimed at but I couldn't see it, probably a problem with my rendering, should be a simple fix (However if you have any insight do share  ;D).

 

Anyway here's my whole EntitySpear code because I really want this fixed.

I still believe I need to use a packet but I'm not sure how.

 

package TuxWeapons.TuxCraft;

import java.util.Iterator;
import java.util.List;

import net.minecraft.block.Block;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.IProjectile;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.AxisAlignedBB;
import net.minecraft.util.DamageSource;
import net.minecraft.util.MathHelper;
import net.minecraft.util.MovingObjectPosition;
import net.minecraft.util.Vec3;
import net.minecraft.world.World;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class EntitySpear extends Entity implements IProjectile
{

private int xTile = -1;
private int yTile = -1;
private int zTile = -1;
private int inTile = 0;
private int inData = 0;
private boolean inGround = false;
private ItemStack stack;

/** 1 if the player can pick up the arrow */
public int canBePickedUp = 0;

/** Seems to be some sort of timer for animating an arrow. */
public int arrowShake = 0;

/** The owner of this arrow. */
public Entity owner;
private int ticksInGround;
private int ticksInAir = 0;
private double damage = 2.0D;

/** The amount of knockback an arrow applies when it hits a mob. */
private int knockbackStrength;

public EntitySpear(World par1World)
{

	super(par1World);
	this.setSize(0.5F, 0.5F);
}

public EntitySpear(World par1World, double par2, double par4, double par6)
{

	super(par1World);
	this.setSize(0.5F, 0.5F);
	this.setPosition(par2, par4, par6);
	this.yOffset = 0.0F;
}

public EntitySpear(World par1World, EntityLiving par2EntityLiving,
        EntityLiving par3EntityLiving, float par4, float par5)
{

	super(par1World);
	this.owner = par2EntityLiving;

	if (par2EntityLiving instanceof EntityPlayer)
	{
		this.canBePickedUp = 1;
	}

	this.posY = par2EntityLiving.posY + par2EntityLiving.getEyeHeight()
	        - 0.10000000149011612D;
	double var6 = par3EntityLiving.posX - par2EntityLiving.posX;
	double var8 = par3EntityLiving.posY + par3EntityLiving.getEyeHeight()
	        - 0.699999988079071D - this.posY;
	double var10 = par3EntityLiving.posZ - par2EntityLiving.posZ;
	double var12 = MathHelper.sqrt_double(var6 * var6 + var10 * var10);

	if (var12 >= 1.0E-7D)
	{
		float var14 = (float) (Math.atan2(var10, var6) * 180.0D / Math.PI) - 90.0F;
		float var15 = (float) -(Math.atan2(var8, var12) * 180.0D / Math.PI);
		double var16 = var6 / var12;
		double var18 = var10 / var12;
		this.setLocationAndAngles(par2EntityLiving.posX + var16, this.posY,
		        par2EntityLiving.posZ + var18, var14, var15);
		this.yOffset = 0.0F;
		float var20 = (float) var12 * 0.2F;
		this.setThrowableHeading(var6, var8 + var20, var10, par4, par5);
	}
}

public EntitySpear(World par1World, EntityLiving par2EntityLiving,
        float par3, ItemStack par4ItemStack)
{

	super(par1World);
	this.owner = par2EntityLiving;
	this.stack = par4ItemStack;

	if (par2EntityLiving instanceof EntityPlayer)
	{
		this.canBePickedUp = 1;
	}

	this.setSize(0.5F, 0.5F);
	this.setLocationAndAngles(par2EntityLiving.posX, par2EntityLiving.posY
	        + par2EntityLiving.getEyeHeight(), par2EntityLiving.posZ,
	        par2EntityLiving.rotationYaw, par2EntityLiving.rotationPitch);
	this.posX -= MathHelper
	        .cos(this.rotationYaw / 180.0F * (float) Math.PI) * 0.16F;
	this.posY -= 0.10000000149011612D;
	this.posZ -= MathHelper
	        .sin(this.rotationYaw / 180.0F * (float) Math.PI) * 0.16F;
	this.setPosition(this.posX, this.posY, this.posZ);
	this.yOffset = 0.0F;
	this.motionX = -MathHelper.sin(this.rotationYaw / 180.0F
	        * (float) Math.PI)
	        * MathHelper.cos(this.rotationPitch / 180.0F * (float) Math.PI);
	this.motionZ = MathHelper.cos(this.rotationYaw / 180.0F
	        * (float) Math.PI)
	        * MathHelper.cos(this.rotationPitch / 180.0F * (float) Math.PI);
	this.motionY = -MathHelper.sin(this.rotationPitch / 180.0F
	        * (float) Math.PI);
	this.setThrowableHeading(this.motionX, this.motionY, this.motionZ,
	        par3 * 1.5F, 1.0F);
}

@Override
protected void entityInit()
{

	this.dataWatcher.addObject(16, Byte.valueOf((byte) 0));
}

/**
 * Similar to setArrowHeading, it's point the throwable entity to a x, y, z
 * direction.
 */
@Override
public void setThrowableHeading(double var1, double var3, double var5,
        float var7, float var8)
{

	float var9 = MathHelper.sqrt_double(var1 * var1 + var3 * var3 + var5
	        * var5);
	var1 /= var9;
	var3 /= var9;
	var5 /= var9;
	var1 += this.rand.nextGaussian() * 0.007499999832361937D * var8;
	var3 += this.rand.nextGaussian() * 0.007499999832361937D * var8;
	var5 += this.rand.nextGaussian() * 0.007499999832361937D * var8;
	var1 *= var7;
	var3 *= var7;
	var5 *= var7;
	this.motionX = var1;
	this.motionY = var3;
	this.motionZ = var5;
	float var10 = MathHelper.sqrt_double(var1 * var1 + var5 * var5);
	this.prevRotationYaw = this.rotationYaw = (float) (Math.atan2(var1,
	        var5) * 180.0D / Math.PI);
	this.prevRotationPitch = this.rotationPitch = (float) (Math.atan2(var3,
	        var10) * 180.0D / Math.PI);
	this.ticksInGround = 0;
}

@Override
@SideOnly(Side.CLIENT)
/**
 * Sets the position and rotation. Only difference from the other one is no bounding on the rotation. Args: posX,
 * posY, posZ, yaw, pitch
 */
public void setPositionAndRotation2(double par1, double par3, double par5,
        float par7, float par8, int par9)
{

	this.setPosition(par1, par3, par5);
	this.setRotation(par7, par8);
}

@Override
@SideOnly(Side.CLIENT)
/**
 * Sets the velocity to the args. Args: x, y, z
 */
public void setVelocity(double par1, double par3, double par5)
{

	this.motionX = par1;
	this.motionY = par3;
	this.motionZ = par5;

	if (this.prevRotationPitch == 0.0F && this.prevRotationYaw == 0.0F)
	{
		float var7 = MathHelper.sqrt_double(par1 * par1 + par5 * par5);
		this.prevRotationYaw = this.rotationYaw = (float) (Math.atan2(par1,
		        par5) * 180.0D / Math.PI);
		this.prevRotationPitch = this.rotationPitch = (float) (Math.atan2(
		        par3, var7) * 180.0D / Math.PI);
		this.prevRotationPitch = this.rotationPitch;
		this.prevRotationYaw = this.rotationYaw;
		this.setLocationAndAngles(this.posX, this.posY, this.posZ,
		        this.rotationYaw, this.rotationPitch);
		this.ticksInGround = 0;
	}
}

/**
 * Called to update the entity's position/logic.
 */
@Override
public void onUpdate()
{

	super.onUpdate();

	if (this.prevRotationPitch == 0.0F && this.prevRotationYaw == 0.0F)
	{
		float var1 = MathHelper.sqrt_double(this.motionX * this.motionX
		        + this.motionZ * this.motionZ);
		this.prevRotationYaw = this.rotationYaw = (float) (Math.atan2(
		        this.motionX, this.motionZ) * 180.0D / Math.PI);
		this.prevRotationPitch = this.rotationPitch = (float) (Math.atan2(
		        this.motionY, var1) * 180.0D / Math.PI);
	}

	int var16 = this.worldObj
	        .getBlockId(this.xTile, this.yTile, this.zTile);

	if (var16 > 0)
	{
		Block.blocksList[var16].setBlockBoundsBasedOnState(this.worldObj,
		        this.xTile, this.yTile, this.zTile);
		AxisAlignedBB var2 = Block.blocksList[var16]
		        .getCollisionBoundingBoxFromPool(this.worldObj, this.xTile,
		                this.yTile, this.zTile);

		if (var2 != null
		        && var2.isVecInside(this.worldObj.getWorldVec3Pool()
		                .getVecFromPool(this.posX, this.posY, this.posZ)))
		{
			this.inGround = true;
		}
	}

	if (this.arrowShake > 0)
	{
		--this.arrowShake;
	}

	if (this.inGround)
	{
		int var18 = this.worldObj.getBlockId(this.xTile, this.yTile,
		        this.zTile);
		int var19 = this.worldObj.getBlockMetadata(this.xTile, this.yTile,
		        this.zTile);

		if (var18 == this.inTile && var19 == this.inData)
		{
			++this.ticksInGround;

			if (this.ticksInGround == 1200)
			{
				this.setDead();
			}
		} else
		{
			this.inGround = false;
			this.motionX *= this.rand.nextFloat() * 0.2F;
			this.motionY *= this.rand.nextFloat() * 0.2F;
			this.motionZ *= this.rand.nextFloat() * 0.2F;
			this.ticksInGround = 0;
			this.ticksInAir = 0;
		}
	} else
	{
		++this.ticksInAir;
		Vec3 var17 = this.worldObj.getWorldVec3Pool().getVecFromPool(
		        this.posX, this.posY, this.posZ);
		Vec3 var3 = this.worldObj.getWorldVec3Pool().getVecFromPool(
		        this.posX + this.motionX, this.posY + this.motionY,
		        this.posZ + this.motionZ);
		MovingObjectPosition var4 = this.worldObj.rayTraceBlocks_do_do(
		        var17, var3, false, true);
		var17 = this.worldObj.getWorldVec3Pool().getVecFromPool(this.posX,
		        this.posY, this.posZ);
		var3 = this.worldObj.getWorldVec3Pool().getVecFromPool(
		        this.posX + this.motionX, this.posY + this.motionY,
		        this.posZ + this.motionZ);

		if (var4 != null)
		{
			var3 = this.worldObj.getWorldVec3Pool().getVecFromPool(
			        var4.hitVec.xCoord, var4.hitVec.yCoord,
			        var4.hitVec.zCoord);
		}

		Entity var5 = null;
		List var6 = this.worldObj.getEntitiesWithinAABBExcludingEntity(
		        this,
		        this.boundingBox.addCoord(this.motionX, this.motionY,
		                this.motionZ).expand(1.0D, 1.0D, 1.0D));
		double var7 = 0.0D;
		Iterator var9 = var6.iterator();
		float var11;

		while (var9.hasNext())
		{
			Entity var10 = (Entity) var9.next();

			if (var10.canBeCollidedWith()
			        && (var10 != this.owner || this.ticksInAir >= 5))
			{
				var11 = 0.3F;
				AxisAlignedBB var12 = var10.boundingBox.expand(var11,
				        var11, var11);
				MovingObjectPosition var13 = var12.calculateIntercept(
				        var17, var3);

				if (var13 != null)
				{
					double var14 = var17.distanceTo(var13.hitVec);

					if (var14 < var7 || var7 == 0.0D)
					{
						var5 = var10;
						var7 = var14;
					}
				}
			}
		}

		if (var5 != null)
		{
			var4 = new MovingObjectPosition(var5);
		}

		float var20;

		if (var4 != null)
		{
			if (var4.entityHit != null)
			{
				var20 = MathHelper.sqrt_double(this.motionX * this.motionX
				        + this.motionY * this.motionY + this.motionZ
				        * this.motionZ);
				int var24 = MathHelper.ceiling_double_int(var20
				        * this.damage);

				if (this.getIsCritical())
				{
					var24 += this.rand.nextInt(var24 / 2 + 2);
				}

				DamageSource var22 = null;

				if (this.owner == null)
				{
					var22 = DamageSource.causeThrownDamage(this, this);
				} else
				{
					var22 = DamageSource
					        .causeThrownDamage(this, this.owner);
				}

				if (this.isBurning())
				{
					var4.entityHit.setFire(5);
				}

				if (var4.entityHit.attackEntityFrom(var22, var24))
				{
					if (var4.entityHit instanceof EntityLiving)
					{

						if (this.knockbackStrength > 0)
						{
							float var25 = MathHelper
							        .sqrt_double(this.motionX
							                * this.motionX + this.motionZ
							                * this.motionZ);

							if (var25 > 0.0F)
							{
								var4.entityHit.addVelocity(this.motionX
								        * this.knockbackStrength
								        * 0.6000000238418579D / var25,
								        0.1D, this.motionZ
								                * this.knockbackStrength
								                * 0.6000000238418579D
								                / var25);
							}
						}
					}

					this.worldObj.playSoundAtEntity(this, "random.bowhit",
					        1.0F,
					        1.2F / (this.rand.nextFloat() * 0.2F + 0.9F));
					this.setDead();
				} else
				{
					this.motionX *= -0.10000000149011612D;
					this.motionY *= -0.10000000149011612D;
					this.motionZ *= -0.10000000149011612D;
					this.rotationYaw += 180.0F;
					this.prevRotationYaw += 180.0F;
					this.ticksInAir = 0;
				}
			} else
			{
				this.xTile = var4.blockX;
				this.yTile = var4.blockY;
				this.zTile = var4.blockZ;
				this.inTile = this.worldObj.getBlockId(this.xTile,
				        this.yTile, this.zTile);
				this.inData = this.worldObj.getBlockMetadata(this.xTile,
				        this.yTile, this.zTile);
				this.motionX = (float) (var4.hitVec.xCoord - this.posX);
				this.motionY = (float) (var4.hitVec.yCoord - this.posY);
				this.motionZ = (float) (var4.hitVec.zCoord - this.posZ);
				var20 = MathHelper.sqrt_double(this.motionX * this.motionX
				        + this.motionY * this.motionY + this.motionZ
				        * this.motionZ);
				this.posX -= this.motionX / var20 * 0.05000000074505806D;
				this.posY -= this.motionY / var20 * 0.05000000074505806D;
				this.posZ -= this.motionZ / var20 * 0.05000000074505806D;
				this.worldObj.playSoundAtEntity(this, "random.bowhit",
				        1.0F, 1.2F / (this.rand.nextFloat() * 0.2F + 0.9F));
				this.inGround = true;
				this.arrowShake = 7;
				this.setIsCritical(false);
			}
		}

		if (this.getIsCritical())
		{
			for (int var21 = 0; var21 < 4; ++var21)
			{
				this.worldObj.spawnParticle("crit", this.posX
				        + this.motionX * var21 / 4.0D, this.posY
				        + this.motionY * var21 / 4.0D, this.posZ
				        + this.motionZ * var21 / 4.0D, -this.motionX,
				        -this.motionY + 0.2D, -this.motionZ);
			}
		}

		this.posX += this.motionX;
		this.posY += this.motionY;
		this.posZ += this.motionZ;
		var20 = MathHelper.sqrt_double(this.motionX * this.motionX
		        + this.motionZ * this.motionZ);
		this.rotationYaw = (float) (Math.atan2(this.motionX, this.motionZ) * 180.0D / Math.PI);

		for (this.rotationPitch = (float) (Math.atan2(this.motionY, var20) * 180.0D / Math.PI); this.rotationPitch
		        - this.prevRotationPitch < -180.0F; this.prevRotationPitch -= 360.0F)
		{
			;
		}

		while (this.rotationPitch - this.prevRotationPitch >= 180.0F)
		{
			this.prevRotationPitch += 360.0F;
		}

		while (this.rotationYaw - this.prevRotationYaw < -180.0F)
		{
			this.prevRotationYaw -= 360.0F;
		}

		while (this.rotationYaw - this.prevRotationYaw >= 180.0F)
		{
			this.prevRotationYaw += 360.0F;
		}

		this.rotationPitch = this.prevRotationPitch
		        + (this.rotationPitch - this.prevRotationPitch) * 0.2F;
		this.rotationYaw = this.prevRotationYaw
		        + (this.rotationYaw - this.prevRotationYaw) * 0.2F;
		float var23 = 0.99F;
		var11 = 0.05F;

		if (this.isInWater())
		{
			for (int var26 = 0; var26 < 4; ++var26)
			{
				float var27 = 0.25F;
				this.worldObj.spawnParticle("bubble", this.posX
				        - this.motionX * var27, this.posY - this.motionY
				        * var27, this.posZ - this.motionZ * var27,
				        this.motionX, this.motionY, this.motionZ);
			}

			var23 = 0.8F;
		}

		this.motionX *= var23;
		this.motionY *= var23;
		this.motionZ *= var23;
		this.motionY -= var11;
		this.setPosition(this.posX, this.posY, this.posZ);
		this.doBlockCollisions();
	}
}

/**
 * (abstract) Protected helper method to write subclass entity data to NBT.
 */
@Override
public void writeEntityToNBT(NBTTagCompound par1NBTTagCompound)
{

	par1NBTTagCompound.setShort("xTile", (short) this.xTile);
	par1NBTTagCompound.setShort("yTile", (short) this.yTile);
	par1NBTTagCompound.setShort("zTile", (short) this.zTile);
	par1NBTTagCompound.setByte("inTile", (byte) this.inTile);
	par1NBTTagCompound.setByte("inData", (byte) this.inData);
	par1NBTTagCompound.setByte("shake", (byte) this.arrowShake);
	par1NBTTagCompound.setByte("inGround", (byte) (this.inGround ? 1 : 0));
	par1NBTTagCompound.setByte("pickup", (byte) this.canBePickedUp);
	par1NBTTagCompound.setDouble("damage", this.damage);
}

/**
 * (abstract) Protected helper method to read subclass entity data from NBT.
 */
@Override
public void readEntityFromNBT(NBTTagCompound par1NBTTagCompound)
{

	this.xTile = par1NBTTagCompound.getShort("xTile");
	this.yTile = par1NBTTagCompound.getShort("yTile");
	this.zTile = par1NBTTagCompound.getShort("zTile");
	this.inTile = par1NBTTagCompound.getByte("inTile") & 255;
	this.inData = par1NBTTagCompound.getByte("inData") & 255;
	this.arrowShake = par1NBTTagCompound.getByte("shake") & 255;
	this.inGround = par1NBTTagCompound.getByte("inGround") == 1;

	if (par1NBTTagCompound.hasKey("damage"))
	{
		this.damage = par1NBTTagCompound.getDouble("damage");
	}

	if (par1NBTTagCompound.hasKey("pickup"))
	{
		this.canBePickedUp = par1NBTTagCompound.getByte("pickup");
	} else if (par1NBTTagCompound.hasKey("player"))
	{
		this.canBePickedUp = par1NBTTagCompound.getBoolean("player") ? 1
		        : 0;
	}
}

/**
 * Called by a player entity when they collide with an entity
 */
@Override
public void onCollideWithPlayer(EntityPlayer par1EntityPlayer)
{

	boolean flag = this.canBePickedUp == 1 || this.canBePickedUp == 2
	        && par1EntityPlayer.capabilities.isCreativeMode;

	if (this.inGround && this.arrowShake <= 0)
	{

		if (!this.worldObj.isRemote)
		{
			if (this.canBePickedUp == 1
			        && !par1EntityPlayer.inventory
			                .addItemStackToInventory(stack))
			{
				flag = false;
			}
		}

		if (flag)
		{
			this.playSound(
			        "random.pop",
			        0.2F,
			        ((this.rand.nextFloat() - this.rand.nextFloat()) * 0.7F + 1.0F) * 2.0F);
			par1EntityPlayer.onItemPickup(this, 1);
			this.setDead();
		}
	}

}

/**
 * returns if this entity triggers Block.onEntityWalking on the blocks they
 * walk on. used for spiders and wolves to
 * prevent them from trampling crops
 */
@Override
protected boolean canTriggerWalking()
{

	return false;
}

@Override
@SideOnly(Side.CLIENT)
public float getShadowSize()
{

	return 0.0F;
}

public void setDamage(double par1)
{

	this.damage = par1;
}

public double getDamage()
{

	return this.damage;
}

/**
 * Sets the amount of knockback the arrow applies when it hits a mob.
 */
public void setKnockbackStrength(int par1)
{

	this.knockbackStrength = par1;
}

/**
 * If returns false, the item will not inflict any damage against entities.
 */
@Override
public boolean canAttackWithItem()
{

	return false;
}

/**
 * Whether the arrow has a stream of critical hit particles flying behind
 * it.
 */
public void setIsCritical(boolean par1)
{

	byte var2 = this.dataWatcher.getWatchableObjectByte(16);

	if (par1)
	{
		this.dataWatcher.updateObject(16, Byte.valueOf((byte) (var2 | 1)));
	} else
	{
		this.dataWatcher.updateObject(16, Byte.valueOf((byte) (var2 & -2)));
	}
}

/**
 * Whether the arrow has a stream of critical hit particles flying behind
 * it.
 */
public boolean getIsCritical()
{

	byte var1 = this.dataWatcher.getWatchableObjectByte(16);
	return (var1 & 1) != 0;
}
}

 

Link to comment
Share on other sites

ok if it's not showing try scrapping the if(world.isRemote) completely. See what that does, I'm to too familiar with entities, it's been a while since I've done stuff with them and i don't have the files anymore :(

 

still don't know about the other one

Link to comment
Share on other sites

ok if it's not showing try scrapping the if(world.isRemote) completely. See what that does, I'm to too familiar with entities, it's been a while since I've done stuff with them and i don't have the files anymore :(

 

still don't know about the other one

 

Nope that doesn't work either. I'm pretty convinced that I need to send packets from the client to the server in order to do what I want but I have no idea how.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I am getting an error message that my mods and my server are not on the same minecraft version when they clearly are. My server and my mods are on 1.20.1 and the error says that the server is 1.20 even though it's on forge 47.2.30.  
    • .Omg, I'm so freaking blind I didn't notice that, it works now, thank you so much @Xoroshio
    • On the one off the last lines of code you have put && boots.isEmpty() Instead of && !boots.isEmpty() is that a typo?
    • I'm trying to apply effects to the emerald armor but it doesn't work, I read that the onArmorTick() method doesn't work anymore, but I tried with inventoryTick, onInventoryTick and onArmorTick but they don't apply the effect either, I don't know if I'm writing it wrong, so I need help to fix it. This is the code in question: public class ModArmorItem extends ArmorItem{ private static final Map<ArmorMaterial, MobEffectInstance> MATERIAL_TO_EFFECT_MAP = (new ImmutableMap.Builder<ArmorMaterial, MobEffectInstance>()) .put(ModArmorMaterials.EMERALD, new MobEffectInstance( MobEffects.HERO_OF_THE_VILLAGE, 200, 1, false, false, true)) .build(); public ModArmorItem(ArmorMaterial pMaterial, Type pType, Properties pProperties) { super(pMaterial, pType, pProperties); } @Override public void onArmorTick(ItemStack stack, Level world, Player player){ if (!world.isClientSide()) { if (hasFullSuitOfArmorOn(player)) { evaluateArmorEffects(player); } } } private void evaluateArmorEffects(Player player) { for (Map.Entry<ArmorMaterial,MobEffectInstance> entry : MATERIAL_TO_EFFECT_MAP.entrySet()){ ArmorMaterial mapArmorMaterial = entry.getKey(); MobEffectInstance mapStatusEffect = entry.getValue(); if (hasCorrectArmorOn(mapArmorMaterial, player)) { addStatusEffectForMaterial(player, mapArmorMaterial, mapStatusEffect); } } } private void addStatusEffectForMaterial(Player player, ArmorMaterial mapArmorMaterial, MobEffectInstance mapStatusEffect) { boolean hasPlayerEffect = player.hasEffect(mapStatusEffect.getEffect()); if (hasCorrectArmorOn(mapArmorMaterial, player) && !hasPlayerEffect) { player.addEffect(new MobEffectInstance(mapStatusEffect)); } } private boolean hasCorrectArmorOn(ArmorMaterial material, Player player) { for (ItemStack armorStack : player.getInventory().armor){ if (!(armorStack.getItem() instanceof ArmorItem)) { return false; } } ArmorItem helmet = ((ArmorItem)player.getInventory().getArmor(3).getItem()); ArmorItem brestplace = ((ArmorItem)player.getInventory().getArmor(2).getItem()); ArmorItem leggins = ((ArmorItem)player.getInventory().getArmor(1).getItem()); ArmorItem boots = ((ArmorItem)player.getInventory().getArmor(0).getItem()); return helmet.getMaterial() == material && brestplace.getMaterial() == material && leggins.getMaterial() == material && boots.getMaterial() == material; } private boolean hasFullSuitOfArmorOn(Player player){ ItemStack helmet = player.getInventory().getArmor(3); ItemStack breastplace = player.getInventory().getArmor(2); ItemStack leggins = player.getInventory().getArmor(1); ItemStack boots = player.getInventory().getArmor(0); return !helmet.isEmpty() && !breastplace.isEmpty() && !leggins.isEmpty() && boots.isEmpty(); } } And here is the armor   public static final RegistryObject<Item> EMERALD_HELMET = ITEMS.register( "emerald_helmet", () -> new ModArmorItem(ModArmorMaterials.EMERALD, ArmorItem.Type.HELMET, new Item.Properties()) ); public static final RegistryObject<Item> EMERALD_CHESTPLATE = ITEMS.register( "emerald_chestplate", () -> new ModArmorItem(ModArmorMaterials.EMERALD, ArmorItem.Type.CHESTPLATE, new Item.Properties()) ); public static final RegistryObject<Item> EMERALD_LEGGINS = ITEMS.register( "emerald_leggins", () -> new ModArmorItem(ModArmorMaterials.EMERALD, ArmorItem.Type.LEGGINGS, new Item.Properties()) ); public static final RegistryObject<Item> EMERALD_BOOTS = ITEMS.register( "emerald_boots", () -> new ModArmorItem(ModArmorMaterials.EMERALD, ArmorItem.Type.BOOTS, new Item.Properties()) ); I hope you can help me. Thanks.
    • so ive been having this issue for a little bit, and have honestly no clue on how to fix it. I'm using minecraft 1.20.1 for clarification.  Here is the latest log: https://pastebin.com/neMuxELv
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.