Jump to content

Changing the world serverside


MindLabor

Recommended Posts

I am new to MC Modding and I was trying to make that the hoe makes multiple farmland blocks at once. This resulted into ghost blocks where I called the Block.replaceBlock method. Then I saw on the documentation that one should distinguish between server and client side. So I added

if (world.isRemote()) return;

 to the start of the event method. This should return on clientside. But then it is not working anymore. Shouldn't changing blockstates be on serverside? Or is there something I am missing?

 

@SubscribeEvent
    public void onRightClickBlock(final PlayerInteractEvent.RightClickBlock event) {
        World world = event.getWorld();
        if (world.isRemote()) return;

        PlayerEntity player = event.getPlayer();
        Item tool = player.getHeldItem(event.getHand()).getItem();
        BlockPos pos = event.getPos();
        Block block = world.getBlockState(pos).getBlock();

        boolean isHoe = tool.getRegistryName().toString().endsWith("_hoe");
        if (!(isHoe && canTurnToFarmland(block))) return;

        BlockPos[] targetPositions = new BlockPos[]{ pos.east(), pos.north(), pos.west(), pos.south()};
        for (BlockPos bp : targetPositions) {
            Block currentBlock = world.getBlockState(bp).getBlock();
            if (!canTurnToFarmland(currentBlock) || new Random().nextDouble() > 0.6) continue;

            Block.replaceBlock(
                    world.getBlockState(bp),
                    Blocks.FARMLAND.getDefaultState(),
                    world, bp, 1
            );
        }

        ItemStack stack = new ItemStack(tool);
        tool.setDamage(stack, tool.getDamage(stack)-30);
    }

    private boolean canTurnToFarmland(Block block) {
        return block == Blocks.DIRT || block == Blocks.GRASS_BLOCK || block == Blocks.GRASS_PATH;
    }

 

Link to comment
Share on other sites

1 hour ago, Beethoven92 said:

Take a look at flags usage in World#setBlockState function...the Block.replaceBlock function uses flags the same way. Also you can subscribe to the UseHoeEvent instead of the RIghtClickBlock event

* 1 will cause a block update.
* 2 will send the change to clients.
* 4 will prevent the block from being re-rendered.
* 8 will force any re-renders to run on the main thread instead
* 16 will prevent neighbor reactions (e.g. fences connecting, observers pulsing).
* 32 will prevent neighbor reactions from spawning drops.
* 64 will signify the block is being moved.

I tried with the flags 1 and 2:

Block.replaceBlock(
                    world.getBlockState(bp),
                    Blocks.FARMLAND.getDefaultState(),
                    world, bp, 1 | 2
            );

 

And it doesn't seem to have worked. I still have ghost blocks (even tried a fresh world). Which flags should I use?

 

PS: The UseHoeEvent is deprected:

@Cancelable
@HasResult
@Deprecated
public class UseHoeEvent extends PlayerEvent

 

EDIT: 

It works now on serverside, since flag 2 sends the change to the client. But there still are ghost blocks (it gets very laggy when a run on the created farmland, its like walking through thick transparent laggy liquid, but you are able to walk through eventually)

 

Edited by MindLabor
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.