Jump to content

About Screen and ContainerScreen


nooblong
 Share

Recommended Posts

I found a very stupid way to save my (Screen) data for each block instead of using (ContainerScreen)

public class Mp3Gui extends Screen {

...

public class BlockMp3 extends BlockBase {
    @Override
    public ActionResultType onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit) {
        if (!worldIn.isRemote){
            Mp3TileEntity t = (Mp3TileEntity) worldIn.getTileEntity(pos);
            System.out.println("server send Gui packet");
            MySimpleNetworkHandler.INSTANCE.send(PacketDistributor.PLAYER.with(() -> (ServerPlayerEntity)player), new GuiDataPacket(my gui data);
            return ActionResultType.SUCCESS;
        } else {
            f(worldIn,pos);
        }
        return ActionResultType.SUCCESS;
    }
//Use this to cheat the inspection
    @OnlyIn(Dist.CLIENT)
    private static void f(World worldIn, BlockPos pos){
        System.out.println("client open gui");
        Mp3Gui mp3Gui = new Mp3Gui((Mp3TileEntity) worldIn.getTileEntity(pos));
        Minecraft.getInstance().displayGuiScreen(mp3Gui);
    }

and in dataPacket

public class GuiDataPacket {
public static void handle(GuiDataPacket msg, Supplier<NetworkEvent.Context> ctx) {
        ctx.get().enqueueWork(() -> {
            World world;
            try {
                //clint to server
                ServerPlayerEntity sender = ctx.get().getSender();
  //at client it will produce null pointer exception
                world = sender.world;
            } catch (NullPointerException e){
                //server to client
                world = getClientWorld();
            }
            if (!world.isRemote) {
                System.out.println("server receive gui packet");
                if (world.getTileEntity(msg.blockPos) instanceof Mp3TileEntity) {
                    Mp3TileEntity mp3TileEntity = ((Mp3TileEntity) world.getTileEntity(msg.blockPos));
                    set my tile entity
                }
            }
            if (world.isRemote){
                System.out.println("client receive gui packet");
                if (world.getTileEntity(msg.blockPos) instanceof Mp3TileEntity) {
                    Mp3TileEntity mp3TileEntity = ((Mp3TileEntity) world.getTileEntity(msg.blockPos));
                    set my tile entity
                }
            }

        });
        ctx.get().setPacketHandled(true);
    }
  //Use this to cheat the inspection
  @OnlyIn(Dist.CLIENT)
    private static World getClientWorld(){
        return Minecraft.getInstance().world;
    }

it does work.

Edited by nooblong
Link to comment
Share on other sites

2 minutes ago, nooblong said:

} catch (NullPointerException e){

You gotta be joking me. This is never ever the right approach.

 

2 minutes ago, nooblong said:

//Use this to cheat the inspection

@OnlyIn(Dist.CLIENT)

Do not use @OnlyIn. Also no idea what that comment is meant to mean.

 

Your message allows a malicious client to modify the data of any tile entity, regardless of how close they are to it. This is why you need a Container, to actually track on the server if the screen is open and if the player is still near it.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.