Jump to content
Currently Supported: 1.20.x (Latest), 1.19.x (LTS)
Search the Forums BEFORE making a new post.

Getting an Error when I try to open my custom GUI in game

TheMajorN

By TheMajorN
in Modder Support

 Share

Recommended Posts

TheMajorN Stone Miner

TheMajorN

Posted
Posted

Heya,

So, I tried making a GUI in minecraft, and everything was going smoothly, it all compiled, and Minecraft ran without a problem.

 

However, when I actually tried to right click the block, instead of opening the GUI, nothing happened and the debug console greeted me with this message:

 

[15:30:04] [Server thread/FATAL] [minecraft/ThreadTaskExecutor]: Error executing task on Server
java.lang.UnsupportedOperationException: Unable to construct this menu by type
    at net.minecraft.inventory.container.Container.getType(Container.java:56) ~[forge:?] {re:classloading}
    at net.minecraftforge.fml.network.NetworkHooks.openGui(NetworkHooks.java:223) ~[forge:?] {re:classloading}
    at net.minecraftforge.fml.network.NetworkHooks.openGui(NetworkHooks.java:188) ~[forge:?] {re:classloading}
    at com.thamajorn.scullery.procedures.OpenProcedure.executeProcedure(OpenProcedure.java:63) ~[?:?] {re:classloading}
    at com.thamajorn.scullery.blocks.Cuttingboard.onBlockActivated(Cuttingboard.java:103) ~[?:?] {re:classloading}
    at net.minecraft.block.AbstractBlock$AbstractBlockState.onBlockActivated(AbstractBlock.java:730) ~[forge:?] {re:classloading}
    at net.minecraft.server.management.PlayerInteractionManager.func_219441_a(PlayerInteractionManager.java:347) ~[forge:?] {re:classloading}
    at net.minecraft.network.play.ServerPlayNetHandler.processTryUseItemOnBlock(ServerPlayNetHandler.java:986) ~[forge:?] {re:classloading}
    at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.processPacket(CPlayerTryUseItemOnBlockPacket.java:45) ~[forge:?] {re:classloading}
    at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.processPacket(CPlayerTryUseItemOnBlockPacket.java:12) ~[forge:?] {re:classloading}
    at net.minecraft.network.PacketThreadUtil.lambda$checkThreadAndEnqueue$0(PacketThreadUtil.java:19) ~[forge:?] {re:classloading}
    at net.minecraft.util.concurrent.TickDelayedTask.run(TickDelayedTask.java:20) ~[forge:?] {re:classloading}
    at net.minecraft.util.concurrent.ThreadTaskExecutor.run(ThreadTaskExecutor.java:139) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.util.concurrent.RecursiveEventLoop.run(RecursiveEventLoop.java:22) ~[forge:?] {re:classloading}
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:758) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:159) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.util.concurrent.ThreadTaskExecutor.driveOne(ThreadTaskExecutor.java:109) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.driveOneInternal(MinecraftServer.java:741) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.driveOne(MinecraftServer.java:735) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.util.concurrent.ThreadTaskExecutor.driveUntil(ThreadTaskExecutor.java:122) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.runScheduledTasks(MinecraftServer.java:721) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:667) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at net.minecraft.server.MinecraftServer.lambda$startServer$0(MinecraftServer.java:233) ~[forge:?] {re:classloading,pl:accesstransformer:B}
    at java.lang.Thread.run(Thread.java:748) [?:1.8.0_261] {}

 

The game never crashed or anything, it would just give that message whenever I right clicked the block.

If anyone can help or at least point me in the right direction, that would be much appreciated!

Link to comment
Share on other sites
ChampionAsh5357 Reality Controller

ChampionAsh5357

Posted
Posted

Yep, you don't properly register the ContainerType. You are calling the initialization before the ContainerType is even registered. This is not to mention that the container type will remain null until the constructor is called.

 

This also brings up logical sides and handling. You are trying to construct a random instance without a true container and compressing them all into one file. Please properly adhere to separation of concerns. There are a few issues, but technically, it will work regardless of the non-forge way of handling.

 

 

Link to comment
Share on other sites
TheMajorN Stone Miner

TheMajorN

Posted
  • Author
Posted (edited)

Thank you so much for the tips, so I should move the init method to after the container type register?

 

Also, how should I better adhere to the separation of concerns?

 

Sorry for all the questions, I'm still fairly new to this.

 

Thanks again!

Edited by TheMajorN
Link to comment
Share on other sites
ChampionAsh5357 Reality Controller

ChampionAsh5357

Posted
Posted
9 minutes ago, TheMajorN said:

Thank you so much for the tips, so I should move the init method to after the container type register?

Well the initialization method holds a client only method for registering screens which would be handled in FMLClientSetupEvent. It should also use enqueueWork which is provided by the event itself instead of calling DeferredWorkQueue directly.

 

11 minutes ago, TheMajorN said:

Also, how should I better adhere to the separation of concerns?

I would suggest reading about it and determining for yourself. In the most cases, client, common, and dedicated server code should be separated. Also, you might want to consider renaming your classes to better match the current class names of Forge.

 

12 minutes ago, TheMajorN said:

Sorry for all the questions, I'm still fairly new to this.

It's perfectly fine. As long as you understand the underlying language, we can explain how it works.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing


  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • TileEntity
      Error loading mods: I Like Wood has failed to load correctly

      By TileEntity · Posted

      Make a test without practical_plushies_mobs, practical_plushies_animals and dark-waters - looks like it is not working with sinytra connector
    • hicolis184
      VIP Call Girlfriend in Abu Dhabi ☮➡+971557861567(㎓) Escorts In Abu Dhabi

      By hicolis184 · Posted

      VIP Call Girlfriend in Abu Dhabi ☮➡+971557861567(㎓) Escorts In Abu Dhabi   VIP Call Girlfriend in Abu Dhabi ☮➡+971557861567(㎓) Escorts In Abu Dhabi   VIP Call Girlfriend in Abu Dhabi ☮➡+971557861567(㎓) Escorts In Abu Dhabi
    • Bozka
      Error loading mods: I Like Wood has failed to load correctly

      By Bozka · Posted

      Maybe your file codes are missing. Therefore it is crashing.
    • CatDoodle
      CurseForge 1.19.2 mod pack, exit code 1

      By CatDoodle · Posted

      I've been trying to make a mod pack for the last day or so now and I haven't been able to launch it once even with all mods disabled. It keeps showing up with Exit Code 1. I gave the modpack to a friend to try and it didn't launch on their pc either due to the same exit code, so I'm not entirely certain what the problem is or how to check it in the logs. So far I've attempted: - Changing from forge version 43.3.0 to 43.3.5 - Downloading Java - Disabling mods (both entirely and individually) I have an NVIDIA GeForce GTX 1070 driver, and I haven't tried to uninstall or reinstall it yet because I'm not certain how to and would have to mess anything up further. I have the latest .txt file of the crash report here: [16:24:34] [main/WARN]: Failed to add PDH Counter: \Paging File(_Total)\% Usage, Error code: 0xC0000BB8 [16:24:34] [main/WARN]: Failed to add counter for PDH counter: \Paging File(_Total)\% Usage [16:24:34] [main/WARN]: Disabling further attempts to query Paging File. [16:24:36] [main/WARN]: COM exception: Invalid Query: SELECT PERCENTUSAGE FROM Win32_PerfRawData_PerfOS_PagingFile [16:24:39] [Datafixer Bootstrap/INFO]: 198 Datafixer optimizations took 149 milliseconds [16:24:40] [Render thread/INFO]: Environment: Environment[sessionHost=https://sessionserver.mojang.com, servicesHost=https://api.minecraftservices.com, name=PROD] [16:24:40] [Render thread/INFO]: Setting user: CatDoodlee [16:24:41] [Render thread/INFO]: Backend library: LWJGL version 3.3.2+13 [16:24:42] [Render thread/INFO]: Reloading ResourceManager: vanilla [16:24:42] [Worker-Main-11/INFO]: Found unifont_all_no_pua-15.1.04.hex, loading [16:24:44] [Render thread/WARN]: Missing sound for event: minecraft:item.goat_horn.play [16:24:44] [Render thread/WARN]: Missing sound for event: minecraft:entity.goat.screaming.horn_break [16:24:44] [Render thread/INFO]: OpenAL initialized on device OpenAL Soft on Speakers (Atrix Wired Elite Headset) [16:24:44] [Render thread/INFO]: Sound engine started [16:24:44] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/blocks.png-atlas [16:24:44] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/signs.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas [16:24:44] [Render thread/INFO]: Created: 1024x1024x4 minecraft:textures/atlas/armor_trims.png-atlas [16:24:44] [Render thread/INFO]: Created: 128x64x4 minecraft:textures/atlas/decorated_pot.png-atlas [16:24:44] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas [16:24:44] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas [16:24:45] [Render thread/WARN]: Shader rendertype_entity_translucent_emissive could not find sampler named Sampler2 in the specified shader program. [16:24:45] [Render thread/INFO]: Created: 512x256x0 minecraft:textures/atlas/particles.png-atlas [16:24:45] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas [16:24:45] [Render thread/INFO]: Created: 128x128x0 minecraft:textures/atlas/mob_effects.png-atlas [16:24:45] [Render thread/INFO]: Created: 1024x512x0 minecraft:textures/atlas/gui.png-atlas [16:25:41] [Render thread/INFO]: Stopping! any form of help is greatly appreciated ❤️
    • pizzakid12345
      bowl, bucket, clock, compass, fishing rod, flint and steel, fire charge, shears, axe, hoe, pickaxe, or shovel.

      By pizzakid12345 · Posted

      😗

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept