Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

How would I make an entity save a float value?

I have looked into capabilities, but they seem a little to complicated to save a single float. 

  • Author

 

public class Car extends AbstractChestedHorseEntity {
    public boolean outofgas;
    private boolean particle_reducer;
   // public static final DataParameter<Float> health = EntityDataManager.createKey(Car.class, DataSerializers.FLOAT);

    public Car(EntityType<? extends Car> type, World worldIn) {
        super(type, worldIn);
        this.outofgas = false;
        this.particle_reducer = false;
    }

    //forgot to do super.registerAttributes() [Sorry]
    @Override
    protected void registerAttributes() {
        this.getAttributes().registerAttribute(SharedMonsterAttributes.MAX_HEALTH);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.MOVEMENT_SPEED);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.FOLLOW_RANGE);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.KNOCKBACK_RESISTANCE);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.ARMOR);
        this.getAttributes().registerAttribute(LivingEntity.SWIM_SPEED);
        this.getAttributes().registerAttribute(LivingEntity.ENTITY_GRAVITY);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.ARMOR_TOUGHNESS);
        this.getAttribute(SharedMonsterAttributes.KNOCKBACK_RESISTANCE).setBaseValue(1.0F);
        this.getAttribute(SharedMonsterAttributes.MOVEMENT_SPEED).setBaseValue(0.4F);
        this.getAttribute(SharedMonsterAttributes.MAX_HEALTH).setBaseValue(40.0F);
        this.getAttribute(SharedMonsterAttributes.FOLLOW_RANGE).setBaseValue(0.0F);
        this.getAttribute(SharedMonsterAttributes.ARMOR).setBaseValue(2.0F);
        this.getAttribute(SharedMonsterAttributes.ARMOR_TOUGHNESS).setBaseValue(2.0F);
        this.getAttribute(LivingEntity.SWIM_SPEED).setBaseValue(0.05F);
    }

    @Override
    protected void registerData() {
        super.registerData();
       // this.dataManager.register(health, 20.0F);
    }

    @Override
    protected void registerGoals() {

    }



    @Override
    public boolean canBeLeashedTo(PlayerEntity player) {
        return false;

    }

    @Override
    public void readAdditional(@NotNull CompoundNBT compound) {
        super.readAdditional(compound);
        this.setFuelValue(compound.getFloat("movedDistance"));
    }

    @Override
    public void writeAdditional(@NotNull CompoundNBT compound) {
        super.writeAdditional(compound);
        compound.putFloat("movedDistance", this.movedDistance);
    }



    @Override
    public void tick() {
        super.tick();
        outofgas = this.movedDistance > 2000;
        this.particle_reducer = !this.particle_reducer;
        ClientWorld world = Minecraft.getInstance().world;
        Vec3d vec = new Vec3d(this.getPosX(),this.getPosY(), this.getPosZ());
        Vec3d speedvec = new Vec3d(-0.3d, 0.2d, 0d);
        vec.add(this.getLookVec());
        if(world != null && !this.outofgas && this.particle_reducer)
            world.addParticle(ParticleTypes.SQUID_INK, vec.x, vec.y, vec.z, speedvec.x, speedvec.y, speedvec.z);
       // this.setHealth(this.getDataManager().get(Car.health));
    }


    public float getMovedDistance(){
        return this.movedDistance;
    }

    public void Refuel(){
        this.distanceWalkedModified = 0;
        this.distanceWalkedOnStepModified = 0;
        this.prevDistanceWalkedModified = 0;
        this.prevMovedDistance = 0;
        this.movedDistance = 0;
        LOGGER.info("REFUELED");
    }

    public void setFuelValue(float value){
        this.distanceWalkedModified = value;
        this.distanceWalkedOnStepModified = value;
        this.prevDistanceWalkedModified = value;
        this.prevMovedDistance = value;
        this.movedDistance = value;
    }


    @Override
    protected boolean canMate() {
        return false;
    }

    @Override
    public boolean canBreed() {
        return false;
    }


    @Nullable
    @Override
    protected SoundEvent getDeathSound() {
        return null;
    }

    @Nullable
    @Override
    protected SoundEvent getAmbientSound() {
        return null;
    }

    @Nullable
    @Override
    protected SoundEvent getHurtSound(DamageSource damageSourceIn) {
        return null;
    }

    @Override
    protected void playStepSound(BlockPos pos, BlockState blockIn) {
        // this.playSound(ModSoundEvents.MOVING_CAR, 0.5F, 1.0F);

    }

    @Override
    public void setMoveStrafing(float amount) {}

    @Override
    public boolean hasChest() {
        return true;
    }

    @Override
    public boolean isTame() {
        return true;
    }

    @Override
    public boolean canEatGrass() {
        return false;
    }

    @Override
    public boolean isHorseSaddled() {
        return !this.outofgas;
    }

    @Override
    public boolean canBeSteered() {
        return !this.outofgas;
    }

    @Override
    public boolean isBreedingItem(@NotNull ItemStack stack) {
        return false;
    }



    @Override
    public boolean wearsArmor() {
        return false;
    }

    @Override
    public boolean canDespawn(double distanceToClosestPlayer) {
        return false;
    }



    @Override
    public boolean canJump() {
        return false;
    }

    @Override
    public boolean canBeRiddenInWater() {
        return false;
    }

    @Override
    public boolean canBePushed() {
        return false;
    }

    @Override
    public boolean canBeSaddled() {
        return false;
    }

    @Override
    protected int getInventorySize() {
        return 29;
    }

    @Override
    public int getInventoryColumns() {
        return 9;
    }
}
  • Author

are you sure about that, because its just text:

@SubscribeEvent
public void onRenderGui(RenderGameOverlayEvent.Post event){
    Minecraft minecraft = Minecraft.getInstance();
    if (event.isCancelable() || event.getType() != RenderGameOverlayEvent.ElementType.EXPERIENCE) {
        return;
    }
    FontRenderer font = minecraft.fontRenderer;
    PlayerEntity player = minecraft.player;
    if(player == null)
        return;
    LivingEntity RidingEntity = (LivingEntity)player.getRidingEntity();
    if(RidingEntity != null) {
        if (RidingEntity instanceof Car) {
            Car car = (Car) RidingEntity;
            ChatFormatting chat = (car.getMovedDistance() > 1500) ? ChatFormatting.RED : ChatFormatting.GREEN;
            font.drawStringWithShadow(chat + "Fuel:" + (2000-car.getMovedDistance())/20 + "%", 5, 5, 0);
        }
    }
    Entity entity = minecraft.pointedEntity;
    if(entity instanceof PlaceholderEntity){
        ChatFormatting chat = ChatFormatting.GREEN;
        font.drawStringWithShadow(chat+"Entity ID:"+entity.getEntityId(), 5,5, 0);
    }
}
  • Author
//updated code
public class Car extends AbstractChestedHorseEntity {
    public boolean outofgas;
    private boolean particle_reducer;
   public static final DataParameter<Float> Fuel = EntityDataManager.createKey(Car.class, DataSerializers.FLOAT);

    public Car(EntityType<? extends Car> type, World worldIn) {
        super(type, worldIn);
        this.outofgas = false;
        this.particle_reducer = false;
    }

    //forgot to do super.registerAttributes() [Sorry]
    @Override
    protected void registerAttributes() {
        this.getAttributes().registerAttribute(SharedMonsterAttributes.MAX_HEALTH);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.MOVEMENT_SPEED);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.FOLLOW_RANGE);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.KNOCKBACK_RESISTANCE);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.ARMOR);
        this.getAttributes().registerAttribute(LivingEntity.SWIM_SPEED);
        this.getAttributes().registerAttribute(LivingEntity.ENTITY_GRAVITY);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.ARMOR_TOUGHNESS);
        this.getAttribute(SharedMonsterAttributes.KNOCKBACK_RESISTANCE).setBaseValue(1.0F);
        this.getAttribute(SharedMonsterAttributes.MOVEMENT_SPEED).setBaseValue(0.4F);
        this.getAttribute(SharedMonsterAttributes.MAX_HEALTH).setBaseValue(40.0F);
        this.getAttribute(SharedMonsterAttributes.FOLLOW_RANGE).setBaseValue(0.0F);
        this.getAttribute(SharedMonsterAttributes.ARMOR).setBaseValue(2.0F);
        this.getAttribute(SharedMonsterAttributes.ARMOR_TOUGHNESS).setBaseValue(2.0F);
        this.getAttribute(LivingEntity.SWIM_SPEED).setBaseValue(0.05F);
    }

    @Override
    protected void registerData() {
        super.registerData();
        this.dataManager.register(Fuel, 0.0F);
    }

    @Override
    protected void registerGoals() {

    }



    @Override
    public boolean canBeLeashedTo(PlayerEntity player) {
        return false;

    }

    @Override
    public void readAdditional(@NotNull CompoundNBT compound) {
        super.readAdditional(compound);
        this.setFuelValue(compound.getFloat("movedDistance"));
    }

    @Override
    public void writeAdditional(@NotNull CompoundNBT compound) {
        super.writeAdditional(compound);
        compound.putFloat("movedDistance", this.movedDistance);
    }



    @Override
    public void tick() {
        super.tick();
        outofgas = this.movedDistance > 2000;
        this.particle_reducer = !this.particle_reducer;
        ClientWorld world = Minecraft.getInstance().world;
        Vec3d vec = new Vec3d(this.getPosX(),this.getPosY(), this.getPosZ());
        Vec3d speedvec = new Vec3d(-0.3d, 0.2d, 0d);
        vec.add(this.getLookVec());
        this.getDataManager().set(Fuel, this.movedDistance);
        if(world != null && !this.outofgas && this.particle_reducer)
            world.addParticle(ParticleTypes.SQUID_INK, vec.x, vec.y, vec.z, speedvec.x, speedvec.y, speedvec.z);
       // this.setHealth(this.getDataManager().get(Car.health));
    }


    public void Refuel(){
        this.distanceWalkedModified = 0;
        this.distanceWalkedOnStepModified = 0;
        this.prevDistanceWalkedModified = 0;
        this.prevMovedDistance = 0;
        this.movedDistance = 0;
        LOGGER.info("REFUELED");
    }

    public void setFuelValue(float value){
        this.distanceWalkedModified = value;
        this.distanceWalkedOnStepModified = value;
        this.prevDistanceWalkedModified = value;
        this.prevMovedDistance = value;
        this.movedDistance = value;
    }


    @Override
    protected boolean canMate() {
        return false;
    }

    @Override
    public boolean canBreed() {
        return false;
    }


    @Nullable
    @Override
    protected SoundEvent getDeathSound() {
        return null;
    }

    @Nullable
    @Override
    protected SoundEvent getAmbientSound() {
        return null;
    }

    @Nullable
    @Override
    protected SoundEvent getHurtSound(DamageSource damageSourceIn) {
        return null;
    }

    @Override
    protected void playStepSound(BlockPos pos, BlockState blockIn) {
        // this.playSound(ModSoundEvents.MOVING_CAR, 0.5F, 1.0F);

    }

    @Override
    public void setMoveStrafing(float amount) {}

    @Override
    public boolean hasChest() {
        return true;
    }

    @Override
    public boolean isTame() {
        return true;
    }

    @Override
    public boolean canEatGrass() {
        return false;
    }

    @Override
    public boolean isHorseSaddled() {
        return !this.outofgas;
    }

    @Override
    public boolean canBeSteered() {
        return !this.outofgas;
    }

    @Override
    public boolean isBreedingItem(@NotNull ItemStack stack) {
        return false;
    }



    @Override
    public boolean wearsArmor() {
        return false;
    }

    @Override
    public boolean canDespawn(double distanceToClosestPlayer) {
        return false;
    }



    @Override
    public boolean canJump() {
        return false;
    }

    @Override
    public boolean canBeRiddenInWater() {
        return false;
    }

    @Override
    public boolean canBePushed() {
        return false;
    }

    @Override
    public boolean canBeSaddled() {
        return false;
    }

    @Override
    protected int getInventorySize() {
        return 29;
    }

    @Override
    public int getInventoryColumns() {
        return 9;
    }
}

Edited by someRandomKid

  • Author

oh wait I just realized how dumb I was

this is what it should be:

this.dataManager.register(Fuel, this.movedDistance);

 

Edited by someRandomKid

  • Author

updated code:

package com.new_swords.Entities;

import net.minecraft.block.BlockState;
import net.minecraft.client.Minecraft;
import net.minecraft.client.world.ClientWorld;
import net.minecraft.entity.EntityType;
import net.minecraft.entity.LivingEntity;
import net.minecraft.entity.SharedMonsterAttributes;
import net.minecraft.entity.passive.horse.AbstractChestedHorseEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.CompoundNBT;
import net.minecraft.network.datasync.DataParameter;
import net.minecraft.network.datasync.DataSerializers;
import net.minecraft.network.datasync.EntityDataManager;
import net.minecraft.particles.ParticleTypes;
import net.minecraft.util.DamageSource;
import net.minecraft.util.SoundEvent;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.Vec3d;
import net.minecraft.world.World;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

public class Car extends AbstractChestedHorseEntity {
    public boolean outofgas;
    private boolean particle_reducer;
   public static final DataParameter<Float> Fuel = EntityDataManager.createKey(Car.class, DataSerializers.FLOAT);

    public Car(EntityType<? extends Car> type, World worldIn) {
        super(type, worldIn);
        this.outofgas = false;
        this.particle_reducer = false;
    }

    //forgot to do super.registerAttributes() [Sorry]
    @Override
    protected void registerAttributes() {
        this.getAttributes().registerAttribute(SharedMonsterAttributes.MAX_HEALTH);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.MOVEMENT_SPEED);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.FOLLOW_RANGE);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.KNOCKBACK_RESISTANCE);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.ARMOR);
        this.getAttributes().registerAttribute(LivingEntity.SWIM_SPEED);
        this.getAttributes().registerAttribute(LivingEntity.ENTITY_GRAVITY);
        this.getAttributes().registerAttribute(SharedMonsterAttributes.ARMOR_TOUGHNESS);
        this.getAttribute(SharedMonsterAttributes.KNOCKBACK_RESISTANCE).setBaseValue(1.0F);
        this.getAttribute(SharedMonsterAttributes.MOVEMENT_SPEED).setBaseValue(0.4F);
        this.getAttribute(SharedMonsterAttributes.MAX_HEALTH).setBaseValue(40.0F);
        this.getAttribute(SharedMonsterAttributes.FOLLOW_RANGE).setBaseValue(0.0F);
        this.getAttribute(SharedMonsterAttributes.ARMOR).setBaseValue(2.0F);
        this.getAttribute(SharedMonsterAttributes.ARMOR_TOUGHNESS).setBaseValue(2.0F);
        this.getAttribute(LivingEntity.SWIM_SPEED).setBaseValue(0.05F);
    }

    @Override
    protected void registerData() {
        super.registerData();
        this.dataManager.register(Fuel, this.movedDistance);
    }

    @Override
    protected void registerGoals() {

    }



    @Override
    public boolean canBeLeashedTo(PlayerEntity player) {
        return false;

    }

    @Override
    public void readAdditional(@NotNull CompoundNBT compound) {
        super.readAdditional(compound);
        this.setFuelValue(compound.getFloat("movedDistance"));
    }

    @Override
    public void writeAdditional(@NotNull CompoundNBT compound) {
        super.writeAdditional(compound);
        compound.putFloat("movedDistance", this.movedDistance);
    }



    @Override
    public void tick() {
        super.tick();
        outofgas = this.movedDistance > 2000;
        this.particle_reducer = !this.particle_reducer;
        World world = this.getEntityWorld();
        Vec3d vec = new Vec3d(this.getPosX(),this.getPosY(), this.getPosZ());
        Vec3d speedvec = new Vec3d(-0.3d, 0.2d, 0d);
        vec.add(this.getLookVec());
        this.getDataManager().set(Fuel, this.movedDistance);
        if(!this.outofgas && this.particle_reducer)
            world.addParticle(ParticleTypes.SQUID_INK, vec.x, vec.y, vec.z, speedvec.x, speedvec.y, speedvec.z);
       // this.setHealth(this.getDataManager().get(Car.health));
    }


    public void Refuel(){
        this.distanceWalkedModified = 0;
        this.distanceWalkedOnStepModified = 0;
        this.prevDistanceWalkedModified = 0;
        this.prevMovedDistance = 0;
        this.movedDistance = 0;
        LOGGER.info("REFUELED");
    }

    public void setFuelValue(float value){
        this.distanceWalkedModified = value;
        this.distanceWalkedOnStepModified = value;
        this.prevDistanceWalkedModified = value;
        this.prevMovedDistance = value;
        this.movedDistance = value;
    }


    @Override
    protected boolean canMate() {
        return false;
    }

    @Override
    public boolean canBreed() {
        return false;
    }


    @Nullable
    @Override
    protected SoundEvent getDeathSound() {
        return null;
    }

    @Nullable
    @Override
    protected SoundEvent getAmbientSound() {
        return null;
    }

    @Nullable
    @Override
    protected SoundEvent getHurtSound(DamageSource damageSourceIn) {
        return null;
    }

    @Override
    protected void playStepSound(BlockPos pos, BlockState blockIn) {
        // this.playSound(ModSoundEvents.MOVING_CAR, 0.5F, 1.0F);

    }

    @Override
    public void setMoveStrafing(float amount) {}

    @Override
    public boolean hasChest() {
        return true;
    }

    @Override
    public boolean isTame() {
        return true;
    }

    @Override
    public boolean canEatGrass() {
        return false;
    }

    @Override
    public boolean isHorseSaddled() {
        return !this.outofgas;
    }

    @Override
    public boolean canBeSteered() {
        return !this.outofgas;
    }

    @Override
    public boolean isBreedingItem(@NotNull ItemStack stack) {
        return false;
    }



    @Override
    public boolean wearsArmor() {
        return false;
    }

    @Override
    public boolean canDespawn(double distanceToClosestPlayer) {
        return false;
    }



    @Override
    public boolean canJump() {
        return false;
    }

    @Override
    public boolean canBeRiddenInWater() {
        return false;
    }

    @Override
    public boolean canBePushed() {
        return false;
    }

    @Override
    public boolean canBeSaddled() {
        return false;
    }

    @Override
    protected int getInventorySize() {
        return 29;
    }

    @Override
    public int getInventoryColumns() {
        return 9;
    }
}
  • Author

so after taking a break from modding (sorry for not responding!)

 

I finally figured out the problem. 

The problem is that this.movedDistance doesn't get updated on the server, but is getting updated on client.

How would I fix that?

 

EDIT:

The data manager can't get the correct value to sync because this.movedDistance only gets updated on client.

So I think I have to make a packet for this to all work.

Edited by someRandomKid

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.