Allow IContainerListeners to opt-in to receiving all slot changes

[Choonster 1651]

I have a system for syncing item capability data that uses ICapabilityListener, as explained here:

 

I discovered in that thread that this pull request for 1.12.2 back in 2017 partially broke my system by changing Container#detectAndSendChanges to only call IContainerListener#sendSlotContents if a slot's Item, count or share tag has changed; which often won't be the case for capability-only updates.

 

The change does make sense for Vanilla IContainerListener implementations to reduce unnecessary network traffic, but would it be possible to allow modded IContainerListeners to opt-in to having sendSlotContents called even if the Items, counts and share tags are equal?

Edited December 17, 2020 by Choonster

[diesieben07 7795]

This is why getShareTag should be used for the capability data, not some custom system.

You don't have any control over when and how ItemStacks are sent over the network, getShareTag is the only real place.

[Choonster 1651]

44 minutes ago, diesieben07 said:

This is why getShareTag should be used for the capability data, not some custom system.

You don't have any control over when and how ItemStacks are sent over the network, getShareTag is the only real place.

 

Part of the idea with my system was to allow syncing capabilities attached to arbitrary items, not just items that know about their capabilities. What would you recommend for capabilities attached to items from Vanilla or another mod?

[loordgek 177]

https://github.com/MinecraftForge/MinecraftForge/pull/6668

is this what you want ?

[Choonster 1651]

5 hours ago, loordgek said:

https://github.com/MinecraftForge/MinecraftForge/pull/6668

is this what you want ?

 

Yes, that probably would have been a useful feature. It's a shame that the author didn't have time to complete it.