KeyBinding.isPressed() fires every tick

[epicMinecrafter666Xx]

help, .isPressed() is not working right for me, it fires every tick, like if it was .isKeyDown()

heres my code:

@Mod.EventBusSubscriber(modid = DannysExpansion.MOD_ID, value = Dist.CLIENT)
public class ModKeybinds {

    @SubscribeEvent
    public static void keyEvent(TickEvent.ClientTickEvent event) {
        PlayerEntity player = Minecraft.getInstance().player;
        GameSettings settings = Minecraft.getInstance().gameSettings;

        if (player != null) {
            if(event.phase.equals(TickEvent.Phase.END) && Minecraft.getInstance().isGameFocused()) {
                if (isWearingAntiqueArmor(player)) {
                    if (settings.keyBindForward.isPressed()) {
                        ClientInstance.player().sendChatMessage("asd");
                        NetworkUtil.notifyAntiqueArmor(0);
                    } else if (settings.keyBindBack.isPressed()) {
                        NetworkUtil.notifyAntiqueArmor(1);
                    } else if (settings.keyBindRight.isPressed()) {
                        NetworkUtil.notifyAntiqueArmor(2);
                    } else if (settings.keyBindLeft.isPressed()) {
                        NetworkUtil.notifyAntiqueArmor(3);
                    }
                }
            }
        }
    }

    public static boolean isWearingAntiqueArmor(PlayerEntity player) {
        return  player.getItemStackFromSlot(EquipmentSlotType.HEAD).getItem() == ModItems.ANTIQUE_ARMOR_HELMET.get() &&
                player.getItemStackFromSlot(EquipmentSlotType.CHEST).getItem() == ModItems.ANTIQUE_ARMOR_CHESTPLATE.get() &&
                player.getItemStackFromSlot(EquipmentSlotType.LEGS).getItem() == ModItems.ANTIQUE_ARMOR_LEGGINGS.get() &&
                player.getItemStackFromSlot(EquipmentSlotType.FEET).getItem() == ModItems.ANTIQUE_ARMOR_BOOTS.get();
    }
}

 

[desht]

Read the javadocs for the isKeyDown() and isPressed() methods of KeyBinding.  They make it pretty clear which of the two methods you should be using in a tick event handler.

[epicMinecrafter666Xx]

hi, i tried this but i keep getting the same outcome

@Mod.EventBusSubscriber(modid = DannysExpansion.MOD_ID, value = Dist.CLIENT)
public class ModKeybinds {
  
    @SubscribeEvent(priority = EventPriority.LOW)
    public static void keyEvent(InputEvent.KeyInputEvent event) {
        PlayerEntity player = Minecraft.getInstance().player;
        GameSettings settings = Minecraft.getInstance().gameSettings;


        if (Minecraft.getInstance().isGameFocused() && isWearingAntiqueArmor(player)) {

            if (settings.keyBindForward.isPressed()) {
                NetworkUtil.notifyAntiqueArmor(0);
            } else if (settings.keyBindBack.isPressed()) {
                NetworkUtil.notifyAntiqueArmor(1);
            } else if (settings.keyBindRight.isPressed()) {
                NetworkUtil.notifyAntiqueArmor(2);
            } else if (settings.keyBindLeft.isPressed()) {
                NetworkUtil.notifyAntiqueArmor(3);
            }
        }
    }

    public static boolean isWearingAntiqueArmor(PlayerEntity player) {
        return  player.getItemStackFromSlot(EquipmentSlotType.HEAD).getItem() == ModItems.ANTIQUE_ARMOR_HELMET.get() &&
                player.getItemStackFromSlot(EquipmentSlotType.CHEST).getItem() == ModItems.ANTIQUE_ARMOR_CHESTPLATE.get() &&
                player.getItemStackFromSlot(EquipmentSlotType.LEGS).getItem() == ModItems.ANTIQUE_ARMOR_LEGGINGS.get() &&
                player.getItemStackFromSlot(EquipmentSlotType.FEET).getItem() == ModItems.ANTIQUE_ARMOR_BOOTS.get();
    }
}

 

[epicMinecrafter666Xx]

I tried this and its the same outcome:

    @SubscribeEvent
    public static void keyEvent(TickEvent.ClientTickEvent event) {
        PlayerEntity player = Minecraft.getInstance().player;
        GameSettings settings = Minecraft.getInstance().gameSettings;

        if (event.phase.equals(TickEvent.Phase.END) && Minecraft.getInstance().isGameFocused() && isWearingAntiqueArmor(player)) {
            while(settings.keyBindForward.isPressed()) {
                NetworkUtil.notifyAntiqueArmor(0);
            }
            while(settings.keyBindBack.isPressed()) {
                NetworkUtil.notifyAntiqueArmor(1);
            }
            while(settings.keyBindRight.isPressed()) {
                NetworkUtil.notifyAntiqueArmor(2);
            }
            while(settings.keyBindLeft.isPressed()) {
                NetworkUtil.notifyAntiqueArmor(3);
            }
        }
    }

 

also, the inventory open action seems to be behaving in the same way, i think i should make my own checker for this

[epicMinecrafter666Xx]

i want something that returns true only on the press action, seems that KeyBinding.isPressed() returns true on press, sets a timer of like 10 ticks and when that timer reach 0 it starts behaving like KeyBinding.isKeyDown()