Search the Forums BEFORE making a new post.

[Help][unsolved]Zooming with Item in hand[1.5.2]

Posted June 30, 201312 yr

Hello Everyone I have a problem, I've been trying to make an item that lets you zoom when certain key is pressed. I have 2 versions

Version 1:

package kaiKaii99Proxy;

import java.util.EnumSet;

import kaiKaii99.MainClass;

import org.lwjgl.input.Keyboard;

import net.minecraft.client.Minecraft;

import net.minecraft.client.gui.Gui;

import net.minecraft.client.renderer.EntityRenderer;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.item.ItemStack;

import cpw.mods.fml.client.FMLClientHandler;

import cpw.mods.fml.common.FMLCommonHandler;

import cpw.mods.fml.common.ITickHandler;

import cpw.mods.fml.common.TickType;

import cpw.mods.fml.relauncher.ReflectionHelper;

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

@SideOnly(Side.CLIENT)

public class ClientTickHandler extends Gui implements ITickHandler

{

public boolean isZoomed = false;

public boolean canZoom = false;

Class c = EntityRenderer.class;

Object o = Minecraft.getMinecraft().entityRenderer;

public ClientTickHandler()

{

super();

}

@Override

public EnumSet<TickType> ticks()

{

return EnumSet.of(TickType.RENDER);

}

@Override

public void tickEnd(EnumSet<TickType> type, Object... tickData)

{

if(type.contains(TickType.RENDER)){

if(Keyboard.isKeyDown(Keyboard.KEY_Z)){

ReflectionHelper.setPrivateValue(c, o, 5D, 36);

}

if(!Keyboard.isKeyDown(Keyboard.KEY_Z)){

ReflectionHelper.setPrivateValue(c, o, 1D, 36);

}

@Override

public void tickStart(EnumSet<TickType> type, Object... tickData)

{

}

protected void drawGradientRect(int par1, int par2, int par3, int par4, int par5, int par6)

{

}

public void drawScreen(int par1, int par2, float par3)

{

}

public static void inizializePlayer(EntityPlayer par1EntityPlayer)

{

}

@Override

public String getLabel() {

return null;

}

and Version 2:

package kaiKaii99Proxy;

import java.util.EnumSet;

import kaiKaii99.MainClass;

import org.lwjgl.input.Keyboard;

import net.minecraft.client.Minecraft;

import net.minecraft.client.gui.Gui;

import net.minecraft.client.renderer.EntityRenderer;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.item.ItemStack;

import cpw.mods.fml.client.FMLClientHandler;

import cpw.mods.fml.common.FMLCommonHandler;

import cpw.mods.fml.common.ITickHandler;

import cpw.mods.fml.common.TickType;

import cpw.mods.fml.relauncher.ReflectionHelper;

import cpw.mods.fml.relauncher.Side;

import cpw.mods.fml.relauncher.SideOnly;

@SideOnly(Side.CLIENT)

public class ClientTickHandler extends Gui implements ITickHandler

{

public boolean isZoomed = false;

public boolean canZoom = false;

Class c = EntityRenderer.class;

Object o = Minecraft.getMinecraft().entityRenderer;

public ClientTickHandler()

{

super();

}

@Override

public EnumSet<TickType> ticks()

{

return EnumSet.of(TickType.RENDER);

}

@Override

public void tickEnd(EnumSet<TickType> type, Object... tickData)

{

Minecraft mc = Minecraft.getMinecraft();

if(type.contains(TickType.RENDER)){

if(mc.thePlayer.getCurrentEquippedItem() != null)

{

ItemStack currItem = mc.thePlayer.getCurrentEquippedItem();

if(currItem.getItem() == MainClass.MagicGauntlet){

canZoom = true;

}else{

canZoom = false;

}

if(Keyboard.isKeyDown(Keyboard.KEY_Z) && canZoom == true){

ReflectionHelper.setPrivateValue(c, o, 5D, 36);

}

if(!Keyboard.isKeyDown(Keyboard.KEY_Z) || canZoom != true){

ReflectionHelper.setPrivateValue(c, o, 1D, 36);

}

@Override

public void tickStart(EnumSet<TickType> type, Object... tickData)

{

}

protected void drawGradientRect(int par1, int par2, int par3, int par4, int par5, int par6)

{

}

public void drawScreen(int par1, int par2, float par3)

{

}

public static void inizializePlayer(EntityPlayer par1EntityPlayer)

{

}

@Override

public String getLabel() {

return null;

}

In version 1 it works almost perfectly, well, i can zoom but with any item in my hand.

and in version 2 when i press the key and i have the correct item in my hand, when i release the key, it stays there, the value does not go back.

If you help me i will add you to my mod's credits list.

Thanks in advance

http://www.minecraftforum.net/topic/1722025-151forgewands-ores-mod-wip021

Wands & Ores Mod!

Quote

June 30, 201312 yr

Firstly, learn to use "else".

Secondly, I notice your zoom code is inside the "if(type.contains(TickType.RENDER)){" in the first version, but outside it in the second.

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Quote

1 month later...

August 9, 201312 yr

I notice your zoom code is inside the "if(type.contains(TickType.RENDER)){" in the first version, but outside it in the second.

I double checked; That is just weird formatting.

Quote

August 9, 201312 yr

Agreed, some else code would be good to use here

if(params)
{
}
else if(params) // another specific situation in the same if instance
{
}
else // every other situation
{
}

Follow me on twitter! @keepablock

Read up on whats new! www.catacombs.co

width=700 height=60 http://electronic-chronic.com/assets/keep-a-block/wikilink/wikilink_logo.png[/img]

Quote

August 9, 201312 yr

What I would do:

Minecraft mc = Minecraft.getMinecraft();
boolean changed = false;
@Override
public void tickEnd(EnumSet<TickType> type, Object... tickData)
{ 
      if(type.contains(TickType.RENDER) && mc.thePlayer!=null){         
              if(mc.thePlayer.getCurrentEquippedItem() != null){
                      ItemStack currItem = mc.thePlayer.getCurrentEquippedItem();
                      if(currItem.getItem().itemID == MainClass.MagicGauntlet.itemID){
                             if(Keyboard.isKeyDown(Keyboard.KEY_Z)){
                                   if(!changed){
                                         ReflectionHelper.setPrivateValue(c, o, 5D, 36);
                                         changed = true;
                                   }
                                   return;
                             }
                       }
                 }
              if(changed){
                       ReflectionHelper.setPrivateValue(c, o, 1D, 36);
                       changed = false;
             }
        }
}

This is to avoid all unnecessary reflection uses.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/9568-helpunsolvedzooming-with-item-in-hand152/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to add my mob to another mod's biome in 1.20.1.

tysm

By ilov3gam3z · 1 hour ago1 hr
Orbital strike cannon fishing rod mod

was focused on school so didnt respond u think ur gonna get 1.21+ done by this week? @FoxyWoxy

By Astoxy · 8 hours ago8 hr
How to add my mob to another mod's biome in 1.20.1.

You can add mob spawns using Forge's Biome Modifiers feature. I won't go into details on how to use a data generator for them, but here's a simple example:
{ "type": "forge:add_spawns", // Required "biomes": "#namespace:biome_tag", // Accepts a biome id, [list of biome ids], or #namespace:biome_tag "spawners": { "type": "namespace:entity_type", // Type of mob to spawn "weight": 100, // int, spawn weighting "minCount": 1, // int, minimum pack size "maxCount": 4 // int, maximum pack size } }This JSON file would go somewhere like this: data/modid/forge/biome_modifier/your_biome_modifier.json

By Jonathing · 19 hours ago19 hr
How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted Yesterday at 12:07 AM1 day
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted Wednesday at 04:08 PM2 days

There are no registered users currently online

Sign In

[Help][unsolved]Zooming with Item in hand[1.5.2]

Featured Replies

Join the conversation

Posts

How to add my mob to another mod's biome in 1.20.1.

Orbital strike cannon fishing rod mod

How to add my mob to another mod's biome in 1.20.1.

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)