[Not solved but im done.]How to save integers to a file.

deadrecon98 · July 6, 2013

With NBT you can load it from anywhere.... Just make sure you have the player object and bam, ability to load from anywhere.

I shall try this then lol

deadrecon98 · July 6, 2013

With NBT you can load it from anywhere.... Just make sure you have the player object and bam, ability to load from anywhere.

How would you add a number to it?

maxpowa · July 6, 2013

Get the player's NBT object,

NBTTagCompound nbt = player.getEntityData();

then

nbt.set<OBJECTTYPE>("keyofobject", valueofobject);

and replace <OBJECTTYPE> with the type of object you want to store. (ie; Boolean, int, String)

So for a number (lets just say that the number is a float)

NBTTagCompound nbt = player.getEntityData();
nbt.setFloat("examplefloat", 1.3F);

That's all you need to set it. Then to get it, you simply use the player object again.

NBTTagCompound nbt = player.getEntityData();
float value = nbt.getFloat("examplefloat");

deadrecon98 · July 7, 2013

Get the player's NBT object,
NBTTagCompound nbt = player.getEntityData();
then
nbt.set<OBJECTTYPE>("keyofobject", valueofobject);
and replace <OBJECTTYPE> with the type of object you want to store. (ie; Boolean, int, String)

So for a number (lets just say that the number is a float)
NBTTagCompound nbt = player.getEntityData();
nbt.setFloat("examplefloat", 1.3F);
That's all you need to set it. Then to get it, you simply use the player object again.
NBTTagCompound nbt = player.getEntityData();
float value = nbt.getFloat("examplefloat");

Lol I mean like nbt.getInteger("MiningXp" + 1); but that method just says that the left-hand side must be a variable and just using the int itself won't work. Any Ideas?

Flenix · July 7, 2013

I'm toying around with the same kind of thing, but with an economy system, so I've been following this post

To add on to an existing int, I think it would be something like this:

public static void saveBalanceForPlayer(EntityPlayer player, World world) {

NBTTagCompound nbt = player.getEntityData();

nbt.setInteger("Balance", (nbt.getInteger("Balance") + moneyValue));

}

In my setup, "Balance" is the players balance as an NBT tag, and "moneyValue" is a static int defined in each of my different coins classes. You'd simply replace moneyValue with the amount of XP you want to add, but by doing something like that you can give different XP for different things relatively easily.

What I want to know; is A) how do we trigger this change (How do I say "You should now add moneyValue to the NBT"), and B) How can I see my current NBT value?

maxpowa · July 7, 2013

Lol I mean like nbt.getInteger("MiningXp" + 1); but that method just says that the left-hand side must be a variable and just using the int itself won't work. Any Ideas?

Whenever you change a value, you have to use nbt.setInteger instead of nbt.getInteger.

nbt.setInteger("MiningXp", nbt.getInteger("MiningXp")+1);

maxpowa · July 7, 2013

What I want to know; is A) how do we trigger this change (How do I say "You should now add moneyValue to the NBT"), and B) How can I see my current NBT value?

Use a command? An eventlistener for rightclick with a certain item? I don't know, you could use pretty much any event trigger... For current NBT value, it's just

Integer currentBalance = nbt.getInteger("Balance");

deadrecon98 · July 7, 2013

What I want to know; is A) how do we trigger this change (How do I say "You should now add moneyValue to the NBT"), and B) How can I see my current NBT value?

Use a command? An eventlistener for rightclick with a certain item? I don't know, you could use pretty much any event trigger... For current NBT value, it's just
Integer currentBalance = nbt.getInteger("Balance");

Ty, I just updated to 1.6 so I have to wait to be able to run it. the renderEngine.bindTexture is broken.. god dammit mojang

maxpowa · July 7, 2013

It's a really simple fix for that, take your old:

mc.renderengine.bindTexture("texloc/wherever/yours/is");

and edit them to be:

mc.func_110434_K().func_110577_a(new ResourceLocation("texloc/wherever/yours/is"));

deadrecon98 · July 7, 2013

It's a really simple fix for that, take your old:
mc.renderengine.bindTexture("texloc/wherever/yours/is");
and edit them to be:
mc.func_110434_K().func_110577_a(new ResourceLocation("texloc/wherever/yours/is"));

lol ty. where do you find this stuff btw? it would help me in the future :3

deadrecon98 · July 7, 2013

I'm toying around with the same kind of thing, but with an economy system, so I've been following this post

To add on to an existing int, I think it would be something like this:

public static void saveBalanceForPlayer(EntityPlayer player, World world) {

NBTTagCompound nbt = player.getEntityData();

nbt.setInteger("Balance", (nbt.getInteger("Balance") + moneyValue));

}

In my setup, "Balance" is the players balance as an NBT tag, and "moneyValue" is a static int defined in each of my different coins classes. You'd simply replace moneyValue with the amount of XP you want to add, but by doing something like that you can give different XP for different things relatively easily.

What I want to know; is A) how do we trigger this change (How do I say "You should now add moneyValue to the NBT"), and B) How can I see my current NBT value?

It looks like you've got it all right and triggering it isn't much different and to see it just use a string + the int.

deadrecon98 · July 7, 2013

It's a really simple fix for that, take your old:
mc.renderengine.bindTexture("texloc/wherever/yours/is");
and edit them to be:
mc.func_110434_K().func_110577_a(new ResourceLocation("texloc/wherever/yours/is"));

ummm dude. i updated to 1.6 and the nbt doesn't save anymore.

Flenix · July 7, 2013

I was about to comment My NBT isn't saving. Here's the code:

    @Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int i, float j, float k, float l) {
    	TileEntity tileEntity = world.getBlockTileEntity(x, y, z);
    	NBTTagCompound nbt = player.getEntityData();
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.debitCard) {
    			player.addChatMessage("Your Balance is: " + nbt.getInteger("Balance"));
    			player.openGui(FlenixCities.instance, 0, world, x, y, z);
    		}
    	}
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.note1000) {
    			nbt.setInteger("balance", (nbt.getInteger("Balance") + ItemNote10.moneyValue));
    			player.addChatMessage(ItemNote10.moneyValue + " Deposited! Your balance is now " + nbt.getInteger("balance"));
    		}
    	}
	return true;
    }

As you can see, in the confirm deposit line, it gets the current NBT at what it is, and reports it's 1000 (which is correct) - however, when I use the debit card after which merely displays the balance, it's back to 0.

I got really excited when it said I'd deposited 1000 then really sad again after

deadrecon98 · July 7, 2013

I was about to comment My NBT isn't saving. Here's the code:

    @Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int i, float j, float k, float l) {
    	TileEntity tileEntity = world.getBlockTileEntity(x, y, z);
    	NBTTagCompound nbt = player.getEntityData();
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.debitCard) {
    			player.addChatMessage("Your Balance is: " + nbt.getInteger("Balance"));
    			player.openGui(FlenixCities.instance, 0, world, x, y, z);
    		}
    	}
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.note1000) {
    			nbt.setInteger("balance", (nbt.getInteger("Balance") + ItemNote10.moneyValue));
    			player.addChatMessage(ItemNote10.moneyValue + " Deposited! Your balance is now " + nbt.getInteger("balance"));
    		}
    	}
	return true;
    }

As you can see, in the confirm deposit line, it gets the current NBT at what it is, and reports it's 1000 (which is correct) - however, when I use the debit card after which merely displays the balance, it's back to 0.

I got really excited when it said I'd deposited 1000 then really sad again after

I'm honestly about to quit updating, they keep breaking everything!!!

maxpowa · July 7, 2013

lol ty. where do you find this stuff btw? it would help me in the future :3

I looked in the vanilla classes which used to use that bindTexture method, then checked what they had changed to when my methods no longer worked.

I was about to comment My NBT isn't saving. Here's the code:

    @Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int i, float j, float k, float l) {
    	TileEntity tileEntity = world.getBlockTileEntity(x, y, z);
    	NBTTagCompound nbt = player.getEntityData();
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.debitCard) {
    			player.addChatMessage("Your Balance is: " + nbt.getInteger("Balance"));
    			player.openGui(FlenixCities.instance, 0, world, x, y, z);
    		}
    	}
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.note1000) {
    			nbt.setInteger("balance", (nbt.getInteger("Balance") + ItemNote10.moneyValue));
    			player.addChatMessage(ItemNote10.moneyValue + " Deposited! Your balance is now " + nbt.getInteger("balance"));
    		}
    	}
	return true;
    }

As you can see, in the confirm deposit line, it gets the current NBT at what it is, and reports it's 1000 (which is correct) - however, when I use the debit card after which merely displays the balance, it's back to 0.

I got really excited when it said I'd deposited 1000 then really sad again after

As for saving issues, I think it might have been a fault on my part... Try changing this:

NBTTagCompound nbt = player.getEntityData();

to this:

NBTTagCompound nbt = player.getEntityData().getCompoundTag(EntityPlayer.PERSISTED_NBT_TAG);

deadrecon98 · July 7, 2013

lol ty. where do you find this stuff btw? it would help me in the future :3

I looked in the vanilla classes which used to use that bindTexture method, then checked what they had changed to when my methods no longer worked.
I was about to comment My NBT isn't saving. Here's the code:
    @Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int i, float j, float k, float l) {
    	TileEntity tileEntity = world.getBlockTileEntity(x, y, z);
    	NBTTagCompound nbt = player.getEntityData();
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.debitCard) {
    			player.addChatMessage("Your Balance is: " + nbt.getInteger("Balance"));
    			player.openGui(FlenixCities.instance, 0, world, x, y, z);
    		}
    	}
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.note1000) {
    			nbt.setInteger("balance", (nbt.getInteger("Balance") + ItemNote10.moneyValue));
    			player.addChatMessage(ItemNote10.moneyValue + " Deposited! Your balance is now " + nbt.getInteger("balance"));
    		}
    	}
	return true;
    }
As you can see, in the confirm deposit line, it gets the current NBT at what it is, and reports it's 1000 (which is correct) - however, when I use the debit card after which merely displays the balance, it's back to 0.

I got really excited when it said I'd deposited 1000 then really sad again after
As for saving issues, I think it might have been a fault on my part... Try changing this:
NBTTagCompound nbt = player.getEntityData();
to this:
NBTTagCompound nbt = player.getEntityData().getCompoundTag(EntityPlayer.PERSISTED_NBT_TAG);

now I can't add to the nbt integer

maxpowa · July 7, 2013

You should be able to, can I see your code now?

Flenix · July 7, 2013

I'm honestly about to quit updating, they keep breaking everything!!!

Meh, we're working early. Give it 3-4 weeks and there will be fixes in forge, and plenty of "how to fix this update bug" tutorials. I didn't update to 1.5.2 for a couple of months and minus the texture de-stitching that didn't take me long at all, coz I could just google any issues

Anyways. I added that extra bit to the code, still getting the same bug:

Code:

    @Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int i, float j, float k, float l) {
    	TileEntity tileEntity = world.getBlockTileEntity(x, y, z);
    	NBTTagCompound nbt = player.getEntityData().getCompoundTag(EntityPlayer.PERSISTED_NBT_TAG);
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.debitCard) {
    			player.addChatMessage("Your Balance is: " + nbt.getInteger("Balance"));
    			player.openGui(FlenixCities.instance, 0, world, x, y, z);
    		}
    	}
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.note1000) {
    			nbt.setInteger("balance", (nbt.getInteger("Balance") + ItemNote10.moneyValue));
   			player.addChatMessage(ItemNote10.moneyValue + " Deposited! Your balance is now " + nbt.getInteger("balance"));
    		}
    	}
	return true;
    }

@deadrecon98 have you got anything working yet?

maxpowa · July 7, 2013

    @Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int i, float j, float k, float l) {
    	TileEntity tileEntity = world.getBlockTileEntity(x, y, z);
    	NBTTagCompound nbt = player.getEntityData().getCompoundTag(EntityPlayer.PERSISTED_NBT_TAG);
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.debitCard) {
    			player.addChatMessage("Your Balance is: " + nbt.getInteger("Balance"));
    			player.openGui(FlenixCities.instance, 0, world, x, y, z);
    		}
    	}
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.note1000) {
    			nbt.setInteger("balance", (nbt.getInteger("Balance") + ItemNote10.moneyValue));
   			player.addChatMessage(ItemNote10.moneyValue + " Deposited! Your balance is now " + nbt.getInteger("balance"));
    		}
    	}
	return true;
    }

Capitalization matters!

    @Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int i, float j, float k, float l) {
    	TileEntity tileEntity = world.getBlockTileEntity(x, y, z);
    	NBTTagCompound nbt = player.getEntityData().getCompoundTag(EntityPlayer.PERSISTED_NBT_TAG);
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.debitCard) {
    			player.addChatMessage("Your Balance is: " + nbt.getInteger("Balance"));
    			player.openGui(FlenixCities.instance, 0, world, x, y, z);
    		}
    	}
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.note1000) {
    			nbt.setInteger("Balance", (nbt.getInteger("Balance") + ItemNote10.moneyValue));
   			player.addChatMessage(ItemNote10.moneyValue + " Deposited! Your balance is now " + nbt.getInteger("Balance"));
    		}
    	}
	return true;
    }

Flenix · July 7, 2013

After a few minutes of "Spot the difference" I noticed the two balances which should be Balances. Was there anything else? That didn't seem to fix it

deadrecon98 · July 7, 2013

I'm honestly about to quit updating, they keep breaking everything!!!

Meh, we're working early. Give it 3-4 weeks and there will be fixes in forge, and plenty of "how to fix this update bug" tutorials. I didn't update to 1.5.2 for a couple of months and minus the texture de-stitching that didn't take me long at all, coz I could just google any issues

Anyways. I added that extra bit to the code, still getting the same bug:

Code:
    @Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int i, float j, float k, float l) {
    	TileEntity tileEntity = world.getBlockTileEntity(x, y, z);
    	NBTTagCompound nbt = player.getEntityData().getCompoundTag(EntityPlayer.PERSISTED_NBT_TAG);
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.debitCard) {
    			player.addChatMessage("Your Balance is: " + nbt.getInteger("Balance"));
    			player.openGui(FlenixCities.instance, 0, world, x, y, z);
    		}
    	}
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.note1000) {
    			nbt.setInteger("balance", (nbt.getInteger("Balance") + ItemNote10.moneyValue));
   			player.addChatMessage(ItemNote10.moneyValue + " Deposited! Your balance is now " + nbt.getInteger("balance"));
    		}
    	}
	return true;
    }
@deadrecon98 have you got anything working yet?

Nope. Still working on it

maxpowa · July 7, 2013

Hmmm... Try using NBTExplorer and check if the NBT objects are actually created in the level.dat. The Balance key should be in saves/<worldname>/players/<playername> , let me know if it's not there.

Flenix · July 7, 2013

Hmmm... Try using NBTExplorer and check if the NBT objects are actually created in the level.dat. The Balance key should be in saves/<worldname>/players/<playername> , let me know if it's not there.

Obviously I'm testing in the Forge environment so all of my .dat's are different. But, they all seem to have the same Balance of 1000. However, most times of logging in I tried to do it at least twice, so it's obviously still not adding properly else there would be some with 2000, some with 3000, some with 0 etc..

Screenshot if it's any help:

maxpowa · July 7, 2013

Lets try some console output debugging.

    @Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int i, float j, float k, float l) {
    	TileEntity tileEntity = world.getBlockTileEntity(x, y, z);
    	NBTTagCompound nbt = player.getEntityData().getCompoundTag(EntityPlayer.PERSISTED_NBT_TAG);
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.debitCard) {
    			player.addChatMessage("Your Balance is: " + nbt.getInteger("Balance"));
    			player.openGui(FlenixCities.instance, 0, world, x, y, z);
    		}
    	}
    	if (player.getHeldItem() != null) {
    		if (player.getHeldItem().getItem() == FlenixCities.note1000) {
                                            System.out.println("Old balance is: "+nbt.getInteger("Balance"));
                                            System.out.println("Adding "+ItemNote10.moneyValue+" to total balance.");
                                            int newBalance = (nbt.getInteger("Balance") + ItemNote10.moneyValue);
                                            System.out.println("New balance is: "+newBalance);
    			nbt.setInteger("Balance", newBalance);
                                            System.out.println("Balance confirm:"+nbt.getInteger("Balance"));
   			player.addChatMessage(ItemNote10.moneyValue + " Deposited! Your balance is now " + nbt.getInteger("Balance"));
    		}
    	}
	return true;
    }

Try that a few times and check if the output is what it should be.

Flenix · July 7, 2013

2013-07-08 00:39:21 [iNFO] [sTDOUT] Old balance is: 0
2013-07-08 00:39:21 [iNFO] [sTDOUT] Adding 1000 to total balance.

2013-07-08 00:39:21 [iNFO] [sTDOUT] New balance is: 1000

2013-07-08 00:39:21 [iNFO] [sTDOUT] Balance confirm:1000

2013-07-08 00:39:21 [iNFO] [Minecraft-Client] [CHAT] 1000 Deposited! Your balance is now 1000

2013-07-08 00:39:26 [iNFO] [sTDOUT] Old balance is: 0

2013-07-08 00:39:26 [iNFO] [sTDOUT] Adding 1000 to total balance.

2013-07-08 00:39:26 [iNFO] [sTDOUT] New balance is: 1000

2013-07-08 00:39:26 [iNFO] [sTDOUT] Balance confirm:1000

2013-07-08 00:39:26 [iNFO] [Minecraft-Client] [CHAT] 1000 Deposited! Your balance is now 1000

2013-07-08 00:39:29 [iNFO] [sTDOUT] Old balance is: 0

2013-07-08 00:39:29 [iNFO] [sTDOUT] Adding 1000 to total balance.

2013-07-08 00:39:29 [iNFO] [sTDOUT] New balance is: 1000

2013-07-08 00:39:29 [iNFO] [sTDOUT] Balance confirm:1000

2013-07-08 00:39:29 [iNFO] [Minecraft-Client] [CHAT] 1000 Deposited! Your balance is now 1000

Everything printed twice but I cleaned it It seems like it's just not saving the balance after it confirms it's been added =/

Sign In

[Not solved but im done.]How to save integers to a file.

Recommended Posts

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Important Information