Jump to content

Recommended Posts

Posted (edited)

Goodday,

 

I am making an armor mod and i want to make some items dyeable just like leather. I already have the dye working on the item models but now i want it also to represent the color on the item. but i cant really figure out how.

 

i saw it had something to do with a item color handler and iitemcolor but i dont realy understand it. does someone maybe have an example on how it should work.

 

this is what i have now and i keep getting a stackoverflow error.

 

@Mod.EventBusSubscriber(modid = ColtCosmeticArmorMod.MOD_ID, bus = Bus.MOD)
public class ModColorHandeler {
	@SubscribeEvent
	@OnlyIn(Dist.CLIENT)
	public static void registerItemColourHandlers(final ColorHandlerEvent.Item event) {
		final BlockColors blockColors = event.getBlockColors();
		final ItemColors itemColors = event.getItemColors();

		final IItemColor itemColourHandler = (stack, tintIndex) -> {
			return itemColors.getColor(stack, tintIndex);
		};
        itemColors.register(itemColourHandler, ccamItems.FLOWER_CROWN.get());
    }
}

 

It is my first time making a minecraft mod. Btw i mostly learn things by example.

Edited by Aligatetcolt
Posted

Alright thanks for the reply.

 

So i deleted the @OnlyIn

 

But as the second part. How would i actually set that color that i get on to the item i want it on. which is in this case the Flower Crown.

Posted

Thanks alot.

 

just to clarify. I will now have to take that data i got from the script i send before and then set that as nbt data into the item that needs that.  but is that supposed to be in a different script or in the color manager script i send before.

 

 

Posted

Sorry for my bad habit of naming things. i got used to using unity alot and a new file is called a script.

 

What i meant was, The color data i got from the code snippet earlier. i need to add that then to the nbt data with the ItemStack#getOrCreateChildTag(<your mod ID>) that you send. Right?

 

The only thing i dont really know at the moment is where would i add to the items nbt data. in the place where i register the items or in a new file.

Posted

Yeah the exact same. just like minecraft does with leather. just put the item in the crafting table with dye and then it is colord. it works on the models but still not in the inventory screen

 

i send an pic of what i have right now as the item. idk if i was clear enough but i want to change the white part to the color that it was dyed.

Screenshot 2021-03-09 155959.png

Posted

I am not 100%. i have basically been doing everything by trail and error. and i couldn't figure out on how and what i was supposed to do. and i am not sure on how to check if it is the right color because right now it still give that stackoverflow error.

Posted
public class ModColorHandeler {
	@SubscribeEvent
	public static void registerItemColourHandlers(final ColorHandlerEvent.Item event) {
		final BlockColors blockColors = event.getBlockColors();
		final ItemColors itemColors = event.getItemColors();

		final IItemColor itemColourHandler = (stack, tintIndex) -> {
			return itemColors.getColor(stack, tintIndex);
		};
        itemColors.register(itemColourHandler, ccamItems.FLOWER_CROWN.get());
    }

Here you go. i havent changed much yet because i didn't fully understand what i was supposed to change yet.

  • 2 years later...
Posted (edited)

I'm trying to essentially do the same thing as you have but in 1.18.2 i dont see any of the comments to help with this could ya help me to do what ya did?

Edited by zero8034
wanted to say the version im working on
Posted

i also finally managed to get it working heres my finished colorHandler that works currently for 1.18.2 and from what i can tell should work post version 1.12

 

//code start

package com.zer0_the_wolf.layeredarmor.item.custom;

import com.zer0_the_wolf.layeredarmor.item.LayeredArmoritems;

import net.minecraft.client.color.item.ItemColor;

import net.minecraft.client.color.item.ItemColors;

import net.minecraft.nbt.CompoundTag;

import net.minecraft.world.item.DyeColor;

import net.minecraft.world.item.DyeableArmorItem;

import net.minecraft.world.item.DyeableLeatherItem;

import net.minecraft.world.item.ItemStack;

import net.minecraftforge.client.event.ColorHandlerEvent;

import net.minecraftforge.eventbus.api.SubscribeEvent;

public class ColorHandlers

{

@SubscribeEvent public static void registerItemColors(ColorHandlerEvent.Item event)

{

event.getItemColors().register(ColorHandlers::getColor,

LayeredArmoritems.LEATHERCHAINHELMET.get(),

LayeredArmoritems.LEATHERCHAINCHESTPLATE.get(),

LayeredArmoritems.LEATHERCHAINLEGGINGS.get(),

LayeredArmoritems.LEATHERCHAINBOOTS.get());

}

private static int getColor(ItemStack pStack, int tintIndex)

{

CompoundTag compoundtag = pStack.getTagElement("display");

if (tintIndex == 0)

{

return compoundtag != null && compoundtag.contains("color", 99) ? compoundtag.getInt("color") : 10511680;

}

return 0xFFFFFF;

}

}

//end code

do note that you have to add a listener should be same place you added a listener for the event bus. mine looks like.

eventBus.addListener(ColorHandlers::registerItemColors);

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi,  I'm using Forge 47.3.0 for Minecraft 1.20.1 I apologise if this is obvious I am very new to modding for Minecraft. I sucessfully made a mod that launched without errors or crashes (without it doing anything) but in order to add the features I need, I need to add "Custom Portal API [Forge]" as a dependency. However no matter the way I've tried to acheive this, it crashes. I am pretty sure it's not the way I'm putting it in the repositories, the dependencies or the way I'm refrencing it, as I've a hundred diffrent combinations and multiple Maven methods. And on all those diffrent variations I still get this crash: pastebin.com/UhumzZCZ Any tips would be invaluable as I've been loosing my mind over this!
    • Hi, i'm really having problems trying to set the texture to my custom item. I thought i'm doing everything correctly, but all i see is the missing texture block for my item. I am trying this for over a week now and getting really frustrated. The only time i could make the texture work, was when i used an older Forge version (52.0.1) for Minecraft (1.21.4). Was there a fundamental change for textures and models somewhere between versions that i'm missing? I started with Forge 54.1.0 and had this problem, so in my frustration i tried many things: Upgrading to Forge 54.1.1, created multiple new projects, workspaces, redownloaded everything and setting things up multiple times, as it was suggested in an older thread. Therea are no errors in the console logs, but maybe i'm blind, so i pasted the console logs to pastebin anyway: https://pastebin.com/zAM8RiUN The only time i see an error is when i change the models JSON file to an incorrect JSON which makes sense and that suggests to me it is actually reading the JSON file.   I set the github repository to public, i would be so thankful if anyone could take a look and tell me what i did wrong: https://github.com/xLorkin/teleport_pug_forge   As a note: i'm pretty new to modding, this is my first mod ever. But i'm used to programming. I had some up and downs, but through reading the documentation, using google and experimenting, i could solve all other problems. I only started modding for Minecraft because my son is such a big fan and wanted this mod.
    • Please read the FAQ (link in orange bar at top of page), and post logs as described there.
    • Hello fellow Minecrafters! I recently returned to Minecraft and realized I needed a wiki that displays basic information easily and had great user navigation. That’s why I decided to build: MinecraftSearch — a site by a Minecraft fan, for Minecraft fans. Key Features So Far Straight-to-the-Point Info: No extra fluff; just the essentials on items, mobs, recipes, loot and more. Clean & Intuitive Layout: Easy navigation so you spend less time scrolling and more time playing. Optimized Search: Search for anything—items, mobs, blocks—and get results instantly. What I’m Thinking of Adding More data/information: Catch chances for fishing rod, traveling villager trades, biomes info and a lot more. The website is still under development and need a lot more data added. Community Contributions: Potential for user-uploaded tips for items/mobs/blocks in the future. Feature Requests Welcome: Your ideas could shape how the wiki evolves! You can see my roadmap at the About page https://minecraftsearch.com/about I’d love for you to check out MinecraftSearch and see if it helps you find the info you need faster. Feedback is crucial—I want to develop this further based on what the community needs most, so please let me know what you think. Thanks, and happy crafting!
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.