[1.16.4] Dyeable armor color represent on item

[Aligatetcolt]

Goodday,

 

I am making an armor mod and i want to make some items dyeable just like leather. I already have the dye working on the item models but now i want it also to represent the color on the item. but i cant really figure out how.

 

i saw it had something to do with a item color handler and iitemcolor but i dont realy understand it. does someone maybe have an example on how it should work.

 

this is what i have now and i keep getting a stackoverflow error.

 

@Mod.EventBusSubscriber(modid = ColtCosmeticArmorMod.MOD_ID, bus = Bus.MOD)
public class ModColorHandeler {
	@SubscribeEvent
	@OnlyIn(Dist.CLIENT)
	public static void registerItemColourHandlers(final ColorHandlerEvent.Item event) {
		final BlockColors blockColors = event.getBlockColors();
		final ItemColors itemColors = event.getItemColors();

		final IItemColor itemColourHandler = (stack, tintIndex) -> {
			return itemColors.getColor(stack, tintIndex);
		};
        itemColors.register(itemColourHandler, ccamItems.FLOWER_CROWN.get());
    }
}

 

It is my first time making a minecraft mod. Btw i mostly learn things by example.

Edited March 9, 2021 by Aligatetcolt

[diesieben07]

• Do not use @OnlyIn.
• You need to actually implement the "which color should this item have" logic in your IItemColor implementation. Currently you just ask Minecraft "hey, what color should this item have?" again. This will trigger your IItemColor again (because you have told Minecraft that that's how to get the color for your item). Your handler then asks Minecraft again. Minecraft asks your handler. And so on until the JVM tells you that you are being silly and throws a StackOverflowError.

[Aligatetcolt]

Alright thanks for the reply.

 

So i deleted the @OnlyIn

 

But as the second part. How would i actually set that color that i get on to the item i want it on. which is in this case the Flower Crown.

[diesieben07]

IItemColor is unrelated to setting the color. It just teaches Minecraft how to get the color.

To store the color, you need to store it in the ItemStack's NBT data. Use ItemStack#getOrCreateChildTag(<your mod ID>) and store the color there.

[Aligatetcolt]

Thanks alot.

 

just to clarify. I will now have to take that data i got from the script i send before and then set that as nbt data into the item that needs that.  but is that supposed to be in a different script or in the color manager script i send before.

 

 

[diesieben07]

By "script" I assume you mean the code you posted previously (Java is not a scripting language).

Please elaborate what you mean by "data i got from the script".

[Aligatetcolt]

Sorry for my bad habit of naming things. i got used to using unity alot and a new file is called a script.

 

What i meant was, The color data i got from the code snippet earlier. i need to add that then to the nbt data with the ItemStack#getOrCreateChildTag(<your mod ID>) that you send. Right?

 

The only thing i dont really know at the moment is where would i add to the items nbt data. in the place where i register the items or in a new file.

[diesieben07]

7 minutes ago, Aligatetcolt said:

The only thing i dont really know at the moment is where would i add to the items nbt data.

Well, that depends. When do you want the color to change? Minecraft does this using a crafting recipe. How do you want to do it?

[Aligatetcolt]

Yeah the exact same. just like minecraft does with leather. just put the item in the crafting table with dye and then it is colord. it works on the models but still not in the inventory screen

 

i send an pic of what i have right now as the item. idk if i was clear enough but i want to change the white part to the color that it was dyed.

[diesieben07]

Did you make your IItemColor return the correct color?

[Aligatetcolt]

I am not 100%. i have basically been doing everything by trail and error. and i couldn't figure out on how and what i was supposed to do. and i am not sure on how to check if it is the right color because right now it still give that stackoverflow error.

[diesieben07]

Post updated code please.

[Aligatetcolt]

public class ModColorHandeler {
	@SubscribeEvent
	public static void registerItemColourHandlers(final ColorHandlerEvent.Item event) {
		final BlockColors blockColors = event.getBlockColors();
		final ItemColors itemColors = event.getItemColors();

		final IItemColor itemColourHandler = (stack, tintIndex) -> {
			return itemColors.getColor(stack, tintIndex);
		};
        itemColors.register(itemColourHandler, ccamItems.FLOWER_CROWN.get());
    }

Here you go. i havent changed much yet because i didn't fully understand what i was supposed to change yet.

[Aligatetcolt]

I got it working. still thanks for your help. it was still realy helpfull