Jump to content

Problems With Getting a Branch of Forge Ready for Pull Request


zanotam

Recommended Posts

So, I'm writing some code to implement something like http://forums.bukkit.org/threads/permissions-faq.25080/ for forge. This should make life much easier than the current creation of fake players and total reliance of mod authors to work well together with mods like Forge Essentials or the PEX port to Forge, instead of the current situation in which mods will oftentimes implement their own pseudo perm system which will be very difficult to modify or deal with from a mod maker and a server owner perspective. Anyways.....

 

I've got the code written that doesn't require modification of base classes, but I can't figure out a way to finish the code off without doing so. I know to do so I should get a clean github copy of forge, get the mcp running and the eclipse directory and all that jazz ready, make my code modifications to the base classes, and then update the patches with the changes I made to base classes, but whenever I try to get a clean version of forge set-up for this purpose (I've already got a 1.6 version of forge for writing mods running fine), I run in to issues. Here are the steps I'm following:

 

1. Fork MinecraftForge.

2. Download fork using the official OS X GitHub app.

3. Go to terminal and move to the directory the downloaded fork is in and run setup.py

 

The issue seems to be the following error, but below that I've included the full text of the terminal output.

 

Just the error: http://pastebin.com/vUssWvva

 

BUILD FAILED

/Users/RobertSBaker/Dropbox/Programming/Minecraft/MinecraftForge/fml/build.xml:263: Execute failed: java.io.IOException: Cannot run program "xz": error=2, No such file or directory

at java.lang.ProcessBuilder.start(ProcessBuilder.java:460)

at java.lang.Runtime.exec(Runtime.java:593)

at org.apache.tools.ant.taskdefs.Execute$Java13CommandLauncher.exec(Execute.java:862)

at org.apache.tools.ant.taskdefs.Execute.launch(Execute.java:481)

at org.apache.tools.ant.taskdefs.Execute.execute(Execute.java:495)

at org.apache.tools.ant.taskdefs.ExecTask.runExecute(ExecTask.java:631)

at org.apache.tools.ant.taskdefs.ExecTask.runExec(ExecTask.java:672)

at org.apache.tools.ant.taskdefs.ExecTask.execute(ExecTask.java:498)

at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)

at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

at java.lang.reflect.Method.invoke(Method.java:597)

at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)

at org.apache.tools.ant.Task.perform(Task.java:348)

at org.apache.tools.ant.Target.execute(Target.java:390)

at org.apache.tools.ant.Target.performTasks(Target.java:411)

at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1399)

at org.apache.tools.ant.Project.executeTarget(Project.java:1368)

at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)

at org.apache.tools.ant.Project.executeTargets(Project.java:1251)

at org.apache.tools.ant.Main.runBuild(Main.java:809)

at org.apache.tools.ant.Main.startAnt(Main.java:217)

at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280)

at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109)

Caused by: java.io.IOException: error=2, No such file or directory

at java.lang.UNIXProcess.forkAndExec(Native Method)

at java.lang.UNIXProcess.<init>(UNIXProcess.java:53)

at java.lang.ProcessImpl.start(ProcessImpl.java:91)

at java.lang.ProcessBuilder.start(ProcessBuilder.java:453)

... 23 more

 

 

 

Full Report: http://pastebin.com/8i7XEjMD

Link to comment
Share on other sites

Easiest way to modify forge files I'd say would be to download the forge src package from files.minecraftforge.net and run the install file. Open the generated eclipse environment and edit away!

 

Once you're ready to make the pull request, push all of your changes to your forked repository.

Link to comment
Share on other sites

That would work for any forge added files, but it wont generate the needed patch files for altered Minecraft classes.

 

Unfortunately I don't seem to be able to setup an environment also.

Not sure if things are not yet set up, things have changed, I'm just having bad luck, or just out right forgot how :)

 

I was sure it was as simple as

- download forge from github (MinecraftForge-master.zip)

- extract to a folder

- download fml from github (FML-master.zip)

- put files in /forge/fml/

- run /forge/setup.py

 

but that isn't providing the usual results

/forge/mcp/src_base doesn't exist, nor does /forge/mcp/src_work

and /forge/eclipse-workspace-dev.zip is never extracted to /forge/eclipse

 

I thought about manually setting it up but ran into a snag

while src_work is easy, its the same we use to create mods

src_base is another thing, its a decompile with merged client and server, fml patches, but no forge patches.

 

update_patches.py compares src_work and src_base, if you set up the folders wrong the patch files will be an unusable mess.

Link to comment
Share on other sites

Switching to windows was a bit weird, but this seems to have ALMOST worked.

 

This is the output I'm getting: http://pastebin.com/N0nhwvny

 

It seems to be MCP throwing an error and while I'm no expert in this regards, I think it's related to a python script building mcp and possibly the fact that the file system attempts.... well lemme show you the final error:

 

 

recompile:

    [exec] == MCP 8.03 (data: 8.03, client: 1.6.1, server: 1.6.1) ==

    [exec] FATAL ERROR

    [exec] Traceback (most recent call last):

    [exec]  File "C:\Minecraft\forge/mcp/runtime/recompile.py", line 29, in re

compile

    [exec]    commands = Commands(conffile, verify=True)

    [exec]  File "C:\Minecraft\forge\mcp\runtime\commands.py", line 206, in __

init__

    [exec]    self.checkjava()

    [exec]  File "C:\Minecraft\forge\mcp\runtime\commands.py", line 853, in ch

eckjava

    [exec]    results.extend(whereis('javac.exe', os.getenv("JAVA_HOME")))

    [exec]  File "C:\Minecraft\forge\mcp\runtime\pylibs\whereis.py", line 14,

in whereis

    [exec]    if not os.path.exists(rootdir):

    [exec]  File "genericpath.pyc", line 18, in exists

    [exec] TypeError: coercing to Unicode: need string or buffer, NoneType foun

d

 

BUILD FAILED

C:\Minecraft\forge\fml\build.xml:116: exec returned: 1

 

Total time: 10 minutes 4 seconds

failed: 1

 

 

Specifically at one point it shows:

 

 

    [exec] Traceback (most recent call last):

    [exec]  File "C:\Minecraft\forge/mcp/runtime/recompile.py", line 29, in re

compile

    [exec]    commands = Commands(conffile, verify=True)

    [exec]  File "C:\Minecraft\forge\mcp\runtime\commands.py", line 206, in __

init__

 

 

and I noticed that "C:\Minecraft\forge/mcp/runtime/recompile.py" is.... well I'm pretty sure that's not a valid windows file? I'm honestly a bit out of my depth here right now, but if nobody else has any ideas I can try to go in and get it fixed for myself.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.