Jump to content

Ore Generation in 1.16.5


Koolade446

Recommended Posts

So I spent forever trying to figure this out so hopefully this solves the problem for those of you in the same situation.

So we use the BiomeLoadingEvent to catch when biomes are loading and add our ConfiguredFeature. Ore Generation like so:

public class WorldGen {

    public static final ConfiguredFeature<?, ?> yourOre = Feature.ORE.withConfiguration(
            new OreFeatureConfig(OreFeatureConfig.FillerBlockType.BASE_STONE_OVERWORLD, YourRegistryHandler.YOUR_ORE.get().getDefaultState(), 4)) //vein size
            .range(12).square() //maximum y level where ore can spawn
            .count(3); //how many veins maximum per chunck

    public static void generateOre(final BiomeLoadingEvent event) {
        BiomeGenerationSettingsBuilder generation = event.getGeneration();
        if (event.getCategory().equals(Biome.Category.ICY)) { //OPTIONAL IF STATMENT allows you to generate ores in specfifc biome types for exmaple icy biomes
            generation.withFeature(GenerationStage.Decoration.UNDERGROUND_ORES, yourOre);
        }
    }
}

Now we need to know where to register this event do NOT use EventBus it will crash your mod on startup by trying to register generation before registering your ore block instead we register this in our main class like so:

//if you use the mdk this function will be pre generated so we only add our refrence here
private void setup(final FMLCommonSetupEvent event) {
        // some preinit code
        LOGGER.info("HELLO FROM PREINIT");
        LOGGER.info("DIRT BLOCK >> {}", Blocks.DIRT.getRegistryName());
  	MinecraftForge.EVENT_BUS.addListener(EventPriority.HIGH, WorldGen::generateOre); //our refrence
    }

 

ALTERNITIVE use if you are generating a bunch of ores in the same way

 


public class WorldGen {

  public static final List<ConfiguredFeature<?, ?>> yourOreList = new ArrayList<>();
  
  public static void init() {
      yourOreList.add(Feature.ORE.withConfiguration(
            new OreFeatureConfig(OreFeatureConfig.FillerBlockType.BASE_STONE_OVERWORLD, YourRegistryHandler.YOUR_ORE_1.get().getDefaultState(), 4)) //vein size
            .range(12).square() //maximum y level where ore can spawn
            .count(3); //how many veins maximum per chunck
      );
      
      yourOreList.add(Feature.ORE.withConfiguration(
            new OreFeatureConfig(OreFeatureConfig.FillerBlockType.BASE_STONE_OVERWORLD, YourRegistryHandler.YOUR_ORE_2.get().getDefaultState(), 4)) //vein size
            .range(12).square() //maximum y level where ore can spawn
            .count(3); //how many veins maximum per chunck
      );

    public static void generateOre(final BiomeLoadingEvent event) {
        BiomeGenerationSettingsBuilder generation = event.getGeneration();
        for (ConfiguredFeature ore : yourOreList) {
          generation.withFeature(GenerationStage.Decoration.UNDERGROUND_ORES, ore);
        }
    }
}

You still register in the same way.

 

Hope this helps.

Edited by Koolade446
Format error
  • Like 1
Link to comment
Share on other sites

This will crash if loaded before blocks are registered and will bottleneck world gen for other mods. The ConfiguredFeature needs to be registered to the associated WorldGenRegistries registry. It also should be made after all registries have passed (e.g. FMLCommonSetupEvent) and registered there via Registry::register since there is no forge associated registry. This can be done by lazily storing the value and resolving it within the common setup.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi everyone  I'm trying to make a custom door and give it a custom sound. In order to do so I've registered the sounds like this   private static final DeferredRegister<SoundEvent> SOUNDS = DeferredRegister.create(ForgeRegistries.SOUND_EVENTS, MineWorld.MOD_ID); ... public static final RegistryObject<SoundEvent> SCULK_DOOR_CLOSE = SOUNDS.register("sculk_door_close", () -> SoundEvent.createVariableRangeEvent(new ResourceLocation(MineWorld.MOD_ID, "sculk_door_close"))); public static final RegistryObject<SoundEvent> SCULK_DOOR_OPEN = SOUNDS.register("sculk_door_open", () -> SoundEvent.createVariableRangeEvent(new ResourceLocation(MineWorld.MOD_ID, "sculk_door_open"))); call the register method of the Sounds registry as the first thing in my mod initialize method IEventBus eventBus = FMLJavaModLoadingContext.get().getModEventBus(); SOUNDS.register(eventBus); Then I create a BlockSetType like this   public static final BlockSetType SCULK = BlockSetType.register(new BlockSetType(new ResourceLocation(MineWorld.MOD_ID, "sculk").toString(), true, SoundType.WOOD, SCULK_DOOR_CLOSE.get(), SCULK_DOOR_OPEN.get(), SoundEvents.WOODEN_TRAPDOOR_CLOSE, SoundEvents.WOODEN_TRAPDOOR_OPEN, SoundEvents.WOODEN_PRESSURE_PLATE_CLICK_OFF, SoundEvents.WOODEN_PRESSURE_PLATE_CLICK_ON, SoundEvents.WOODEN_BUTTON_CLICK_OFF, SoundEvents.WOODEN_BUTTON_CLICK_ON); And finally the door block like this private static final DeferredRegister<Block> BLOCKS = DeferredRegister.create(ForgeRegistries.BLOCKS, MineWorld.MOD_ID); ... BLOCKS.register("sculk_door", () -> new DoorBlock(BlockBehaviour.Properties.copy(Blocks.OAK_DOOR), blockSetType)); But when I launch the game I get this error   Registry Object not present: mineworld:sculk_door_close Am I doing something wrong? Maybe the BlockSetType registration needs to be done in a different way? I have other BlockSetTypes registered like this that only uses vanilla sounds and they work just fine. You can see an example in my GitHub repo here: https://github.com/JimiIT92/MineWorld/blob/master/src/main/java/org/mineworld/core/MWBlockSetTypes.java
    • it was eldritch end, thank you
    • Okay. Thank you. I think it works now. I added the jdk-17 path to the batch instead of the jvm arguments txt file. The windows command prompt is just blank, but when I close the native windows command prompt, the java command prompt opens & loads the server. If that won't cause issues then I'm all good. 
    • I have no idea - the last mentioned mods are eldritch_end, supplementaries and mahoutsukai Start with removing mahoutsukai
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.