Jump to content

Recommended Posts

Posted

Hi,

I am trying to get HikariCP bundled with my mod as a one fat jar. But there is a problem where HikariCP causes reobfJar to fail with InvalidArgumentException, and I'm not sure why.

Here is my gradle code right now (I left out a lot of stuff which I don't think matters):
 

configurations {
    embed
}

dependencies {
    minecraft 'net.minecraftforge:forge:1.16.5-36.1.0'
	embed group: 'com.zaxxer', name: 'HikariCP', version: '4.0.3'
    compileOnly group: 'com.ea.async', name: 'ea-async', version: '1.2.3'
}

jar {
    from configurations.embed.collect{ it.isDirectory() ? it : zipTree(it) }
    manifest {
        attributes([
                "Specification-Title": "examplemod",
                "Specification-Vendor": "examplemodsareus",
                "Specification-Version": "1", // We are version 1 of ourselves
                "Implementation-Title": project.name,
                "Implementation-Version": "${version}",
                "Implementation-Vendor" :"examplemodsareus",
                "Implementation-Timestamp": new Date().format("yyyy-MM-dd'T'HH:mm:ssZ")
        ])
    }
}

jar.finalizedBy('reobfJar')

 

As I understand, this is the current order of events:

  1. `jar` task to run, which will bundle all the dependencies marked with `embed`, which will create the fat jar
  2. `reobfJar` will run on that fat jar.


Would I would like to do instead is this order of events:

  1. `jar` task to run, but no fat jar is created at this time.
  2. `reobfJar` will run on the output of `jar`.
  3. A new task runs, which will take the output of `reobfJar` and combine it with the dependencies marked with `embed` to create the one fat jar

 

I think the code would look something like this:
 

jar {
    manifest {
        attributes([
            "Specification-Title": "examplemod",
            "Specification-Vendor": "examplemodsareus",
            "Specification-Version": "1", // We are version 1 of ourselves
            "Implementation-Title": project.name,
            "Implementation-Version": "${version}",
            "Implementation-Vendor" :"examplemodsareus",
            "Implementation-Timestamp": new Date().format("yyyy-MM-dd'T'HH:mm:ssZ")
        ])
    }
}

jar.finalizedBy('reobfJar')

task bundle(type: Jar) {
    manifest {
        attributes 'Main-Class': 'com.gluecode.fpvdrone.server.Main'
    }
    from "build/libs/modid-1.0.jar"
    from configurations.embed.collect{ it.isDirectory() ? it : zipTree(it) }
}


The problems I have with the above is:

  1. I have to run `./gradlew bundle` after running `./gradlew buildNeeded`. And I'd like to just run 1 command.
  2. It doesn't work because it results in an invalid mod jar.

I'm am still learning gradle. Can anyone help me?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.