Jump to content

Replacing base class


sep87x

Recommended Posts

Hey there,

 

I'm having some problems with a mod I'm working on. I want to rewrite the WorldGenDesertWells class so they become useful (seriously, they are pretty useless as they are now). As I finished and made the whole re-compile-obfuscate-blah procedure I recognized and remembered that it's impossible due to the new 1.6 update to replace base class files. Now I'm having a bit of a problem: I read a lot about ClassTransformers and stuff, but it didn't fit my imagination.

 

So my question is: is there any way to replace a whole vanilla class? The "new" class contains a new field, a (quiet huge) method and some changes in the generate() method. I do not own the original class file, because I've already edited it. Does anyone have an idea on how to do this? I am very close to release this mod and this is my last hurdle. I don't want to start the whole project all over again.

 

Greets from Germany

~ sep87x

Link to comment
Share on other sites

possible but hard..

 

anyways wouldn't it be easier to replace every reference to that class with one to your own class. That at least sounds like less work if it's not called all over the place which it sounds like it ain't ?

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

well I suggested moving it to it's own class. Since you where about to req. a few hundred byte code manipulations to change the whole class I figured you knew your java.

 

In any case it sounds quite extreme to do it like that, are you sure there aren't better ways to do the generation?

 

Also the base class thing not getting edited is possible to override for a mod if ya want to, but as always base class edited will possibly make your mod incompatible with other mods.

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

In any case it sounds quite extreme to do it like that, are you sure there aren't better ways to do the generation?

 

My current plan was to make the "custom" generation only one method in the main class to call, but diesieben07 had the better idea.

 

How I would do it: Disable the vanilla WorldGenDesertWell by removing the override BiomeGenDesert.decorate via ASM (should be quite easy). That will stop the generation and then just generate a new type of well.

 

Thanks for that. Is there already an interface for that in Forge? I know I have to read something about ASM, but I already know a byte about it.

Link to comment
Share on other sites

Okay, so I read through the whole thing and made the following: I set up a IClassTransformer which locates the decorate()-function inside the BiomeGenDesert class. With some byte code stuff I attempted to remove these lines:

 

            WorldGenDesertWells worldgendesertwells = new WorldGenDesertWells();
            worldgendesertwells.generate(par1World, par2Random, k, par1World.getHeightValue(k, l) + 1, l);

 

(Small amount of code, I hope it is okay to post it directly here)

 

... and make it to this:

 

            new FakeWorldGenDesertWells().generate(par1World, par2Random, k, par1World.getHeightValue(k, l) + 1, l);

 

I wrote it out and retrieved the byte code. My class transformer looks like this now: http://gw.minecraftforge.net/Ybvi

 

Before compiling, I have some questions left. Where do I need to register the class transformer and the FMLLoadingPlugin (onInit() should be clear, but which class is needed)? There are some other classes with the decorate()-method in it as I looked inside conf/methods. At the code it is now, should it be clear which method I want? I think "a" is a bit short ... even for a recompiled source.

Link to comment
Share on other sites

I'm sorry but I'm a bit confused now. I don't have an idea about coremods, so I need to ask. The DesertGenFMLLoadingPlugin (http://gw.minecraftforge.net/RBEG) class is the main class of the core mod. I've already "linked" the ClassTransformer in it. Do I need to add the name of the "original" mod in the method getModContainerClass(), so ModDesertWells.class.getName()? What does the manifest file look like? And I tried to add the argument (in program arguments) "fml.coreMods.load net.sep87x.desertwells.DesertGenFMLLoadingPlugin", but it didn't work. Am I doing something wrong?

Link to comment
Share on other sites

As far as I understood: I have two "main" classes now, the ModDesertWells class (\w @Mod annotation) and the DesertGenFMLLoadingPlugin (implements IFMLLoadingPlugin). Is it possible to "merge" both files? I mean if I can use the implementation in my ModDesertWells class? And ...

 

I tried to add the argument (in program arguments) "fml.coreMods.load net.sep87x.desertwells.DesertGenFMLLoadingPlugin", but it didn't work. Am I doing something wrong?

 

I am very sorry to ask so much. I'm new to coremods. Alternatively a link about coremods would be MUCH more appreciated. I couldn't find a page where coremods are being described.

Link to comment
Share on other sites

The link you found above is more or less the only collection of info on coremods besides the source code :P

You can replace the ModDessertWells with the FMMLLoadingplugin class totally if you'd like, or use both as two seperate mods if you wish.

 

 

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

I still don't get it. There must be something wrong when running MC. I removed the class with the @Mod annotation, moved anything to a ModContainer, and put the path into the gteModContainerClass() method of the FMLLoadingPlugin class. There must be something wrong with the running settings. I added the argument and added an environment variable.

 

uiEqWA8.png

 

dC1cG04.png

 

I just don't get it. What am I doing wrong?

Link to comment
Share on other sites

Argh, me stupid ::)

 

I added it to the vm args. Well, it recognizes the mod as a coremod, BUT there is another hurdle that popped up suddenly. There's a ClassNotFound exception in the package cpw.mods.fml.common.asm.FMLSanityChecker. See the full stack trace here: http://gw.minecraftforge.net/uPpv Is this normal?

 

My nerves are done for today. I guess I should wait for the next morning to come. Thanks to anyone who has helped me so far.

 

P.S. The class exists in the package explorer.

 

y8LTHgn.png

Link to comment
Share on other sites

I followed some instructions from the stack trace forum. That means I checked the class build path (everything alright) and checked the code where the exception has been created. I guess that something is wrong with my main coremod class (http://gw.minecraftforge.net/ufOJ), but I can't spot anything. It still raises the ClassNotFoundException (http://gw.minecraftforge.net/uPpv). Any ideas?

Link to comment
Share on other sites

java.lang.RuntimeException: java.lang.ClassNotFoundException: cpw.mods.fml.common.asm.FMLSanityChecker

 

Finally. I am not entirely sure, but I guess I found the source of the ClassNotFound error. As I read through the stack trace and searched for the path inside the jar, I couldn't find the common directory, the repackage and the server directory inside cpw/mods/fml. Might that be the source of the error? And what would be a way to fix this?

Link to comment
Share on other sites

I've gotten some ASM stuff to work, not replacing a whole class though. What I would assume you do is this:

(just pseudocode)

for the transformer, the transform method will be called for *I think* every class

byte[] transform(String name, byte[] bytes)
{
if (name == obfuscated name || name == deobfuscatedname)
{
   byte[] newClass = getYourClassBytes();
   return newClass;
}
}

The transform method kinda just goes through everything, see if you want to make changes, then asks for the modified or unmodified bytes back. You might be getting class not found because you aren't returning the bytes of the class.

Link to comment
Share on other sites

I'm rewriting the decorate() method in the BiomeGenDesert class ... so a method.

Try this, it replaces 2 method bodies, and I've used it to modify a few things. Just copy the method declaration and then write your own body in a new class.

public byte[] patch (String name, byte[] bytes, String desc, String iFile, String rname) throws IOException
{
	ClassNode cn = new ClassNode();
	ClassReader cr = new ClassReader(bytes);
	//the class node is now visiting the bytes that the class reader has
	cr.accept(cn,0);
	//giving us something we can look at all the methods
	Iterator<MethodNode> methods = cn.methods.iterator();
	//creating the method node we are going to mess with
	MethodNode mn = null;
	while (methods.hasNext())
	{
		MethodNode m = methods.next();
		if (m.name.equals(name) && m.desc.equals(desc))
		{
			System.out.printf("Found a method we want to transform%n");
			mn = m;
			break;
		}
	}
	//get the file we're going to replace a method with
	java.io.InputStream in = DHNTransformer.class.getResourceAsStream(iFile);
	byte[] newbyte = IOUtils.toByteArray(in);
	//get the method
	ClassNode cnr = new ClassNode();
	ClassReader crr = new ClassReader(newbyte);
	crr.accept(cnr,0);
	//find the right one
	Iterator<MethodNode> repalcemethods = cnr.methods.iterator();
	MethodNode mnr = null;
	while (repalcemethods.hasNext())
	{
		MethodNode m = repalcemethods.next();
		if (m.name.equals(rname))
		{
			System.out.printf("Found the right method that is going to be the replacement");
			mnr = m;
			break;
		}
	}
	//now we start changing the bodies
	mn.instructions = mnr.instructions;
	ClassWriter cw = new ClassWriter(ClassWriter.COMPUTE_MAXS | ClassWriter.COMPUTE_FRAMES);
	//let the writer visit the class now
	cn.accept(cw);

	return cw.toByteArray();

}

And how to use it:

if (arg0.equals("bhg")) {
		System.out.println("Doing RenderPlayer transformers in a obfuscated environment");
		newimport("",arg2);
		try {
			return patch("a", arg2, "(Lue;)V","/DHNCore/asm/Methods.class","renderFirstPersonArm");
		} catch (IOException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}
if (arg0.equals("net.minecraft.client.renderer.entity.RenderPlayer")) {
		System.out.println("Doing RenderPlayer transformers in a de-obfuscated environment");
		//make sure we import the class so that it does crash
		newimport("",arg2);
		try {
			return patch("renderFirstPersonArm", arg2, "(Lnet/minecraft/entity/player/EntityPlayer;)V","/DHNCore/asm/Methods.class","renderFirstPersonArm");
		} catch (IOException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}

		}

Link to comment
Share on other sites

So, last question: the Methods.class in your patch method ... does it contain a method it should be replaced with?

 

P.S. While skimming the transformer class I found the error in the code ... well ... nobody was born perfect.

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.


  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.