Jump to content

Replacing base class


sep87x

Recommended Posts

Hey there,

 

I'm having some problems with a mod I'm working on. I want to rewrite the WorldGenDesertWells class so they become useful (seriously, they are pretty useless as they are now). As I finished and made the whole re-compile-obfuscate-blah procedure I recognized and remembered that it's impossible due to the new 1.6 update to replace base class files. Now I'm having a bit of a problem: I read a lot about ClassTransformers and stuff, but it didn't fit my imagination.

 

So my question is: is there any way to replace a whole vanilla class? The "new" class contains a new field, a (quiet huge) method and some changes in the generate() method. I do not own the original class file, because I've already edited it. Does anyone have an idea on how to do this? I am very close to release this mod and this is my last hurdle. I don't want to start the whole project all over again.

 

Greets from Germany

~ sep87x

Link to comment
Share on other sites

possible but hard..

 

anyways wouldn't it be easier to replace every reference to that class with one to your own class. That at least sounds like less work if it's not called all over the place which it sounds like it ain't ?

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

well I suggested moving it to it's own class. Since you where about to req. a few hundred byte code manipulations to change the whole class I figured you knew your java.

 

In any case it sounds quite extreme to do it like that, are you sure there aren't better ways to do the generation?

 

Also the base class thing not getting edited is possible to override for a mod if ya want to, but as always base class edited will possibly make your mod incompatible with other mods.

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

In any case it sounds quite extreme to do it like that, are you sure there aren't better ways to do the generation?

 

My current plan was to make the "custom" generation only one method in the main class to call, but diesieben07 had the better idea.

 

How I would do it: Disable the vanilla WorldGenDesertWell by removing the override BiomeGenDesert.decorate via ASM (should be quite easy). That will stop the generation and then just generate a new type of well.

 

Thanks for that. Is there already an interface for that in Forge? I know I have to read something about ASM, but I already know a byte about it.

Link to comment
Share on other sites

Okay, so I read through the whole thing and made the following: I set up a IClassTransformer which locates the decorate()-function inside the BiomeGenDesert class. With some byte code stuff I attempted to remove these lines:

 

            WorldGenDesertWells worldgendesertwells = new WorldGenDesertWells();
            worldgendesertwells.generate(par1World, par2Random, k, par1World.getHeightValue(k, l) + 1, l);

 

(Small amount of code, I hope it is okay to post it directly here)

 

... and make it to this:

 

            new FakeWorldGenDesertWells().generate(par1World, par2Random, k, par1World.getHeightValue(k, l) + 1, l);

 

I wrote it out and retrieved the byte code. My class transformer looks like this now: http://gw.minecraftforge.net/Ybvi

 

Before compiling, I have some questions left. Where do I need to register the class transformer and the FMLLoadingPlugin (onInit() should be clear, but which class is needed)? There are some other classes with the decorate()-method in it as I looked inside conf/methods. At the code it is now, should it be clear which method I want? I think "a" is a bit short ... even for a recompiled source.

Link to comment
Share on other sites

I'm sorry but I'm a bit confused now. I don't have an idea about coremods, so I need to ask. The DesertGenFMLLoadingPlugin (http://gw.minecraftforge.net/RBEG) class is the main class of the core mod. I've already "linked" the ClassTransformer in it. Do I need to add the name of the "original" mod in the method getModContainerClass(), so ModDesertWells.class.getName()? What does the manifest file look like? And I tried to add the argument (in program arguments) "fml.coreMods.load net.sep87x.desertwells.DesertGenFMLLoadingPlugin", but it didn't work. Am I doing something wrong?

Link to comment
Share on other sites

As far as I understood: I have two "main" classes now, the ModDesertWells class (\w @Mod annotation) and the DesertGenFMLLoadingPlugin (implements IFMLLoadingPlugin). Is it possible to "merge" both files? I mean if I can use the implementation in my ModDesertWells class? And ...

 

I tried to add the argument (in program arguments) "fml.coreMods.load net.sep87x.desertwells.DesertGenFMLLoadingPlugin", but it didn't work. Am I doing something wrong?

 

I am very sorry to ask so much. I'm new to coremods. Alternatively a link about coremods would be MUCH more appreciated. I couldn't find a page where coremods are being described.

Link to comment
Share on other sites

The link you found above is more or less the only collection of info on coremods besides the source code :P

You can replace the ModDessertWells with the FMMLLoadingplugin class totally if you'd like, or use both as two seperate mods if you wish.

 

 

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

I still don't get it. There must be something wrong when running MC. I removed the class with the @Mod annotation, moved anything to a ModContainer, and put the path into the gteModContainerClass() method of the FMLLoadingPlugin class. There must be something wrong with the running settings. I added the argument and added an environment variable.

 

uiEqWA8.png

 

dC1cG04.png

 

I just don't get it. What am I doing wrong?

Link to comment
Share on other sites

Argh, me stupid ::)

 

I added it to the vm args. Well, it recognizes the mod as a coremod, BUT there is another hurdle that popped up suddenly. There's a ClassNotFound exception in the package cpw.mods.fml.common.asm.FMLSanityChecker. See the full stack trace here: http://gw.minecraftforge.net/uPpv Is this normal?

 

My nerves are done for today. I guess I should wait for the next morning to come. Thanks to anyone who has helped me so far.

 

P.S. The class exists in the package explorer.

 

y8LTHgn.png

Link to comment
Share on other sites

I followed some instructions from the stack trace forum. That means I checked the class build path (everything alright) and checked the code where the exception has been created. I guess that something is wrong with my main coremod class (http://gw.minecraftforge.net/ufOJ), but I can't spot anything. It still raises the ClassNotFoundException (http://gw.minecraftforge.net/uPpv). Any ideas?

Link to comment
Share on other sites

java.lang.RuntimeException: java.lang.ClassNotFoundException: cpw.mods.fml.common.asm.FMLSanityChecker

 

Finally. I am not entirely sure, but I guess I found the source of the ClassNotFound error. As I read through the stack trace and searched for the path inside the jar, I couldn't find the common directory, the repackage and the server directory inside cpw/mods/fml. Might that be the source of the error? And what would be a way to fix this?

Link to comment
Share on other sites

I've gotten some ASM stuff to work, not replacing a whole class though. What I would assume you do is this:

(just pseudocode)

for the transformer, the transform method will be called for *I think* every class

byte[] transform(String name, byte[] bytes)
{
if (name == obfuscated name || name == deobfuscatedname)
{
   byte[] newClass = getYourClassBytes();
   return newClass;
}
}

The transform method kinda just goes through everything, see if you want to make changes, then asks for the modified or unmodified bytes back. You might be getting class not found because you aren't returning the bytes of the class.

Link to comment
Share on other sites

I'm rewriting the decorate() method in the BiomeGenDesert class ... so a method.

Try this, it replaces 2 method bodies, and I've used it to modify a few things. Just copy the method declaration and then write your own body in a new class.

public byte[] patch (String name, byte[] bytes, String desc, String iFile, String rname) throws IOException
{
	ClassNode cn = new ClassNode();
	ClassReader cr = new ClassReader(bytes);
	//the class node is now visiting the bytes that the class reader has
	cr.accept(cn,0);
	//giving us something we can look at all the methods
	Iterator<MethodNode> methods = cn.methods.iterator();
	//creating the method node we are going to mess with
	MethodNode mn = null;
	while (methods.hasNext())
	{
		MethodNode m = methods.next();
		if (m.name.equals(name) && m.desc.equals(desc))
		{
			System.out.printf("Found a method we want to transform%n");
			mn = m;
			break;
		}
	}
	//get the file we're going to replace a method with
	java.io.InputStream in = DHNTransformer.class.getResourceAsStream(iFile);
	byte[] newbyte = IOUtils.toByteArray(in);
	//get the method
	ClassNode cnr = new ClassNode();
	ClassReader crr = new ClassReader(newbyte);
	crr.accept(cnr,0);
	//find the right one
	Iterator<MethodNode> repalcemethods = cnr.methods.iterator();
	MethodNode mnr = null;
	while (repalcemethods.hasNext())
	{
		MethodNode m = repalcemethods.next();
		if (m.name.equals(rname))
		{
			System.out.printf("Found the right method that is going to be the replacement");
			mnr = m;
			break;
		}
	}
	//now we start changing the bodies
	mn.instructions = mnr.instructions;
	ClassWriter cw = new ClassWriter(ClassWriter.COMPUTE_MAXS | ClassWriter.COMPUTE_FRAMES);
	//let the writer visit the class now
	cn.accept(cw);

	return cw.toByteArray();

}

And how to use it:

if (arg0.equals("bhg")) {
		System.out.println("Doing RenderPlayer transformers in a obfuscated environment");
		newimport("",arg2);
		try {
			return patch("a", arg2, "(Lue;)V","/DHNCore/asm/Methods.class","renderFirstPersonArm");
		} catch (IOException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}
if (arg0.equals("net.minecraft.client.renderer.entity.RenderPlayer")) {
		System.out.println("Doing RenderPlayer transformers in a de-obfuscated environment");
		//make sure we import the class so that it does crash
		newimport("",arg2);
		try {
			return patch("renderFirstPersonArm", arg2, "(Lnet/minecraft/entity/player/EntityPlayer;)V","/DHNCore/asm/Methods.class","renderFirstPersonArm");
		} catch (IOException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}

		}

Link to comment
Share on other sites

So, last question: the Methods.class in your patch method ... does it contain a method it should be replaced with?

 

P.S. While skimming the transformer class I found the error in the code ... well ... nobody was born perfect.

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • im stuck in a problem whit BlockEntities i cannot solve so im trying to work around it but in the less complex way possible  i think is posible to store data to the minecraft world  in older versions people talk about  WordDataSave i dont find anything about it for 1.20.4  i find a tutorial for player capability in 1.19    here is an event      //########## ########## ########## ##########     @SubscribeEvent     public static void onAttachCapabilitiesPlayer(AttachCapabilitiesEvent<Entity> event) {         if(event.getObject() instanceof Player) {             if(!event.getObject().getCapability(PlayerThirstProvider.PLAYER_THIRST).isPresent()) {                 event.addCapability(new ResourceLocation(mercmod.MOD_ID, "properties"), new PlayerThirstProvider());             }         }     }  soo i made this      //########## ########## ########## ##########     @SubscribeEvent     public static void onAttachCapabilitiesLevel(AttachCapabilitiesEvent<Level> event) {     } i think i can do some witchcraft  here  but is many things don't understand  to start whit i dont get yet how to recall the saved data from a BlockEntity  the handler still in progress the plan is to make a Map to store nbt data using the block coordinates as index later store that map as a big nbt      ########## any way the question is if theres alredy a tutorial for 1.20.4 for this ?? or some alredy working code from someone else doing something similar ?           
    • I tried this, and found out that Oculus is the mod that is crashing the game. I have removed it, and it now works fine! Thanks!
    • Hi @DanielderErbauer, I arrived here as I have the "as it does not exist in Block{minecraft:air}" error in a modpack I am trying to start. It's a long-shot, I know, but as the post that led this to being solved is missing, can I ask if you may recall what it said? Thanks in advance
    • Hm yeah sorry, not seeing anything else that's sticking out, I'd need to debug myself probably. Do you have a github or bitbucket repo? I could poke around when I have time to see what the problem might be.
    • looking around for the capabilities thing i found a piece of code and find this piece of code  //########## ########## ########## ########## @SubscribeEvent public static void addCustomTrades(VillagerTradesEvent event) { if(event.getType() == VillagerProfession.FLETCHER) { System.out.println("\n\n### VillagerProfession.FLETCHER \n\n");//<----------- Int2ObjectMap<List<VillagerTrades.ItemListing>> trades = event.getTrades(); ItemStack stack = new ItemStack(ItemInit.ARROW_STEEL.get(), 16); int villagerLevel = 1; trades.get(villagerLevel).add((trader, rand) -> new MerchantOffer( new ItemStack(Items.EMERALD, 2), stack,1,3,0.02F)); } if(event.getType() == VillagerProfession.TOOLSMITH) { System.out.println("\n\n### VillagerProfession.TOOLSMITH \n\n");//<----------- Int2ObjectMap<List<VillagerTrades.ItemListing>> trades = event.getTrades(); ItemStack stack = new ItemStack(ItemInit.INGOT_STEEL.get(), 1); int villagerLevel = 1; trades.get(villagerLevel).add((trader, rand) -> new MerchantOffer( new ItemStack(Items.EMERALD, 2), stack,10,8,0.02F)); } } //########## ########## ########## ########## the event is aknoledge and execute when the maps load  ### VillagerProfession.FLETCHER  ### VillagerProfession.TOOLSMITH  //########## But is not working      is a random piece of code is not working  could it be than this code is old 1.18 and no valid anymore for 1.20.4 or the thing are this numbers  stack,10,8,0.02F));  i dont know what this numbers means    ########## the question is ¿how to add things to the villager traders    thanks for your attention               
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.