Jump to content

Bumpay

Members
  • Posts

    61
  • Joined

  • Last visited

Everything posted by Bumpay

  1. So I already do rotate the Template via PlacementSettings. The problem is, it rotates the Template around the corner. Can I somehow set it to rotate around center?
  2. Thanks, can you tell me which settings there are for the Template class?
  3. Hello there, I have a template that should be placed in a certain area. The area defines wheter the template should be rotated and on which side of the area it should be placed. Is there an easy method to do that? Right now I am trying to play around with the addBlocksToWorld() function, but it is hard to get the right BlockPos where to place the template since it could also be rotated.
  4. Hello there, I have several objects that have a defined area. I want to store that are to NBT with the WorldSavedData class. The area is defined in the object via two BlockPos'. And I store them each with an integer array. Is there a better way to do so? Greetings, Bumpay!
  5. Ah I see the problem with that is I do not use a literal Argument builder in the way you do. I have my main Command class (TraSimCommands) and they register a new command in this case the CreateDock class and in there the fourth argument is the enum.
  6. Hello there, I have a SuggestionProvider that suggest names that could be seperated by a space. So it would be a nice feature to add quotation marks arround the names. private static final SuggestionProvider<CommandSource> SUGGEST_PORT = (source, builder) -> ISuggestionProvider.suggest(PortWorldSavedData.getPortNameListByUuid(source.getSource().asPlayer().getUniqueID(), PortWorldSavedData.get(source.getSource().asPlayer().getServerWorld())).stream(), builder); How do I do that? greetings Bumpay
  7. I don't get your way of implementing the argument. You mean i should create a for loop to get all directions out of the Direction class? But the how do I add those as an argument?
  8. Hello there, my goal is to get the Direction enum as an argument into a command. I tried this: Commands.argument("isFacing", EnumArgument.enumArgument(Direction.class)) .executes(source -> { return createShip(source.getSource(), StringArgumentType.getString(source, "shipName"), StringArgumentType.getString(source, "portName"), BlockPosArgument.getBlockPos(source, "pos1"), BlockPosArgument.getBlockPos(source, "pos2"), source.getArgument("isFacing", Direction.class)); } But that suggests me all the Direction Names which when use autocomplete can't be referred to an enum. Is there a way to get the suggestions in upper case letters? Also I only want to display the horizontal Directions. Bumpay
  9. How do I read my saved Objects back when this is how I write it? GitHub - PortWorldSavedData @Override public CompoundNBT write(CompoundNBT compound) { //NBT_Compound ListNBT portsListNBT = new ListNBT(); compound.put("ports", portsListNBT); //-NBT_List "ports" for (Port p:portList){ CompoundNBT portNBT = new CompoundNBT(); //--NBT_Compound "a single port" portNBT.putLong("uuidL", p.getOwner().getUniqueID().getLeastSignificantBits()); //---NBT_Long "uuidL" portNBT.putLong("uuidM", p.getOwner().getUniqueID().getMostSignificantBits()); //---NBT_Long "uuidM" portNBT.putBoolean("isOpen", p.isOpen()); //---NBT_Bool "isOpen" portNBT.putString("name", p.getName()); //---NBT_String "name" portNBT.putInt("x", p.getXCoordinate()); //---NBT_Int "x" portNBT.putInt("y", p.getZCoordinate()); //---NBT_Int "y" ListNBT docksListNBT = new ListNBT(); portNBT.put("docks", docksListNBT); //---NBT_List "docks" for (Dock d:p.getDocks()) { CompoundNBT dockNBT = new CompoundNBT(); //----NBT_Compound "a single dock" dockNBT.putBoolean("isHomeDock", d.isHomeDock); //----NBT_Bool "isHomeDock" dockNBT.putBoolean("isUsed", d.isUsed); //----NBT_Bool "isUsed" dockNBT.putIntArray("dockArea", d.getDockArea().toNBTTagIntArray().getIntArray()); //----NBT_Int[] "dockArea" docksListNBT.add(dockNBT); } portsListNBT.add(portNBT); } return compound; } Edit: Okay I tried around a bit and does this might be the right way to load the data again? @Override public void read(CompoundNBT nbt) { ListNBT list = nbt.getList("ports", Constants.NBT.TAG_COMPOUND); for (int i = 0; i < list.stream().count(); i++) { CompoundNBT portNBT = list.getCompound(i); ListNBT listDocks = portNBT.getList("docks", Constants.NBT.TAG_COMPOUND); ArrayList<Dock> docks = new ArrayList<>(); for (int j = 0; j < listDocks.stream().count(); j++) { CompoundNBT dockNBT = listDocks.getCompound(i); Dock dock = new Dock( dockNBT.getBoolean("isHomedock"), dockNBT.getBoolean("isUsed"), new Vec3i(dockNBT.getIntArray("pos1")[0], dockNBT.getIntArray("pos1")[1], dockNBT.getIntArray("pos1")[2]), new Vec3i(dockNBT.getIntArray("pos2")[0], dockNBT.getIntArray("pos2")[1], dockNBT.getIntArray("pos2")[2])); docks.add(dock); } Port port = new Port( new UUID(portNBT.getLong("uuidM"), portNBT.getLong("uuidL")), portNBT.getString("name"), portNBT.getInt("x"), portNBT.getInt("z"), portNBT.getBoolean("isOpen"), docks); portList.add(port); } }
  10. How can I create a switch case in a command? I want the command /create to merge all /createPort, / createDock, /createShip etc. So the player can type in / create [type] and then the arguments vary, depending on what the type needs.
  11. NIce this finally helps me to figure out problems on my own and work even more efficient 👍 Can I somehow check the objects I have saved now?
  12. I found it under the debug options, so it might only work when i run the debug mode right?
  13. Ah well that helped alot. Then for quick fix these errors is it possible, and if so how, to edit and build the code while running the client?
  14. Is it right, that the break happens while I am loading the world, and it does not breaks when I execut the command? I placed it here in CreatePort.java:
  15. At the debug.log? Because there it only says [03Okt2020 12:31:45.476] [Render thread/INFO] [net.minecraft.client.gui.NewChatGui/]: [CHAT] An unexpected error occurred trying to execute that command So where do I need to place it when I want to stop it after the user executes the command? I tried some places but they only fired when loading the world and not in-game.
  16. I didn't know how important they are. I will push them in a moment. Well, right after executing the command: Can I use the Debugger with breakpoints? Because when I first tried it, it went off when I started the world, probably because it was initialized there. So where do I need to set the brekpoints when I watch the client actions?
  17. I have now created a repository on GitHub for my TravelSimplifiedMod. So you are saying I don't need networking for now? Then if you look at my CreatePort class, why do I get a NullPointerExeption when I execute the command?
  18. Alright thanks man, so I will definetly read myself into Git. Also I now want to connect to the WorldSavedData through a command (later a gui), do I need to do this via a network? Because the command is executed from the client side, but it needs to be saved on the server side? And I do get this error when I run my command: [03Okt2020 02:07:13.719] [Server thread/FATAL] [net.minecraftforge.fml.loading.RuntimeDistCleaner/DISTXFORM]: Attempted to load class net/minecraft/client/Minecraft for invalid dist DEDICATED_SERVER The command looks like this: private static int createPort(CommandSource source, String name, int xCoordinate, int zCoordinate) throws CommandSyntaxException { TraSimPacketHandler.INSTANCE.sendToServer(new PacketCreatePort(source.asPlayer().getUniqueID(), name, xCoordinate, zCoordinate)); /* Port port = new Port(source.asPlayer(), name, xCoordinate, zCoordinate); PortWorldSavedData portWorldSavedData = PortWorldSavedData.get(source.asPlayer().getServerWorld()); portWorldSavedData.addPortToList(port, portWorldSavedData); */ source.sendFeedback(new TranslationTextComponent("commands.createPort.name.x.y", name , xCoordinate, zCoordinate), true); return 1; } And if this is also important I do get a NullPointerException with the old commented stuff. latest.log
  19. I run my mod now on the server and the memory use constantly goes up and gets dumped in repeat. Also I get this message when I join the server: Server: [19:51:03] [Netty Server IO #1/ERROR] [minecraft/ArgumentTypes]: Could not serialize net.minecraftforge.server.command.ModIdArgument@6c4cc19b (class net.minecraftforge.server.command.ModIdArgument) - will not be sent to client! [19:51:03] [Netty Server IO #1/ERROR] [minecraft/ArgumentTypes]: Could not serialize net.minecraftforge.server.command.EnumArgument@5d8e20ce (class net.minecraftforge.server.command.EnumArgument) - will not be sent to client! Client: [20:03:51] [Netty Client IO #0/ERROR] [minecraft/ArgumentTypes]: Could not deserialize minecraft: [20:03:51] [Netty Client IO #0/ERROR] [minecraft/ArgumentTypes]: Could not deserialize minecraft: And would it be easier for you if I brin my project to git, so you could look at the code? Or would it be unnessesary?
  20. So like this: private static int createPort(CommandSource source, String name, int xCoordinate, int zCoordinate) throws CommandSyntaxException { Port port = new Port(source.asPlayer(), name, xCoordinate, zCoordinate); PortWorldSavedData.addPortToList(port, PortWorldSavedData.get(source.asPlayer().getServerWorld())); source.sendFeedback(new TranslationTextComponent("commands.createPort.name.x.y", name , xCoordinate, zCoordinate), true); return 1; } and I call markDirty here: public static void addPortToList(Port port, PortWorldSavedData instance){ portList.add(port); instance.markDirty(); } so thats all? Now it will save my list of ports everytime I create a new one.
  21. Alright I got it working! This topic can be closed if this is a thing here.
  22. And the markDirty is completly fine here? @Override public CompoundNBT write(CompoundNBT compound) { //NBT_Compound ListNBT portsListNBT = new ListNBT(); compound.put("ports", portsListNBT); //-NBT_List "ports" for (Port p:portList){ CompoundNBT portNBT = new CompoundNBT(); //--NBT_Compound "a single port" portNBT.putLong("uuidL", p.getOwner().getUniqueID().getLeastSignificantBits()); //---NBT_Long "uuidL" portNBT.putLong("uuidM", p.getOwner().getUniqueID().getMostSignificantBits()); //---NBT_Long "uuidM" portNBT.putBoolean("isOpen", p.isOpen()); //---NBT_Bool "isOpen" portNBT.putString("name", p.getName()); //---NBT_String "name" portNBT.putInt("x", p.getXCoordinate()); //---NBT_Int "x" portNBT.putInt("y", p.getZCoordinate()); //---NBT_Int "y" ListNBT docksListNBT = new ListNBT(); portNBT.put("docks", docksListNBT); //---NBT_List "docks" for (Dock d:p.getDocks()) { CompoundNBT dockNBT = new CompoundNBT(); //----NBT_Compound "a single dock" dockNBT.putBoolean("isHomeDock", d.isHomeDock); //----NBT_Bool "isHomeDock" dockNBT.putBoolean("isUsed", d.isUsed); //----NBT_Bool "isUsed" dockNBT.putIntArray("dockArea", d.getDockArea().toNBTTagIntArray().getIntArray()); //----NBT_Int[] "dockArea" docksListNBT.add(dockNBT); } portsListNBT.add(portNBT); } this.markDirty(); return compound; }
  23. Ah that is nice. So I assume I need to create an instance of my PortWorldSavedData. Do I need to do it in a specific space?
  24. How/Where do I implement my new PortWorldSavedData? I saw Minecraft uses a save function to save it to a file. But where and when do I write the save funtion? Also I found the isDirty attribute. I assume I need to mark the WorldSavedData as dirty, when the nbt data changed. Can't I just simply mark it dirty at the end of my write function? because i have seen, that mojang did not do that in their write functions. Why so?
  25. Ah and what do I need to give the write function as it needs a CompoundNBT?
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.