Retsal

Hi, I need a custom armor model and I can't figure out how to do it. I've been reading documentation (modding tutorials, forge wiki -) but I still don't know how to archieve it. I would like to do a helmet with horns to practice. Could you point me the proper way to do it? Thank you so much :)

Finally I figure out how to solve my last mistake. Thank you so much for your help anyway The sound path must be like this: assets.rsmakeitharder sounds.json sounds heartbeat.ogg

Thank you for your quick response @diesieben07 Now Minecraft doesn't crash, but it is not working. I can't hear any sound after I equip the helmet. Code update for MihArmorMaterial (getSoundEvent is hardcoded for testing propouse): package retsal.rsmakeitharder.common.armor; import java.util.function.Supplier; import net.minecraft.inventory.EquipmentSlotType; import net.minecraft.item.IArmorMaterial; import net.minecraft.item.crafting.Ingredient; import net.minecraft.util.SoundEvent; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.api.distmarker.OnlyIn; import net.minecraftforge.common.util.Lazy; import retsal.rsmakeitharder.MakeItHarder; import retsal.rsmakeitharder.init.InitItems; import retsal.rsmakeitharder.init.InitSounds; public enum MihArmorMaterial implements IArmorMaterial { RUBY("ruby", 30, new int[] {2, 6, 7, 3}, 15, null, 1.0F, 0.0F, () -> Ingredient.fromItems(InitItems.NETHER_STAR_CORE.get())); ; private static final int[] MAX_DAMAGE_ARRAY = new int[] {13,15,16,11}; private final String name; private final int maxDamageFactor; private final int[] damageReductionAmountArray; private final int enchantability; private final SoundEvent soundEvent; private final float toughness; private final float knockbackResistance; private final Lazy<Ingredient> repairMaterialLazy; private MihArmorMaterial( String nameIn, int maxDamageFactorIn, int[] damageReductionAmountArrayIn, int enchantabilityIn, SoundEvent soundEventIn, float toughnessIn, float knockbackResistanceIn, Supplier<Ingredient> repairMaterialSupplier ) { this.name = MakeItHarder.MODID + ":" + nameIn; this.maxDamageFactor = maxDamageFactorIn; this.damageReductionAmountArray = damageReductionAmountArrayIn; this.enchantability = enchantabilityIn; this.soundEvent = soundEventIn; this.toughness = toughnessIn; this.knockbackResistance = knockbackResistanceIn; this.repairMaterialLazy = Lazy.concurrentOf(repairMaterialSupplier); } @Override public int getDurability(EquipmentSlotType slotIn) { return MAX_DAMAGE_ARRAY[slotIn.getIndex()] * this.maxDamageFactor; } @Override public int getDamageReductionAmount(EquipmentSlotType slotIn) { return this.damageReductionAmountArray[slotIn.getIndex()]; } @Override public int getEnchantability() { return this.enchantability; } @Override public SoundEvent getSoundEvent() { return InitSounds.HEARTBEAT.get(); } @Override public Ingredient getRepairMaterial() { return this.repairMaterialLazy.get(); } @OnlyIn(Dist.CLIENT) public String getName() { return this.name; } @Override public float getToughness() { return this.toughness; } @Override public float getKnockbackResistance() { return this.knockbackResistance; } } Edit: When I start the game the log shows: [23:47:48] [modloading-worker-3/DEBUG] [ne.mi.re.GameData/REGISTRIES]: All registries frozen [23:47:48] [Render thread/DEBUG] [ne.mi.fm.ForgeI18n/CORE]: Loading I18N data entries: 5224 [23:47:48] [Render thread/WARN] [minecraft/SoundEngine]: Missing sound for event: rsmakeitharder:heartbeat [23:47:48] [Render thread/INFO] [minecraft/SoundSystem]: OpenAL initialized. [23:47:48] [Render thread/INFO] [minecraft/SoundEngine]: Sound engine started

Hi I was trying to register my own SoundEvent, and use it when you equip your helmet. MakeItHarder (main class): package retsal.rsmakeitharder; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; import net.minecraft.item.ItemGroup; import net.minecraft.item.ItemStack; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext; import net.minecraftforge.fml.loading.FMLEnvironment; import retsal.rsmakeitharder.client.event.ClientEvents; import retsal.rsmakeitharder.core.event.EventHandler; import retsal.rsmakeitharder.init.InitBlocks; import retsal.rsmakeitharder.init.InitItems; import retsal.rsmakeitharder.init.InitSounds; @Mod(MakeItHarder.MODID) public class MakeItHarder { public static final String MODID = "rsmakeitharder"; public static final String NAME = "RS MakeItHarder"; public static final Logger LOGGER = LogManager.getLogger(NAME); public static final ItemGroup ITEM_GROUP = new ItemGroup(MODID) { @Override public ItemStack createIcon() { return InitItems.FRESISUIS_STRAWBERRY.get().getDefaultInstance(); } }; public MakeItHarder() { IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus(); // bus.addListener(this::setup); InitItems.ITEMS.register(bus); InitBlocks.BLOCKS.register(bus); InitSounds.SOUNDS.register(bus); MinecraftForge.EVENT_BUS.register(new EventHandler()); if (FMLEnvironment.dist == Dist.CLIENT) { MinecraftForge.EVENT_BUS.register(new ClientEvents()); } } } InitSounds class: public class InitSounds { public static final DeferredRegister<SoundEvent> SOUNDS = DeferredRegister.create(ForgeRegistries.SOUND_EVENTS, MakeItHarder.MODID); public static final RegistryObject<SoundEvent> HEARTBEAT = SOUNDS.register("heartbeat", () -> new SoundEvent( new ResourceLocation(MakeItHarder.MODID, "heartbeat") )); } MihArmorMaterial class (where InitSounds.HEARTBEAT.get() is called): public enum MihArmorMaterial implements IArmorMaterial { RUBY("ruby", 30, new int[] {2, 6, 7, 3}, 15, InitSounds.HEARTBEAT.get(), 1.0F, 0.0F, () -> Ingredient.fromItems(InitItems.NETHER_STAR_CORE.get())); ; // blah blah blah.. } Sounds.json (under: src/main/resources assets.rsmakeitharder.sounds): { "heartbeat": { "category": "master", "sounds": [ "rsmakeitharder:heartbeat" ] } } heartbeat.ogg is under src/main/resources assets.rsmakeitharder.sounds too. Error log: Description: Mod loading error has occurred java.lang.Exception: Mod Loading has failed at net.minecraftforge.fml.CrashReportExtender.dumpModLoadingCrashReport(CrashReportExtender.java:85) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.fml.client.ClientModLoader.completeModLoading(ClientModLoader.java:188) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.lambda$null$1(Minecraft.java:513) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.util.Util.acceptOrElse(Util.java:323) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraft.client.Minecraft.lambda$new$2(Minecraft.java:509) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.gui.ResourceLoadProgressGui.render(ResourceLoadProgressGui.java:113) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.GameRenderer.updateCameraAndRender(GameRenderer.java:493) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1002) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.run(Minecraft.java:612) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.main(Main.java:184) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_251] {} at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_251] {} at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_251] {} at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_251] {} at net.minecraftforge.userdev.FMLUserdevClientLaunchProvider.lambda$launchService$0(FMLUserdevClientLaunchProvider.java:52) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {} at net.minecraftforge.userdev.LaunchTesting.main(LaunchTesting.java:105) [forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {} A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- Head -- Thread: Render thread Stacktrace: at java.util.Objects.requireNonNull(Objects.java:290) ~[?:1.8.0_251] {} -- MOD rsmakeitharder -- Details: Caused by 0: java.lang.ExceptionInInitializerError at retsal.rsmakeitharder.init.InitItems.lambda$4(InitItems.java:42) ~[main/:?] {re:classloading} at net.minecraftforge.registries.DeferredRegister.lambda$register$0(DeferredRegister.java:124) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.registries.DeferredRegister.addEntries(DeferredRegister.java:200) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.registries.DeferredRegister.access$000(DeferredRegister.java:61) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.registries.DeferredRegister$EventDispatcher.handleEvent(DeferredRegister.java:172) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.eventbus.ASMEventHandler_0_EventDispatcher_handleEvent_Register.invoke(.dynamic) ~[?:?] {} at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:85) ~[eventbus-4.0.0.jar:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:302) ~[eventbus-4.0.0.jar:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:283) ~[eventbus-4.0.0.jar:?] {} at net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:120) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:36.0] {re:classloading} at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:121) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1640) ~[?:1.8.0_251] {} at net.minecraftforge.fml.ModWorkManager$SyncExecutor.driveOne(ModWorkManager.java:56) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.fml.ModWorkManager$DrivenExecutor.drive(ModWorkManager.java:40) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.fml.ModLoader.waitForTransition(ModLoader.java:243) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.fml.ModLoader.dispatchAndHandleError(ModLoader.java:230) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:196) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.fml.client.ClientModLoader.lambda$begin$1(ClientModLoader.java:103) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$4(ClientModLoader.java:123) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraftforge.fml.client.ClientModLoader.begin(ClientModLoader.java:103) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.<init>(Minecraft.java:442) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.main(Main.java:149) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_251] {} at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_251] {} at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_251] {} at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_251] {} at net.minecraftforge.userdev.FMLUserdevClientLaunchProvider.lambda$launchService$0(FMLUserdevClientLaunchProvider.java:52) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {} at net.minecraftforge.userdev.LaunchTesting.main(LaunchTesting.java:105) [forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {} Mod File: main Failure message: RS Make it Harder (rsmakeitharder) encountered an error during the load_registries event phase java.lang.ExceptionInInitializerError: null Mod Version: NONE Mod Issue URL: NOT PROVIDED Exception message: java.lang.NullPointerException: Registry Object not present: rsmakeitharder:heartbeat Stacktrace: at java.util.Objects.requireNonNull(Objects.java:290) ~[?:1.8.0_251] {} at net.minecraftforge.fml.RegistryObject.get(RegistryObject.java:120) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at retsal.rsmakeitharder.common.armor.MihArmorMaterial.<clinit>(MihArmorMaterial.java:18) ~[main/:?] {re:classloading} at retsal.rsmakeitharder.init.InitItems.lambda$4(InitItems.java:42) ~[main/:?] {re:classloading} at net.minecraftforge.registries.DeferredRegister.lambda$register$0(DeferredRegister.java:124) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.registries.DeferredRegister.addEntries(DeferredRegister.java:200) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.registries.DeferredRegister.access$000(DeferredRegister.java:61) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.registries.DeferredRegister$EventDispatcher.handleEvent(DeferredRegister.java:172) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.eventbus.ASMEventHandler_0_EventDispatcher_handleEvent_Register.invoke(.dynamic) ~[?:?] {} at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:85) ~[eventbus-4.0.0.jar:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:302) ~[eventbus-4.0.0.jar:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:283) ~[eventbus-4.0.0.jar:?] {} at net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:120) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:36.0] {re:classloading} at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:121) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1640) ~[?:1.8.0_251] {} at net.minecraftforge.fml.ModWorkManager$SyncExecutor.driveOne(ModWorkManager.java:56) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.fml.ModWorkManager$DrivenExecutor.drive(ModWorkManager.java:40) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.fml.ModLoader.waitForTransition(ModLoader.java:243) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.fml.ModLoader.dispatchAndHandleError(ModLoader.java:230) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:196) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading} at net.minecraftforge.fml.client.ClientModLoader.lambda$begin$1(ClientModLoader.java:103) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraftforge.fml.client.ClientModLoader.lambda$createRunnableWithCatch$4(ClientModLoader.java:123) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraftforge.fml.client.ClientModLoader.begin(ClientModLoader.java:103) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.<init>(Minecraft.java:442) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.main(Main.java:149) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_251] {} at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_251] {} at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_251] {} at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_251] {} at net.minecraftforge.userdev.FMLUserdevClientLaunchProvider.lambda$launchService$0(FMLUserdevClientLaunchProvider.java:52) ~[forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {} at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {} at net.minecraftforge.userdev.LaunchTesting.main(LaunchTesting.java:105) [forge-1.16.5-36.0.42_mapped_snapshot_20201028-1.16.3-recomp.jar:?] {} Any help is highly appreciated

When i wrote the above post it was too late and i just made a working version. So I am going to upload a cleaner version and I hope it helps someone. I don't know when I put it out of the try scope, but it should definitely be inside. I think it is not a public property. Maybe I am wrong, but in 1.16.5-36.0.42 it is coded as private. Below I upload a cleaner version: public class BlockShop extends Block { public BlockShop() { super(AbstractBlock.Properties .create(Material.BARRIER) .hardnessAndResistance(-1) ); } @Override public ActionResultType onBlockActivated( BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockRayTraceResult hit) { if (!world.isRemote) { // Just server side needed TileEntity te = world.getTileEntity(pos.down()); if (te instanceof SignTileEntity) { SignTileEntity signTe = (SignTileEntity)te; try { String[] signText = getSignText(signTe); String sellId = signText[1]; int price = Integer.parseInt(signText[2]); int quantity = Integer.parseInt(signText[3]); buyItem(player, world, sellId, price, quantity); } catch (NumberFormatException | NullPointerException e) { e.printStackTrace(System.err); } } } return ActionResultType.CONSUME; } private String[] getSignText(SignTileEntity signTe) { CompoundNBT nbt = signTe.getUpdateTag(); String[] text = new String[4]; for (int i = 0; i < 4; i++) text[i] = ITextComponent.Serializer .getComponentFromJson(nbt.getString("Text" + (i + 1))) .getString(); return text; } private void buyItem(PlayerEntity player, World world, String itemId, int price, int quantity) { PlayerInventory inv = player.inventory; ItemStack creditStack = InitItems.CREDIT_ITEM.get().getDefaultInstance(); ItemStack itemStack = getItemStackByName(itemId); int initialCoins = inv.count(creditStack.getItem()); if (!itemStack.isEmpty() && initialCoins >= price && isAvailableSpaceForItem(quantity, player, itemStack) ) { doPayment(price, player, creditStack); giveItemsToPlayer(quantity, player, itemStack); } } private void giveItemsToPlayer(int quantity, PlayerEntity player, ItemStack itemStack) { itemStack.setCount(quantity); player.addItemStackToInventory(itemStack); } private boolean isAvailableSpaceForItem(int quantity, PlayerEntity player, ItemStack itemStack) { PlayerInventory inv = player.inventory; int leftInInventory = inv.count(itemStack.getItem()) % itemStack.getMaxStackSize(); int freeSlotsNeeded = (int)Math.ceil((quantity - leftInInventory) / (double)itemStack.getMaxStackSize()); if (freeSlotsNeeded == 0) return true; for (ItemStack is : inv.mainInventory) if (is.isEmpty() && --freeSlotsNeeded == 0) return true; return false; } private void doPayment(int price, PlayerEntity player, ItemStack coinType) { PlayerInventory inv = player.inventory; int toPay = price; while (toPay > 0) { int coinSlotIndex = inv.findSlotMatchingUnusedItem(coinType); ItemStack coinSlot = inv.getStackInSlot(coinSlotIndex); int amount = Math.min(coinSlot.getCount(), toPay); coinSlot.setCount(coinSlot.getCount() - amount); player.replaceItemInInventory(coinSlotIndex, coinSlot); toPay -= amount; } } private ItemStack getItemStackByName(String name) { ItemStack itemStack = ItemStack.EMPTY; if (name.contains("blueberry")) itemStack = InitItems.FRESISUIS_BLUEBERRY.get().getDefaultInstance(); else if (name.contains("lemon")) itemStack = InitItems.FRESISUIS_LEMON.get().getDefaultInstance(); else if (name.contains("lime")) itemStack = InitItems.FRESISUIS_LIME.get().getDefaultInstance(); else if (name.contains("orange")) itemStack = InitItems.FRESISUIS_ORANGE.get().getDefaultInstance(); else if (name.contains("strawberry")) itemStack = InitItems.FRESISUIS_STRAWBERRY.get().getDefaultInstance(); else if (name.contains("suppository")) itemStack = InitItems.GLOWING_SUPPOSITORY.get().getDefaultInstance(); return itemStack; } } Thank you for your help

Finally it is working. Thank you so much for the hints and for pointing me to the right direction @Draco18s. I'm going to share a functional version. Although it is not finished, I think it can help someone who has the same issue. public class BlockShop extends Block { public BlockShop() { super(AbstractBlock.Properties .create(Material.BARRIER) .hardnessAndResistance(-1) ); } @Override public ActionResultType onBlockActivated( BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockRayTraceResult hit) { if (!world.isRemote) { // Server side BlockState signState = world.getBlockState(pos.down()); if (signState != null) { Block blockSign = signState.getBlock(); if (blockSign == Blocks.OAK_SIGN) { Item item = blockSign.getBlock().asItem(); TileEntity te = world.getTileEntity(pos.down()); SignTileEntity signTe = (SignTileEntity)te; CompoundNBT nbt = signTe.getUpdateTag(); String sellId = ""; int price = -1; int quantity = -1; try { sellId = ITextComponent.Serializer .getComponentFromJson(nbt.getString("Text2")) .getString(); price = Integer.parseInt(ITextComponent.Serializer .getComponentFromJson(nbt.getString("Text3")) .getString() ); quantity = Integer.parseInt(ITextComponent.Serializer .getComponentFromJson(nbt.getString("Text4")) .getString() ); } catch (NumberFormatException e) { e.printStackTrace(System.err); } buyItem(player, world, sellId, price, quantity); } } } return ActionResultType.CONSUME; } private void buyItem(PlayerEntity player, World world, String itemId, int price, int quantity) { PlayerInventory inv = player.inventory; ItemStack creditStack = InitItems.CREDIT_ITEM.get().getDefaultInstance(); ItemStack itemStack = ItemStack.EMPTY; if (itemId.contains("blueberry")) itemStack = InitItems.FRESISUIS_BLUEBERRY.get().getDefaultInstance(); else if (itemId.contains("lemon")) itemStack = InitItems.FRESISUIS_LEMON.get().getDefaultInstance(); else if (itemId.contains("lime")) itemStack = InitItems.FRESISUIS_LIME.get().getDefaultInstance(); else if (itemId.contains("orange")) itemStack = InitItems.FRESISUIS_ORANGE.get().getDefaultInstance(); else if (itemId.contains("strawberry")) itemStack = InitItems.FRESISUIS_STRAWBERRY.get().getDefaultInstance(); else if (itemId.contains("suppository")) itemStack = InitItems.GLOWING_SUPPOSITORY.get().getDefaultInstance(); // TODO: check if space is available before removing coins int initialCoins = inv.count(creditStack.getItem()); if (!itemStack.isEmpty() && initialCoins >= price) { int freeSlotIndex = inv.getFirstEmptyStack(); // TODO: replace by <append to firstItemStack> itemStack.setCount(quantity); int toPay = price; while (toPay > 0) { int coinSlotIndex = inv.findSlotMatchingUnusedItem(creditStack); ItemStack coinSlot = inv.getStackInSlot(coinSlotIndex); int amount = Math.min(coinSlot.getCount(), toPay); coinSlot.setCount(coinSlot.getCount() - amount); player.replaceItemInInventory(coinSlotIndex, coinSlot); toPay -= amount; } player.replaceItemInInventory(freeSlotIndex, itemStack); } } }

Thanks for your quick response @Draco18s. I have laughed a lot with some of your answers, especially with the webpage where they explained Yoda's if 😂 Updated code: public class BlockShop extends Block { public BlockShop() { super(AbstractBlock.Properties .create(Material.BARRIER) .hardnessAndResistance(-1) ); } @Override public ActionResultType onBlockActivated( BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockRayTraceResult hit) { BlockState signState = world.getBlockState(pos.down()); if (signState != null) { Block blockSign = world.getBlockState(pos.down()).getBlock(); if (blockSign == Blocks.OAK_SIGN) { Item item = blockSign.getBlock().asItem(); TileEntity te = world.getTileEntity(pos.down()); String sellId = ""; int price = -1; int quantity = -1; if (te instanceof SignTileEntity) { SignTileEntity signTe = (SignTileEntity)te; String description = signTe.getText(0).getString(); sellId = signTe.getText(1).getString(); String stringPrice = signTe.getText(2).getString(); String stringQuantity = signTe.getText(3).getString(); try { price = Integer.parseInt(stringPrice); quantity = Integer.parseInt(stringQuantity); buyItem(player, world, sellId, price, quantity); } catch (NumberFormatException e) { e.printStackTrace(System.err); } } } } return ActionResultType.CONSUME; } private void buyItem(PlayerEntity player, World world, String itemId, int price, int quantity) { PlayerInventory inv = player.inventory; ItemStack creditStack = InitItems.CREDIT_ITEM.get().getDefaultInstance(); ItemStack itemStack = ItemStack.EMPTY; if (itemId.contains("blueberry")) itemStack = InitItems.FRESISUIS_BLUEBERRY.get().getDefaultInstance(); else if (itemId.contains("lemon")) itemStack = InitItems.FRESISUIS_LEMON.get().getDefaultInstance(); else if (itemId.contains("lime")) itemStack = InitItems.FRESISUIS_LIME.get().getDefaultInstance(); else if (itemId.contains("orange")) itemStack = InitItems.FRESISUIS_ORANGE.get().getDefaultInstance(); else if (itemId.contains("strawberry")) itemStack = InitItems.FRESISUIS_STRAWBERRY.get().getDefaultInstance(); else if (itemId.contains("suppository")) itemStack = InitItems.GLOWING_SUPPOSITORY.get().getDefaultInstance(); if (!itemStack.isEmpty() && inv.count(creditStack.getItem()) >= price) { inv.decrStackSize(inv.getSlotFor(creditStack), price); itemStack.setCount(quantity); inv.add(inv.getFirstEmptyStack(), itemStack); } } } I didn't find Blocks.SIGN in net.minecraft.block.Blocks nor net.minecraft.forge.common.Tags so for the moment I will check block.Blocks.OAK_SIGN. Well, the desired behavior would be that if the price exceeds the maximum stack size, then the mod will be able to count the total coins. But I think that (for the moment) it would not be a problem, because I can iterate the slots and calculate the total count. In the same way, I can calculate if I can deposit the desired amount of items sold in the player's inventory. I had to delegate to the client because I don't know how to capture the text of the sign with the server. If I remove the condition of being a client when capturing the text if I run the mod in Singleplayer it works fine, but if I run it on a server it causes a crash with the following exception, and I don't know how to fix it: java.lang.NoSuchMethodError: net.minecraft.tileentity.SignTileEntity.func_212366_a(I)Lnet/minecraft/util/text/ITextComponent; at retsal.rsmakeitharder.common.block.BlockShop.func_225533_a_(BlockShop.java:45) ~[rsmakeitharder:0.2] {re:classloading} at net.minecraft.block.AbstractBlock$AbstractBlockState.func_227031_a_(AbstractBlock.java:638) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.server.management.PlayerInteractionManager.func_219441_a(PlayerInteractionManager.java:338) ~[?:?] {re:classloading} at net.minecraft.network.play.ServerPlayNetHandler.func_184337_a(ServerPlayNetHandler.java:958) ~[?:?] {re:classloading} at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.func_148833_a(SourceFile:36) ~[?:?] {re:classloading} at net.minecraft.network.play.client.CPlayerTryUseItemOnBlockPacket.func_148833_a(SourceFile:10) ~[?:?] {re:classloading} at net.minecraft.network.PacketThreadUtil.func_225383_a(SourceFile:21) ~[?:?] {re:classloading} at net.minecraft.util.concurrent.TickDelayedTask.run(SourceFile:18) ~[?:?] {re:classloading} at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) ~[?:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) ~[?:?] {re:classloading} Thank you so much for your help

Hey, I'm new to minecraft modding, but I know java programming. I am trying to create a custom block that can exchange items when you right click on it, and it gives you the item only if you have enough coins. You will find a picture of the scene attached to this post. Problem: When you right click on the block, it gives you the item if you have enough coins. But if you disconnect and then reconnect to the world, something undoes the changes made by the transaction. I think it happens because I am writing the code on the client side and not updating the information on the server side. But I have no idea how I should do it properly. Code of the Block class: public class BlockShop extends Block { public BlockShop() { super(AbstractBlock.Properties .create(Material.BARRIER) .hardnessAndResistance(-1) ); } @Override public ActionResultType onBlockActivated( BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockRayTraceResult hit) { BlockState signState = world.getBlockState(pos.down()); if (signState != null) { Block blockSign = world.getBlockState(pos.down()).getBlock(); if (blockSign.getRegistryName().toString().equals("minecraft:oak_sign")) { Item item = blockSign.getBlock().asItem(); TileEntity te = world.getTileEntity(pos.down()); String sellId = ""; int price = -1; int quantity = -1; if (world.isRemote && te instanceof SignTileEntity) { SignTileEntity signTe = (SignTileEntity)te; String description = signTe.getText(0).getString(); sellId = signTe.getText(1).getString(); String stringPrice = signTe.getText(2).getString(); String stringQuantity = signTe.getText(3).getString(); try { price = Integer.parseInt(stringPrice); quantity = Integer.parseInt(stringQuantity); buyItem(player, world, sellId, price, quantity); } catch (Exception e) { } } } } return ActionResultType.CONSUME; } private void buyItem(PlayerEntity player, World world, String itemId, int price, int quantity) { PlayerInventory inv = player.inventory; ItemStack creditStack = InitItems.CREDIT_ITEM.get().getDefaultInstance(); ItemStack itemStack = null; if (itemId.contains("blueberry")) itemStack = InitItems.FRESISUIS_BLUEBERRY.get().getDefaultInstance(); else if (itemId.contains("lemon")) itemStack = InitItems.FRESISUIS_LEMON.get().getDefaultInstance(); else if (itemId.contains("lime")) itemStack = InitItems.FRESISUIS_LIME.get().getDefaultInstance(); else if (itemId.contains("orange")) itemStack = InitItems.FRESISUIS_ORANGE.get().getDefaultInstance(); else if (itemId.contains("strawberry")) itemStack = InitItems.FRESISUIS_STRAWBERRY.get().getDefaultInstance(); else if (itemId.contains("suppository")) itemStack = InitItems.GLOWING_SUPPOSITORY.get().getDefaultInstance(); if (itemStack != null && inv.count(creditStack.getItem()) >= price) { inv.decrStackSize(inv.getSlotFor(creditStack), price); itemStack.setCount(quantity); inv.add(inv.getFirstEmptyStack(), itemStack); } } } Any help is appreciated Thank you so much and sorry for my level of english.