Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

KiwiChris84

Members
  • Posts

    16
  • Joined

  • Last visited

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

KiwiChris84's Achievements

Tree Puncher

Tree Puncher (2/8)

0

Reputation

  1. yeah but it's still not working, it's giving multiple effects instead of just one and the effects don't go away unless I die, even if i drink milk or clear effects with /effect
  2. So I did this but the end result still has multiple potion effects that don't go away even after effect clearing and drinking milk. public static final RegistryObject<Item> EYE_OF_ALWORTH = ITEMS.register("eye_of_alworth", ()-> new ModEventListeners(new Item.Properties().tab(CreativeModeTab.TAB_MISC).food(ModFoods.EYE_OF_ALWORTH))); Did I do it wrong?
  3. I know I'm the worst, but where would that be in my code to create a new instance?
  4. I was using that class while I was trying to create an event. So what should I do, move the methods to the ModItems?
  5. package net.kiwichris84.items; import net.minecraft.world.food.FoodProperties; public class ModFoods extends ModItems { public static final FoodProperties EYE_OF_ALWORTH = (new FoodProperties.Builder()).fast().nutrition(4).saturationMod(0.2F).alwaysEat().build(); } package net.kiwichris84.coolnewitem; import com.mojang.logging.LogUtils; import net.kiwichris84.items.ModItems; import net.minecraft.world.level.block.Blocks; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent; import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext; import org.slf4j.Logger; // The value here should match an entry in the META-INF/mods.toml file @Mod(coolNewItem.MOD_ID) public class coolNewItem { public static final String MOD_ID = "coolnewitem"; // Directly reference a slf4j logger private static final Logger LOGGER = LogUtils.getLogger(); public coolNewItem() { IEventBus eventBus = FMLJavaModLoadingContext.get().getModEventBus(); ModItems.register(eventBus); eventBus.addListener(this::setup); // Register ourselves for server and other game events we are interested in MinecraftForge.EVENT_BUS.register(this); } private void setup(final FMLCommonSetupEvent event) { // some preinit code LOGGER.info("HELLO FROM PREINIT"); LOGGER.info("DIRT BLOCK >> {}", Blocks.DIRT.getRegistryName()); } } package net.kiwichris84.items; import net.kiwichris84.coolnewitem.coolNewItem; import net.minecraft.world.item.CreativeModeTab; import net.minecraft.world.item.Item; import net.minecraft.world.item.Items; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.registries.DeferredRegister; import net.minecraftforge.registries.ForgeRegistries; import net.minecraftforge.registries.RegistryObject; public class ModItems extends Items { public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, coolNewItem.MOD_ID); public static final RegistryObject<Item> EYE_OF_ALWORTH = ITEMS.register("eye_of_alworth", ()-> new Item(new Item.Properties().tab(CreativeModeTab.TAB_MISC).food(ModFoods.EYE_OF_ALWORTH))); public static void register(IEventBus eventBus){ ITEMS.register(eventBus); } } These are my other classes for the mod.
  6. package net.kiwichris84.items; import net.kiwichris84.coolnewitem.coolNewItem; import net.minecraft.world.effect.MobEffect; import net.minecraft.world.effect.MobEffectInstance; import net.minecraft.world.entity.LivingEntity; import net.minecraft.world.entity.player.Player; import net.minecraft.world.item.Item; import net.minecraft.world.item.ItemStack; import net.minecraft.world.level.Level; import net.minecraftforge.fml.common.Mod; import org.jetbrains.annotations.NotNull; import java.util.Objects; @Mod.EventBusSubscriber(modid= coolNewItem.MOD_ID) public class ModEventListeners extends Item { public ModEventListeners(Properties pProperties) {super(pProperties);} @Override public @NotNull ItemStack finishUsingItem(@NotNull ItemStack pStack, @NotNull Level pLevel, @NotNull LivingEntity pLivingEntity) { if (pLivingEntity instanceof Player) { Player player = (Player) pLivingEntity; if (player.getMainHandItem().getItem() == ModItems.EYE_OF_ALWORTH.get()) { int random = (int) ((Math.random() * 32) + 1); player.addEffect(new MobEffectInstance(Objects.requireNonNull(MobEffect.byId(random)), 1200, 2)); return this.isEdible() ? pLivingEntity.eat(pLevel, pStack) : pStack; } } return this.isEdible() ? pLivingEntity.eat(pLevel, pStack) : pStack; } } It doesn't seem to be firing now, what should I do?
  7. Alright I did that, and now for the Player player declaration what should I do to fix the variables? now "event" is marked as red public class ModEventListeners extends Item { public ModEventListeners(Properties pProperties) { super(pProperties); } @Override public ItemStack finishUsingItem(ItemStack pStack, Level pLevel, LivingEntity pLivingEntity) { Player player = (Player) event.getEntity(); if (player.getMainHandItem().getItem()== EYE_OF_ALWORTH.get()){ int random = (int) ((Math.random() * 32) +1); player.addEffect(new MobEffectInstance(Objects.requireNonNull(MobEffect.byId(random)), 1200, 2));} return this.isEdible() ? pLivingEntity.eat(pLevel, pStack) : pStack;
  8. Attempting to do that gives me this though. There is no default constructor available in 'net.minecraft.world.item.Item'
  9. Alright that works, thank you, but for changing the code to finishUsingItem how would I go about that. I know how to override but It seems I cant extend Item or implement it
  10. here @SubscribeEvent protected void onFoodEaten(LivingEntityUseItemEvent.Finish event) { if (event.getEntityLiving() instanceof Player) { Player player = (Player) event.getEntity(); player.removeAllEffects(); if (player.getMainHandItem().getItem()== RegistryObject.get(EYE_OF_ALWORTH)){ int random = (int) ((Math.random() * 32) +1); player.addEffect(new MobEffectInstance(Objects.requireNonNull(MobEffect.byId(random)), 1200, 2));} } } }
  11. or my apologies, its a non static method that cannot be called from a static context. I should read things twice lol
  12. It says that registryobject#get is a static method. Also, when I tried to change to override the Item class extending the class said that there is no default constructor, and implementing the class said that an interface was required and to be honest I'm not familiar enough with setting up an interface class properly.
  13. When I attempted to replace the the .equals toString part of my if statement i recieved this error Operator '==' cannot be applied to 'net.minecraft.world.item.Item', 'net.minecraftforge.registries.RegistryObject<net.minecraft.world.item.Item>'
  14. And doing that should fix the effect triggering twice every time a food is eaten?
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.