Custom EntityRenderer.getEntityTexture() is not called

[GrigLog]

Ive already made an arrow entity (derived from vanilla one), and it works fine (they dont get picked up by a player), but for some reason my texture is not rendered, the arrow looks like vanilla one...

Arrow code:

public class HolyArrow extends ArrowEntity {
    public HolyArrow(World world, PlayerEntity player){
        super(world, player);
    }

    public HolyArrow(EntityType<HolyArrow> type, World world){
        super(type, world);
    }

    public void onCollideWithPlayer(PlayerEntity entityIn) {} //no pickup

    public static EntityType<HolyArrow> getRegistryType(){
        return (EntityType<HolyArrow>) EntityType.Builder
                .<HolyArrow>create(HolyArrow::new, EntityClassification.MISC)
                .size(1, 1)
                .build("")
                .setRegistryName("holy_arrow");
    }
}

Renderer (the texture method is never called):

public class HolyArrowRenderer extends ArrowRenderer<HolyArrow> {
    public HolyArrowRenderer(EntityRendererManager e){
        super(e);
    }

    @Override
    public ResourceLocation getEntityTexture(HolyArrow entity) {
        System.out.println("texture requested");
        return new ResourceLocation(Soul.id, "textures/entity/holy_arrow.png");
    }
}

Registering a renderer:

@Mod.EventBusSubscriber(value=Dist.CLIENT, bus=Mod.EventBusSubscriber.Bus.MOD)
public class ClientEvents {
    @SubscribeEvent
    public static void setupClient(FMLClientSetupEvent event){
        RenderingRegistry.registerEntityRenderingHandler(Entities.holyArrow, HolyArrowRenderer::new);
    }
}

Registering an entity:

@Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
public class RegistryEvents {
    @SubscribeEvent
    static void registerEntities(final RegistryEvent.Register<EntityType<?>> event){
        event.getRegistry().registerAll(Entities.holyArrow);
    }
}

Entity reference:

public class Entities {
    public static final EntityType<HolyArrow> holyArrow = HolyArrow.getRegistryType();
}

 

[diesieben07]

Your registry code is broken. Read the documentation. Do not change things unless you absolutely know what you are doing.

45 minutes ago, GrigLog said:

public HolyArrow(World world, PlayerEntity player){
    super(world, player);
}

 

This will create your entity with EntityType.ARROW, i.e. the vanilla entity type. You must always specify your entity type.

Your entity must also override getAddEntityPacket and return NetworkHooks.getEntitySpawningPacket, the vanila spawn packets only work for vanilla entities.

[GrigLog]

Quote

Your registry code is broken. Read the documentation

The problem is, in docs its only said how to register EntityTypes through DeferredRegisters...

Quote

You must always specify your entity type

Ive added an override for getType() {return Entities.holyArrow;} now the arrows are simply invisible. Am I doing right?

Quote

Your entity must also override getAddEntityPacket and return NetworkHooks.getEntitySpawningPacket

Ok, but it didnt change anything

 

[diesieben07]

Just now, GrigLog said:

The problem is, in docs its only said how to register EntityTypes through DeferredRegisters...

The registration code for blocks, items, entity types, etc. is all the same. The documentation explains both using DeferredRegister and also using the RegistryEvent manually and using @ObjectHolder.

1 minute ago, GrigLog said:

Ive added an override for getType() {return Entities.holyArrow;} now the arrows are simply invisible. Am I doing right?

No. You have to specify the correct type in the constructor. Do not override getType.

[GrigLog]

I think Ive done everything as it and you say, and I looked through other mods code and it looks similar everywhere, but the arrows are still invisible, whats wrong?

public class Entities {
    public static final EntityType<HolyArrow> holyArrow = EntityType.Builder
            .<HolyArrow>create(HolyArrow::new, EntityClassification.MISC)
            .size(1, 1)
            .build("");
}

public class HolyArrow extends AbstractArrowEntity {
    public HolyArrow(World world, PlayerEntity player){
        super(Entities.holyArrow, player, world);
    }

    public HolyArrow (EntityType<HolyArrow> type, World world){
        super(Entities.holyArrow, world);
    }

    public IPacket<?> createSpawnPacket() {
        Entity entity = this.getShooter();
        return NetworkHooks.getEntitySpawningPacket(entity);
    }

    public void onCollideWithPlayer(PlayerEntity entityIn) {} //no pickup


    @Override
    protected ItemStack getArrowStack() {
        return null;
    }
}

@Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD)
public class RegistryEvents {
    @SubscribeEvent
    static void registerEntities(final RegistryEvent.Register<EntityType<?>> event){
        event.getRegistry().registerAll(Entities.holyArrow.setRegistryName("holy_arrow"));
    }
}

@Mod.EventBusSubscriber(value=Dist.CLIENT, bus=Mod.EventBusSubscriber.Bus.MOD)
public class ClientEvents {
    @SubscribeEvent
    public static void setupClient(FMLClientSetupEvent event){
        RenderingRegistry.registerEntityRenderingHandler(Entities.holyArrow, HolyArrowRenderer::new);
    }
}

 

[diesieben07]

You have not followed the registry documentation. Do not change anything about the code it shows you unless you know what it means.

14 minutes ago, GrigLog said:

    public IPacket<?> createSpawnPacket() {
        Entity entity = this.getShooter();
        return NetworkHooks.getEntitySpawningPacket(entity);
    }

 

Why are you creating a spawning packet for the shooter instead of your entity?!

[GrigLog]

Quote

Why are you creating a spawning packet for the shooter instead of your entity?!

Oh hell, that was the problem, now it finally works XD Im just tired and didnt notice that, thanks a lot!

[diesieben07]

You still need to fix your registry code. It is broken. Do not leave it like this.