Jump to content

Getting all instances of a block to do something?


googoo1876

Recommended Posts

If you mean every block in the world, the only way I could think it could be done would be to literally check every block in the world (the stored blocks array) and check if each one has the specific ID, and if it does, add it to the list. It'd be best to check a small range (maybe -64 to 64 in x, y, z directions) and see which of those blocks, if any, are the block ID you're looking for, and then add them. Doing literally every block in a world could cause extreme lag running through nested loops that many times.

Link to comment
Share on other sites

Okay, I'm making a radios mod, currently there are radios, and transmitters. The transmitters broadcast to a certain range, and send a packet with a URL and a few other details to all players that should hear sound, that being within the range of a radio block. So there are two ranges, a radio range, and a transmitter range, and if a player falls within a radio range that is within a transmitter range, the player should get a packet with a URL. How I originally wanted to do this was, I have an array of radios, and I just check if its in rage, issue is, this list only holds *active* radios(ones that are playing, or in the process of playing), and this array doesn't really need to be stored, so it isn't. My new idea is to require radios to be turned "on" with a redstone signal, and then to be added to the array. So a question, would onNeighborBlockChange run if there was a button press, or a redstone pulse? If not how would I go about doing that?

Link to comment
Share on other sites

One way to do the transmission is to basically use nested for-loops for the x, y, and z directions for when the transmitter is updating (assuming you're using a tile entity, if not, you might be able to use randomDisplayTick()), and then run through every block:

 

if(world.getBlockId(i + i1, j + j1, k + k1) == radio.blockID)

where i, j, and k are the coords of the transmitter and i1, j1, and k1 are the offsets in the for-loops (-range <= i1 < range). Then under the if-statement, you can do something with the radio's tile entity (assuming you have one) like this:

 

((TileEntityRadio)world.getBlockTileEntity(i + i1, j + j1, k + k1)).playRadio();

 

and then your code for the radio's range will go in the entity file under play radio, to basically play a sound, song, etc at that coordinate using the Tile Entity's worldObj and coords, at a specific loudness to cover the radio's range. I'm sure you can figure out the things like whether or not a radio is on or not.

 

Also, sorry if this confused you, I think you had something else in mind but I find probably the easiest way to do it.

Link to comment
Share on other sites

I have an idea, but it would make the range thing not work (unless it's only one transmitter per frequency). so what you would do, is you would have a static array in the transmitter class, and it would have all the frequencies, the coordinates of the transmitter, and what's being played. the radio will only play it if it is within a certain range of the transmitter and is on. it would look something like this.

public static Object[][][][] radio = new Object[MAX_NUMBER_OF_FREQUENCIES][x][y][z]

the x, y, and z would be the coordinates of the transmitter. if the transmitter was at the coordinates 20, 72, 30 and was on frequency 42 and transmitting "hello world" you would add it to the list by doing

CLASS_WITH_THE_ARRAY_IN_IT.radio[42][20][72][30] = "hello world";

the radio would just have to look at the coordinates around it and see if there is something being played on it's frequency at the coordinates in it's range. of course, you could make the array any type of array you want, it doesn't have to be an object array. if you want it to not have a range, you can omit the last three [] of the array. so it would look like

public static Object[] radio = new Object[MAX_NUMBER_OF_FREQUENCIES]

and making it have "hello world" on frequency 42 would be

CLASS_WITH_THE_ARRAY_IN_IT.radio[42] = "hello world";

Link to comment
Share on other sites

Huh, interesting code, but I think I found a way, but I need help. So originally I had two option for making a radio that would even work, make a tileentity with a small class to handle the radio, or just go all out in one huge handler class. I wanted to do the first, but I couldn't get tile entities working, so I went with the latter method. Now I want/need to use tile entities, because there is a updateEntity method which is called everytick. I thought perfect, but again I tried couldn't get tile entities to work >_<. I

1) Made a simple tile entity class extending tileentity with a updateEntity method that prints test

2) Put create tile entity in my block

3) Registered my tile entity with GameRegistry

4) Cried as all my attempts failed. >_<

Link to comment
Share on other sites

Oh sorry, I didn't want to use his code, for looping though large amounts of blocks is being resource consuming, but with tile entities I had my own idea, but failed, anyways, I'll get code.

 

Radio class with some unrelated code removed

public class Radio extends Block {
private Side side = FMLCommonHandler.instance().getEffectiveSide();
@SideOnly(Side.CLIENT)
private Icon[] icons;
private int id;
        public Radio (int id, Material material){
                super(id, material);
        		this.id=id;
                this.setCreativeTab(CreativeTabs.tabBlock);
                this.setHardness(5F);
                this.setUnlocalizedName("Radio");
        @Override
        public boolean hasTileEntity(){
        	return true;
        }
        @Override
        public TileEntity createTileEntity(World world, int metadata){
        	System.out.println("test");
                return new RadioTileEntity();
        }
}

 

TileEntity class

public class RadioTileEntity extends TileEntity{
@Override
public void writeToNBT(NBTTagCompound par1){
   super.writeToNBT(par1);
}

@Override
public void readFromNBT(NBTTagCompound par1){
   super.readFromNBT(par1);
}
@Override
public void updateEntity(){
	System.out.println("TEST?EDFRT");
}
}

Main mod file with some unrelated things removed

package matthew.CloudSound;

@Mod(modid="CloudSound", name="CloudSound", version="0.0.7")
@NetworkMod(clientSideRequired=true, serverSideRequired=false, channels={"URLfrom", "URLto", "RadioBreak", "transmitter"}, packetHandler = PacketHandler.class)
public class CloudSound {
private Side side = FMLCommonHandler.instance().getEffectiveSide();
public Radio radio = new Radio(1000, Material.wood);
public IronAntenna antenna= new IronAntenna(502, "Iron", Material.iron);
public final static Transmitter transmitter= new Transmitter(500, Material.rock);
public final WoodTransmitter woodTransmitter= new WoodTransmitter(501, Material.wood);
//player is set in RAdioGUI
public String player=null;
ItemStack obsidian = new ItemStack(Block.obsidian);
public TransmitterHandler transHandler = new TransmitterHandler();
ItemStack diamond = new ItemStack(Item.diamond, 64);

        // The instance of your mod that Forge uses.
        @Instance("CloudSound")
        public static CloudSound instance;
        
        // Says where the client and server 'proxy' code is loaded.
        @SidedProxy(clientSide="matthew.CloudSound.client.ClientProxy", serverSide="matthew.CloudSound.CommonProxy")
        public static CommonProxy proxy;
        
        @Mod.EventHandler
        public void preInit(FMLPreInitializationEvent event) {
        	if(side==Side.CLIENT){
            	transHandler = new TransmitterHandler();
        	}
            Utils.makeStore();
           // GameRegistry.registerPlayerTracker(new playerTracker());
            NetworkRegistry.instance().registerConnectionHandler(new ConnectionHandler());
        	NetworkRegistry.instance().registerGuiHandler(this, new GuiHandler());
        	instance = this;
        }
        
        @Mod.EventHandler
        public void load(FMLInitializationEvent event) {
            proxy.registerRenderers();
            GameRegistry.registerBlock(transmitter, "Transmitter");
            GameRegistry.registerBlock(radio, "Radio");
            GameRegistry.registerBlock(woodTransmitter, "Wood Transmitter");
            GameRegistry.registerBlock(antenna, "IronAntenna");
            GameRegistry.addRecipe(new ItemStack(transmitter), "xxx", "xyx", "xxx", 'x', obsidian, 'y', diamond);
            LanguageRegistry.addName(transmitter, "Transmitter");
            LanguageRegistry.addName(woodTransmitter, "Wooden Transmitter");
            LanguageRegistry.addName(antenna, "Iron Antenna");
            LanguageRegistry.addName(radio, "Radio");
            MinecraftForge.setBlockHarvestLevel(transmitter, "pickaxe", 3);
            MinecraftForge.setBlockHarvestLevel(woodTransmitter, "pickaxe", 1);
        	GameRegistry.registerTileEntity(RadioTileEntity.class, "Radio");
                
        }

Link to comment
Share on other sites

Block Container is what makes the TileEntity work!

 

But you don't need to do that, you just need to implement/override the TE related methods.

I can't remember all their names in my head at the moment but they are something like

CreateNewTileEntity (returns the new tileEntity).

HasTileEntity(returns true if it has one).

 

Also I'm not sure but you may have to just create you're own TE upon placing and adding the block to the world if the above isn't enough :)

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

Hmm but how many blocks of this type will there ever be inn the world?

if it's radios I guess there wont be so many hundreds of them?

 

Inn that case you could make them add their positions to a Vec3 list when added/placed?

then you can loop trough that list whenever you need to find radios and then you only loop trough the worlds radios? :)

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.