I'm new to modding, can someone help me fix this 1.17 issue i found in mcjty's mod tutorial?

[PogMan_15]

I tried to follow along to his tutorial, but when I got to the end and tried to test it out for myself, it would not load properly. It keeps the same error messages, and none of Eclipse's quickfixes help or seem to affect anything whatsoever. I don't know what to do and would appreciate any help. The error message it gives is:

The method register(String, Supplier<? extends I>) in the type DeferredRegister<Item> is not applicable for the arguments (String, Supplier<capture#2-of ? extends I>)

 

[PogMan_15]

I was trying to make a very simple item with no properties, and the minecraft client will not start, and it says that the mod failed to load.

[MrMarnic]

Could you show your code please.

[PogMan_15]

package com.Charlie.items;

import com.Charlie.items.TestItem;
import net.minecraft.world.item.Item;
import net.minecraft.world.item.Item.Properties;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import net.minecraftforge.fmllegacy.RegistryObject;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.ForgeRegistries;

import static com.Charlie.tutorial.Tutorial.MODID;

public class Registration {


	private static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, MODID);
	
	public static void init() {
		ITEMS.register(FMLJavaModLoadingContext.get().getModEventBus());
	}
	
	public static final RegistryObject<Item> TESTITEM = ITEMS.register("testitem", () -> new TestItem(new Item.Properties()))
	
}

Thats the registry code, do you need any of the other code?

[MrMarnic]

Firstly you forgot the semicolon at the end of this line 

public static final RegistryObject<Item> TESTITEM = ITEMS.register("testitem", () -> new TestItem(new Item.Properties()))

The second thing:

In this line here:

private static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, MODID);

You are using the variable MODID but you have never created it.

You need to create it like this:

public static final String MODID = "<your modid>";

Then it should work

Edited September 7, 2021 by MrMarnic

[PogMan_15]

Thanks, I will try that right now.

[PogMan_15]

It did not work. I think that the errors are in line 23, this one right here

public static final RegistryObject<Item> TESTITEM = ITEMS.register("testitem", () -> new TestItem(new Item.Properties()));

it has an error line underneath register that says "The method register(String, Supplier<? extends I>) in the type DeferredRegister<Item> is not applicable for the arguments (String, Supplier<capture#2-of ? extends I>)"

And the Error line underneath TestItem says that "TestItem cannot be resolved to a type"

[MrMarnic]

Have you created a TestItem class?

[MrMarnic]

And could you show your TestItem class please

[Luis_ST]

please post the log

[PogMan_15]

package com.Charlie.items;

import net.minecraft.world.item.Item;

public class TestItem extends Item{

	public TestItem(Properties properties) {
		super(properties);
		// TODO Auto-generated constructor stub
	}

}

There is the TestItem class, and i even made sure to import it into the Registration file, which is why I am so confused. There is an error line beneath the part where I imported the class that says that that import is unused. 

[PogMan_15]

Where would I find my log?

[MrMarnic]

In the run folder there is a logs and crash reports folder

[MrMarnic]

And I believe the import should look like this:

import net.minecraft.item.Item;

without the world

[PogMan_15]

Here are the logs

logs.zip

[PogMan_15]

And when i remove the world from the import, an error line show up that was not there before.

[MrMarnic]

What does the new error say?

[PogMan_15]

It says that the import will not resolve

 

[MrMarnic]

Sorry your import was right. I was still on 1.16.5

[Luis_ST]

I told you to post the log and not the log folder

[PogMan_15]

Doesn't that contain the log?

I wasn't sure which log you wanted

[Luis_ST]

run the game an post the console log