Jump to content

Recommended Posts

Posted

Using ShieldBaseModel from vanilla, I have added a copper shield with the exact same model as the vanilla item.

It renders properly when holding it, but it doesn't properly go up when blocking with the shield. 

It's also slightly rotated when I look at the player in third person mode.

I can't figure out where the mistake lies, any help would be greatly appreciated.

I am modding with Forge 36.2.6 for Minecraft 1.16.5

 

GitRepo: https://github.com/Leronus/mOres

 

Classes used:

src/main/java/mod/mores/client/entity/model/ModelHandler.java 

src/main/java/mod/mores/client/entity/render/ShieldTileEntityRenderer.java

src/main/java/mod/mores/client/entity/ShieldTextures.java

src/main/java/mod/mores/init/ItemInit.java

src/main/java/mod/mores/objects/ItemShield.java

 

https://imgshare.io/image/pFTDBO

https://imgshare.io/image/pFTtc9

Posted (edited)
30 minutes ago, Luis_ST said:

that's not a answer to my question 

Your question was and I quote "did you looked at vanilla?"

This can be interpreted in many ways, but I'm guessing that you meant "did you look at the vanilla source code for the shield?"

If that is in fact what you meant, I answered with "yes I did." 

I believe that suffices as an answer to your question but please correct me if I'm wrong.

In conclusion, I still don't see how a single annotation in a class used for saving the ResourceLocation of my shield textures impacts the way the model is rendered when blocking with the shield...

Edited by Leronus
Posted
1 hour ago, Leronus said:

I am? ShieldTileEntityRenderer extends ItemStackTileEntityRenderer

sorry, I forgot that vanilla handle rendering of Items in one class

the render code looks okay i think your blocking model is wrong

Posted
6 hours ago, Luis_ST said:

no, it's an error in your json models check them or use the vanilla one for testing

oh shit okay thanks I'll take a look at that

Posted (edited)
7 hours ago, Luis_ST said:

no, it's an error in your json models check them or use the vanilla one for testing

I have updated the json models. The blocking is now registering properly in third person mode, however when just holding the shield it is still slightly rotated.

It also appears to be rendering the blocking shield permanently in first person mode. Even when not actually blocking.

Any ideas what might be the cause?

Edited by Leronus
Posted

your copper shield json "extends" your wood shield, inside i found this error:

  1. wood_shield, line 17, translation y should be 2
  2. wood_shield, line 22, translation y should be -2
  3. wood_shield_blocking, line 17, translation y should be 5
  4. wood_shield_blocking, line 22, translation y should be 5

i'm not sure if this values cause the error but you can change them and test again

  • Thanks 1
Posted
38 minutes ago, Luis_ST said:

your copper shield json "extends" your wood shield, inside i found this error:

  1. wood_shield, line 17, translation y should be 2
  2. wood_shield, line 22, translation y should be -2
  3. wood_shield_blocking, line 17, translation y should be 5
  4. wood_shield_blocking, line 22, translation y should be 5

i'm not sure if this values cause the error but you can change them and test again

Yeah that was my old model, I have since committed and pushed the new models, where new problems arise

Posted

Copper shield - Not blocking - Third Person (does not work as intended)

https://imgshare.io/image/pFofW8

Vanilla shield - Not blocking - Third Person
https://imgshare.io/image/pFozKw

Copper shield - Blocking - Third Person (works as intended)
https://imgshare.io/image/pFoBOK

Vanilla shield - Blocking - Third Person
https://imgshare.io/image/pFo1FS

Vanilla shield - Not blocking - First Person
https://imgshare.io/image/pFogUj

Copper shield - Not blocking - First Person (does not work as intended, is being rendered as "blocking")
https://imgshare.io/image/pFtrH6

Copper shield - Blocking - First Person (works as intended)
https://imgshare.io/image/pFtNwe

Vanilla shield - Blocking - First Person
https://imgshare.io/image/pFtpIy

Posted

after use debugger in your repo i found the error:
that's your error compare this with the vanilla ItemModelProperty for the Shield

it should be:

Spoiler
(stack, world, entity) -> entity != null && entity.isUsingItem() && entity.getUseItem() == stack ? 1.0F : 0.0F

 

  • Thanks 1
Posted
2 hours ago, Luis_ST said:

after use debugger in your repo i found the error:
that's your error compare this with the vanilla ItemModelProperty for the Shield

it should be:

  Hide contents
(stack, world, entity) -> entity != null && entity.isUsingItem() && entity.getUseItem() == stack ? 1.0F : 0.0F

 

Bro I thought it was that statement too, back in 1.16.3 it was entity.IsHandActive(), but I couldn't find the right replacement. Apparently it's isUsingItem() as you said

Thanks a lot man!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • hello i am wanting to know if anyone can help me with this crash happened when i tried to go to bed on server https://pastebin.com/CezfAbAh
    • I accidentally posted this in the ForgeGradle subforum, super sorry. I meant to post it in the regular modders forum. Hopefully it can still reach the right people!
    • I've been trying to make an addon mod for create, but setting up dependencies and trying to add the mod into my mod environment has proven a little difficult for me. Ive been searching this forum and I've seen problems that were close to mine but not exactly mine, searching the error output just yields  people having trouble with their own modid, not an addons. The error while loading Minecraft,  "mods.toml missing metadata of modid create" and  "The Mod File C:Users\user1\data\<mod>\build\resources\main has mods that were not found" My build.gradle file plugins { id 'eclipse' id 'idea' id 'maven-publish' id 'net.minecraftforge.gradle' version '[6.0,6.2)' id 'org.parchmentmc.librarian.forgegradle' version '1.+' } version = mod_version group = mod_group_id base { archivesName = mod_id } // Mojang ships Java 17 to end users in 1.18+, so your mod should target Java 17. java.toolchain.languageVersion = JavaLanguageVersion.of(17) println "Java: ${System.getProperty 'java.version'}, JVM: ${System.getProperty 'java.vm.version'} (${System.getProperty 'java.vendor'}), Arch: ${System.getProperty 'os.arch'}" minecraft { mappings channel: 'parchment', version: '2023.09.03-1.20.1' copyIdeResources = true runs { configureEach { workingDirectory project.file('run') property 'forge.logging.markers', 'REGISTRIES' property 'forge.logging.console.level', 'debug' property 'mixin.env.remapRefMap', 'true' property 'mixin.env.refMapRemappingFile', "${projectDir}/build/createSrgToMcp/output.srg" mods { "${mod_id}" { source sourceSets.main } } } client { // ... mods { other_mod { // ... } // Configures the 'example' mod create { // Add a source set to a mod's sources source sourceSets.main // Merges this configuration and specifies whether to overwrite existing properties merge mods.other_mod, true } } } server { property 'forge.enabledGameTestNamespaces', mod_id args '--nogui' } // This run config launches GameTestServer and runs all registered gametests, then exits. // By default, the server will crash when no gametests are provided. // The gametest system is also enabled by default for other run configs under the /test command. gameTestServer { property 'forge.enabledGameTestNamespaces', mod_id } data { // example of overriding the workingDirectory set in configureEach above workingDirectory project.file('run-data') // Specify the modid for data generation, where to output the resulting resource, and where to look for existing resources. args '--mod', mod_id, '--all', '--output', file('src/generated/resources/'), '--existing', file('src/main/resources/') } } } // Include resources generated by data generators. sourceSets.main.resources { srcDir 'src/generated/resources' } repositories { maven { url = 'https://maven.tterrag.com/' } } dependencies { // Specify the version of Minecraft to use. // Any artifact can be supplied so long as it has a "userdev" classifier artifact and is a compatible patcher artifact. // The "userdev" classifier will be requested and setup by ForgeGradle. // If the group id is "net.minecraft" and the artifact id is one of ["client", "server", "joined"], // then special handling is done to allow a setup of a vanilla dependency without the use of an external repository. minecraft "net.minecraftforge:forge:1.20.1-47.3.22" implementation fg.deobf("com.simibubi.create:create-${create_minecraft_version}:${create_version}:slim") { transitive = false } implementation fg.deobf("com.jozufozu.flywheel:flywheel-forge-${flywheel_minecraft_version}:${flywheel_version}") implementation fg.deobf("com.tterrag.registrate:Registrate:${registrate_version}") // Example mod dependency with JEI - using fg.deobf() ensures the dependency is remapped to your development mappings // The JEI API is declared for compile time use, while the full JEI artifact is used at runtime // compileOnly fg.deobf("mezz.jei:jei-${mc_version}-common-api:${jei_version}") // compileOnly fg.deobf("mezz.jei:jei-${mc_version}-forge-api:${jei_version}") // runtimeOnly fg.deobf("mezz.jei:jei-${mc_version}-forge:${jei_version}") // Example mod dependency using a mod jar from ./libs with a flat dir repository // This maps to ./libs/coolmod-${mc_version}-${coolmod_version}.jar // The group id is ignored when searching -- in this case, it is "blank" // implementation fg.deobf("blank:coolmod-${mc_version}:${coolmod_version}") // For more info: // http://www.gradle.org/docs/current/userguide/artifact_dependencies_tutorial.html // http://www.gradle.org/docs/current/userguide/dependency_management.html } // This block of code expands all declared replace properties in the specified resource targets. // A missing property will result in an error. Properties are expanded using ${} Groovy notation. // When "copyIdeResources" is enabled, this will also run before the game launches in IDE environments. // See https://docs.gradle.org/current/dsl/org.gradle.language.jvm.tasks.ProcessResources.html tasks.named('processResources', ProcessResources).configure { var replaceProperties = [ minecraft_version: minecraft_version, minecraft_version_range: minecraft_version_range, forge_version: forge_version, forge_version_range: forge_version_range, loader_version_range: loader_version_range, mod_id: mod_id, mod_name: mod_name, mod_license: mod_license, mod_version: mod_version, mod_authors: mod_authors, mod_description: mod_description, ] inputs.properties replaceProperties filesMatching(['META-INF/mods.toml', 'pack.mcmeta']) { expand replaceProperties + [project: project] } } // Example for how to get properties into the manifest for reading at runtime. tasks.named('jar', Jar).configure { manifest { attributes([ 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors, 'Specification-Version' : '1', // We are version 1 of ourselves 'Implementation-Title' : project.name, 'Implementation-Version' : project.jar.archiveVersion, 'Implementation-Vendor' : mod_authors, 'Implementation-Timestamp': new Date().format("yyyy-MM-dd'T'HH:mm:ssZ") ]) } // This is the preferred method to reobfuscate your jar file finalizedBy 'reobfJar' } // However if you are in a multi-project build, dev time needs unobfed jar files, so you can delay the obfuscation until publishing by doing: // tasks.named('publish').configure { // dependsOn 'reobfJar' // } // Example configuration to allow publishing using the maven-publish plugin publishing { publications { register('mavenJava', MavenPublication) { artifact jar } } } tasks.withType(JavaCompile).configureEach { options.encoding = 'UTF-8' // Use the UTF-8 charset for Java compilation } -And my mods.toml file  modLoader="javafml" #mandatory loaderVersion="[47,)" license="MIT" [[mods]] modId="mechmod" version="0.0.1" displayName="Create: Mechs" authors="Affe" [[dependencies.mechmod]] modId="create" mandatory=true versionRange="[0,)" ordering="NONE" side="BOTH" [[dependencies.mechmod]] modId="forge" mandatory=true versionRange="[47.1.3,)" ordering="NONE" side="BOTH" [[dependencies.mechmod]] modId="minecraft" mandatory=true versionRange="[1.20,1.21)" ordering="NONE" side="BOTH" [[dependencies.mechmod]] modId="flywheel" mandatory=true versionRange="[0.6.11,0.6.12)" ordering="AFTER" side="CLIENT" I thought I had implemented the code from the "depending on create" section from their github correctly. But I assume I haven't implemented something that is needed. But I don't know what or where. I can also provide any file you think will help with your diagnosis. Any help would be appreciated, cheers!   
    • Yo i might be a lil bit late but on 1.20.6 you can call BuiltInRegistries.ITEMS.getTagOrEmpty(*required tag*) to get an iterable of item holders, this might be possible on 1.18.2 as well. Then you get the items using for(Holder<Item> holder: iterable) or the .forEach(Consumer<Holder<Item>>) method, or convert the iterable to array/list/collection. When you get the holders, use the .get() method to get the items
    • I'm troubleshooting some mods that I want for a single player world in 1.21.4 and I was having trouble with a resource library config crashing my game so I tried another mod and the library config for that was causing crashes as well. I've updated java and forge recently. Both of these dependency mods have caused Exit Code: -1 but I'm using the crash report for the mod that I was originally wanting to use. https://pastebin.com/82FZPwS2
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.