Jump to content

Combine banners with custom shields


Leronus

Recommended Posts

I'm trying to make it so that Minecraft banners can be combined with my custom shields.

I have created the ShieldRecipes.java class which extends SpecialRecipe and handles the logic.

I have registered this recipe in my main mod class, Mores.java

However, when I try to combine them in a crafting table, there is no output item, aka it doesn't work.

What am I doing wrong?

GitRepo: https://github.com/Leronus/mOres

 

Classes used:

mOres/src/main/java/mod/mores/recipe/ShieldRecipes.java

mOres/src/main/java/mod/mores/Mores.java

Link to comment
Share on other sites

6 hours ago, Luis_ST said:

you don't need a custom recipe, it should work by default if your Shield is an instance of ShieldItem, your ISTER use the vanilla logic and you have the correct texture template 

I do need a custom recipe because I'm using my own ItemShield.java class, which extends ShieldItem.java

It does not work as it is now

Link to comment
Share on other sites

1 hour ago, diesieben07 said:

This is untrue.

@LeronusYou cannot create registry entries in a static initializer. You must create them in the registry event, I would recommend using DeferredRegister.

I also still cannot find any recipe JSON in your repository that uses your shield_decoration serializer.

Thanks, I got it working now!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.