ChangingHoldingItemEvent

[hydroflame]

hi guys, for my mod i need the event describe in the title, basicly its an event that is posted whenever a player tries to change visually the item he is holding ONLY VISUALLY btw.

basicly my mod has this "combat mode" where i want the offensive gear to be rendered no matter what actual item the player is holding in his hand (in skill mode the dmg is redirected to the damage that the player has equipped in his "main weapon" equipment slot)

Right now im doing this via ASM but maybe some other modders would benefit from this ( i understand that its very specific btw )  Im just posting to see if its worth that i do a PR for it.

 

 

edit: its not more then like 2 vanilla line changed

 

[hydroflame]

not exactly, you see with your solution i can change what item the player has "equipped" but my options are only the items in the main inventory/hotbar. In my case, the item i want to set the player as holding is located in another inventory then the main player inventory (a battle gear inventory) meaning i can set that player X is "holding" a mage staff even if the staff isn't in the player's main inventory.

 

Technicly i COULD use a tickhandler and check every tick if it has changed.... but for 1 the "set equipped item" packet (Packet5 i think) will be sent anyway. so i would ahve to resend a packet saying "no actually its this item" and i think this would cause the other players to see people changing item super quickyl but always landing on their weapon

and 2 efficiency would be greatly reduced compared to making an event for it

 

note that if the game sees that a player press a different number (like your hotbar was at 1 and you press 3) if both items are the same it will NOT send a itemchange packet

 

so im my case if the player is in "combat mode" and the player press 1-9 it will always return the same item and the server will not send the packet since the "equipped" item server side doesnt change