Jump to content

Server not sending packet to player on multiplayer


GotoLink

Recommended Posts

I have been struggling with this issue for the past few days.

I made an universal packet handler on my network mod, which handles changes to a tileentity induced by a player from a gui.

public class PacketHandler implements IPacketHandler{

@Override
public void onPacketData(INetworkManager manager, Packet250CustomPayload packet, Player player) 
{
	if(packet.channel == GeneralRef.PACKET_CHANNELS[0])
	{//Sent by AnimatorGUI to server when a button has been activated
		handleGuiChange(manager, packet,(EntityPlayer) player);
	}
	else if(packet.channel == GeneralRef.PACKET_CHANNELS[1])
	{//Sent by server to client FIXME: packet isn't received on multiplayer ??
		handleDescriptionPacket(packet,(EntityPlayer) player);
	}
	//DEBUG:
	Side side = ((EntityPlayer)player).worldObj.isRemote?Side.CLIENT:Side.SERVER;
	FMLLog.getLogger().info(side.toString()+" recieved a "+packet.channel +" packet");
}
/**
* Client method to handle a packet describing the TileEntityAnimator from server
* @param packet
* @param player
*/
private static void handleDescriptionPacket(Packet250CustomPayload packet, EntityPlayer player)
{
	DataInputStream dat = new DataInputStream(new ByteArrayInputStream(packet.data));
	try{
        int x = dat.readInt();
        int y = dat.readInt();
        int z = dat.readInt();
        TileEntity te = player.worldObj.getBlockTileEntity(x, y, z);
        if (te instanceof TileEntityAnimator)
        {
            TileEntityAnimator animator = (TileEntityAnimator) te;
            animator.setEditing(dat.readBoolean());
            if(!animator.isEditing() && animator.getStackInSlot(0)!=null)
                resetRemote(animator.getStackInSlot(0));
            animator.setFrame(dat.readInt());
            animator.setMaxFrame(dat.readInt());
            animator.setCount(dat.readInt());
            animator.resetDelay();
            animator.setDelay(dat.readInt());
            animator.setMode(Mode.values()[dat.readShort()]);
        }
	}catch(IOException i)
	{
		i.printStackTrace();
	}
}
/**
* Server method to handle a client action in AnimatorGUI
* @param manager 
* @param packet
* @param player
*/
private static void handleGuiChange(INetworkManager manager, Packet250CustomPayload packet, EntityPlayer player) 
{
	DataInputStream inStream = new DataInputStream(new ByteArrayInputStream(packet.data));
	int[] data = new int[packet.data.length/4];
	try 
	{
		for(int id = 0; id < data.length; id++)
			data[id] = inStream.readInt();
	} 
	catch (IOException e) 
	{
            e.printStackTrace();
            return;
	}
	TileEntity tile = player.worldObj.getBlockTileEntity(data[1], data[2], data[3]);
	if(tile instanceof TileEntityAnimator)
	{
		handleData((TileEntityAnimator) tile, data);
            if(player.openContainer instanceof ContainerAnimator && ((ContainerAnimator)player.openContainer).getControl() == tile)
    			player.openContainer.detectAndSendChanges();
		//manager.addToSendQueue(getPacket((TileEntityAnimator) tile));
		player.worldObj.markBlockForUpdate(data[1], data[2], data[3]);
	}
}

public static void handleData(TileEntityAnimator animator, int... data)
{
	switch(data[0])
	{
	case 0://"+" button has been pressed
		animator.setDelay(1);
		break;
	case 1://"-" button has been pressed
		if(animator.getDelay()>-1)
		{//Lower delay won't work and might crash
			animator.setDelay(-1);
		}
		break;
	case 2://"Switch button has been pressed, going LOOP->ORDER->REVERSE->RANDOM->LOOP
		int mod = animator.getMode().ordinal();
		if(mod + 1 < Mode.values().length)
			animator.setMode(Mode.values()[mod + 1]);
		else
			animator.setMode(Mode.LOOP);
            break;
        case 3:
        case 4://One of the "Reset" button has been pressed
                animator.setEditing(false);
                animator.setLinker(null);
                if(data[0]==4)//This is a full reset
                {
                	resetAnimator(animator);
                }
                if(data.length > 4)//Get the item and reset it
                	resetRemote(animator.getStackInSlot(0));
                break;
        case 5://Increment Max number of frames that will run
        	animator.setMaxFrame(animator.getMaxFrame() + 1);
		break;
        case 6://Increment first frame to display
    		animator.setFrame(animator.getFrame() + 1);
        	break;
	}

}

public static void resetAnimator(TileEntityAnimator animator) 
{
	animator.setFrame(0);                
        animator.setMode(Mode.ORDER);
        animator.resetDelay();
        animator.setMaxFrame(-1);
        animator.setCount(0);
}

public static void resetRemote(ItemStack stack)
{
        ItemBase remote = (ItemBase)stack.getItem();
        remote.resetLinker();
        stack.getTagCompound().removeTag(ItemBase.KEYTAG);
}

public static Packet getPacket(TileEntityAnimator animator) 
{
	ByteArrayOutputStream bos = new ByteArrayOutputStream(31);
        DataOutputStream dos = new DataOutputStream(bos);     
        try
        {
            dos.writeInt(animator.xCoord);
            dos.writeInt(animator.yCoord);
            dos.writeInt(animator.zCoord);
            dos.writeBoolean(animator.isEditing());
            dos.writeInt(animator.getFrame());
            dos.writeInt(animator.getMaxFrame());
            dos.writeInt(animator.getCount());
            dos.writeInt(animator.getDelay());
            dos.writeShort(animator.getMode().ordinal());
        }
        catch (IOException e)
        {
        	e.printStackTrace();
        }
        Packet250CustomPayload pkt = new Packet250CustomPayload();
        pkt.channel = GeneralRef.PACKET_CHANNELS[1];
        pkt.data = bos.toByteArray();
        pkt.length = bos.size();
        pkt.isChunkDataPacket = true;
        return pkt;
}
}

While it works on single player, with values being changed and gui following it

("SERVER received a Gui packet","CLIENT received description packet")

it doesn't on multiplayer with mcp test server

("SERVER received a Gui packet",*nothing follows*)

 

Hopefully someone will found where I derped :)

 

Edit: This is on 1.5.2 and Forge 7.8.1.737 by the way.

Link to comment
Share on other sites

player.openContainer.detectAndSendChanges();

//manager.addToSendQueue(getPacket((TileEntityAnimator) tile));

player.worldObj.markBlockForUpdate(data[1], data[2], data[3]);

 

this is commented ?

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

I tried to fix with the commented part, but result is the same.

In my tile entity, i have

@Override
    public Packet getDescriptionPacket()
    {
        return PacketHandler.getPacket(this);
    }

So with

player.worldObj.markBlockForUpdate(data[1], data[2], data[3]);

the description packet is sent. But only on single player... :-\

Link to comment
Share on other sites

btw im looking at your code atm i just wanted to tell you i made a tutorial about tile entity synchronizing on the wiki (its kindaof shitty though)

 

its called: "synchronizing tile entities" or something similar

 

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

oh, im sorry its so simple, you're not sending the packet with the right channel

 

server will send a packet using GeneralRef.PACKET_CHANNELS[1] but client only accepts [0]

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Nope, the description packet given by getPacket(TileEntityAnimator) has channel 1 and the receiving part handleDescriptionPacket is also waiting for channel 1. It wouldn't work on single player if I made that mistake.

Link to comment
Share on other sites

@NetworkMod(clientSideRequired = true, serverSideRequired = false , channels={"Gui","Animator"}, packetHandler = PacketHandler.class)

public static final String[] PACKET_CHANNELS = {"Gui","Animator"};

While reading your tutorial, I came across PacketDispatcher class. Trying the methods in it right now.

 

Link to comment
Share on other sites

While reading your tutorial, I came across PacketDispatcher class. Trying the methods in it right now.

 

is not really different then

 

manager.addToSendQueue(getPacket((TileEntityAnimator) tile));

 

 

its just that its the same everywhere :P

 

so thats probably not goign to help

 

can you at least println BEFORE the packet from server is sent ? (making sure that it WAS send )

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

ok but when the gui is changed, can you println right before you send the packet so you can tell for sure that the server is sending the packet, because if it IS sending it then you know your client  packet handler is not registered correctly

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Debug says "SERVER received gui packet", even on multiplayer.

But I only have "CLIENT received animator packet" on single player.

That is the whole issue, as my title says, server don't send the packet to the player on multiplayer.

Link to comment
Share on other sites

yes link i know that but just because the message gets to the server doesnt meant that it is sent FROM the server. i jsut want to make sure the server is actually SENDING the packet, if its not sending it the client is obviously not receiving it

 

if(player.openContainer instanceof ContainerAnimator && ((ContainerAnimator)player.openContainer).getControl() == tile)

    player.openContainer.detectAndSendChanges();

//manager.addToSendQueue(getPacket((TileEntityAnimator) tile));

System.out.println("yes i have send the packet :)");

player.worldObj.markBlockForUpdate(data[1], data[2], data[3]);

}

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Single player:

[sTDOUT] yes i have send the packet :)

[iNFO] [ForgeModLoader] SERVER recieved a Gui packet

[iNFO] [ForgeModLoader] CLIENT recieved a Animator packet

Multi:

[iNFO] [ForgeModLoader] SERVER recieved a Gui packet

 

Server not sending packet, as I said.

Oh, and there isn't any exception thrown due to bad data.

Link to comment
Share on other sites

(sorry i got to go)

but try println before and after every if, method call, while, for

this way youll know exactly at which point this is stopping

 

 

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.


  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.