custom Throw Item

[Spring]

Like a snowball

 

but, it has no throwing animation

 

my entity

public class FirecrackerEntity extends ProjectileItemEntity {

    public FirecrackerEntity(EntityType<? extends FirecrackerEntity> entityType, World world) {
        super(entityType, world);
    }

    public FirecrackerEntity(World world, LivingEntity livingEntity) {
        super(ModEntityTypes.FIRE_CRACKER.get(), livingEntity, world);
    }

    @Override
    protected Item getDefaultItem() {
        return ModItems.FIRE_CRACKER.get();
    }

    @OnlyIn(Dist.CLIENT)
    private IParticleData getParticle() {
        ItemStack itemstack = this.getItemRaw();
        return itemstack.isEmpty() ? ParticleTypes.ITEM_SNOWBALL : new ItemParticleData(ParticleTypes.ITEM, itemstack);
    }

    @OnlyIn(Dist.CLIENT)
    @Override
    public void handleEntityEvent(byte height) {
        if (height == 3) {
            IParticleData iparticledata = this.getParticle();
            for (int i = 0; i < 8; ++i) {
                this.level.addParticle(iparticledata, this.getX(), this.getY(), this.getZ(), 0.0D, 0.0D, 0.0D);
            }
        }

    }
}

 

my item:

public class Firecracker extends Item {
    public Firecracker() {
        super(new Properties().tab(GroupDefine.MISC).stacksTo(16));
    }

    @Override
    public ActionResult<ItemStack> use(World world, PlayerEntity player, Hand hand) {
        ItemStack itemstack = player.getItemInHand(hand);
        world.playSound(null, player.getX(), player.getY(), player.getZ(), ModSounds.FIRE_CRACKER.get(),
                SoundCategory.VOICE, 1F, 1F);
        if (!world.isClientSide) {
            FirecrackerEntity firecracker = new FirecrackerEntity(world, player);
            firecracker.setItem(itemstack);
            firecracker.shootFromRotation(player, player.xRot, player.yRot, 0.0F, 1.5F, 1.0F);
            world.addFreshEntity(firecracker);
        }
        if (!player.abilities.instabuild) {
            itemstack.shrink(1);
        }
        return ActionResult.sidedSuccess(itemstack, world.isClientSide());
    }
}

 

entity register

    public static final DeferredRegister<EntityType<?>> ENTITY_TYPE = DeferredRegister.create(ForgeRegistries.ENTITIES,
            ApplicationConstants.MOD_ID);

    public static final RegistryObject<EntityType<FirecrackerEntity>> FIRE_CRACKER = ENTITY_TYPE.register(
            "fire_cracker",
            () -> EntityType.Builder.<FirecrackerEntity>of(FirecrackerEntity::new,
                            EntityClassification.MISC).sized(0.5f, 0.5f)
                    .build(new ResourceLocation(ApplicationConstants.MOD_ID, "fire_cracker").toString()));

    public static void register(IEventBus bus) {
        ENTITY_TYPE.register(bus);
    }

my entity class . It doesn't seem to be working, how can I make it run?

 

look: https://error-1254387167.cos.ap-chengdu.myqcloud.com/20211225/2021-12-25-18-24-35.avi

Edited December 25, 2021 by Spring

[OutCraft]

Does

/summon yourmodid:fire_cracker

work?

[Spring]

  On 12/25/2021 at 10:25 AM, OutCraft said:

Does

/summon yourmodid:fire_cracker

work?

Expand  

.... NO !

[OutCraft]

  On 12/25/2021 at 10:18 AM, Spring said:

ENTITY_TYPE.register(bus);

Expand  

Then test if this line is being executed (print something in console etc.)

Edit:

Also: does the Entity have a model? Try throwing it with Bounding boxes (F3 + B) enabled

Edited December 25, 2021 by OutCraft

[Spring]

  On 12/25/2021 at 10:31 AM, OutCraft said:

Then test if this line is being executed (print something in console etc.)

Expand  

yes,It executed

[OutCraft]

  On 12/25/2021 at 10:31 AM, OutCraft said:

Does the Entity have a model? Try throwing it with Bounding boxes (F3 + B) enabled

Expand  

 

[Spring]

  On 12/25/2021 at 10:35 AM, OutCraft said:

 

Expand  

..No, I don’t seem to add a model to it, how do I add it?

[OutCraft]

First:

Can you see a white cube when Bounding boxes (F3 + B) are enabled and you throw it?

[Spring]

  On 12/25/2021 at 10:47 AM, OutCraft said:

First:

Can you see a white cube when Bounding boxes (F3 + B) are enabled and you throw it?

Expand  

No

[OutCraft]

Also not when you summon it?

Edited December 25, 2021 by OutCraft

[Spring]

  On 12/25/2021 at 10:49 AM, OutCraft said:

Also now when you summon it?

Expand  

When I use summon, there is no Bounding boxes，(F3+B)

[OutCraft]

...

Try changing the extending class from FirecrackerEntity to just Entity

[OutCraft]

Are you on 1.16.5?

[Spring]

  On 12/25/2021 at 11:00 AM, OutCraft said:

Are you on 1.16.5?

Expand  

yes

[OutCraft]

I copied your code and tried it, but for me it crashes:

"java.lang.NullPointerException: Cannot invoke "net.minecraft.client.renderer.entity.EntityRenderer.shouldRender(net.minecraft.world.entity.Entity, net.minecraft.client.renderer.culling.Frustum, double, double, double)" because "entityrenderer" is null"

This means that the Entity doesn't have a renderer or model.

Does it crash also for you?

Edited December 25, 2021 by OutCraft
Spelling

[Spring]

  On 12/25/2021 at 11:12 AM, OutCraft said:

I copied your code and tried it, but for me it crashes:

"java.lang.NullPointerException: Cannot invoke "net.minecraft.client.renderer.entity.EntityRenderer.shouldRender(net.minecraft.world.entity.Entity, net.minecraft.client.renderer.culling.Frustum, double, double, double)" because "entityrenderer" is null"

This means that the Entity doesn't have a model.

Does it crash also for you?

Expand  

 

add this:

MinecraftForge.EVENT_BUS.register(this);

ModEntityTypes.register(modEventBus);

try again?

[Spring]

  On 12/25/2021 at 11:15 AM, Spring said:

 

add this:

MinecraftForge.EVENT_BUS.register(this);

ModEntityTypes.register(modEventBus);

try again?

Expand  

Because I have no problem here, but it does not have a model, how can I add a model?

[OutCraft]

  On 12/25/2021 at 11:15 AM, Spring said:

MinecraftForge.EVENT_BUS.register(this);

ModEntityTypes.register(modEventBus);

Expand  

I added this, but it crashes because it doesn't have a renderer. Does your Entity have a renderer?

[Spring]

  On 12/25/2021 at 11:24 AM, OutCraft said:

I added this, but it crashes because it doesn't have a renderer. Does your Entity have a renderer?

Expand  

No, my code is from SnowballEntity class, I didn't see vanilla try this.. So, what should I do.

[OutCraft]

Vanilla does this in the Client renderer registry:

	@SubscribeEvent
	public static void registerEntityRenders(EntityRenderersEvent.RegisterRenderers event) {
		event.registerEntityRenderer(EntityList.FIRE_CRACKER.get(), ThrownItemRenderer::new);
	}

I did the same and now it works!

Edited December 25, 2021 by OutCraft

[OutCraft]

But you need a texture for the Item, otherwise it's just black-pink

[Spring]

  On 12/25/2021 at 11:33 AM, OutCraft said:

Vanilla does this in the Client renderer registry:

	@SubscribeEvent
	public static void registerEntityRenders(EntityRenderersEvent.RegisterRenderers event) {
		event.registerEntityRenderer(EntityList.FIRE_CRACKER.get(), ThrownItemRenderer::new);
	}

I did the same and now it works!

Expand  

you version ?I can't use this code

Edited December 25, 2021 by Spring

[OutCraft]

  On 12/25/2021 at 11:38 AM, Spring said:

you version ? 

Expand  

1.16.5, but you need to change 

  On 12/25/2021 at 11:38 AM, Spring said:

EntityList.FIRE_CRACKER.get()

Expand  

to

ModEntityTypes.FIRE_CRACKER.get()

because your EntityTypes class is named "ModEntityTypes"

Edited December 25, 2021 by OutCraft

[Spring]

  On 12/25/2021 at 11:43 AM, OutCraft said:

1.16.5, but you need to change 

 

to

ModEntityTypes.FIRE_CRACKER.get()

because your EntityTypes class is named "ModEntityTypes"

Expand  

yes,i know,but i no class: EntityRenderersEvent、ThrownItemRenderer

 

my forge: 1.16.5-36.2.2

Edited December 25, 2021 by Spring

[OutCraft]

Do you use the Mojang or MCP mappings?

Also you can just search in your IDE for something like RenderEvent and it should show up