[1.18.1] Trouble Getting Ores to Spawn at an Intended Rarity and Vein Size

[Squidsword]

Hey, I am trying to get ore veins to spawn 3x and 9x rarer than diamonds in 1.18.1 and also spawn less ores per vein. I was looking at net.minecraft.data.worldgen.features.OreFeatures and found that diamond uses vein sizes of 4, 8, and 12 for DIAMOND_SMALL, DIAMOND_BURIED, and DIAMOND_LARGE. I already made it so the veins for black opal spawn 9x less than diamond, which worked well. However, when I try to reduce the vein size by 25% for black opal, the ores spawn a lot less than mathematically expected. Here's two imgur links below.

Ore Distribution 1 (BLACK_OPAL_SMALL = 4, BLACK_OPAL_BURIED = 8, BLACK_OPAL_LARGE = 12) (same as diamonds)

Ore Distribution 2 (BLACK_OPAL_SMALL = 3, BLACK_OPAL_BURIED = 6, BLACK_OPAL_LARGE = 9) (25% vein size reduction)

For some reason, Ore Distribution 2 spawned fewer black opals than expected. Amethysts have a similar problem if the same vein sizes are used.

It was expected to have around 58421 / 9 * (3 / 4) = 4868 black opal ores. Yet there were only 3578, which is 1.36x rarer than I intended. It ended up more like a 45-50% vein size reduction.

 

Here's the code. I adjusted the vein sizes using the config file (ore dist 1 has black_opal_vein_size at 8, ore dist 2 has it at 6). The ore distributions stats were generated using worldedit's //pos1 //pos2 and //distr commands.

OresAboveDiamonds/OreGeneration.java at 1.18.1_test · Squidsword/OresAboveDiamonds (github.com)

 

Anybody have any clues?

[Luis_ST]

in how many chunks have you checked the ores generation?

Question for me, how did you check the Ore generation?

[Squidsword]

2 hours ago, Luis_ST said:

in how many chunks have you checked the ores generation?

Question for me, how did you check the Ore generation?

I checked 3900 chunks (1000*1000 blocks) by selecting 0 -64 0 to 1000 16 1000 in worldedit and then using the //distr command.

Edited January 4, 2022 by Squidsword
clarity

[Luis_ST]

then unfortunately I have no idea, you could check an even larger area