(1.16.5 MCP) turn on the noclip is not working

[Luis_ST]

17 hours ago, diesieben07 said:

Then they were wrong.

thought it work like an ability

16 hours ago, ElTotisPro50 said:

player.sendPlayerAbilities();

since noClip isn't an ability, you don't need this anymore

[ElTotisPro50]

7 hours ago, diesieben07 said:

No you were not right. Check if the entity being updated is a player, if so use it. Do not use Minecraft.getInstance from common code.

 

[ElTotisPro50]

On 1/30/2022 at 5:56 AM, diesieben07 said:

No you were not right. Check if the entity being updated is a player, if so use it. Do not use Minecraft.getInstance from common code.

@SubscribeEvent
    public static void test(LivingEvent.LivingUpdateEvent event)
    {
        if(Minecraft.getInstance().player == null)
            return;
        PlayerEntity player = Minecraft.getInstance().player;
        if(event.getEntityLiving() instanceof PlayerEntity) {
            player.noClip = true;
        }
    }

didnt work

[Luis_ST]

I already told that LivingUpdateEvent will never be called for players

[ElTotisPro50]

1 hour ago, Luis_ST said:

I already told that LivingUpdateEvent will never be called for players

diesieben and you are telling me 2 different things :/, what i have to do?

[Luis_ST]

2 minutes ago, ElTotisPro50 said:

diesieben and you are telling me 2 different things :/, what i have to do?

i see i see, you can test it

18 minutes ago, ElTotisPro50 said:

        if(event.getEntityLiving() instanceof PlayerEntity) {
            player.noClip = true;
        }

if i'm correct noClip should never be set to true
use debugger

[Luis_ST]

2 hours ago, diesieben07 said:

Why wouldn't it?

iirc the Player class override the tick method completely which call the LivingUpdateEvent in LivingEntity, this means he does not call super. But now I'm not sure I will later take a look into it.

Edited February 2, 2022 by Luis_ST

[ElTotisPro50]

7 hours ago, Luis_ST said:

i see i see, you can test it

if i'm correct noClip should never be set to true
use debugger

noclip should never be set to true?? but thats how it works you set the boolean to true,

and with debugger you mean run the game in debug mode and when i export my mod it should work fine?

[Luis_ST]

3 hours ago, ElTotisPro50 said:

noclip should never be set to true??

it should work in LivingUpdateEvent

 

3 hours ago, ElTotisPro50 said:

and with debugger you mean run the game in debug mode

i mean the debug feature of your IDE, or a simple Logger#debug

[ElTotisPro50]

1 hour ago, Luis_ST said:

it should work in LivingUpdateEvent

 

i mean the debug feature of your IDE, or a simple Logger#debug

nope didnt work, i saw some people asking for noclip and it worked for them, why is not working for me? (also luis are you "good" with rendering?)

[Luis_ST]

10 hours ago, ElTotisPro50 said:

nope didnt work, i saw some people asking for noclip and it worked for them, why is not working for me?

show the update code so I can debug this locally 

 

10 hours ago, ElTotisPro50 said:

(also luis are you "good" with rendering?)

I haven't done so much render stuff, I hava basic knowledge, but for your question it's not enough 

[ElTotisPro50]

12 hours ago, Luis_ST said:

show the update code so I can debug this locally 

 

I haven't done so much render stuff, I hava basic knowledge, but for your question it's not enough 

1-Can you help me with a post i made about rendering a glowing line? (the line is following my head movements but not from the eyes and if dont look to the north the line doesnt follow my head)

 

2-the code you asked

@SubscribeEvent
    public static void test(LivingEvent.LivingUpdateEvent event)
    {
        if(Minecraft.getInstance().player == null)
            return;
        PlayerEntity player = Minecraft.getInstance().player;
        if(event.getEntityLiving() == player) { //OR  if(event.getEntity() == player) {
            player.noClip = true;
        }
    }

 

[Luis_ST]

23 minutes ago, ElTotisPro50 said:

(the line is following my head movements but not from the eyes and if dont look to the north the line doesnt follow my head)

please don't ask for my help in other threads, I read 95% of all threads
if i have an answer/solution i will reply, but i will take a look into your thread (again)

 

28 minutes ago, ElTotisPro50 said:

2-the code you asked

1. do not use the Minecraft class when you want to change a server side thing
2. use the LivingEntity of the Event
3. use and instanceof check instead of == to check if the LivingEntity is a PlayerEntity
4. LivingUpdateEvent#getEntityLiving and LivingUpdateEvent#getEntity retrun the same Entity

[ElTotisPro50]

1 hour ago, Luis_ST said:

please don't ask for my help in other threads, I read 95% of all threads
if i have an answer/solution i will reply, but i will take a look into your thread (again)

 

1. do not use the Minecraft class when you want to change a server side thing
2. use the LivingEntity of the Event
3. use and instanceof check instead of == to check if the LivingEntity is a PlayerEntity
4. LivingUpdateEvent#getEntityLiving and LivingUpdateEvent#getEntity retrun the same Entity

the if(Minecraft.getInstance().player == null) is because else it gives me a null exception

and i have to get the player from minecraft class or else where do i get it(without instantiating it)

didnt work the game thinks im cheating like if you are in a server and you turn on noclip hacks

@SubscribeEvent
    public static void test(LivingEvent.LivingUpdateEvent event)
    {
        if(Minecraft.getInstance().player == null)
            return;
        PlayerEntity player = Minecraft.getInstance().player;
        if(event.getEntityLiving() instanceof PlayerEntity) {
            player.noClip = true;
        }
    }

 

[ElTotisPro50]

1 hour ago, diesieben07 said:

Please learn basic Java.

Do not use the Minecraft class here at all. You are reaching across logical sides and this does not do what you wnat.

 i didnt mean "without instantiate player class", i meant where do i get the player class without "PlayerEntity player = new PlayerEntity()", Minecraft's class can give me the player

(i know basic java even if it sometimes doesnt look like it)

[Luis_ST]

36 minutes ago, ElTotisPro50 said:

event.getEntityLiving() instanceof PlayerEntity

if this retruns true the LivingEntity is a PlayerEntity so you can cast the LivingEntity of the Event to a PlayerEntity,
if you don't know how to do that -> learn basic Java.

Edited February 3, 2022 by Luis_ST

[ElTotisPro50]

1 hour ago, Luis_ST said:

if this retruns true the LivingEntity is a PlayerEntity so you can cast the LivingEntity of the Event to a PlayerEntity,
if you don't know how to do that -> learn basic Java.

FINALLY IT WORKED :))))))))))), so in what contexts i cant initialize the player with minecraft.instance.player?