How can I get the original Max Health of the entity type (mob)?

[IPECTER]

How can I get the original Max Health of the entity type (mob)?

For example, like this.

@SubscribeEvent
    public void onMobSpawn(EntityJoinWorldEvent e) {
        if (e.getEntity() instanceof Mob) {
            Mob mob = (Mob) e.getEntity();
            if (mob.getOriginalMaxHealth() == mob.getMaxHealth()){
                //do something (modify mob max health)
            }
        }
    }

" mob.getOriginalMaxHealth() "

 

Edited February 16, 2022 by IPECTER

[IPECTER]

54 minutes ago, diesieben07 said:

What do you mean by "original"?

 just...

The original of the mob.

For Example...

cow's original max health is 10.

[IPECTER]

EntityJoinWorldEvent occurs every time a player visits the world.
 

So,

In order not to continue to increase the mob's max health, if the mob's max health is more than 100 times the mob's original max health, it will not change the mob's max health.

Edited February 17, 2022 by IPECTER

[IPECTER]

19 hours ago, diesieben07 said:

If you use AttributeModifier like I told you in your other thread multiple times already it will achieve this automatically without any extra work on your part.

private static final AttributeModifier x100MaxHealth = new AttributeModifier(Attributes.MAX_HEALTH, "x100 Max Health", 100, AttributeModifier.Operation.MULTIPLY_BASE);
    

error...

Cannot resolve constructor 'AttributeModifier(net.minecraft.world.entity.ai.attributes.Attribute, java.lang.String, int, net.minecraft.world.entity.ai.attributes.AttributeModifier.Operation)

[IPECTER]

 

16 minutes ago, diesieben07 said:

For the future: Please refrain from creating multiple topics for the same thing. In your other thread you mentioned success, is this solved?

sorry.....

I only succeeded in raising the mob's hp above 1024.

Now I have to find a way to control Mob's physical strength using AttributeModifier.

[IPECTER]

On 2/18/2022 at 8:33 PM, diesieben07 said:

Look at the AttributeModifier constructor. You are not passing the correct parameters.

success. thx.
but....

private static final AttributeModifier x100MaxHealth = new AttributeModifier("x100 Max Health", 99, AttributeModifier.Operation.MULTIPLY_BASE); @SubscribeEvent public static void onMobSpawn(EntityJoinWorldEvent e) { if (e.getEntity() instanceof Mob) { Mob mob = (Mob) e.getEntity(); if (mob.getHealth() > mob.getAttribute(Attributes.MAX_HEALTH).getBaseValue()) { mob.getAttribute(Attributes.MAX_HEALTH).addTransientModifier(x100MaxHealth); mob.setHealth(mob.getHealth() * 100); } } }

    private static final AttributeModifier x100MaxHealth = new AttributeModifier("x100 Max Health", 99, AttributeModifier.Operation.MULTIPLY_BASE);
    @SubscribeEvent
    public static void onMobSpawn(EntityJoinWorldEvent e) {

        if (e.getEntity() instanceof Mob) {
            Mob mob = (Mob) e.getEntity();
            if (mob.getHealth() >= mob.getAttribute(Attributes.MAX_HEALTH).getBaseValue()) {
                mob.getAttribute(Attributes.MAX_HEALTH).addTransientModifier(x100MaxHealth);
                mob.setHealth(mob.getHealth() * 100);
            }
        }

    }

Every time a player join the world, even if the mob's hp is lower than the maximum hp, all hp is recovered. What should I do?

Edited February 19, 2022 by IPECTER

[IPECTER]

1 minute ago, diesieben07 said:

Do not do this check. Simply add the modifier.

Do not set the health.

private static final AttributeModifier x100MaxHealth = new AttributeModifier("x100 Max Health", 99, AttributeModifier.Operation.MULTIPLY_BASE);
    @SubscribeEvent
    public static void onMobSpawn(EntityJoinWorldEvent e) {

        if (e.getEntity() instanceof Mob) {
            Mob mob = (Mob) e.getEntity();
            mob.getAttribute(Attributes.MAX_HEALTH).addTransientModifier(x100MaxHealth);
        }

    }

like this?

When mobs spawn for the first time, Mobs have to have full hp.

[IPECTER]

5 minutes ago, diesieben07 said:

You have to put a flag in the entity's data (you can either use a capability or getPersistentData, in the latter case make sure to prefix it with your ModID). If the flag is not yet present, increase mob health.

@Mod.EventBusSubscriber(modid = "x100health", bus = Mod.EventBusSubscriber.Bus.FORGE, value = Dist.CLIENT)
public class EntityJoinWorld {
    private static final AttributeModifier x100MaxHealth = new AttributeModifier("x100 Max Health", 99, AttributeModifier.Operation.MULTIPLY_BASE);
    @SubscribeEvent
    public static void onMobSpawn(EntityJoinWorldEvent e) {

        if (e.getEntity() instanceof Mob) {
            Mob mob = (Mob) e.getEntity();
            mob.getAttribute(Attributes.MAX_HEALTH).addTransientModifier(x100MaxHealth);
            if (!mob.getPersistentData().getBoolean("x100health")){
                mob.getPersistentData().put("x100health", tag..?);
                mob.setHealth(mob.getHealth() * 100);
            }
        }

    }
}

mob.getPersistentData().put("x100health", tag..?);

tag..???? What I should do?

Edited February 19, 2022 by IPECTER

[IPECTER]

2 minutes ago, diesieben07 said:

You need to put a boolean in there.

mob.getPersistentData().put("x100health", true);

Required type:
Tag
Provided:
boolean

......

[IPECTER]

2 minutes ago, diesieben07 said:

Maybe don't use put then, there are other methods.

@Mod.EventBusSubscriber(modid = "x100health", bus = Mod.EventBusSubscriber.Bus.FORGE, value = Dist.CLIENT)
public class EntityJoinWorld {
    private static final AttributeModifier x100MaxHealth = new AttributeModifier("x100 Max Health", 99, AttributeModifier.Operation.MULTIPLY_BASE);
    @SubscribeEvent
    public static void onMobSpawn(EntityJoinWorldEvent e) {

        if (e.getEntity() instanceof Mob) {
            Mob mob = (Mob) e.getEntity();
            mob.getAttribute(Attributes.MAX_HEALTH).addTransientModifier(x100MaxHealth);
            if (!mob.getPersistentData().contains("x100health")){
                mob.getPersistentData().putBoolean("x100health", true);
                mob.setHealth(mob.getHealth() * 100);
            }
        }

    }
}

like this! right?

[IPECTER]

1 minute ago, diesieben07 said:

Looks OK.

@Mod.EventBusSubscriber(modid = "x100health", bus = Mod.EventBusSubscriber.Bus.FORGE, value = Dist.CLIENT)
public class EntityJoinWorld {
    private static final AttributeModifier x100MaxHealth = new AttributeModifier("x100 Max Health", 99, AttributeModifier.Operation.MULTIPLY_BASE);
    @SubscribeEvent
    public static void onMobSpawn(EntityJoinWorldEvent e) {

        if (e.getEntity() instanceof Mob) {
            Mob mob = (Mob) e.getEntity();
            mob.getAttribute(Attributes.MAX_HEALTH).addTransientModifier(x100MaxHealth);
            if (!mob.getPersistentData().contains("x100health")){
                mob.getPersistentData().putBoolean("x100health", true);
                mob.setHealth(mob.getHealth() * 100);
            }
        }

    }
}

When the player joins the world, the mob's current hp is initialized.

[IPECTER]

before player rejoin the world,  1980/2000 (hp/max hp)
after player rejoin the world, 20/2000

[IPECTER]

10 hours ago, diesieben07 said:

You can try using addPermanentModifier instead and only add it if hasModifier returns false.

AddPermanentModifier does not exist in Mob.