Jump to content

Recommended Posts

Posted

have a container which is like a chest but with a bit more inventory space when i save all the items in the chest the stay in them when reseting the game but the only problem is that 3 slots wont save anyone might know the reason

I like helping people because i was also in a same problem and i do not like unfinished work, so a thank you will be enough for the people im helping and a thank you to the people that helped me :)

Posted

here is the container

package medieval.medievalitems.containers;

import medieval.medievalblocks.blocks.barrel.Barrel_Tile;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.Slot;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class Barrel_Container extends Container
{
private IInventory bottombarrel;
private int numOfRows;



public Barrel_Container(EntityPlayer player, World world, int x, int y, int z)

{
Barrel_Tile bartile = (Barrel_Tile) world.getBlockTileEntity(x, y, z);

this.bottombarrel = bartile;
this.numOfRows = bartile.getSizeInventory() / 11;

bartile.openChest();

int i = (this.numOfRows - 4) *18;
int j;
int k;
int l = 6;
int m;
int n = 7;
int o;
int p;
int q;

//Chest inv middle
for(j = 0;  j < this.numOfRows; j++)
{
   for (k = 0; k < 7; k++)
   {
   this.addSlotToContainer(new Slot(bartile, k + j * 18, 44 + k * 18 - 8, 18 + j *18 + 41));
   }
}
//chest inv down
   for (m = 0; m < 5; m++)
   {
   this.addSlotToContainer(new Slot(bartile, m + l * 18, 44 + m * 18 + 10, 18 + l *18 + 23));
   }
//Chest invup
   for (o = 0; o < 5; o++)
   {
   this.addSlotToContainer(new Slot(bartile, o + n * 18, 44 + o * 18 + 10, 18 +n *18 - 103));
   }



   //Player inv
   for(j = 0;  j < 3; j++)
   {
      for (k = 0; k < 9; k++)
      {
   	   this.addSlotToContainer(new Slot(player.inventory , k + j * 9 + 9, 8 + k * 18 + 10, 108 + j *18 + i + 58));
      }
}
   
   
   //Player itembar
   for(j = 0;  j < 9; j++)
   {
     
   	   this.addSlotToContainer(new Slot(player.inventory , j, 8 + j * 18 + 10, 161 + i + 63));
   }
}


public boolean canInteractWith(EntityPlayer entityplayer) 
{
	return this.bottombarrel.isUseableByPlayer(entityplayer);
}

public ItemStack transferStackInSlot(EntityPlayer player, int index)
{
	ItemStack stack = null;
	Slot slot = (Slot) this.inventorySlots.get(index);
	if(slot!=null&&slot.getHasStack())
	{
		ItemStack slotstack = slot.getStack();
		stack = slotstack.copy();
		if(index<45)
		{
			if(!this.mergeItemStack(slotstack,45,this.inventorySlots.size(),true)) return null;
		}
		else if(!this.getSlot(0).isItemValid(slotstack)||!this.mergeItemStack(slotstack,0,45,true)) return null;
		if(slotstack.stackSize==0)
		{
			slot.putStack((ItemStack) null);
		}
		else
		{
			slot.onSlotChanged();
		}
		if(slotstack.stackSize==stack.stackSize) return null;
		slot.onPickupFromSlot(player,slotstack);
	}
	return stack;
}

@Override
public boolean mergeItemStack(ItemStack stack, int start, int end, boolean reverse){
	return super.mergeItemStack(stack,start,end,reverse);
}

/**
 * Does the same as mergeItemStack with the same args, except does not
 * actually merge— just returns the number of items that can be merged
 * (usually either stack.stackSize or 0, but can be in between)
 * @param stack
 * @param start
 * @param end
 * @param reverse
 * @return
 */
int dryMerge(ItemStack stack, int start, int end, boolean reverse)
{
	boolean flag1 = false;
	int i = start;
	if(reverse)
	{
		i = end-1;
	}
	int quantity = stack.stackSize;
	Slot slot;
	ItemStack slotstack;
	if(stack.isStackable())
	{
		while(stack.stackSize>0&&(!reverse&&i<end||reverse&&i>=start))
		{
			slot = this.getSlot(i);
			slotstack = slot.getStack();
			if(slotstack!=null&&slotstack.itemID==stack.itemID&&(!stack.getHasSubtypes()||stack.getItemDamage()==slotstack.getItemDamage())&&ItemStack.areItemStackTagsEqual(stack,slotstack))
			{
				int l = slotstack.stackSize+stack.stackSize;
				if(l<=stack.getMaxStackSize())
				{
					quantity -= slotstack.stackSize;
				}else if(slotstack.stackSize<stack.getMaxStackSize())
				{
					quantity -= (stack.getMaxStackSize() - slotstack.stackSize);
				}
			}
			if(reverse) --i;
			else ++i;
		}
	}
	if(stack.stackSize>0){
		if(reverse){
			i = end-1;
		}else{
			i = start;
		}
		while(!reverse&&i<end||reverse&&i>=start){
			slot = (Slot) this.inventorySlots.get(i);
			slotstack = slot.getStack();
			if(slotstack==null){
				quantity = 0;
				break;
			}
			if(reverse){
				--i;
			}else{
				++i;
			}
		}
	}
	return stack.stackSize-quantity;
}
}

 

here is the tile

package medieval.medievalblocks.blocks.barrel;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.ISidedInventory;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.tileentity.TileEntity;

public final class Barrel_Tile extends TileEntity implements ISidedInventory
{

private ItemStack[] inventoryitems = new ItemStack[2240];
private String localizedName;
public int playersCurrentlyUsingChest;
private String stuffname;


public int getSizeInventory() 
{
	return 65;
}

 public ItemStack getStackInSlot(int slot) {
         return inventoryitems[slot];
}

@Override
public void setInventorySlotContents(int slot, ItemStack stack) {
         inventoryitems[slot] = stack;
         if (stack != null && stack.stackSize > getInventoryStackLimit()) {
                 stack.stackSize = getInventoryStackLimit();
         }               
}

@Override
public ItemStack decrStackSize(int slot, int amt) {
         ItemStack stack = getStackInSlot(slot);
         if (stack != null) {
                 if (stack.stackSize <= amt) {
                         setInventorySlotContents(slot, null);
                 } else {
                         stack = stack.splitStack(amt);
                         if (stack.stackSize == 0) {
                                 setInventorySlotContents(slot, null);
                         }
                 }
         }
         return stack;
}

@Override
public ItemStack getStackInSlotOnClosing(int slot) {
         ItemStack stack = getStackInSlot(slot);
         if (stack != null) {
                 setInventorySlotContents(slot, null);
         }
         return stack;
}


@Override
public boolean isUseableByPlayer(EntityPlayer player) {
         return worldObj.getBlockTileEntity(xCoord, yCoord, zCoord) == this &&
         player.getDistanceSq(xCoord + 0.5, yCoord + 0.5, zCoord + 0.5) < 64;
}

@Override
public void readFromNBT(NBTTagCompound tagCompound) {
         super.readFromNBT(tagCompound);
         
         NBTTagList tagList = tagCompound.getTagList("Inventory");
         for (int i = 0; i < tagList.tagCount(); i++) {
                 NBTTagCompound tag = (NBTTagCompound) tagList.tagAt(i);
                 byte slot = tag.getByte("Slot");
                 if (slot >= 0 && slot < inventoryitems.length) {
                         inventoryitems[slot] = ItemStack.loadItemStackFromNBT(tag);
                 }
         }
}

@Override
public void writeToNBT(NBTTagCompound tagCompound) {
         super.writeToNBT(tagCompound);
                         
         NBTTagList itemList = new NBTTagList();
         for (int i = 0; i < inventoryitems.length; i++) {
                 ItemStack stack = inventoryitems[i];
                 if (stack != null) {
                         NBTTagCompound tag = new NBTTagCompound();
                         tag.setByte("Slot", (byte) i);
                         stack.writeToNBT(tag);
                         itemList.appendTag(tag);
                 }
         }
         tagCompound.setTag("Inventory", itemList);
}


public String getInvName() {
	return this.isInvNameLocalized() ? this.localizedName : "medieval.container.barrel";
}


public boolean isInvNameLocalized() {
	return this.localizedName != null && this.localizedName.length() > 0;
}

/**
 * Setting the localizedName Variable
 * @param localizedName
 */
public void func_94043_a(String par1Str)
{
this.localizedName = par1Str;
}


public int getInventoryStackLimit() 
{
	return 64;
}


@Override
public void openChest() {
//TODO

}

@Override
public void closeChest() {
	// TODO Auto-generated method stub

}


public boolean isItemValidForSlot(int i, ItemStack itemstack) 
{
	return true;
}

@Override
public int[] getAccessibleSlotsFromSide(int var1) {
	// TODO Auto-generated method stub
	return null;
}


public boolean canInsertItem(int i, ItemStack itemstack, int j) {
	return true;
}


public boolean canExtractItem(int i, ItemStack itemstack, int j) {
	return true;
}

}

I like helping people because i was also in a same problem and i do not like unfinished work, so a thank you will be enough for the people im helping and a thank you to the people that helped me :)

Posted

and like i said all the slots work exept  on barrel_container //Chest inv up  last 3

 

 

I like helping people because i was also in a same problem and i do not like unfinished work, so a thank you will be enough for the people im helping and a thank you to the people that helped me :)

Posted

I'm not really sure this has something to to with your saving problem, but 2240 ItemStacks??!

private ItemStack[] inventoryitems = new ItemStack[2240];

Also I'm noticing that you're telling ISidedInventory that you're only holding 65 stacks?

public int getSizeInventory() 
{
	return 65;
}

Apart from that I can't see anything strange...

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

actually its possible to make stack of 100+ item, but i dont know if its causing a problem with ISidedInventory, im jsut saying in general, you can

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Posted

here is the container

this.numOfRows = bartile.getSizeInventory() / 11;

 

here is the tile

public final class Barrel_Tile extends TileEntity implements ISidedInventory
{
private ItemStack[] inventoryitems = new ItemStack[2240];

public int getSizeInventory() 
{
	return 65;
}
}

I don't think 65 can be properly divided by 11.

Posted

fixed the values but its still happening :/

I like helping people because i was also in a same problem and i do not like unfinished work, so a thank you will be enough for the people im helping and a thank you to the people that helped me :)

Posted

can anyone tell me :/

I like helping people because i was also in a same problem and i do not like unfinished work, so a thank you will be enough for the people im helping and a thank you to the people that helped me :)

Posted

nevermind i fixed it:D it was a simple problem and it was that the number of rows was determined by multiplying the numofrows :)

I like helping people because i was also in a same problem and i do not like unfinished work, so a thank you will be enough for the people im helping and a thank you to the people that helped me :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.